make-mp-data 3.0.6 → 3.1.0

package/lib/orchestrators/mixpanel-sender.js

@@ -66,8 +66,7 @@ export async function sendToMixpanel(context) {
 	log(`${'─'.repeat(50)}\n`);
 
 	// Import events
-	if (eventData?.length > 0 || isBATCH_MODE) {
-		log(`  Events`);
+	if (eventData?.length > 0 || isBATCH_MODE || (writeToDisk && eventData)) {
 		let eventDataToImport = u.deepClone(eventData);
 		const shouldReadFromFiles = isBATCH_MODE || (writeToDisk && eventData && eventData.length === 0);
 		if (shouldReadFromFiles && eventData?.getWriteDir) {
@@ -76,17 +75,19 @@ export async function sendToMixpanel(context) {
 			// @ts-ignore
 			eventDataToImport = files.filter(f => f.includes('-EVENTS'));
 		}
-		const imported = await mp(creds, eventDataToImport, {
-			recordType: "event",
-			...commonOpts,
-		});
-		log(`  -> ${comma(imported.success)} events sent\n`);
-		importResults.events = imported;
+		if (eventDataToImport?.length > 0) {
+			log(`  Events`);
+			const imported = await mp(creds, eventDataToImport, {
+				recordType: "event",
+				...commonOpts,
+			});
+			log(`  -> ${comma(imported.success)} events sent\n`);
+			importResults.events = imported;
+		}
 	}
 
 	// Import user profiles
-	if (userProfilesData?.length > 0 || isBATCH_MODE) {
-		log(`  User Profiles`);
+	if (userProfilesData?.length > 0 || isBATCH_MODE || (writeToDisk && userProfilesData)) {
 		let userProfilesToImport = u.deepClone(userProfilesData);
 		const shouldReadFromFiles = isBATCH_MODE || (writeToDisk && userProfilesData && userProfilesData.length === 0);
 		if (shouldReadFromFiles && userProfilesData?.getWriteDir) {
@@ -95,17 +96,19 @@ export async function sendToMixpanel(context) {
 			// @ts-ignore
 			userProfilesToImport = files.filter(f => f.includes('-USERS'));
 		}
-		const imported = await mp(creds, userProfilesToImport, {
-			recordType: "user",
-			...commonOpts,
-		});
-		log(`  -> ${comma(imported.success)} user profiles sent\n`);
-		importResults.users = imported;
+		if (userProfilesToImport?.length > 0) {
+			log(`  User Profiles`);
+			const imported = await mp(creds, userProfilesToImport, {
+				recordType: "user",
+				...commonOpts,
+			});
+			log(`  -> ${comma(imported.success)} user profiles sent\n`);
+			importResults.users = imported;
+		}
 	}
 
-	// Import ad spend data
-	if (adSpendData?.length > 0 || isBATCH_MODE) {
-		log(`  Ad Spend`);
+	// Import ad spend data (only when feature enabled)
+	if (config.hasAdSpend && (adSpendData?.length > 0 || isBATCH_MODE || (writeToDisk && adSpendData))) {
 		let adSpendDataToImport = u.deepClone(adSpendData);
 		const shouldReadFromFiles = isBATCH_MODE || (writeToDisk && adSpendData && adSpendData.length === 0);
 		if (shouldReadFromFiles && adSpendData?.getWriteDir) {
@@ -114,20 +117,23 @@ export async function sendToMixpanel(context) {
 			// @ts-ignore
 			adSpendDataToImport = files.filter(f => f.includes('-ADSPEND'));
 		}
-		const imported = await mp(creds, adSpendDataToImport, {
-			recordType: "event",
-			...commonOpts,
-		});
-		log(`  -> ${comma(imported.success)} ad spend events sent\n`);
-		importResults.adSpend = imported;
+		if (adSpendDataToImport?.length > 0) {
+			log(`  Ad Spend`);
+			const imported = await mp(creds, adSpendDataToImport, {
+				recordType: "event",
+				...commonOpts,
+			});
+			log(`  -> ${comma(imported.success)} ad spend events sent\n`);
+			importResults.adSpend = imported;
+		}
 	}
 
 	// Import group profiles
 	if (groupProfilesData && Array.isArray(groupProfilesData) && groupProfilesData.length > 0) {
 		for (const groupEntity of groupProfilesData) {
-			if (!groupEntity || groupEntity.length === 0) continue;
+			if (!groupEntity) continue;
+			if (groupEntity.length === 0 && !isBATCH_MODE && !writeToDisk) continue;
 			const groupKey = groupEntity?.groupKey;
-			log(`  Group Profiles (${groupKey})`);
 			let groupProfilesToImport = u.deepClone(groupEntity);
 			const shouldReadFromFiles = isBATCH_MODE || (writeToDisk && groupEntity.length === 0);
 			if (shouldReadFromFiles && groupEntity?.getWriteDir) {
@@ -136,6 +142,8 @@ export async function sendToMixpanel(context) {
 				// @ts-ignore
 				groupProfilesToImport = files.filter(f => f.includes(`-${groupKey}-GROUPS`));
 			}
+			if (!groupProfilesToImport?.length) continue;
+			log(`  Group Profiles (${groupKey})`);
 			const imported = await mp({ token, groupKey }, groupProfilesToImport, {
 				recordType: "group",
 				...commonOpts,
@@ -147,8 +155,7 @@ export async function sendToMixpanel(context) {
 	}
 
 	// Import group events
-	if (groupEventData?.length > 0) {
-		log(`  Group Events`);
+	if (groupEventData?.length > 0 || isBATCH_MODE || (writeToDisk && groupEventData)) {
 		let groupEventDataToImport = u.deepClone(groupEventData);
 		const shouldReadFromFiles = isBATCH_MODE || (writeToDisk && groupEventData.length === 0);
 		if (shouldReadFromFiles && groupEventData?.getWriteDir) {
@@ -157,13 +164,17 @@ export async function sendToMixpanel(context) {
 			// @ts-ignore
 			groupEventDataToImport = files.filter(f => f.includes('-GROUP-EVENTS'));
 		}
-		const imported = await mp(creds, groupEventDataToImport, {
-			recordType: "event",
-			...commonOpts,
-			strict: false
-		});
-		log(`  -> ${comma(imported.success)} group events sent\n`);
-		importResults.groupEvents = imported;
+		// Skip if no data to import (avoids mp() throwing on empty input)
+		if (groupEventDataToImport?.length > 0) {
+			log(`  Group Events`);
+			const imported = await mp(creds, groupEventDataToImport, {
+				recordType: "event",
+				...commonOpts,
+				strict: false
+			});
+			log(`  -> ${comma(imported.success)} group events sent\n`);
+			importResults.groupEvents = imported;
+		}
 	}
 
 	// Import SCD data (requires service account)

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "make-mp-data",
-	"version": "3.0.6",
+	"version": "3.1.0",
 	"description": "builds all mixpanel primitives for a given project",
 	"type": "module",
 	"main": "index.js",
@@ -60,7 +60,7 @@
 		"dotenv": "^16.4.5",
 		"hyparquet-writer": "^0.6.1",
 		"mixpanel": "^0.18.0",
-		"mixpanel-import": "^3.2.9",
+		"mixpanel-import": "^3.3.1",
 		"p-limit": "^3.1.0",
 		"pino": "^9.0.0",
 		"pino-pretty": "^11.0.0",