make-mp-data 1.1.16 → 1.1.18

package/index.js

@@ -479,8 +479,8 @@ function AKsTimeSoup(earliestTime, latestTime = NOW, peakDays = PEAK_DAYS) {
 
 	if (typeof earliestTime !== "number") {
 		if (parseInt(earliestTime) > 0) earliestTime = parseInt(earliestTime);
-		if (dayjs(earliestTime).isValid()) earliestTime = dayjs(earliestTime).unix();		
-	} 
+		if (dayjs(earliestTime).isValid()) earliestTime = dayjs(earliestTime).unix();
+	}
 
 	while (!validTime) {
 
@@ -506,7 +506,7 @@ function AKsTimeSoup(earliestTime, latestTime = NOW, peakDays = PEAK_DAYS) {
 		// Generate a random time within business hours with a higher concentration in the middle of the period
 		const businessStart = dayjs.unix(selectedDay).hour(peakStartHour).minute(0).second(0).unix();
 		const businessEnd = dayjs.unix(selectedDay).hour(peakEndHour).minute(0).second(0).unix();
-		
+
 		if (selectedDay === peakDays[0]) {
 			// Use a skewed distribution for peak days
 			eventTime = chance.normal({ mean: (businessEnd + businessStart) / integer(1, 4), dev: (businessEnd - businessStart) / integer(2, 8) });
@@ -518,8 +518,10 @@ function AKsTimeSoup(earliestTime, latestTime = NOW, peakDays = PEAK_DAYS) {
 		// usually, ensure the event time is within business hours
 		if (chance.bool({ likelihood: 42 })) eventTime = Math.min(Math.max(eventTime, businessStart), businessEnd);
 
-		const compareTime = dayjs.unix(eventTime).toISOString();
-		if (dayjs(chosenTime).isAfter(dayjs.unix(0))) validTime = true;
+		if (eventTime > 0) validTime = true;
+		const parsedTime = dayjs.unix(eventTime).toISOString();
+		if (!parsedTime.startsWith('20')) validTime = false;
+
 	}
 	chosenTime = dayjs.unix(eventTime).toISOString();
 	return chosenTime;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "make-mp-data",
-  "version": "1.1.16",
+  "version": "1.1.18",
   "description": "builds all mixpanel primitives for a given project",
   "main": "index.js",
   "types": "types.d.ts",

package/tests/unit.test.js

@@ -10,7 +10,7 @@ require('dotenv').config();
 describe('timeSoup', () => {
 	test('always positive dates', () => {
 		const dates = [];
-		for (let i = 0; i < 10000; i++) {
+		for (let i = 0; i < 20000; i++) {
 			const earliest = dayjs().subtract(u.rand(2, 360), 'D');
 			dates.push(timeSoup());
 		}