maiass 5.15.3 → 5.15.8

package/lib/account-info.js

@@ -6,7 +6,7 @@ import { SYMBOLS } from './symbols.js';
 import { loadEnvironmentConfig } from './config.js';
 import { generateMachineFingerprint } from './machine-fingerprint.js';
 import { retrieveSecureVariable, storeSecureVariable, removeSecureVariable } from './secure-storage.js';
-import { getClientName, getClientVersion } from './client-info.js';
+import { getClientName, getClientVersion, isAIModeOff, isCI, ciHeaders } from './client-info.js';
 import { getSingleCharInput } from './input-utils.js';
 import fs from 'fs';
 import path from 'path';
@@ -40,8 +40,24 @@ function maskToken(token) {
  */
 async function createAnonymousSubscriptionIfNeeded() {
   const debugMode = process.env.MAIASS_DEBUG === 'true';
-  
+
   try {
+    // MAI-98 defense-in-depth: don't mint a throwaway anonymous sub when AI is
+    // off, or on an ephemeral CI runner with no existing token (fresh
+    // fingerprint per run drains the global free-credit pool).
+    if (isAIModeOff()) {
+      if (debugMode) {
+        log.debug(SYMBOLS.INFO, `[MAIASS DEBUG] AI mode is off (MAIASS_AI_MODE=${process.env.MAIASS_AI_MODE}); skipping anonymous subscription`);
+      }
+      return null;
+    }
+    if (isCI()) {
+      if (debugMode) {
+        log.debug(SYMBOLS.INFO, '[MAIASS DEBUG] CI environment detected with no existing token; skipping anonymous subscription (MAI-98)');
+      }
+      return null;
+    }
+
     log.info(SYMBOLS.INFO, 'Generating machine fingerprint...');
     const machineFingerprint = generateMachineFingerprint();
     
@@ -58,7 +74,8 @@ async function createAnonymousSubscriptionIfNeeded() {
       headers: {
         'Content-Type': 'application/json',
         'X-Client-Name': getClientName(),
-        'X-Client-Version': getClientVersion()
+        'X-Client-Version': getClientVersion(),
+        ...ciHeaders()
       },
       body: JSON.stringify({
         machine_fingerprint: machineFingerprint
@@ -334,8 +351,7 @@ export async function handleAccountInfoCommand(options = {}) {
     
     // If still no API key and AI mode is not off, create anonymous subscription
     if (!apiKey || apiKey === 'DISABLED') {
-      const aiMode = process.env.MAIASS_AI_MODE || 'ask';
-      if (aiMode !== 'off') {
+      if (!isAIModeOff()) {
         if (debugMode) {
           log.debug(SYMBOLS.INFO, '[MAIASS DEBUG] No AI token found, creating anonymous subscription...');
         }

package/lib/changelog-cleanup.js

@@ -29,7 +29,7 @@ import { SYMBOLS } from './symbols.js';
 import colors from './colors.js';
 import { createAnonymousSubscriptionIfNeeded } from './commit.js';
 import { generateMachineFingerprint } from './machine-fingerprint.js';
-import { getClientName, getClientVersion } from './client-info.js';
+import { getClientName, getClientVersion, isAIModeOff, ciHeaders } from './client-info.js';
 import { getSingleCharInput } from './input-utils.js';
 
 export const FLAGS = ['--cleanup-changelogs'];
@@ -48,8 +48,10 @@ const MAX_OUTPUT_TOKENS = 2000;
  * anything other than 'off' as on; we mirror that here.
  */
 function isAIModeActive() {
-  const mode = String(process.env.MAIASS_AI_MODE || 'ask').toLowerCase();
-  return mode !== 'off' && mode !== 'false' && mode !== 'disabled';
+  // MAI-98: delegate to the shared parser so "off"-ish spellings (off/false/no/
+  // 0/disabled, plus the YAML-boolean "false" produced by an unquoted GH Actions
+  // `MAIASS_AI_MODE: off`) are all treated as off consistently across the CLI.
+  return !isAIModeOff();
 }
 
 function executeGitCommand(command) {
@@ -548,7 +550,8 @@ async function callCleanupAI(systemContent, userContent) {
         'X-Machine-Fingerprint': generateMachineFingerprint(),
         'X-Client-Name': getClientName(),
         'X-Client-Version': getClientVersion(),
-        'X-Subscription-ID': process.env.MAIASS_SUBSCRIPTION_ID || ''
+        'X-Subscription-ID': process.env.MAIASS_SUBSCRIPTION_ID || '',
+        ...ciHeaders()
       },
       body: JSON.stringify(requestBody),
       signal: controller.signal

package/lib/client-info.js

@@ -58,3 +58,56 @@ export function getClientInfo() {
     version: getClientVersion()
   };
 }
+
+/**
+ * Robustly decide whether AI is effectively OFF based on MAIASS_AI_MODE.
+ *
+ * MAI-98: the GitHub Actions version-bump workflow set `MAIASS_AI_MODE: off`
+ * (an unquoted YAML boolean) which GitHub stringifies to "false". We also need
+ * to treat the various "off"-ish spellings consistently everywhere so no AI
+ * path ever fires when the operator meant to disable it. A null/undefined/empty
+ * value is NOT off (default behaviour is the interactive 'ask' mode).
+ *
+ * @param {string|undefined} [mode] - raw MAIASS_AI_MODE value (defaults to env)
+ * @returns {boolean} true when AI should be considered disabled
+ */
+export function isAIModeOff(mode = process.env.MAIASS_AI_MODE) {
+  if (mode === undefined || mode === null) return false;
+  const normalised = String(mode).trim().toLowerCase();
+  if (normalised === '') return false;
+  return ['off', 'false', 'no', '0', 'disabled'].includes(normalised);
+}
+
+/**
+ * Detect whether we are running inside a CI / automation environment.
+ *
+ * MAI-98: ephemeral CI runners produce a fresh machine fingerprint on every
+ * run, so any anonymous-subscription mint there creates a brand new sub +
+ * free-credit grant that is never reused — draining the global free pool.
+ * When in CI with no pre-existing token we must never mint an anonymous sub.
+ *
+ * @returns {boolean} true when a known CI environment is detected
+ */
+export function isCI() {
+  return (
+    process.env.CI === 'true' ||
+    !!process.env.GITHUB_ACTIONS ||
+    !!process.env.GITLAB_CI ||
+    !!process.env.CIRCLECI ||
+    !!process.env.BUILDKITE ||
+    !!process.env.TF_BUILD
+  );
+}
+
+/**
+ * Headers to attach to MAIASS proxy / token requests so the server can
+ * independently detect CI and apply its own anti-abuse handling.
+ *
+ * MAI-98 SHARED CONTRACT with worker-api-specialist: the header name is
+ * `X-MAIASS-CI` and is only sent when {@link isCI} is true.
+ *
+ * @returns {Object} header object ({} when not in CI)
+ */
+export function ciHeaders() {
+  return isCI() ? { 'X-MAIASS-CI': 'true' } : {};
+}

package/lib/commit.js

@@ -10,7 +10,7 @@ import readline from 'readline';
 import { loadEnvironmentConfig } from './config.js';
 import { generateMachineFingerprint } from './machine-fingerprint.js';
 import { storeSecureVariable, retrieveSecureVariable } from './secure-storage.js';
-import { getClientName, getClientVersion } from './client-info.js';
+import { getClientName, getClientVersion, isAIModeOff, isCI, ciHeaders } from './client-info.js';
 import { getSingleCharInput, getMultiLineInput } from './input-utils.js';
 import { logCommit } from './devlog.js';
 import colors from './colors.js';
@@ -206,6 +206,25 @@ async function createAnonymousSubscriptionIfNeeded() {
       return existingToken;
     }
 
+    // MAI-98 defense-in-depth: never mint an anonymous subscription when AI is
+    // effectively off, or when running on an ephemeral CI runner with no
+    // pre-existing token. Both conditions otherwise create a fresh anonymous
+    // sub + free-credit grant on every run (CI fingerprints are non-reusable),
+    // draining the global free-credit pool. The caller MUST treat a null return
+    // as "no AI" and proceed without it — the version bump must never block.
+    if (isAIModeOff()) {
+      if (debugMode) {
+        log.debug(SYMBOLS.INFO, `[MAIASS DEBUG] AI mode is off (MAIASS_AI_MODE=${process.env.MAIASS_AI_MODE}); skipping anonymous subscription`);
+      }
+      return null;
+    }
+    if (isCI()) {
+      if (debugMode) {
+        log.debug(SYMBOLS.INFO, '[MAIASS DEBUG] CI environment detected with no existing token; skipping anonymous subscription to avoid pool drain (MAI-98)');
+      }
+      return null;
+    }
+
     log.info(SYMBOLS.INFO, 'Generating machine fingerprint...');
     const machineFingerprint = generateMachineFingerprint();
     
@@ -223,7 +242,8 @@ async function createAnonymousSubscriptionIfNeeded() {
       headers: {
         'Content-Type': 'application/json',
         'X-Client-Name': getClientName(),
-        'X-Client-Version': getClientVersion()
+        'X-Client-Version': getClientVersion(),
+        ...ciHeaders()
       },
       body: JSON.stringify({
         machine_fingerprint: machineFingerprint
@@ -309,6 +329,77 @@ async function createAnonymousSubscriptionIfNeeded() {
   }
 }
 
+/**
+ * Normalize a bullet-style AI commit suggestion into a deterministic on-disk
+ * format. Pure function — no side effects. The normalizer is deliberately
+ * conservative and content-preserving: it reformats whitespace/markers but
+ * never fabricates a subject and never drops body content.
+ *
+ * Contract:
+ *   - Input is coerced via String(text); non-string input cannot throw.
+ *   - CRLF (`\r\n`) and CR line endings are tolerated (trailing \r stripped).
+ *   - Early return (input returned trimmed, unchanged) when the input has zero
+ *     or one non-empty line — a bare title with no bullets, or empty input.
+ *   - No-title passthrough: if the first non-empty line already starts with a
+ *     bullet marker (`-` or `*`), the model produced bullets with no summary
+ *     line. A deterministic normalizer must not invent a subject, so the input
+ *     is returned trimmed and otherwise unchanged.
+ *   - Otherwise the first non-empty line becomes the title (trailing whitespace
+ *     stripped; no marker stripping — it is not a marker line by definition).
+ *   - Each subsequent non-empty line that starts with a bullet marker becomes
+ *     "  - <content>" (exactly two-space indent, single dash; the original
+ *     marker and leading indentation are stripped).
+ *   - Each subsequent non-empty line that does NOT start with a marker is a
+ *     soft-wrapped continuation of the previous line: it is appended to the
+ *     previous bullet (joined with a single space). If no bullet exists yet,
+ *     it is appended to the title line instead.
+ *   - Blank lines between the title and bullets (and trailing blanks) are
+ *     dropped.
+ * @param {string} text - raw AI suggestion (already trimmed/quote-stripped)
+ * @returns {string} normalized bullet-style message
+ */
+function normalizeBulletMessage(text) {
+  const source = String(text);
+  // Normalize line endings so \r\n / \r inputs behave identically to \n.
+  const lines = source.split(/\r\n|\r|\n/);
+
+  // Guard: zero or one non-empty line (empty input or a bare title) is left
+  // untouched apart from outer trimming.
+  if (lines.filter(l => l.trim() !== '').length <= 1) {
+    return source.trim();
+  }
+
+  // No-title passthrough: the model emitted bullets with no summary line. Do
+  // not promote a bullet to a title — return the input trimmed, unchanged.
+  const firstNonEmpty = lines.find(l => l.trim() !== '');
+  if (/^\s*[-*]\s+/.test(firstNonEmpty)) {
+    return source.trim();
+  }
+
+  const isMarker = (line) => /^\s*[-*]\s+/.test(line);
+  const stripMarker = (line) => line.replace(/^\s*[-*]\s+/, '').trim();
+
+  const out = [];
+  let titleSet = false;
+  for (const raw of lines) {
+    const line = raw.replace(/\s+$/, '');
+    if (line.trim() === '') continue;
+    if (!titleSet) {
+      // First non-empty line is the title (guaranteed non-marker above).
+      out.push(line.trim());
+      titleSet = true;
+      continue;
+    }
+    if (isMarker(line)) {
+      out.push('  - ' + stripMarker(line));
+    } else {
+      // Soft-wrapped continuation: append to the previous line.
+      out[out.length - 1] = out[out.length - 1] + ' ' + line.trim();
+    }
+  }
+  return out.join('\n');
+}
+
 /**
  * Get AI commit message suggestion
  * @param {Object} gitInfo - Git information object
@@ -446,20 +537,31 @@ async function getAICommitSuggestion(gitInfo) {
     }
 
     // Create AI prompt based on commit message style
+    //
+    // ⚠️ MAI-108 PROMPT CHANGE / ROLLBACK POINT: the bullet prompt below was
+    // rewritten (placeholders + anti-leak/anti-invent guard) because small/local
+    // models echoed the old few-shot example bullets verbatim. The PREVIOUS,
+    // long-standing prompt is production-proven against the 1min.ai chat path.
+    // If hosted-model commit-message QUALITY regresses, revert this block to its
+    // pre-change form: see git history of this file before commit dca4519 (PR #28).
     let prompt;
     if (commitMessageStyle === 'bullet') {
-      prompt = `Analyze the following git diff and create a commit message with bullet points. Format as:
-Brief summary title
-  - feat: add user authentication
-  - fix(api): resolve syntax error
-  - docs: update README
-
-Use past tense verbs. No blank line between title and bullets. Keep concise. Do not wrap the response in quotes.
+      prompt = `Write a git commit message for the diff below.
+Format exactly like this template:
+<one-line summary>
+  - <type>: <description>
+  - <type>: <description>
+Rules:
+- First line: a brief past-tense summary with no leading dash.
+- Then one or more bullet lines, each indented by exactly two spaces, starting with "- ", then a conventional-commit type (feat, fix, docs, refactor, chore) and a colon.
+- No blank line between the summary line and the bullets.
+- Describe ONLY the actual changes in the diff. Do not output the literal words type or description or any angle brackets, and do not invent changes that are not in the diff.
+- Do not wrap the response in quotes.
 
 Git diff:
 ${gitDiff}`;
     } else {
-      prompt = `Analyze the following git diff and create a concise, descriptive commit message. Use conventional commit format when appropriate (feat:, fix:, docs:, etc.). Keep it under 72 characters for the first line.
+      prompt = `Analyze the following git diff and create a concise, descriptive commit message. Use conventional commit format when appropriate (feat:, fix:, docs:, etc.). Keep it under 72 characters for the first line. Describe only the actual changes in the diff; do not invent changes.
 
 Git diff:
 ${gitDiff}`;
@@ -513,7 +615,8 @@ ${gitDiff}`;
           'X-Machine-Fingerprint': generateMachineFingerprint(),
           'X-Client-Name': getClientName(),
           'X-Client-Version': getClientVersion(),
-          'X-Subscription-ID': process.env.MAIASS_SUBSCRIPTION_ID || ''
+          'X-Subscription-ID': process.env.MAIASS_SUBSCRIPTION_ID || '',
+          ...ciHeaders()
         },
         body: JSON.stringify(requestBody),
         signal: controller.signal
@@ -556,11 +659,16 @@ ${gitDiff}`;
         }
         
         // Clean up any quotes that might wrap the entire response
-        if ((suggestion.startsWith("'") && suggestion.endsWith("'")) || 
+        if ((suggestion.startsWith("'") && suggestion.endsWith("'")) ||
             (suggestion.startsWith('"') && suggestion.endsWith('"'))) {
           suggestion = suggestion.slice(1, -1).trim();
         }
-        
+
+        // Deterministically normalize bullet format so it's model-independent.
+        if (commitMessageStyle === 'bullet') {
+          suggestion = normalizeBulletMessage(suggestion);
+        }
+
         // Extract credit information from billing data
         let creditsUsed, creditsRemaining;
         if (data.billing) {
@@ -1136,6 +1244,7 @@ export {
   getCommitMessage,
   handleStagedCommit,
   getAICommitSuggestion,
+  normalizeBulletMessage,
   executeGitCommand,
   remoteExists
 };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "maiass",
   "type": "module",
-  "version": "5.15.3",
+  "version": "5.15.8",
   "description": "AI commit messages, version bumps, and changelogs from one command. Stages, commits, merges, tags. Anonymous on first run — no email, no card.",
   "main": "maiass.mjs",
   "bin": {

package/templates/ci/github-version-bump.yml

@@ -72,4 +72,9 @@ jobs:
       - name: Bump version
         run: maiass -a patch
         env:
-          MAIASS_AI_MODE: off  # Disable AI — no credits used in CI
+          # Quoted: unquoted `off` is a YAML boolean that GitHub stringifies to
+          # "false", and a repo's tracked .env.maiass (loaded with override) can
+          # still flip AI back on — both previously minted a throwaway anonymous
+          # subscription on every CI run. The CLI now also self-guards via CI
+          # detection (see MAI-98), but keep this explicit and correct.
+          MAIASS_AI_MODE: "off"  # Disable AI — no credits used in CI