maiass 5.15.3 → 5.15.6

package/lib/account-info.js

@@ -6,7 +6,7 @@ import { SYMBOLS } from './symbols.js';
 import { loadEnvironmentConfig } from './config.js';
 import { generateMachineFingerprint } from './machine-fingerprint.js';
 import { retrieveSecureVariable, storeSecureVariable, removeSecureVariable } from './secure-storage.js';
-import { getClientName, getClientVersion } from './client-info.js';
+import { getClientName, getClientVersion, isAIModeOff, isCI, ciHeaders } from './client-info.js';
 import { getSingleCharInput } from './input-utils.js';
 import fs from 'fs';
 import path from 'path';
@@ -40,8 +40,24 @@ function maskToken(token) {
  */
 async function createAnonymousSubscriptionIfNeeded() {
   const debugMode = process.env.MAIASS_DEBUG === 'true';
-  
+
   try {
+    // MAI-98 defense-in-depth: don't mint a throwaway anonymous sub when AI is
+    // off, or on an ephemeral CI runner with no existing token (fresh
+    // fingerprint per run drains the global free-credit pool).
+    if (isAIModeOff()) {
+      if (debugMode) {
+        log.debug(SYMBOLS.INFO, `[MAIASS DEBUG] AI mode is off (MAIASS_AI_MODE=${process.env.MAIASS_AI_MODE}); skipping anonymous subscription`);
+      }
+      return null;
+    }
+    if (isCI()) {
+      if (debugMode) {
+        log.debug(SYMBOLS.INFO, '[MAIASS DEBUG] CI environment detected with no existing token; skipping anonymous subscription (MAI-98)');
+      }
+      return null;
+    }
+
     log.info(SYMBOLS.INFO, 'Generating machine fingerprint...');
     const machineFingerprint = generateMachineFingerprint();
     
@@ -58,7 +74,8 @@ async function createAnonymousSubscriptionIfNeeded() {
       headers: {
         'Content-Type': 'application/json',
         'X-Client-Name': getClientName(),
-        'X-Client-Version': getClientVersion()
+        'X-Client-Version': getClientVersion(),
+        ...ciHeaders()
       },
       body: JSON.stringify({
         machine_fingerprint: machineFingerprint
@@ -334,8 +351,7 @@ export async function handleAccountInfoCommand(options = {}) {
     
     // If still no API key and AI mode is not off, create anonymous subscription
     if (!apiKey || apiKey === 'DISABLED') {
-      const aiMode = process.env.MAIASS_AI_MODE || 'ask';
-      if (aiMode !== 'off') {
+      if (!isAIModeOff()) {
         if (debugMode) {
           log.debug(SYMBOLS.INFO, '[MAIASS DEBUG] No AI token found, creating anonymous subscription...');
         }

package/lib/changelog-cleanup.js

@@ -29,7 +29,7 @@ import { SYMBOLS } from './symbols.js';
 import colors from './colors.js';
 import { createAnonymousSubscriptionIfNeeded } from './commit.js';
 import { generateMachineFingerprint } from './machine-fingerprint.js';
-import { getClientName, getClientVersion } from './client-info.js';
+import { getClientName, getClientVersion, isAIModeOff, ciHeaders } from './client-info.js';
 import { getSingleCharInput } from './input-utils.js';
 
 export const FLAGS = ['--cleanup-changelogs'];
@@ -48,8 +48,10 @@ const MAX_OUTPUT_TOKENS = 2000;
  * anything other than 'off' as on; we mirror that here.
  */
 function isAIModeActive() {
-  const mode = String(process.env.MAIASS_AI_MODE || 'ask').toLowerCase();
-  return mode !== 'off' && mode !== 'false' && mode !== 'disabled';
+  // MAI-98: delegate to the shared parser so "off"-ish spellings (off/false/no/
+  // 0/disabled, plus the YAML-boolean "false" produced by an unquoted GH Actions
+  // `MAIASS_AI_MODE: off`) are all treated as off consistently across the CLI.
+  return !isAIModeOff();
 }
 
 function executeGitCommand(command) {
@@ -548,7 +550,8 @@ async function callCleanupAI(systemContent, userContent) {
         'X-Machine-Fingerprint': generateMachineFingerprint(),
         'X-Client-Name': getClientName(),
         'X-Client-Version': getClientVersion(),
-        'X-Subscription-ID': process.env.MAIASS_SUBSCRIPTION_ID || ''
+        'X-Subscription-ID': process.env.MAIASS_SUBSCRIPTION_ID || '',
+        ...ciHeaders()
       },
       body: JSON.stringify(requestBody),
       signal: controller.signal

package/lib/client-info.js

@@ -58,3 +58,56 @@ export function getClientInfo() {
     version: getClientVersion()
   };
 }
+
+/**
+ * Robustly decide whether AI is effectively OFF based on MAIASS_AI_MODE.
+ *
+ * MAI-98: the GitHub Actions version-bump workflow set `MAIASS_AI_MODE: off`
+ * (an unquoted YAML boolean) which GitHub stringifies to "false". We also need
+ * to treat the various "off"-ish spellings consistently everywhere so no AI
+ * path ever fires when the operator meant to disable it. A null/undefined/empty
+ * value is NOT off (default behaviour is the interactive 'ask' mode).
+ *
+ * @param {string|undefined} [mode] - raw MAIASS_AI_MODE value (defaults to env)
+ * @returns {boolean} true when AI should be considered disabled
+ */
+export function isAIModeOff(mode = process.env.MAIASS_AI_MODE) {
+  if (mode === undefined || mode === null) return false;
+  const normalised = String(mode).trim().toLowerCase();
+  if (normalised === '') return false;
+  return ['off', 'false', 'no', '0', 'disabled'].includes(normalised);
+}
+
+/**
+ * Detect whether we are running inside a CI / automation environment.
+ *
+ * MAI-98: ephemeral CI runners produce a fresh machine fingerprint on every
+ * run, so any anonymous-subscription mint there creates a brand new sub +
+ * free-credit grant that is never reused — draining the global free pool.
+ * When in CI with no pre-existing token we must never mint an anonymous sub.
+ *
+ * @returns {boolean} true when a known CI environment is detected
+ */
+export function isCI() {
+  return (
+    process.env.CI === 'true' ||
+    !!process.env.GITHUB_ACTIONS ||
+    !!process.env.GITLAB_CI ||
+    !!process.env.CIRCLECI ||
+    !!process.env.BUILDKITE ||
+    !!process.env.TF_BUILD
+  );
+}
+
+/**
+ * Headers to attach to MAIASS proxy / token requests so the server can
+ * independently detect CI and apply its own anti-abuse handling.
+ *
+ * MAI-98 SHARED CONTRACT with worker-api-specialist: the header name is
+ * `X-MAIASS-CI` and is only sent when {@link isCI} is true.
+ *
+ * @returns {Object} header object ({} when not in CI)
+ */
+export function ciHeaders() {
+  return isCI() ? { 'X-MAIASS-CI': 'true' } : {};
+}

package/lib/commit.js

@@ -10,7 +10,7 @@ import readline from 'readline';
 import { loadEnvironmentConfig } from './config.js';
 import { generateMachineFingerprint } from './machine-fingerprint.js';
 import { storeSecureVariable, retrieveSecureVariable } from './secure-storage.js';
-import { getClientName, getClientVersion } from './client-info.js';
+import { getClientName, getClientVersion, isAIModeOff, isCI, ciHeaders } from './client-info.js';
 import { getSingleCharInput, getMultiLineInput } from './input-utils.js';
 import { logCommit } from './devlog.js';
 import colors from './colors.js';
@@ -206,6 +206,25 @@ async function createAnonymousSubscriptionIfNeeded() {
       return existingToken;
     }
 
+    // MAI-98 defense-in-depth: never mint an anonymous subscription when AI is
+    // effectively off, or when running on an ephemeral CI runner with no
+    // pre-existing token. Both conditions otherwise create a fresh anonymous
+    // sub + free-credit grant on every run (CI fingerprints are non-reusable),
+    // draining the global free-credit pool. The caller MUST treat a null return
+    // as "no AI" and proceed without it — the version bump must never block.
+    if (isAIModeOff()) {
+      if (debugMode) {
+        log.debug(SYMBOLS.INFO, `[MAIASS DEBUG] AI mode is off (MAIASS_AI_MODE=${process.env.MAIASS_AI_MODE}); skipping anonymous subscription`);
+      }
+      return null;
+    }
+    if (isCI()) {
+      if (debugMode) {
+        log.debug(SYMBOLS.INFO, '[MAIASS DEBUG] CI environment detected with no existing token; skipping anonymous subscription to avoid pool drain (MAI-98)');
+      }
+      return null;
+    }
+
     log.info(SYMBOLS.INFO, 'Generating machine fingerprint...');
     const machineFingerprint = generateMachineFingerprint();
     
@@ -223,7 +242,8 @@ async function createAnonymousSubscriptionIfNeeded() {
       headers: {
         'Content-Type': 'application/json',
         'X-Client-Name': getClientName(),
-        'X-Client-Version': getClientVersion()
+        'X-Client-Version': getClientVersion(),
+        ...ciHeaders()
       },
       body: JSON.stringify({
         machine_fingerprint: machineFingerprint
@@ -513,7 +533,8 @@ ${gitDiff}`;
           'X-Machine-Fingerprint': generateMachineFingerprint(),
           'X-Client-Name': getClientName(),
           'X-Client-Version': getClientVersion(),
-          'X-Subscription-ID': process.env.MAIASS_SUBSCRIPTION_ID || ''
+          'X-Subscription-ID': process.env.MAIASS_SUBSCRIPTION_ID || '',
+          ...ciHeaders()
         },
         body: JSON.stringify(requestBody),
         signal: controller.signal

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "maiass",
   "type": "module",
-  "version": "5.15.3",
+  "version": "5.15.6",
   "description": "AI commit messages, version bumps, and changelogs from one command. Stages, commits, merges, tags. Anonymous on first run — no email, no card.",
   "main": "maiass.mjs",
   "bin": {

package/templates/ci/github-version-bump.yml

@@ -72,4 +72,9 @@ jobs:
       - name: Bump version
         run: maiass -a patch
         env:
-          MAIASS_AI_MODE: off  # Disable AI — no credits used in CI
+          # Quoted: unquoted `off` is a YAML boolean that GitHub stringifies to
+          # "false", and a repo's tracked .env.maiass (loaded with override) can
+          # still flip AI back on — both previously minted a throwaway anonymous
+          # subscription on every CI run. The CLI now also self-guards via CI
+          # detection (see MAI-98), but keep this explicit and correct.
+          MAIASS_AI_MODE: "off"  # Disable AI — no credits used in CI