magus-cli 7.9.0 → 7.9.1

package/src/__tests__/blind/review-followups/ledger-pruning.test.ts

@@ -0,0 +1,79 @@
+import { expect, test } from "bun:test";
+import {
+	access,
+	chmod,
+	mkdir,
+	readdir,
+	utimes,
+	writeFile,
+} from "node:fs/promises";
+import { join } from "node:path";
+
+import {
+	hookCommand,
+	linkExecutable,
+	makeHookPlugin,
+	makeShellPath,
+	makeWorld,
+	pinnedEnv,
+	removeWorld,
+	runChild,
+	sessionInput,
+} from "../plugin-deps/helpers";
+
+test("each stale ledger is pruned even when another stale ledger cannot be removed", async () => {
+	const world = await makeWorld();
+	let blocked = "";
+	try {
+		const plugin = await makeHookPlugin(world, "ledger-pruning", {
+			schema: 1,
+			bin: [],
+		});
+		const shellPath = await makeShellPath(world);
+		await linkExecutable(world.bin, "bun", process.execPath);
+
+		for (const name of ["magus-deps-candidate-a", "magus-deps-candidate-b"]) {
+			await mkdir(join(world.tmp, name));
+		}
+		const candidates = (await readdir(world.tmp)).filter((name) =>
+			name.startsWith("magus-deps-candidate-"),
+		);
+		blocked = join(world.tmp, candidates[0] ?? "magus-deps-candidate-a");
+		const removable = join(
+			world.tmp,
+			candidates[1] ?? "magus-deps-candidate-b",
+		);
+		await mkdir(join(blocked, "contents"));
+		await writeFile(join(blocked, "contents", "ledger"), "stale\n");
+		const stale = new Date(0);
+		await utimes(blocked, stale, stale);
+		await utimes(removable, stale, stale);
+		await chmod(blocked, 0o000);
+
+		await runChild(
+			join(shellPath, "sh"),
+			["-c", `umask 022; ${hookCommand("pruner")}`],
+			{
+				cwd: world.project,
+				env: pinnedEnv(world, [world.bin, shellPath], {
+					BUN_INSTALL: join(world.home, ".bun"),
+					CLAUDE_PLUGIN_ROOT: plugin,
+					SHELL: join(shellPath, "sh"),
+				}),
+				input: sessionInput("current-ledger"),
+				timeoutMs: 9_500,
+			},
+		);
+
+		let removableExists = true;
+		try {
+			await access(removable);
+		} catch {
+			removableExists = false;
+		}
+		expect(removableExists).toBe(false);
+	} finally {
+		if (blocked) await chmod(blocked, 0o700).catch(() => undefined);
+		await removeWorld(world);
+	}
+});

package/src/__tests__/blind/review-followups/path-advice.test.ts

@@ -0,0 +1,46 @@
+import { expect, test } from "bun:test";
+import { writeFile } from "node:fs/promises";
+import { join } from "node:path";
+
+import {
+	configureClaude,
+	makePlugin,
+	makeWorld,
+	removeWorld,
+	runDoctor,
+	writeExecutable,
+} from "../plugin-deps/helpers";
+
+test("doctor does not advise adding a PATH line already present in the shell rc file", async () => {
+	const world = await makeWorld();
+	try {
+		const rcLine = 'export PATH="$HOME/.bun/bin:$PATH"';
+		await writeFile(join(world.home, ".zshrc"), `${rcLine}\n`);
+		const plugin = await makePlugin(world, "path-advice", {
+			schema: 1,
+			bin: [
+				{
+					name: "bun",
+					check: ["bun", "--version"],
+					install: [{ tool: "bun", via: "bootstrap" }],
+				},
+				{
+					name: "widget",
+					check: ["widget", "--version"],
+					install: [{ package: "widget", via: "bun" }],
+				},
+			],
+		});
+		await configureClaude(world, [{ key: "path-advice@test", root: plugin }]);
+		await writeExecutable(join(world.bin, "bun"), "exit 0");
+		await writeExecutable(join(world.home, ".bun", "bin", "widget"), "exit 0");
+
+		const result = await runDoctor(world, ["--fix", "--yes"], {
+			extraEnv: { BUN_INSTALL: join(world.home, ".bun") },
+		});
+		const output = `${result.stdout}\n${result.stderr}`;
+		expect(output).not.toContain(`${rcLine}  to ~/.zshrc`);
+	} finally {
+		await removeWorld(world);
+	}
+});

package/src/__tests__/blind/review-followups/stats-requires.test.ts

@@ -0,0 +1,16 @@
+import { expect, test } from "bun:test";
+import { readFile } from "node:fs/promises";
+import { join } from "node:path";
+
+import { REPO_ROOT } from "../plugin-deps/helpers";
+
+test("the stats plugin declares only tools its runtime uses", async () => {
+	const manifest = JSON.parse(
+		await readFile(
+			join(REPO_ROOT, "plugins", "stats", ".claude-plugin", "plugin.json"),
+			"utf8",
+		),
+	) as { requires: { bin: { name: string }[] } };
+
+	expect(manifest.requires.bin.map(({ name }) => name).sort()).toEqual(["bun"]);
+});

package/src/__tests__/deps-plan.test.ts

@@ -468,7 +468,7 @@ describe("applyDepsPlan — uv-module", () => {
 			env,
 		);
 		const { calls, run } = fakeRun([
-			[(a) => a[1] === "python" && a[2] === "find", { outputTail: `${PY}\n` }],
+			[(a) => a[1] === "python" && a[2] === "find", { stdout: `${PY}\n` }],
 		]);
 		const outcomes = await applyDepsPlan(plan, options({ run }));
 		expect(outcomes.map((o) => [o.name, o.status])).toEqual([
@@ -518,7 +518,7 @@ describe("applyDepsPlan — uv-module", () => {
 		for (const t of ["sudo", "uv"]) tool(bin, t);
 		const plan = planDeps([LIBS], [missing("chromium-libs")], env);
 		const { calls, run } = fakeRun([
-			[(a) => a[1] === "python", { outputTail: "/usr/bin/python3.12\n" }],
+			[(a) => a[1] === "python", { stdout: "/usr/bin/python3.12\n" }],
 			[(a) => a[1] === "-c", { exitCode: 1 }],
 		]);
 		const [outcome] = await applyDepsPlan(plan, options({ run }));
@@ -835,6 +835,7 @@ describe("applyDepsPlan — installed means the re-probe found it", () => {
 				signal: null,
 				timedOut: false,
 				outputTail: argv[1] === "pm" ? `${xdgBin}\n` : "installed claudish",
+				...(argv[1] === "pm" ? { stdout: `${xdgBin}\n` } : {}),
 				durationMs: 1,
 			};
 		};