magus-cli 7.8.0 → 7.9.1

package/src/__tests__/shell-script-callers.test.ts

@@ -1,92 +0,0 @@
-/**
- * `runShellScript` has exactly one legitimate caller, and this pins it.
- *
- * The whole of item 3 is the split between two ways of running a child process:
- * argv (`runCommand`), which no shell ever sees, and a script (`runShellScript`),
- * which `/bin/sh` parses. Every installer command belongs to the first, because
- * it is assembled from package names that arrive in `.claude/profiles.json` and
- * plugin `requires.bin` — hand-authored, committed by teammates, fetched from
- * marketplaces, validated by nothing. The second exists only for the two
- * `TOOLCHAIN_BOOTSTRAP` values, which are constants in this repo copied from
- * bun.sh and brew.sh and which genuinely contain a pipe and a command
- * substitution.
- *
- * Nothing in the type system distinguishes them — both are strings — so after
- * the commit lands, the design decision is enforced by this test or by nothing.
- * A branded `ShellScript` type would enforce it at compile time and was
- * considered; for one map, two entries and one call site it is more machinery
- * than the rule is worth, and unlike a brand this is greppable.
- *
- * Source-scanning precedent in this suite: `uppercase-keybindings.test.ts`.
- */
-
-import { describe, expect, test } from "bun:test";
-import path from "node:path";
-import fs from "fs-extra";
-
-const SRC_DIR = path.join(import.meta.dir, "..");
-
-/** Files permitted to call `runShellScript`, relative to `src/`. */
-const ALLOWED = ["cli/install.ts"];
-
-/** The definition itself, plus this test, are not callers. */
-const NOT_CALLERS = ["utils/run.ts", "__tests__/shell-script-callers.test.ts"];
-
-async function sourceFiles(dir: string): Promise<string[]> {
-	const out: string[] = [];
-	for (const entry of await fs.readdir(dir, { withFileTypes: true })) {
-		const full = path.join(dir, entry.name);
-		if (entry.isDirectory()) out.push(...(await sourceFiles(full)));
-		else if (/\.tsx?$/.test(entry.name)) out.push(full);
-	}
-	return out;
-}
-
-const isComment = (line: string) => {
-	const t = line.trim();
-	return t.startsWith("//") || t.startsWith("*") || t.startsWith("/*");
-};
-
-async function callersOf(pattern: RegExp): Promise<string[]> {
-	const found = new Set<string>();
-	for (const file of await sourceFiles(SRC_DIR)) {
-		const rel = path.relative(SRC_DIR, file);
-		if (NOT_CALLERS.includes(rel)) continue;
-		const text = await fs.readFile(file, "utf8");
-		for (const line of text.split("\n")) {
-			if (isComment(line)) continue;
-			if (pattern.test(line)) found.add(rel);
-		}
-	}
-	return [...found].sort();
-}
-
-describe("only the toolchain bootstrap goes through a shell", () => {
-	test("runShellScript is called from exactly the allowed files", async () => {
-		expect(await callersOf(/\brunShellScript\(/)).toEqual(ALLOWED);
-	});
-
-	test("nothing spawns with a shell outside utils/run.ts", async () => {
-		// Catches someone reaching for `spawn`/`exec` directly rather than
-		// through the seam — a second shell path that never names
-		// `runShellScript`.
-		//
-		// Both spellings: `shell: true` and a named shell (`shell: "/bin/bash"`).
-		// The CLI Tools screen used the second for its version probe (`which -a`
-		// pipelines, a string-form `exec` of each check command); that probe now
-		// lives in services/tool-probe.ts and runs argv only. `shell: false` and
-		// the alias writer's `shell: ShellKind` values are not spawn options and
-		// do not match.
-		expect(await callersOf(/shell:\s*(true|["'`])/)).toEqual([]);
-	});
-
-	test("the scan can actually fail", async () => {
-		// Negative control. The two assertions above pass trivially if the walk
-		// finds nothing or the pattern never matches, and a check that cannot
-		// fail is not evidence. `runCommand(` is known to be called from several
-		// files, so a working scan must find them.
-		const runCommandCallers = await callersOf(/\brunCommand\(/);
-		expect(runCommandCallers.length).toBeGreaterThan(0);
-		expect(runCommandCallers).toContain("cli/install.ts");
-	});
-});