magus-cli 7.7.0 → 7.8.0

package/src/__tests__/version-snapshot.test.ts

@@ -1,212 +0,0 @@
-import { describe, expect, test } from "bun:test";
-import { promises as fs } from "node:fs";
-import os from "node:os";
-import path from "node:path";
-import {
-	UNKNOWN_VERSION,
-	diffVersions,
-	isKnownVersion,
-	loadSeenVersions,
-	saveSeenVersions,
-} from "../services/version-snapshot.js";
-
-/**
- * Plugins get updated by things magus does not control — Claude Code's own
- * `plugin update` writes installed_plugins.json without touching magus's
- * bookkeeping. Diffing what we last rendered against reality catches every
- * source; logging only magus's own actions catches none of them.
- */
-
-describe("isKnownVersion", () => {
-	test('"0.0.0" is not a usable version', () => {
-		// Claude Code records this for a plugin whose version it cannot determine.
-		expect(isKnownVersion(UNKNOWN_VERSION)).toBe(false);
-		expect(isKnownVersion(undefined)).toBe(false);
-		expect(isKnownVersion("")).toBe(false);
-		expect(isKnownVersion("1.0.0")).toBe(true);
-	});
-});
-
-describe("diffVersions — first run", () => {
-	test("no baseline reports nothing at all", () => {
-		// Without this, the first launch would flag every installed plugin as new,
-		// which is both wrong and the fastest way to train someone to ignore badges.
-		expect(
-			diffVersions(null, { "dev@magus": "2.12.1", "a@mp": UNKNOWN_VERSION }),
-		).toEqual([]);
-	});
-
-	test("an empty baseline is NOT the same as no baseline", () => {
-		// A real snapshot that happens to be empty means we have looked before and
-		// saw nothing, so anything present now is genuinely new.
-		const changes = diffVersions({}, { "dev@magus": "2.12.1" });
-		expect(changes).toEqual([
-			{ pluginId: "dev@magus", kind: "installed", to: "2.12.1" },
-		]);
-	});
-});
-
-describe("diffVersions — installs", () => {
-	test("a plugin absent from the baseline is reported as installed, not updated", () => {
-		const changes = diffVersions(
-			{ "other@mp": "1.0.0" },
-			{ "new@mp": "3.1.0" },
-		);
-		expect(changes).toEqual([
-			{ pluginId: "new@mp", kind: "installed", to: "3.1.0" },
-		]);
-	});
-
-	test("an install with an unknown version is still reported", () => {
-		// The version is unusable but the install is real — the UI shows "new"
-		// with no version rather than suppressing the plugin entirely.
-		const changes = diffVersions({}, { "a@mp": UNKNOWN_VERSION });
-		expect(changes).toEqual([
-			{ pluginId: "a@mp", kind: "installed", to: UNKNOWN_VERSION },
-		]);
-	});
-});
-
-describe("diffVersions — updates", () => {
-	test("reports a genuine version transition", () => {
-		expect(
-			diffVersions({ "dev@magus": "2.12.0" }, { "dev@magus": "2.12.1" }),
-		).toEqual([
-			{ pluginId: "dev@magus", kind: "updated", from: "2.12.0", to: "2.12.1" },
-		]);
-	});
-
-	test("unchanged versions report nothing", () => {
-		expect(
-			diffVersions({ "dev@magus": "2.12.1" }, { "dev@magus": "2.12.1" }),
-		).toEqual([]);
-	});
-
-	test("learning a previously unknown version is not an update", () => {
-		// This is exactly what v4.22.0's registry overlay caused: versions that
-		// could not be resolved suddenly could be. Reporting it would announce
-		// magus's own bugfix as if the user's plugins had changed.
-		expect(
-			diffVersions({ "a@mp": UNKNOWN_VERSION }, { "a@mp": "5.3.0" }),
-		).toEqual([]);
-	});
-
-	test("losing a known version is not an update either", () => {
-		expect(
-			diffVersions({ "a@mp": "5.3.0" }, { "a@mp": UNKNOWN_VERSION }),
-		).toEqual([]);
-	});
-
-	test("a downgrade IS reported", () => {
-		// Rolling back is a real change, arguably the most important to surface.
-		expect(diffVersions({ "a@mp": "2.0.0" }, { "a@mp": "1.0.0" })).toEqual([
-			{ pluginId: "a@mp", kind: "updated", from: "2.0.0", to: "1.0.0" },
-		]);
-	});
-});
-
-describe("diffVersions — removals and mixed sets", () => {
-	test("a removed plugin is not reported", () => {
-		expect(diffVersions({ "gone@mp": "1.0.0" }, {})).toEqual([]);
-	});
-
-	test("classifies each plugin independently in one pass", () => {
-		const changes = diffVersions(
-			{ same: "1.0.0", moved: "2.0.0", learned: UNKNOWN_VERSION },
-			{ same: "1.0.0", moved: "2.1.0", learned: "9.0.0", fresh: "0.1.0" },
-		);
-		expect(changes).toEqual([
-			{ pluginId: "moved", kind: "updated", from: "2.0.0", to: "2.1.0" },
-			{ pluginId: "fresh", kind: "installed", to: "0.1.0" },
-		]);
-	});
-});
-
-describe("per-project baselines", () => {
-	/**
-	 * The baseline used to be one flat map for the whole machine, but the
-	 * versions written into it are resolved per project. Two projects
-	 * legitimately on different versions overwrote each other's baseline, so
-	 * every differing plugin was reported as "updated" on the next render — a
-	 * change that never happened.
-	 *
-	 * CLAUDE_CONFIG_DIR, not HOME: os.homedir() reads the passwd database on
-	 * macOS and ignores $HOME, so a HOME-only override writes to the operator's
-	 * real ~/.claude. That is not hypothetical — it happened while writing these.
-	 */
-	const withSandbox = async (fn: () => Promise<void>): Promise<void> => {
-		const dir = await fs.mkdtemp(path.join(os.tmpdir(), "vsnap-"));
-		const prev = process.env.CLAUDE_CONFIG_DIR;
-		process.env.CLAUDE_CONFIG_DIR = dir;
-		try {
-			await fn();
-		} finally {
-			// biome-ignore lint/performance/noDelete: assigning undefined to process.env stores the string "undefined"; only delete unsets the variable
-			if (prev === undefined) delete process.env.CLAUDE_CONFIG_DIR;
-			else process.env.CLAUDE_CONFIG_DIR = prev;
-			await fs.rm(dir, { recursive: true, force: true });
-		}
-	};
-
-	test("a project with no baseline of its own reports nothing", async () => {
-		await withSandbox(async () => {
-			await saveSeenVersions("/proj/a", { "setup@magus": "2.2.0" });
-			const baseline = await loadSeenVersions("/proj/b");
-			expect(baseline).toBeNull();
-			expect(diffVersions(baseline, { "setup@magus": "2.5.0" })).toEqual([]);
-		});
-	});
-
-	test("saving one project preserves the others", async () => {
-		await withSandbox(async () => {
-			await saveSeenVersions("/proj/a", { "designer@magus": "2.0.0" });
-			await saveSeenVersions("/proj/b", { "designer@magus": "2.0.1" });
-			expect(await loadSeenVersions("/proj/a")).toEqual({
-				"designer@magus": "2.0.0",
-			});
-			expect(await loadSeenVersions("/proj/b")).toEqual({
-				"designer@magus": "2.0.1",
-			});
-		});
-	});
-
-	test("a real update inside one project is still reported", async () => {
-		await withSandbox(async () => {
-			await saveSeenVersions("/proj/a", { "dev@magus": "3.0.0" });
-			const previous = await loadSeenVersions("/proj/a");
-			expect(diffVersions(previous, { "dev@magus": "3.0.1" })).toEqual([
-				{ pluginId: "dev@magus", kind: "updated", from: "3.0.0", to: "3.0.1" },
-			]);
-		});
-	});
-
-	test("a pre-migration flat baseline is adopted once, then replaced", async () => {
-		await withSandbox(async () => {
-			const file = path.join(
-				process.env.CLAUDE_CONFIG_DIR as string,
-				"magus-version-snapshot.json",
-			);
-			await fs.writeFile(
-				file,
-				JSON.stringify({
-					seen: { "dev@magus": "3.0.0" },
-					seededAt: "2026-07-29T00:00:00.000Z",
-					updatedAt: "2026-07-29T00:00:00.000Z",
-				}),
-			);
-
-			// Legacy shape carries no project, so it stands in for whoever asks first
-			// rather than being thrown away.
-			expect(await loadSeenVersions("/proj/a")).toEqual({
-				"dev@magus": "3.0.0",
-			});
-
-			await saveSeenVersions("/proj/a", { "dev@magus": "3.0.1" });
-			// Once per-project entries exist, the flat map is no longer consulted.
-			expect(await loadSeenVersions("/proj/b")).toBeNull();
-			expect(await loadSeenVersions("/proj/a")).toEqual({
-				"dev@magus": "3.0.1",
-			});
-		});
-	});
-});

package/src/services/version-snapshot.ts

@@ -1,189 +0,0 @@
-/**
- * version-snapshot.ts — detect plugin changes that happened outside magus.
- *
- * Plugins get updated by things magus does not control: Claude Code's own
- * `plugin install`/`update`, or a direct CLI
- * call. All of them write `installed_plugins.json`; none of them tell the user
- * anything the next time magus opens, so versions move underfoot silently.
- *
- * Rather than log what magus itself did — which misses every other source —
- * this records what magus last *saw* installed and diffs against reality on
- * load. Any change is reported, regardless of who made it.
- *
- * The snapshot is advisory UI state, kept separate from the update-check cache
- * so a TTL expiry or a corrupt cache can never make plugins look changed.
- */
-
-import { promises as fs } from "node:fs";
-import os from "node:os";
-import path from "node:path";
-
-/**
- * Sentinel recorded by Claude Code for a plugin that is installed but whose
- * version is unknown — every plugin in the official Anthropic marketplace uses
- * it. It is not a real version and must never be rendered as one.
- */
-export const UNKNOWN_VERSION = "0.0.0";
-
-/** True when a version string carries no usable information. */
-export function isKnownVersion(v: string | undefined): v is string {
-	return !!v && v !== UNKNOWN_VERSION;
-}
-
-export type PluginChangeKind = "installed" | "updated";
-
-export interface PluginChange {
-	pluginId: string;
-	kind: PluginChangeKind;
-	/** Previous version. Only set for "updated", and always a known version. */
-	from?: string;
-	/** Current version. May be UNKNOWN_VERSION — callers must not render it raw. */
-	to: string;
-}
-
-interface SnapshotFile {
-	/**
-	 * Legacy flat baseline: pluginId -> version, with no record of which project
-	 * it was observed from. Kept only so an existing file can be migrated.
-	 */
-	seen?: Record<string, string>;
-	/**
-	 * projectPath -> (pluginId -> installedVersion) as of the last time magus
-	 * rendered that project.
-	 *
-	 * Versions are per-project (installed_plugins.json keys installs by
-	 * projectPath), but this file is global. A single flat map therefore let two
-	 * projects legitimately on different versions overwrite each other's
-	 * baseline, and every differing plugin was badged "updated" on the next
-	 * render — a change that never happened. Keying by project removes the
-	 * cross-talk entirely.
-	 */
-	byProject?: Record<string, Record<string, string>>;
-	/** Set on the run that first created the baseline. */
-	seededAt: string;
-	updatedAt: string;
-}
-
-/**
- * Honour CLAUDE_CONFIG_DIR — the same override Claude Code itself uses.
- *
- * `os.homedir()` reads the passwd database on macOS and ignores $HOME, so a
- * test that only overrides HOME writes to the operator's real snapshot file.
- * That is not hypothetical: it happened while building the tests for this fix.
- */
-function snapshotPath(): string {
-	const configDir =
-		process.env.CLAUDE_CONFIG_DIR || path.join(os.homedir(), ".claude");
-	return path.join(configDir, "magus-version-snapshot.json");
-}
-
-async function read(): Promise<SnapshotFile | null> {
-	try {
-		const raw = await fs.readFile(snapshotPath(), "utf-8");
-		const data = JSON.parse(raw) as SnapshotFile;
-		if (!data) return null;
-		const hasFlat = typeof data.seen === "object" && data.seen !== null;
-		const hasByProject =
-			typeof data.byProject === "object" && data.byProject !== null;
-		if (!hasFlat && !hasByProject) return null;
-		return data;
-	} catch {
-		return null; // absent or corrupt — treated as "no baseline yet"
-	}
-}
-
-/**
- * Diff what is installed now against the previous snapshot.
- *
- * Three cases are deliberately silent, because each reflects magus's own
- * knowledge changing rather than anything happening to the user's plugins:
- *
- *  1. No baseline (first run). Every plugin would otherwise be reported as
- *     newly installed on the very first launch — a guaranteed false flood that
- *     trains the user to ignore the badge. The first run seeds and says nothing.
- *
- *  2. A version moving to or from UNKNOWN_VERSION. That is magus learning
- *     (or losing) a version it could not previously resolve — notably after
- *     v4.22.0 taught it to read the registry — not the plugin changing.
- *
- *  3. A plugin disappearing. Uninstalls are visible elsewhere; nothing to badge.
- *
- * A downgrade IS reported: rolling back is a real change worth surfacing.
- */
-export function diffVersions(
-	previous: Record<string, string> | null,
-	current: Record<string, string>,
-): PluginChange[] {
-	if (!previous) return [];
-
-	const changes: PluginChange[] = [];
-	for (const [pluginId, to] of Object.entries(current)) {
-		const from = previous[pluginId];
-
-		// Never seen before → newly installed, not an update. There is no
-		// meaningful "from", and `to` may legitimately be UNKNOWN_VERSION.
-		if (from === undefined) {
-			changes.push({ pluginId, kind: "installed", to });
-			continue;
-		}
-
-		if (from === to) continue;
-
-		// One side carries no real version: we learned or lost it, nothing moved.
-		if (!isKnownVersion(from) || !isKnownVersion(to)) continue;
-
-		changes.push({ pluginId, kind: "updated", from, to });
-	}
-	return changes;
-}
-
-/**
- * Load the baseline for one project, or null when that project has none.
- *
- * A project seen for the first time returns null, so `diffVersions` stays
- * silent — the same rule as a first ever run. That is deliberate: opening
- * magus in a new project must not badge every plugin as "updated" just
- * because this file has never seen that path before.
- *
- * A pre-migration flat file is adopted as the baseline for whichever project
- * asks first, which is the closest thing to the truth it contains.
- */
-export async function loadSeenVersions(
-	projectPath: string,
-): Promise<Record<string, string> | null> {
-	const data = await read();
-	if (!data) return null;
-	const scoped = data.byProject?.[projectPath];
-	if (scoped) return scoped;
-	// Legacy flat baseline, project unknown — use it once, then it is replaced
-	// by per-project entries on save.
-	if (data.seen && !data.byProject) return data.seen;
-	return null;
-}
-
-/**
- * Persist what is installed now, so the same change is not reported twice.
- * Best-effort: a failure here must never break the UI — it only means the badge
- * shows again next launch.
- */
-export async function saveSeenVersions(
-	projectPath: string,
-	current: Record<string, string>,
-): Promise<void> {
-	try {
-		const file = snapshotPath();
-		await fs.mkdir(path.dirname(file), { recursive: true });
-		const existing = await read();
-		const now = new Date().toISOString();
-		const payload: SnapshotFile = {
-			// Other projects' baselines are preserved — writing only this project's
-			// slot is the entire point of the fix.
-			byProject: { ...(existing?.byProject ?? {}), [projectPath]: current },
-			seededAt: existing?.seededAt ?? now,
-			updatedAt: now,
-		};
-		await fs.writeFile(file, JSON.stringify(payload, null, 2), "utf-8");
-	} catch {
-		// ignore
-	}
-}