magus-cli 7.4.1 → 7.5.1

package/src/services/profile-startup.ts

@@ -3,9 +3,11 @@
  *
  * ## One source of truth, not two
  *
- * A profiled project's `.claude/settings.json` is a SYMLINK into
- * `_profiles/<id>/`, and that file is generated from the manifest. So the
- * manifest is the truth and `enabledPlugins` is its output.
+ * A profiled project's `.claude/settings.json` is rendered from the manifest,
+ * so the manifest is the truth and `enabledPlugins` is its output. (Claude
+ * Code may since have written to it; that is a change to the active profile,
+ * absorbed into the manifest before anything reads it — see
+ * `profile-absorb.ts` — not a question asked here.)
  *
  * An earlier version of this file compared the two — the manifest against the
  * plugins `enabledPlugins` lists — and offered to create a new profile when
@@ -20,11 +22,13 @@
  * a set of declared plugins to a set of installed ones — they are different
  * kinds of thing and a comparison between them cannot be acted on.
  *
- * ## What is left is a three-state question, and one state with no question
+ * ## What is left is a small set of states
  *
  *   ok           a profile is active; the manifest is in effect; ask nothing
  *   unmigrated   no manifest — the project is not using profiles at all
- *   inactive     a manifest with profiles, none of them linked into place
+ *   inactive     a manifest with profiles, none of them activated
+ *   unknown      the active-profile marker names a profile the manifest does
+ *                not define; the only way on is activating one that exists
  *   unparseable  a manifest that exists and is not valid JSON, or is valid
  *                JSON in the wrong shape (see `readProfilesFile`)
  *
@@ -38,8 +42,12 @@
  * manifest over whatever the file held. So it offers nothing but the way out,
  * and names the file to fix.
  *
- * Detection only — nothing here writes. That is what makes it callable from the
- * TUI's startup effect, and testable without a renderer.
+ * `detectProfileStartupNeed` is detection only — nothing it does writes, which
+ * is what makes it testable without a renderer. `prepareProfileStartup` is
+ * the TUI's entry point: it runs the same gate as every CLI command first
+ * (`prepareProfileState` — restore a lost marker, convert an older layout,
+ * absorb Claude Code's edits, regenerate from a changed manifest), then
+ * detects.
  */
 
 import type { ProfileManifest } from "../types/index.js";
@@ -51,14 +59,20 @@ import type { SelectOption } from "../ui/state/types.js";
 import { MANIFEST_FILE, emptyManifest, readManifest } from "./manifest.js";
 import type { ProfileChoice } from "./profile-activate.js";
 import { freeProfileId } from "./profile-adopt.js";
+import {
+	activeProfile,
+	displaceableArtifacts,
+	namedActiveProfile,
+} from "./profile-live.js";
+import { prepareProfileState } from "./profile-state.js";
 import { SettingsParseError } from "./settings-file.js";
-import { activeProfile, displaceableArtifacts } from "./symlink-manager.js";
 
 /** Whether the project can be worked on, and if not, why not. */
 export type ProfileStartupState =
 	| "ok"
 	| "unmigrated"
 	| "inactive"
+	| "unknown"
 	| "unparseable";
 
 /** A profile the user could activate. */
@@ -81,8 +95,13 @@ export interface ProfileStartupNeed {
 	 * Null when a profile is already active. Never an id already in use.
 	 */
 	adopt: string | null;
-	/** Profiles that could be activated. Empty unless the state is `inactive`. */
+	/**
+	 * Profiles that could be activated. Empty unless the state is `inactive` or
+	 * `unknown`.
+	 */
 	activate: ActivatableProfile[];
+	/** For `unknown`: the profile the marker names. */
+	unknownProfile?: string;
 	/**
 	 * The profile this project declares it wants, if the manifest names one that
 	 * exists. Used to preselect the row so Enter does the intended thing.
@@ -159,8 +178,8 @@ export async function detectProfileStartupNeed(
 	}
 
 	// The ONE question that decides whether the manifest is in effect. Not a
-	// comparison, not a heuristic: either settings.json is a link into a
-	// profile or it is not.
+	// comparison, not a heuristic: either the active-profile marker names a
+	// materialized profile or it does not (see `activeProfile`).
 	if ((await activeProfile(projectPath)) !== null) {
 		return {
 			state: "ok",
@@ -172,6 +191,28 @@ export async function detectProfileStartupNeed(
 		};
 	}
 
+	const activate = ids.map((id) => ({
+		id,
+		name: manifest.profiles[id]?.name ?? id,
+		pluginCount: Object.keys(manifest.profiles[id]?.plugins ?? {}).length,
+	}));
+
+	// A marker naming a profile the manifest does not define: magus must not act
+	// on it, and saving "what you have" would capture the output of a profile
+	// that no longer exists. The only way on is activating one that does.
+	const named = await namedActiveProfile(projectPath);
+	if (named !== null) {
+		return {
+			state: "unknown",
+			adopt: null,
+			activate,
+			declaredDefault: null,
+			autoActivate: false,
+			unknownProfile: named.profile,
+			manifest,
+		};
+	}
+
 	// Validated, not trusted: a `default` naming a profile that was renamed or
 	// removed must fall back to asking rather than throw somewhere downstream.
 	// `validateManifest` reports the typo; this keeps magus usable meanwhile.
@@ -196,15 +237,39 @@ export async function detectProfileStartupNeed(
 		// magus can no longer form an opinion on it without the comparison that
 		// used to be here.
 		adopt: freeProfileId(manifest),
-		activate: ids.map((id) => ({
-			id,
-			name: manifest.profiles[id]?.name ?? id,
-			pluginCount: Object.keys(manifest.profiles[id]?.plugins ?? {}).length,
-		})),
+		activate,
 		manifest,
 	};
 }
 
+/** What the TUI shows at startup, beyond the question (if any). */
+export interface ProfileStartup {
+	need: ProfileStartupNeed;
+	/** One line per thing the gate did: absorbed edits, regeneration, repairs. */
+	notices: string[];
+}
+
+/**
+ * The TUI's startup: the same gate every CLI command runs, then detection.
+ *
+ * A failure in the gate never blocks the TUI — its message becomes a notice
+ * and detection still runs, so the user is asked whatever is left to ask.
+ */
+export async function prepareProfileStartup(
+	projectPath: string,
+): Promise<ProfileStartup> {
+	const notices: string[] = [];
+	try {
+		const prep = await prepareProfileState(projectPath);
+		notices.push(...prep.lines, ...prep.problems);
+	} catch (error) {
+		if (!(error instanceof SettingsParseError)) {
+			notices.push(error instanceof Error ? error.message : String(error));
+		}
+	}
+	return { need: await detectProfileStartupNeed(projectPath), notices };
+}
+
 // ─── What to offer, as data both surfaces render ─────────────────────────────
 
 /** Option values are parsed back, so they are data, not prose. */
@@ -284,6 +349,13 @@ export function describeNeed(need: ProfileStartupNeed): {
 		};
 	}
 
+	if (need.state === "unknown") {
+		return {
+			title: "Active profile no longer exists",
+			message: `This project was running the profile "${need.unknownProfile ?? "?"}", which the team's profiles file no longer defines.\n\nActivate one of the profiles below. It replaces the plugins, MCP servers and settings turned on here with that profile's.`,
+		};
+	}
+
 	if (need.state === "unmigrated") {
 		return {
 			title: "magus uses profiles",