magus-cli 7.2.0 → 7.3.0

package/src/ui/screens/PluginsScreen.tsx

@@ -996,9 +996,16 @@ export function PluginsScreen() {
 	const handleUpdate = async () => {
 		const item = selectableItems[pluginsState.selectedIndex];
 		if (!item || item.kind !== "plugin") return;
-		// The row said "update" or "stale — reinstall"; nothing else is work.
+		// The row said "update", "stale — reinstall" or "BROKEN"; nothing else is
+		// work for this key. `install` stays out — that is the scope keys' and the
+		// profile's business, and the detail panel never offers U for it.
 		const status = statuses.get(item.plugin.id);
-		if (status?.action !== "update" && status?.action !== "repair") return;
+		if (
+			status?.action !== "update" &&
+			status?.action !== "repair" &&
+			status?.action !== "stale-load"
+		)
+			return;
 
 		const plugin = item.plugin;
 		const scope: PluginScope =
@@ -1010,9 +1017,13 @@ export function PluginsScreen() {
 		const repairing = status.action === "repair";
 
 		modal.loading(
-			repairing
-				? `Repairing ${plugin.name}…\nclaude plugin uninstall ${plugin.id} --scope ${scope} && claude plugin install ${plugin.id} --scope ${scope}`
-				: `Updating ${plugin.name}…\nclaude plugin install ${plugin.id} --scope ${scope}`,
+			// A broken plugin runs NO claude command at all, so naming one here would
+			// misdescribe the work: the repair rewrites installed_plugins.json rows.
+			status.action === "stale-load"
+				? `Repairing ${plugin.name}…\nmoving this repository's install records forward to v${status.target ?? "?"}`
+				: repairing
+					? `Repairing ${plugin.name}…\nclaude plugin uninstall ${plugin.id} --scope ${scope} && claude plugin install ${plugin.id} --scope ${scope}`
+					: `Updating ${plugin.name}…\nclaude plugin install ${plugin.id} --scope ${scope}`,
 		);
 		const reasons = noMoveReasons();
 		try {
@@ -1069,24 +1080,38 @@ export function PluginsScreen() {
 	const handleUpdateAll = async () => {
 		if (pluginsState.plugins.status !== "success") return;
 
-		// Exactly the rows that say "update" or "stale — reinstall", each planned
-		// under its real pin. Content-stale plugins are included: they need
-		// repairing, and excluding them meant "update all" left the machine with
-		// silently outdated files.
+		// Exactly the rows that say "update", "stale — reinstall" or "BROKEN — press
+		// a to fix", each planned under its real pin. Content-stale plugins are
+		// included: they need repairing, and excluding them meant "update all" left
+		// the machine with silently outdated files. Broken (`stale-load`) rows are
+		// included because the row itself now names this key — leaving them out
+		// would make that hint a lie. `install` stays out: a plugin nothing has
+		// installed is `s`'s business, per the note above.
 		const items = [...statuses.values()]
-			.filter((s) => s.action === "update" || s.action === "repair")
+			.filter(
+				(s) =>
+					s.action === "update" ||
+					s.action === "repair" ||
+					s.action === "stale-load",
+			)
 			.sort((a, b) => a.pluginId.localeCompare(b.pluginId));
 		if (items.length === 0) return;
 
 		const projectPath = state.projectPath || process.cwd();
 		const total = items.filter(pluginNeedsWork).length;
 
+		// A broken plugin is repaired in the registry, not updated, and the progress
+		// line is the only place the user sees which one happened to which plugin.
+		const actionOf = new Map(items.map((i) => [i.pluginId, i.action]));
+
 		let done = 0;
 		const reasons = noMoveReasons();
 		const reporter: ApplyReporter = {
 			begin: (name) => {
 				done++;
-				modal.loading(`Updating ${name} (${done}/${total})…`);
+				const verb =
+					actionOf.get(name) === "stale-load" ? "Repairing" : "Updating";
+				modal.loading(`${verb} ${name} (${done}/${total})…`);
 			},
 			finish: reasons.reporter.finish,
 			detach: (work) => work(),
@@ -1348,8 +1373,16 @@ export function PluginsScreen() {
 	// "cannot tell rendered as fine" bug.
 	const unknownCount = counts.unknown;
 	const installCount = counts.install;
-	const subtitle = `${scopeLabel} │ ${installedCount} installed${updateCount > 0 ? ` │ ${updateCount} updates` : ""}${installCount > 0 ? ` │ ${installCount} to install` : ""}${unknownCount > 0 ? ` │ ${unknownCount} unverified` : ""}`;
-	const searchPlaceholder = `${scopeLabel} │ ${installedCount} installed${updateCount > 0 ? ` │ ${updateCount} ⬆` : ""}${installCount > 0 ? ` │ ${installCount} +` : ""}${unknownCount > 0 ? ` │ ${unknownCount} ?` : ""} │ / to search`;
+	// Broken: installed at the right version, loading an older one. Its own
+	// number, never folded into `updateCount` or into silence — a clean header
+	// over a session running a version nobody installed is the whole defect.
+	//
+	// "broken", not "loading older". The old wording described the mechanism, so
+	// a reader had to already know what "loads" versus "installed" means here
+	// before the count told them anything. `a` clears these.
+	const brokenCount = counts["stale-load"];
+	const subtitle = `${scopeLabel} │ ${installedCount} installed${updateCount > 0 ? ` │ ${updateCount} updates` : ""}${installCount > 0 ? ` │ ${installCount} to install` : ""}${brokenCount > 0 ? ` │ ${brokenCount} broken` : ""}${unknownCount > 0 ? ` │ ${unknownCount} unverified` : ""}`;
+	const searchPlaceholder = `${scopeLabel} │ ${installedCount} installed${updateCount > 0 ? ` │ ${updateCount} ⬆` : ""}${installCount > 0 ? ` │ ${installCount} +` : ""}${brokenCount > 0 ? ` │ ${brokenCount} ✗` : ""}${unknownCount > 0 ? ` │ ${unknownCount} ?` : ""} │ / to search`;
 
 	const catalogNotice = buildCatalogNotice({
 		failures: catalogFailures,