magus-cli 7.13.0 → 7.14.1

package/src/__tests__/market-r2-skill-create-plugin.test.ts

@@ -0,0 +1,315 @@
+import { afterEach, expect, test } from "bun:test";
+import { readFileSync } from "node:fs";
+import { join } from "node:path";
+import {
+	ID,
+	MANIFEST,
+	MarketFixture,
+	PLUGIN_MANIFEST,
+	SKILL,
+	SKILL_REL,
+	write,
+} from "./market-fixture.js";
+
+const NEW_ID = "writing-kit@acme";
+const NEW_MANIFEST = "plugins/writing-kit/.claude-plugin/plugin.json";
+const NEW_SKILL = "plugins/writing-kit/skills/authoring/SKILL.md";
+const AUTHORING =
+	"---\nname: authoring\ndescription: Writes guides.\n---\nWrite clear guides.\n";
+
+let f: MarketFixture | undefined;
+afterEach(() => {
+	f?.close();
+	f = undefined;
+});
+
+test.each(["project", "global"] as const)(
+	"R4.2 R4.5 TEST-34 adding a %s skill creates its plugin in the same consented commit at 0.1.0",
+	(from) => {
+		f = new MarketFixture(true);
+		const repo = f.seed();
+		f.register(repo);
+		const folder = f.folder(from, "authoring");
+		write(join(folder, "SKILL.md"), AUTHORING);
+		const old = f.head(repo);
+		const before = f.snapshot();
+		const args = [
+			"skill",
+			"add",
+			"authoring",
+			"--plugin",
+			NEW_ID,
+			"--from",
+			from,
+			"--create-plugin",
+			"--description",
+			"Writing tools",
+		];
+
+		const plan = f.market(args);
+
+		expect({ exit: plan.code, outcome: plan.result.outcome }).toEqual({
+			exit: 3,
+			outcome: "needs-consent",
+		});
+		expect(typeof plan.result.planId).toBe("string");
+		expect(plan.result.plan?.join("\n")).toContain("writing-kit");
+		expect(plan.result.plan?.join("\n")).toContain("authoring");
+		expect(f.snapshot()).toEqual(before);
+		expect(f.head(repo)).toBe(old);
+
+		const result = f.market([...args, `--yes=${plan.result.planId}`]);
+
+		expect({ exit: result.code, outcome: result.result.outcome }).toEqual({
+			exit: 0,
+			outcome: "ok",
+		});
+		expect(
+			f.git(
+				f.root,
+				"--git-dir",
+				repo.bare,
+				"rev-list",
+				"--count",
+				`${old}..HEAD`,
+			),
+		).toBe("1");
+		expect(
+			f
+				.git(f.root, "--git-dir", repo.bare, "diff", "--name-only", old, "HEAD")
+				.split("\n")
+				.sort(),
+		).toEqual([MANIFEST, NEW_MANIFEST, NEW_SKILL].sort());
+		expect(f.remoteJson(repo, NEW_MANIFEST)).toEqual({
+			name: "writing-kit",
+			version: "0.1.0",
+			description: "Writing tools",
+			author: { name: "acme" },
+		});
+		expect(f.remoteJson(repo, MANIFEST).plugins).toContainEqual({
+			name: "writing-kit",
+			source: "./plugins/writing-kit",
+			version: "0.1.0",
+			description: "Writing tools",
+		});
+		expect(f.remoteBytes(repo, NEW_SKILL)).toBe(AUTHORING);
+		expect(f.remoteBytes(repo, SKILL_REL)).toBe(SKILL);
+		expect(f.version(NEW_ID)).toBeNull();
+		expect(result.result.localCopy?.action).toBe("kept");
+		expect(result.result.localCopy?.scope).toBe(
+			from === "global" ? "user" : "project",
+		);
+		expect(result.result.localCopy?.reason?.length).toBeGreaterThan(0);
+		expect(readFileSync(join(folder, "SKILL.md"), "utf8")).toBe(AUTHORING);
+		expect(result.result.steps.map((step) => step.id)).toEqual([
+			"edit",
+			"copy",
+			"validate",
+			"commit",
+			"deliver",
+			"refresh",
+			"install",
+			"local-copy",
+		]);
+
+		write(
+			join(folder, "SKILL.md"),
+			`${AUTHORING}\nA tracked follow-up edit.\n`,
+		);
+		const tracked = f.market([
+			"publish",
+			"authoring",
+			"--plugin",
+			NEW_ID,
+			"--from",
+			from,
+		]);
+		expect({ exit: tracked.code, outcome: tracked.result.outcome }).toEqual({
+			exit: 3,
+			outcome: "needs-consent",
+		});
+		expect(tracked.result.error).toBeUndefined();
+		expect(f.head(repo)).toBe(result.result.commit!);
+		f.assertOwned();
+	},
+	90_000,
+);
+
+test("R4.2 TEST-35 --create-plugin reuses an existing plugin without overwriting its description", () => {
+	f = new MarketFixture();
+	const repo = f.seed();
+	f.register(repo);
+	f.install();
+	write(join(f.folder("project", "authoring"), "SKILL.md"), AUTHORING);
+	const old = f.head(repo);
+
+	const result = f.market([
+		"skill",
+		"add",
+		"authoring",
+		"--plugin",
+		ID,
+		"--create-plugin",
+		"--description",
+		"Only for a newly created plugin",
+		"--keep-local",
+		"--yes",
+	]);
+
+	expect(result.code).toBe(0);
+	expect(f.remoteJson(repo, PLUGIN_MANIFEST).version).toBe("0.3.2");
+	expect(f.remoteJson(repo, PLUGIN_MANIFEST).description).toBe(
+		"Reviews changes.",
+	);
+	expect(f.remoteJson(repo, MANIFEST).plugins).toHaveLength(1);
+	expect(
+		f.remoteBytes(repo, "plugins/review-kit/skills/authoring/SKILL.md"),
+	).toBe(AUTHORING);
+	expect(f.remoteBytes(repo, SKILL_REL)).toBe(SKILL);
+	expect(
+		f.git(
+			f.root,
+			"--git-dir",
+			repo.bare,
+			"rev-list",
+			"--count",
+			`${old}..HEAD`,
+		),
+	).toBe("1");
+	f.assertOwned();
+}, 60_000);
+
+test.each([
+	{
+		label: "missing plugin without flag",
+		skill: "authoring",
+		target: NEW_ID,
+		flags: [],
+		code: 2,
+		error: "not-found",
+	},
+	{
+		label: "invalid new plugin name",
+		skill: "authoring",
+		target: "../escape@acme",
+		flags: ["--create-plugin"],
+		code: 2,
+		error: "invalid-name",
+	},
+	{
+		label: "already held skill",
+		skill: "review",
+		target: ID,
+		flags: ["--create-plugin"],
+		code: 1,
+		error: "name-taken",
+	},
+])(
+	"R4.2 TEST-36 skill add refuses $label and leaves source and remote alone",
+	({ skill, target, flags, code, error }) => {
+		f = new MarketFixture();
+		const repo = f.seed();
+		f.register(repo);
+		write(
+			join(f.folder("project", skill), "SKILL.md"),
+			skill === "review" ? SKILL : AUTHORING,
+		);
+		const before = f.snapshot();
+		const old = f.head(repo);
+
+		const result = f.market([
+			"skill",
+			"add",
+			skill,
+			"--plugin",
+			target,
+			...flags,
+			"--yes",
+		]);
+
+		expect({ exit: result.code, error: result.result.error?.code }).toEqual({
+			exit: code,
+			error,
+		});
+		expect(result.result.outcome).toBe("failed");
+		expect(f.head(repo)).toBe(old);
+		expect(f.snapshot()).toEqual(before);
+	},
+	30_000,
+);
+
+test("R4.2 TEST-37 --description without --create-plugin is a usage error with no side effects", () => {
+	f = new MarketFixture();
+	const repo = f.seed();
+	f.register(repo);
+	write(join(f.folder("project", "authoring"), "SKILL.md"), AUTHORING);
+	const before = f.snapshot();
+	const old = f.head(repo);
+
+	const result = f.market([
+		"skill",
+		"add",
+		"authoring",
+		"--plugin",
+		ID,
+		"--description",
+		"Not a create action",
+		"--yes",
+	]);
+
+	expect(result.code).toBe(2);
+	expect(f.snapshot()).toEqual(before);
+	expect(f.head(repo)).toBe(old);
+}, 30_000);
+
+test.each(["description", "source"] as const)(
+	"R4.5 TEST-44 changing new skill/plugin %s after consent refuses the whole atomic add",
+	(changed) => {
+		f = new MarketFixture();
+		const repo = f.seed();
+		f.register(repo);
+		const folder = f.folder("project", "authoring");
+		write(join(folder, "SKILL.md"), AUTHORING);
+		const args = [
+			"skill",
+			"add",
+			"authoring",
+			"--plugin",
+			NEW_ID,
+			"--create-plugin",
+			"--description",
+			"Writing tools",
+		];
+		const plan = f.market(args);
+		expect(plan.code).toBe(3);
+		expect(typeof plan.result.planId).toBe("string");
+		if (changed === "source")
+			write(join(folder, "SKILL.md"), `${AUTHORING}\nChanged after consent.\n`);
+		const bytes = readFileSync(join(folder, "SKILL.md"), "utf8");
+		const old = f.head(repo);
+		const changedArgs =
+			changed === "description"
+				? [...args.slice(0, -1), "Different description"]
+				: args;
+
+		const result = f.market([...changedArgs, `--yes=${plan.result.planId}`]);
+
+		expect({
+			exit: result.code,
+			outcome: result.result.outcome,
+			error: result.result.error?.code,
+		}).toEqual({
+			exit: 3,
+			outcome: "needs-consent",
+			error: "plan-changed",
+		});
+		expect(result.result.planId).not.toBe(plan.result.planId);
+		expect(f.head(repo)).toBe(old);
+		expect(f.remotePaths(repo)).not.toContain(NEW_MANIFEST);
+		expect(f.remotePaths(repo)).not.toContain(NEW_SKILL);
+		expect(readFileSync(join(folder, "SKILL.md"), "utf8")).toBe(bytes);
+		expect(f.version(NEW_ID)).toBeNull();
+		f.assertOwned();
+	},
+	60_000,
+);

package/src/__tests__/market-r2b-display-path.test.ts

@@ -0,0 +1,180 @@
+import { afterEach, expect, test } from "bun:test";
+import { join, sep } from "node:path";
+import { displayPath } from "../utils/display-path.js";
+import { MarketFixture, sourceModule } from "./market-fixture.js";
+
+const project = join(sep, "a", "project");
+const home = join(sep, "people", "alex");
+const nestedProject = join(home, "work", "project");
+const skillParts = [".claude", "skills", "greet"];
+
+const cases = [
+	{
+		label: "a project skill is relative to cwd",
+		abs: join(project, ...skillParts),
+		cwd: project,
+		home,
+		expected: join(...skillParts),
+	},
+	{
+		label: "cwd itself is a dot",
+		abs: project,
+		cwd: project,
+		home,
+		expected: ".",
+	},
+	{
+		label: "the /a/project-x sibling is not inside /a/project",
+		abs: join(sep, "a", "project-x"),
+		cwd: project,
+		home,
+		expected: join(sep, "a", "project-x"),
+	},
+	{
+		label: "a descendant of /a/project-x is not inside /a/project",
+		abs: join(sep, "a", "project-x", ...skillParts),
+		cwd: project,
+		home,
+		expected: join(sep, "a", "project-x", ...skillParts),
+	},
+	{
+		label: "an ancestor of cwd stays absolute outside home",
+		abs: join(sep, "a"),
+		cwd: project,
+		home,
+		expected: join(sep, "a"),
+	},
+	{
+		label: "a home skill outside cwd uses a tilde",
+		abs: join(home, ...skillParts),
+		cwd: project,
+		home,
+		expected: join("~", ...skillParts),
+	},
+	{
+		label: "home itself is a tilde outside cwd",
+		abs: home,
+		cwd: project,
+		home,
+		expected: "~",
+	},
+	{
+		label: "a sibling sharing the home prefix stays absolute",
+		abs: join(sep, "people", "alex-extra", "tools"),
+		cwd: project,
+		home,
+		expected: join(sep, "people", "alex-extra", "tools"),
+	},
+	{
+		label: "an unrelated path is unchanged",
+		abs: join(sep, "elsewhere", "tools"),
+		cwd: project,
+		home,
+		expected: join(sep, "elsewhere", "tools"),
+	},
+	{
+		label: "cwd wins for a path inside both cwd and home",
+		abs: join(nestedProject, ...skillParts),
+		cwd: nestedProject,
+		home,
+		expected: join(...skillParts),
+	},
+	{
+		label: "cwd inside home is still a dot for itself",
+		abs: nestedProject,
+		cwd: nestedProject,
+		home,
+		expected: ".",
+	},
+	{
+		label: "home above cwd uses a tilde rather than parent traversal",
+		abs: home,
+		cwd: nestedProject,
+		home,
+		expected: "~",
+	},
+	{
+		label: "cwd equal to home wins for the directory itself",
+		abs: home,
+		cwd: home,
+		home,
+		expected: ".",
+	},
+	{
+		label: "cwd equal to home wins for a descendant",
+		abs: join(home, ...skillParts),
+		cwd: home,
+		home,
+		expected: join(...skillParts),
+	},
+	{
+		label: "home nested inside cwd is shown relative to cwd",
+		abs: join(project, "personal-home"),
+		cwd: project,
+		home: join(project, "personal-home"),
+		expected: "personal-home",
+	},
+	{
+		label: "a root cwd contains descendants",
+		abs: project,
+		cwd: sep,
+		home,
+		expected: join("a", "project"),
+	},
+	{
+		label: "a root cwd is a dot for itself",
+		abs: sep,
+		cwd: sep,
+		home,
+		expected: ".",
+	},
+	{
+		label: "a root home abbreviates paths outside cwd",
+		abs: join(sep, "elsewhere", "tools"),
+		cwd: project,
+		home: sep,
+		expected: join("~", "elsewhere", "tools"),
+	},
+];
+
+test.each(cases)(
+	"R6.1 REQ-4 TEST-11 $label",
+	({ abs, cwd, home: explicitHome, expected }) => {
+		const shown = displayPath(abs, cwd, explicitHome);
+
+		expect(shown).toBe(expected);
+	},
+);
+
+let world: MarketFixture | undefined;
+afterEach(() => {
+	world?.close();
+	world = undefined;
+});
+
+test.each([
+	{ label: "chosen HOME", mode: "chosen" },
+	{ label: "absent HOME", mode: "absent" },
+	{ label: "empty HOME", mode: "empty" },
+] as const)(
+	"R6.1 REQ-4 TEST-12 uses the specified default home with $label",
+	({ mode }) => {
+		world = new MarketFixture(true);
+		const f = world;
+		const chosenHome = join(f.root, "shell-home");
+		const changeHome =
+			mode === "chosen"
+				? `process.env.HOME=${JSON.stringify(chosenHome)};`
+				: mode === "absent"
+					? "delete process.env.HOME;"
+					: 'process.env.HOME="";';
+		const homeExpression =
+			mode === "chosen" ? JSON.stringify(chosenHome) : "homedir()";
+
+		const shown = f.value<string>(
+			`import {homedir} from 'node:os';import {join} from 'node:path';${changeHome}const {displayPath}=await import(${JSON.stringify(sourceModule("utils/display-path.js"))});console.log(JSON.stringify(displayPath(join(${homeExpression},'library','team-tools'),${JSON.stringify(f.project)})));`,
+		);
+
+		expect(shown).toBe(join("~", "library", "team-tools"));
+	},
+);