magus-cli 7.12.2 → 7.14.0

package/src/__tests__/market-r2-company-cli.test.ts

@@ -0,0 +1,350 @@
+import { afterEach, expect, test } from "bun:test";
+import { existsSync } from "node:fs";
+import { join } from "node:path";
+import type { LocalMarketplace } from "../services/local-marketplace.js";
+import type { Marketplace } from "../types/index.js";
+import {
+	MANIFEST,
+	MarketFixture,
+	readJson,
+	sourceModule,
+	writeJson,
+} from "./market-fixture.js";
+
+let f: MarketFixture | undefined;
+afterEach(() => {
+	f?.close();
+	f = undefined;
+});
+
+test.each([
+	{
+		label: "split flag",
+		flags: ["--company", "  10xlabs  "],
+		company: "10xlabs",
+	},
+	{ label: "equals flag", flags: ["--company=10xlabs"], company: "10xlabs" },
+	{
+		label: "64 Unicode code points",
+		flags: [`--company=${"🏢".repeat(64)}`],
+		company: "🏢".repeat(64),
+	},
+	{ label: "GitHub owner default", flags: [], company: "different-owner" },
+])(
+	"R1.1 R1.2 TEST-10 create writes owner.name from $label",
+	({ flags, company }) => {
+		f = new MarketFixture();
+
+		const result = f.market([
+			"create",
+			"different-owner/team-tools",
+			"--private",
+			"--name",
+			"team",
+			...flags,
+			"--yes",
+		]);
+
+		expect({ exit: result.code, outcome: result.result.outcome }).toEqual({
+			exit: 0,
+			outcome: "ok",
+		});
+		const bare = join(f.root, "remotes", "different-owner", "team-tools.git");
+		const manifest = JSON.parse(
+			f.git(f.root, "--git-dir", bare, "show", `HEAD:${MANIFEST}`),
+		);
+		expect(manifest.owner).toEqual({ name: company });
+		expect(
+			f.market(["list"]).result.marketplaces?.find((row) => row.name === "team")
+				?.company,
+		).toBe(company);
+		f.assertOwned();
+	},
+	60_000,
+);
+
+const invalidCompanies = [
+	"",
+	"  ",
+	"Acme\nLabs",
+	"Acme\rLabs",
+	"Acme\tLabs",
+	"Acme\u0000Labs",
+	"Acme\u007fLabs",
+	"Acme
Labs",
+	"Acme
Labs",
+	"x".repeat(65),
+	"🏢".repeat(65),
+];
+// NUL cannot be represented in an OS argv; its validation is covered by TEST-2.
+for (const command of ["create", "connect"] as const) {
+	test.each(invalidCompanies.filter((name) => !name.includes("\u0000")))(
+		`R1.3 TEST-11 ${command} rejects company %j before any GitHub work`,
+		(company) => {
+			f = new MarketFixture();
+			const before = f.snapshot();
+			const args =
+				command === "create"
+					? ["create", "acme/not-created", "--private"]
+					: ["connect", "acme/not-created"];
+
+			const result = f.market([...args, `--company=${company}`, "--yes"]);
+
+			expect(result.code).toBe(2);
+			expect(f.snapshot()).toEqual(before);
+			expect(
+				existsSync(join(f.root, "remotes", "acme", "not-created.git")),
+			).toBe(false);
+			expect(f.journal().filter((event) => event.tool === "gh")).toEqual([]);
+		},
+		30_000,
+	);
+	test(`R1.3 TEST-11 ${command} rejects a missing --company value without writes`, () => {
+		f = new MarketFixture();
+		const before = f.snapshot();
+		const args =
+			command === "create"
+				? ["create", "acme/not-created", "--private"]
+				: ["connect", "acme/not-created"];
+
+		const result = f.cli(["market", ...args, "--company"]);
+
+		expect(result.code).toBe(2);
+		expect(f.snapshot()).toEqual(before);
+		expect(f.journal()).toEqual([]);
+	}, 30_000);
+}
+
+test.each(["create", "connect"] as const)(
+	"R1.4 R4.5 TEST-12 %s plan displays the trimmed company and binds consent to it",
+	(command) => {
+		f = new MarketFixture();
+		const repo = command === "connect" ? f.seed({ empty: true }) : undefined;
+		const base =
+			command === "create"
+				? ["create", "acme/new-market", "--private", "--name", "acme"]
+				: ["connect", repo!.slug, "--name", "acme"];
+		const before = f.snapshot();
+		const plan = f.market([...base, "--company", "  10xlabs  "]);
+		const equivalent = f.market([...base, "--company=10xlabs"]);
+
+		expect(plan.code).toBe(3);
+		expect(plan.result.outcome).toBe("needs-consent");
+		expect(plan.result.plan).toContain(
+			'Company name: 10xlabs (magus shows the marketplace as "by 10xlabs")',
+		);
+		expect(typeof plan.result.planId).toBe("string");
+		expect(plan.result.planId?.length).toBeGreaterThan(0);
+		expect(equivalent.result.planId).toBe(plan.result.planId);
+		expect(f.snapshot()).toEqual(before);
+
+		const changed = f.market([
+			...base,
+			"--company",
+			"Other Labs",
+			`--yes=${plan.result.planId}`,
+		]);
+
+		expect({
+			exit: changed.code,
+			outcome: changed.result.outcome,
+			error: changed.result.error?.code,
+		}).toEqual({
+			exit: 3,
+			outcome: "needs-consent",
+			error: "plan-changed",
+		});
+		expect(changed.result.planId).not.toBe(plan.result.planId);
+		expect(changed.result.plan).toContain(
+			'Company name: Other Labs (magus shows the marketplace as "by Other Labs")',
+		);
+		const bare =
+			repo?.bare ?? join(f.root, "remotes", "acme", "new-market.git");
+		if (repo) {
+			expect(
+				f.git(f.root, "--git-dir", bare, "rev-list", "--all", "--count"),
+			).toBe("0");
+		} else {
+			expect(existsSync(bare)).toBe(false);
+		}
+		// A refused apply may sync its disposable clone; no repository or registration is changed.
+		expect(f.market(["list"]).result.marketplaces).toEqual([]);
+
+		const applied = f.market([
+			...base,
+			"--company=10xlabs",
+			`--yes=${plan.result.planId}`,
+		]);
+		expect(applied.code).toBe(0);
+		const manifest = JSON.parse(
+			f.git(f.root, "--git-dir", bare, "show", `HEAD:${MANIFEST}`),
+		);
+		expect(manifest.owner).toEqual({ name: "10xlabs" });
+		f.assertOwned();
+	},
+	60_000,
+);
+
+test.each([
+	{
+		empty: true,
+		companyFlag: ["--company", "  10xlabs  "],
+		expected: "10xlabs",
+	},
+	{ empty: false, companyFlag: ["--company=10xlabs"], expected: "10xlabs" },
+	{ empty: true, companyFlag: [], expected: "acme" },
+	{ empty: false, companyFlag: [], expected: "acme" },
+])(
+	"R1.1 R1.5 TEST-13 connect writes company only when making a manifest: %j",
+	({ empty, companyFlag, expected }) => {
+		f = new MarketFixture();
+		const repo = f.seed({ empty, noManifest: true });
+		const old = empty ? undefined : f.head(repo);
+
+		const result = f.market([
+			"connect",
+			repo.slug,
+			"--name",
+			"acme",
+			...companyFlag,
+			"--yes",
+		]);
+
+		expect(result.code).toBe(0);
+		expect(f.remoteJson(repo, MANIFEST).owner).toEqual({ name: expected });
+		if (old) {
+			expect(
+				f.git(
+					f.root,
+					"--git-dir",
+					repo.bare,
+					"rev-list",
+					"--count",
+					`${old}..HEAD`,
+				),
+			).toBe("1");
+			expect(f.remoteFile(repo, "README.md")).toBe(
+				"Existing repository documentation",
+			);
+		}
+		f.assertOwned();
+	},
+	60_000,
+);
+
+test.each([true, false])(
+	"R1.5 TEST-14 existing marketplace refuses --company, marker=%s",
+	(marker) => {
+		f = new MarketFixture();
+		const repo = f.seed({ marker });
+		const manifest = readJson(join(repo.author, MANIFEST));
+		manifest.owner = { name: "Manifest Company" };
+		writeJson(join(repo.author, MANIFEST), manifest);
+		f.push(repo);
+		const before = f.snapshot();
+		const head = f.head(repo);
+
+		const refused = f.market([
+			"connect",
+			repo.slug,
+			"--company",
+			"Override",
+			"--yes",
+		]);
+
+		expect(refused.code).toBe(2);
+		expect(f.head(repo)).toBe(head);
+		expect(f.remoteJson(repo, MANIFEST).owner).toEqual({
+			name: "Manifest Company",
+		});
+		expect(f.snapshot()).toEqual(before);
+
+		const connected = f.market(["connect", repo.slug, "--yes"]);
+		expect(connected.code).toBe(0);
+		expect(f.remoteJson(repo, MANIFEST).owner).toEqual({
+			name: "Manifest Company",
+		});
+		expect(f.market(["list"]).result.marketplaces?.[0]?.company).toBe(
+			"Manifest Company",
+		);
+		f.assertOwned();
+	},
+	60_000,
+);
+
+test.each([
+	{ owner: { name: "  10xlabs  " }, expected: "10xlabs" },
+	{ owner: { name: "   " }, expected: undefined },
+	{ owner: {}, expected: undefined },
+])(
+	"R1.6 TEST-6 scanner and catalog carry trimmed ownerName or omit the key: %j",
+	({ owner, expected }) => {
+		f = new MarketFixture(true);
+		const repo = f.seed();
+		const manifest = readJson(join(repo.author, MANIFEST));
+		manifest.owner = owner;
+		writeJson(join(repo.author, MANIFEST), manifest);
+		f.push(repo);
+		f.register(repo);
+		const before = f.snapshot();
+
+		const data = f.value<{
+			local: LocalMarketplace;
+			catalog: Marketplace;
+			localHasName: boolean;
+			catalogHasName: boolean;
+		}>(
+			`const {scanLocalMarketplaces}=await import(${JSON.stringify(sourceModule("services/local-marketplace.js"))});const {getAllMarketplaces}=await import(${JSON.stringify(sourceModule("data/marketplaces.js"))});const locals=await scanLocalMarketplaces(); const local=locals.get('acme'); const catalog=getAllMarketplaces(locals).find(m=>m.name==='acme');console.log(JSON.stringify({local,catalog,localHasName:Object.hasOwn(local,'ownerName'),catalogHasName:Object.hasOwn(catalog,'ownerName')}));`,
+		);
+
+		expect(data.local.ownerName).toBe(expected);
+		expect(data.catalog.ownerName).toBe(expected);
+		expect(data.localHasName).toBe(expected !== undefined);
+		expect(data.catalogHasName).toBe(expected !== undefined);
+		expect(f.snapshot()).toEqual(before);
+	},
+	30_000,
+);
+
+test.each([
+	{ owner: { name: "  10xlabs  " }, company: "10xlabs" },
+	{ owner: { name: "" }, company: "acme" },
+])(
+	"R1.7 TEST-15 list JSON and text show company without changing state: %j",
+	({ owner, company }) => {
+		f = new MarketFixture(true);
+		const repo = f.seed();
+		const manifest = readJson(join(repo.author, MANIFEST));
+		manifest.owner = owner;
+		writeJson(join(repo.author, MANIFEST), manifest);
+		f.push(repo);
+		f.register(repo);
+		const before = f.snapshot();
+		const head = f.head(repo);
+
+		const json = f.market(["list"]);
+		const text = f.cli(["market", "list"]);
+
+		expect(json.code).toBe(0);
+		expect(
+			json.result.marketplaces?.map(
+				({ name, repo: source, company: value, scope }) => ({
+					name,
+					repo: source,
+					company: value,
+					scope,
+				}),
+			),
+		).toEqual([{ name: "acme", repo: "acme/market", company, scope: "user" }]);
+		expect(text.code).toBe(0);
+		const line = text.out
+			.split("\n")
+			.find((line) => line.includes(`by ${company}`));
+		expect(line).toBeDefined();
+		expect(line).toContain("acme/market");
+		expect(line).toContain("USER");
+		expect(f.snapshot()).toEqual(before);
+		expect(f.head(repo)).toBe(head);
+	},
+	30_000,
+);

package/src/__tests__/market-r2-company-unit.test.ts

@@ -0,0 +1,224 @@
+import { describe, expect, test } from "bun:test";
+import {
+	COMPANY_NAME_MAX,
+	checkCompanyName,
+} from "../services/market-ops-repo.js";
+import { companyOf } from "../services/market-ops.js";
+import { MarketError } from "../services/market-types.js";
+import type { Marketplace } from "../types/index.js";
+import {
+	buildPluginBrowserItems,
+	companyName,
+} from "../ui/adapters/pluginsAdapter.js";
+
+const marketplace = (over: Partial<Marketplace> = {}): Marketplace => ({
+	name: "company-tools",
+	displayName: "Company tools",
+	description: "Team tools",
+	source: { source: "github", repo: "github-owner/tools" },
+	company: true,
+	...over,
+});
+
+describe("round-two company identity", () => {
+	test.each([
+		{ input: "  10xlabs  ", expected: "10xlabs" },
+		{ input: "A", expected: "A" },
+		{ input: "  North Star Labs  ", expected: "North Star Labs" },
+		{ input: "x".repeat(64), expected: "x".repeat(64) },
+		{ input: `  ${"界".repeat(64)}  `, expected: "界".repeat(64) },
+		{ input: "🏢".repeat(64), expected: "🏢".repeat(64) },
+	])(
+		"R1.3 TEST-1 returns trimmed company name at valid boundaries: $input",
+		({ input, expected }) => {
+			expect(COMPANY_NAME_MAX).toBe(64);
+			expect(checkCompanyName(input)).toBe(expected);
+		},
+	);
+
+	const invalidNames = [
+		{ input: "", message: "The company name is empty" },
+		{ input: "   ", message: "The company name is empty" },
+		{
+			input: "x".repeat(65),
+			message: "The company name is longer than 64 characters",
+		},
+		{
+			input: "🏢".repeat(65),
+			message: "The company name is longer than 64 characters",
+		},
+		...[0, 1, 8, 9, 10, 11, 12, 13, 31, 127, 128, 133, 159, 0x2028, 0x2029].map(
+			(code) => ({
+				input: `Acme${String.fromCodePoint(code)}Labs`,
+				message: "The company name must be a single line",
+			}),
+		),
+	];
+	test.each(invalidNames)(
+		"R1.3 TEST-2 rejects invalid company name %j as invalid-name usage",
+		({ input, message }) => {
+			expect(() => checkCompanyName(input)).toThrow(MarketError);
+			expect(() => checkCompanyName(input)).toThrow(message);
+			let failure: unknown;
+			try {
+				checkCompanyName(input);
+			} catch (error) {
+				failure = error;
+			}
+			expect(failure).toBeInstanceOf(MarketError);
+			if (!(failure instanceof MarketError))
+				throw new Error("Expected a company-name MarketError");
+			expect({ code: failure.code, exit: failure.exit }).toEqual({
+				code: "invalid-name",
+				exit: 2,
+			});
+		},
+	);
+
+	test.each([
+		{
+			manifest: { owner: { name: "  10xlabs  " } },
+			source: "git-owner/market",
+			expected: "10xlabs",
+		},
+		{
+			manifest: { owner: { name: "10xlabs" } },
+			source: "https://git.example.invalid/team/market",
+			expected: "10xlabs",
+		},
+		{
+			manifest: { owner: { name: "  " } },
+			source: "GitOwner/market",
+			expected: "GitOwner",
+		},
+		{
+			manifest: { owner: { name: 42 } },
+			source: "GitOwner/market",
+			expected: "GitOwner",
+		},
+		{ manifest: {}, source: "GitOwner/market", expected: "GitOwner" },
+		{ manifest: null, source: "GitOwner/market", expected: "GitOwner" },
+		{ manifest: { owner: null }, source: "", expected: undefined },
+		{
+			manifest: { owner: { name: "" } },
+			source: "https://git.example.invalid/team/market",
+			expected: undefined,
+		},
+		{ manifest: {}, source: "file:///company-market", expected: undefined },
+	])(
+		"R1.6 TEST-3 companyOf prefers manifest owner and falls back only to GitHub source: %j",
+		({ manifest, source, expected }) => {
+			expect(companyOf(manifest, source)).toBe(expected);
+		},
+	);
+
+	test.each([
+		{ mp: marketplace({ ownerName: "10xlabs" }), expected: "10xlabs" },
+		{ mp: marketplace(), expected: "github-owner" },
+		{
+			mp: marketplace({ source: { source: "github", repo: "" } }),
+			expected: undefined,
+		},
+	])(
+		"R1.6 TEST-4 companyName uses manifest, GitHub owner, then no name: %j",
+		({ mp, expected }) => {
+			expect(companyName(mp)).toBe(expected);
+		},
+	);
+});
+
+describe("round-two company badges", () => {
+	test.each([
+		{ mp: marketplace({ ownerName: "10xlabs" }), badge: "by 10xlabs" },
+		{ mp: marketplace(), badge: "by github-owner" },
+		{
+			mp: marketplace({ source: { source: "github", repo: "" } }),
+			badge: "◆ Company",
+		},
+		{
+			mp: marketplace({
+				source: { source: "github", repo: "MadAppGang/team-tools" },
+				ownerName: "Different Company",
+			}),
+			badge: "by Different Company",
+		},
+	])(
+		"R1.6 TEST-5 empty company marketplace has the real byline and info tone: $badge",
+		({ mp, badge }) => {
+			const rows = buildPluginBrowserItems({
+				marketplaces: [mp],
+				plugins: [],
+				collapsedMarketplaces: new Set(),
+			});
+			const row = rows.find((item) => item.kind === "category");
+			expect(row?.kind).toBe("category");
+			if (row?.kind !== "category") throw new Error("Company category missing");
+			expect({ tone: row.tone, badge: row.badge }).toEqual({
+				tone: "info",
+				badge,
+			});
+		},
+	);
+
+	test.each([
+		{ name: "A".repeat(24), expected: `by ${"A".repeat(24)}` },
+		{ name: "A".repeat(25), expected: `by ${"A".repeat(23)}…` },
+	])(
+		"R1.6 TEST-5 truncates the company name to 24 columns including ellipsis: $name",
+		({ name, expected }) => {
+			const row = buildPluginBrowserItems({
+				marketplaces: [marketplace({ ownerName: name })],
+				plugins: [],
+				collapsedMarketplaces: new Set(["company-tools"]),
+			}).find((item) => item.kind === "category");
+			expect(row?.kind === "category" ? row.badge : undefined).toBe(expected);
+		},
+	);
+
+	test("R1.6 TEST-5 wide company characters also fit the 24-column name budget", () => {
+		const row = buildPluginBrowserItems({
+			marketplaces: [marketplace({ ownerName: "界".repeat(20) })],
+			plugins: [],
+			collapsedMarketplaces: new Set(),
+		}).find((item) => item.kind === "category");
+		if (row?.kind !== "category" || !row.badge)
+			throw new Error("Company badge missing");
+		expect(row.badge.startsWith("by ")).toBe(true);
+		expect(row.badge.endsWith("…")).toBe(true);
+		expect(Bun.stringWidth(row.badge.slice(3))).toBeLessThanOrEqual(24);
+	});
+
+	test("R1.6 TEST-5 company marketplaces sort before ordinary and MadAppGang marketplaces", () => {
+		const rows = buildPluginBrowserItems({
+			marketplaces: [
+				marketplace({
+					name: "ordinary",
+					company: false,
+					source: { source: "github", repo: "other/ordinary" },
+				}),
+				marketplace({
+					name: "magus",
+					company: false,
+					source: { source: "github", repo: "MadAppGang/magus" },
+				}),
+				marketplace({ name: "company-tools", ownerName: "10xlabs" }),
+			],
+			plugins: ["ordinary", "magus", "company-tools"].map((name) => ({
+				id: `demo@${name}`,
+				name: "demo",
+				version: "1.0.0",
+				description: "Demonstration plugin",
+				marketplace: name,
+				marketplaceDisplay: name,
+				author: { name: "Publisher" },
+			})),
+			collapsedMarketplaces: new Set(),
+		}).filter((item) => item.kind === "category");
+		expect(rows.map((row) => row.marketplace.name).sort()).toEqual([
+			"company-tools",
+			"magus",
+			"ordinary",
+		]);
+		expect(rows[0]?.marketplace.name).toBe("company-tools");
+	});
+});