magus-cli 7.11.4 → 7.11.6

package/src/__tests__/mcp-registry-install.test.ts

@@ -0,0 +1,551 @@
+import { describe, expect, test } from "bun:test";
+import {
+	type RegistryInstallPlan,
+	registryInstallPlan,
+} from "../services/mcp-registry.js";
+
+// Contract-only expectations. Every alternative in the behaviour table has its
+// own row; strict equality also rejects invented type/env/config properties.
+type PlanInput = Parameters<typeof registryInstallPlan>[0] & {
+	package_registry?: string;
+};
+type InstallCase = [
+	scenario: string,
+	input: PlanInput,
+	expected: RegistryInstallPlan,
+];
+
+const cases: InstallCase[] = [
+	[
+		"TEST-1 REQ-1 REQ-6: returns the unchanged HTTPS config",
+		{
+			url: "https://mcp.notion.com/mcp",
+		},
+		{
+			ok: true,
+			kind: "http",
+			config: {
+				type: "http",
+				url: "https://mcp.notion.com/mcp",
+			},
+		},
+	],
+	[
+		"TEST-2 REQ-1 REQ-6: returns the unchanged HTTP config",
+		{
+			url: "http://localhost:8080/mcp",
+		},
+		{
+			ok: true,
+			kind: "http",
+			config: {
+				type: "http",
+				url: "http://localhost:8080/mcp",
+			},
+		},
+	],
+	[
+		"TEST-3 REQ-1 REQ-6: accepts an upper-case HTTPS scheme without rewriting the URL",
+		{
+			url: "HTTPS://Host/x",
+		},
+		{
+			ok: true,
+			kind: "http",
+			config: {
+				type: "http",
+				url: "HTTPS://Host/x",
+			},
+		},
+	],
+	[
+		"TEST-4 REQ-1 REQ-6: trims surrounding whitespace from the HTTP URL",
+		{
+			url: "  https://h/x ",
+		},
+		{
+			ok: true,
+			kind: "http",
+			config: {
+				type: "http",
+				url: "https://h/x",
+			},
+		},
+	],
+	[
+		"TEST-5 REQ-1 REQ-4 REQ-6 REQ-7: refuses HTTPS without a host as unknown",
+		{
+			url: "https:",
+		},
+		{
+			ok: false,
+			kind: "unknown",
+			reason: "magus can't read this server's address.",
+		},
+	],
+	[
+		"TEST-6 REQ-1 REQ-4 REQ-6 REQ-7: refuses HTTPS with an empty host as unknown",
+		{
+			url: "https://",
+		},
+		{
+			ok: false,
+			kind: "unknown",
+			reason: "magus can't read this server's address.",
+		},
+	],
+	[
+		"TEST-7 REQ-2 REQ-6 REQ-14: returns uvx with only the PyPI package and no type or env",
+		{
+			url: "pypi:mcparmory-notion",
+		},
+		{
+			ok: true,
+			kind: "pypi",
+			config: {
+				command: "uvx",
+				args: ["mcparmory-notion"],
+			},
+		},
+	],
+	[
+		"TEST-8 REQ-2 REQ-6: accepts a mixed-case PyPI scheme and trims the package",
+		{
+			url: "PyPI:  pkg ",
+		},
+		{
+			ok: true,
+			kind: "pypi",
+			config: {
+				command: "uvx",
+				args: ["pkg"],
+			},
+		},
+	],
+	[
+		"TEST-9 REQ-5 REQ-6 REQ-7: refuses an empty PyPI package with the no-package reason",
+		{
+			url: "pypi:",
+		},
+		{
+			ok: false,
+			kind: "pypi",
+			reason:
+				"This pypi server has no package name, so there's nothing to run.",
+		},
+	],
+	[
+		"TEST-10 REQ-5 REQ-6 REQ-7: refuses a whitespace-only PyPI package with the no-package reason",
+		{
+			url: "pypi:   ",
+		},
+		{
+			ok: false,
+			kind: "pypi",
+			reason:
+				"This pypi server has no package name, so there's nothing to run.",
+		},
+	],
+	[
+		"TEST-11 REQ-5 REQ-6 REQ-7: refuses PyPI extras with the bad-package reason",
+		{
+			url: "pypi:pkg[extra]",
+		},
+		{
+			ok: false,
+			kind: "pypi",
+			reason:
+				"The package name of this pypi server looks wrong, so magus won't run it.",
+		},
+	],
+	[
+		"TEST-12 REQ-5 REQ-6 REQ-7: refuses a PyPI equals pin with the bad-package reason",
+		{
+			url: "pypi:pkg==1.0",
+		},
+		{
+			ok: false,
+			kind: "pypi",
+			reason:
+				"The package name of this pypi server looks wrong, so magus won't run it.",
+		},
+	],
+	[
+		"TEST-13 REQ-5 REQ-6 REQ-7: refuses embedded whitespace in a PyPI package",
+		{
+			url: "pypi:a b",
+		},
+		{
+			ok: false,
+			kind: "pypi",
+			reason:
+				"The package name of this pypi server looks wrong, so magus won't run it.",
+		},
+	],
+	[
+		"TEST-14 REQ-2 REQ-6 REQ-14: passes a PyPI package at-version through verbatim",
+		{
+			url: "pypi:pkg@1.2.3",
+		},
+		{
+			ok: true,
+			kind: "pypi",
+			config: {
+				command: "uvx",
+				args: ["pkg@1.2.3"],
+			},
+		},
+	],
+	[
+		"TEST-15 REQ-3 REQ-6 REQ-14: returns npx -y with an unscoped npm package and no type or env",
+		{
+			url: "npm:npm-search-mcp",
+		},
+		{
+			ok: true,
+			kind: "npm",
+			config: {
+				command: "npx",
+				args: ["-y", "npm-search-mcp"],
+			},
+		},
+	],
+	[
+		"TEST-16 REQ-3 REQ-6: returns npx -y with a scoped npm package",
+		{
+			url: "npm:@yawlabs/npmjs-mcp",
+		},
+		{
+			ok: true,
+			kind: "npm",
+			config: {
+				command: "npx",
+				args: ["-y", "@yawlabs/npmjs-mcp"],
+			},
+		},
+	],
+	[
+		"TEST-17 REQ-3 REQ-6 REQ-14: passes an unscoped npm version through verbatim",
+		{
+			url: "npm:pkg@1.2.3",
+		},
+		{
+			ok: true,
+			kind: "npm",
+			config: {
+				command: "npx",
+				args: ["-y", "pkg@1.2.3"],
+			},
+		},
+	],
+	[
+		"TEST-18 REQ-3 REQ-6 REQ-14: passes a scoped npm latest tag through verbatim",
+		{
+			url: "npm:@s/p@latest",
+		},
+		{
+			ok: true,
+			kind: "npm",
+			config: {
+				command: "npx",
+				args: ["-y", "@s/p@latest"],
+			},
+		},
+	],
+	[
+		"TEST-19 REQ-5 REQ-6 REQ-7: refuses an npm scope without a package",
+		{
+			url: "npm:@scope",
+		},
+		{
+			ok: false,
+			kind: "npm",
+			reason:
+				"The package name of this npm server looks wrong, so magus won't run it.",
+		},
+	],
+	[
+		"TEST-20 REQ-5 REQ-6 REQ-7: refuses an npm package with an empty scope",
+		{
+			url: "npm:@/x",
+		},
+		{
+			ok: false,
+			kind: "npm",
+			reason:
+				"The package name of this npm server looks wrong, so magus won't run it.",
+		},
+	],
+	[
+		"TEST-21 REQ-5 REQ-6 REQ-7: refuses an npm name that would become the -y option",
+		{
+			url: "npm:-y",
+		},
+		{
+			ok: false,
+			kind: "npm",
+			reason:
+				"The package name of this npm server looks wrong, so magus won't run it.",
+		},
+	],
+	[
+		"TEST-22 REQ-5 REQ-6 REQ-7: refuses npm --package option injection",
+		{
+			url: "npm:--package=x",
+		},
+		{
+			ok: false,
+			kind: "npm",
+			reason:
+				"The package name of this npm server looks wrong, so magus won't run it.",
+		},
+	],
+	[
+		"TEST-23 REQ-4 REQ-6 REQ-7: refuses oci with the exact unsupported-kind reason",
+		{
+			url: "oci:ghcr.io/x/y:1",
+		},
+		{
+			ok: false,
+			kind: "oci",
+			reason:
+				"magus can't install oci servers. It can install https, pypi and npm ones.",
+		},
+	],
+	[
+		"TEST-24 REQ-4 REQ-6 REQ-7: refuses nuget with the exact unsupported-kind reason",
+		{
+			url: "nuget:Foo",
+		},
+		{
+			ok: false,
+			kind: "nuget",
+			reason:
+				"magus can't install nuget servers. It can install https, pypi and npm ones.",
+		},
+	],
+	[
+		"TEST-25 REQ-4 REQ-6 REQ-7: refuses an unsupported foo scheme and names it",
+		{
+			url: "foo:bar",
+		},
+		{
+			ok: false,
+			kind: "foo",
+			reason:
+				"magus can't install foo servers. It can install https, pypi and npm ones.",
+		},
+	],
+	[
+		"TEST-26 REQ-4 REQ-6 REQ-7: refuses a bare localhost port as unknown",
+		{
+			url: "localhost:8080",
+		},
+		{
+			ok: false,
+			kind: "unknown",
+			reason: "magus can't read this server's address.",
+		},
+	],
+	[
+		"TEST-27 REQ-4 REQ-6 REQ-7: refuses bare text as an unreadable address",
+		{
+			url: "just-text",
+		},
+		{
+			ok: false,
+			kind: "unknown",
+			reason: "magus can't read this server's address.",
+		},
+	],
+	[
+		"TEST-28 REQ-4 REQ-6 REQ-7: refuses an empty address as unknown",
+		{
+			url: "",
+		},
+		{
+			ok: false,
+			kind: "unknown",
+			reason: "magus can't read this server's address.",
+		},
+	],
+	[
+		"TEST-29 REQ-5 REQ-6 REQ-7: refuses an empty npm package with the no-package reason",
+		{
+			url: "npm:",
+		},
+		{
+			ok: false,
+			kind: "npm",
+			reason: "This npm server has no package name, so there's nothing to run.",
+		},
+	],
+	[
+		"TEST-30 REQ-5 REQ-6 REQ-7: refuses a whitespace-only npm package with the no-package reason",
+		{
+			url: "npm:   ",
+		},
+		{
+			ok: false,
+			kind: "npm",
+			reason: "This npm server has no package name, so there's nothing to run.",
+		},
+	],
+	[
+		"TEST-31 REQ-3 REQ-6: accepts an upper-case npm scheme and trims the scoped package",
+		{
+			url: "NPM:  @yawlabs/npmjs-mcp ",
+		},
+		{
+			ok: true,
+			kind: "npm",
+			config: {
+				command: "npx",
+				args: ["-y", "@yawlabs/npmjs-mcp"],
+			},
+		},
+	],
+	[
+		"TEST-32 REQ-4 REQ-6 REQ-7: lower-cases the refused OCI kind and its wording",
+		{
+			url: "OCI:ghcr.io/x/y:1",
+		},
+		{
+			ok: false,
+			kind: "oci",
+			reason:
+				"magus can't install oci servers. It can install https, pypi and npm ones.",
+		},
+	],
+	[
+		"TEST-33 REQ-4 REQ-6 REQ-7: refuses a whitespace-only address as unknown",
+		{
+			url: "   ",
+		},
+		{
+			ok: false,
+			kind: "unknown",
+			reason: "magus can't read this server's address.",
+		},
+	],
+	[
+		"TEST-34 REQ-1 REQ-4 REQ-6 REQ-7: refuses HTTP without a host as unknown",
+		{
+			url: "http:",
+		},
+		{
+			ok: false,
+			kind: "unknown",
+			reason: "magus can't read this server's address.",
+		},
+	],
+	[
+		"TEST-35 REQ-1 REQ-4 REQ-6 REQ-7: refuses HTTP with an empty host as unknown",
+		{
+			url: "http://",
+		},
+		{
+			ok: false,
+			kind: "unknown",
+			reason: "magus can't read this server's address.",
+		},
+	],
+	[
+		"TEST-36 REQ-1 REQ-6: keeps a hosted HTTPS server as HTTP despite npm metadata",
+		{
+			url: "https://mcp.notion.com/mcp",
+			package_registry: "npm",
+		},
+		{
+			ok: true,
+			kind: "http",
+			config: {
+				type: "http",
+				url: "https://mcp.notion.com/mcp",
+			},
+		},
+	],
+	[
+		"TEST-37 REQ-1 REQ-6: keeps a hosted HTTPS server as HTTP despite PyPI metadata",
+		{
+			url: "https://mcp.notion.com/mcp",
+			package_registry: "pypi",
+		},
+		{
+			ok: true,
+			kind: "http",
+			config: {
+				type: "http",
+				url: "https://mcp.notion.com/mcp",
+			},
+		},
+	],
+	[
+		"TEST-38 REQ-2 REQ-6: uses the PyPI URL rather than conflicting npm metadata",
+		{
+			url: "pypi:mcparmory-notion",
+			package_registry: "npm",
+		},
+		{
+			ok: true,
+			kind: "pypi",
+			config: {
+				command: "uvx",
+				args: ["mcparmory-notion"],
+			},
+		},
+	],
+	[
+		"TEST-39 REQ-3 REQ-6: uses the npm URL rather than conflicting PyPI metadata",
+		{
+			url: "npm:@yawlabs/npmjs-mcp",
+			package_registry: "pypi",
+		},
+		{
+			ok: true,
+			kind: "npm",
+			config: {
+				command: "npx",
+				args: ["-y", "@yawlabs/npmjs-mcp"],
+			},
+		},
+	],
+	[
+		"TEST-40 REQ-4 REQ-6 REQ-7: does not turn an unsupported OCI URL into npm using metadata",
+		{
+			url: "oci:ghcr.io/x/y:1",
+			package_registry: "npm",
+		},
+		{
+			ok: false,
+			kind: "oci",
+			reason:
+				"magus can't install oci servers. It can install https, pypi and npm ones.",
+		},
+	],
+	[
+		"TEST-41 REQ-4 REQ-6 REQ-7: does not turn an unreadable address into npm using metadata",
+		{
+			url: "just-text",
+			package_registry: "npm",
+		},
+		{
+			ok: false,
+			kind: "unknown",
+			reason: "magus can't read this server's address.",
+		},
+	],
+];
+
+describe("registryInstallPlan: a registry address becomes an install config or a plain refusal", () => {
+	test.each(cases)("%s", (_scenario, input, expected) => {
+		const frozen = Object.freeze({ ...input });
+
+		const first = registryInstallPlan(frozen);
+		const repeated = registryInstallPlan(frozen);
+
+		expect(first).toStrictEqual(expected);
+		expect(repeated).toStrictEqual(expected);
+		expect(frozen).toStrictEqual(input);
+	});
+});