magus-cli 0.0.0-placeholder → 7.0.0

package/src/__tests__/plugin-row-text.test.ts

@@ -0,0 +1,336 @@
+import { describe, expect, test } from "bun:test";
+import type { PluginInfo } from "../services/plugin-manager.js";
+import {
+	type PluginUpdateItem,
+	classifyPluginRows,
+	planPluginUpdates,
+} from "../services/update-plan.js";
+import type { Marketplace } from "../types/index.js";
+import {
+	type PluginPluginItem,
+	buildPluginBrowserItems,
+} from "../ui/adapters/pluginsAdapter.js";
+import { pluginRowText } from "../ui/renderers/pluginRowText.js";
+import { pluginStatusText } from "../ui/renderers/pluginStatusText.js";
+
+/**
+ * `pluginRowText` is exactly what a Plugins row prints after the name, in
+ * every branch of `pluginRow` — selected, unselected, orphan. So asserting on
+ * it asserts on the screen.
+ *
+ * Rows here are built the way the screen builds them: `classifyPluginRows` over
+ * the plugin list and the profile's pins, then `buildPluginBrowserItems`. The
+ * note each row must contain is taken from `planPluginUpdates` — the CLI's own
+ * answer — never retyped, so the two front ends are compared, not two copies.
+ */
+
+const OFFICIAL: Marketplace = {
+	name: "claude-plugins-official",
+	displayName: "Anthropic Official",
+	source: { source: "github", repo: "anthropics/claude-plugins-official" },
+	description: "",
+} as Marketplace;
+
+const MAGUS: Marketplace = {
+	name: "magus",
+	displayName: "Magus",
+	source: { source: "github", repo: "MadAppGang/magus" },
+	description: "",
+	owned: true,
+} as Marketplace;
+
+function info(over: Partial<PluginInfo> & { id: string }): PluginInfo {
+	const [name, marketplace] = over.id.split("@");
+	return {
+		name,
+		version: null,
+		description: "",
+		marketplace,
+		marketplaceDisplay: "",
+		enabled: true,
+		author: { name: "Anthropic" },
+		...over,
+	} as PluginInfo;
+}
+
+/** Real: `code-review@claude-plugins-official` in /Users/jack/mag/claudish. */
+const CODE_REVIEW = info({
+	id: "code-review@claude-plugins-official",
+	version: null, // the official catalog publishes no version for it
+	installedVersion: "3ea32df27be7",
+	projectScope: { enabled: true, version: "3ea32df27be7" },
+});
+
+/** A registry "0.0.0" — the value the old row hid every status behind. */
+const ZERO = info({
+	id: "zero-version@claude-plugins-official",
+	version: null,
+	installedVersion: "0.0.0",
+	projectScope: { enabled: true, version: "0.0.0" },
+});
+
+/** Other listed ids, so each marketplace demonstrably was read. */
+const LISTED = [
+	info({ id: "dev@magus", version: "4.7.0", author: { name: "MadAppGang" } }),
+	info({ id: "github@claude-plugins-official", version: null }),
+];
+
+function rows(
+	plugins: PluginInfo[],
+	pins: Record<string, string> = {},
+): Map<string, PluginPluginItem> {
+	const all = [...plugins, ...LISTED];
+	const items = buildPluginBrowserItems({
+		marketplaces: [MAGUS, OFFICIAL],
+		plugins: all,
+		collapsedMarketplaces: new Set(),
+		statuses: classifyPluginRows(all, pins),
+	});
+	return new Map(
+		items
+			.filter((i): i is PluginPluginItem => i.kind === "plugin")
+			.map((i) => [i.plugin.id, i]),
+	);
+}
+
+/** The note `magus update` prints for this plugin under this pin. */
+function cliNote(
+	plugins: PluginInfo[],
+	id: string,
+	pin = "latest",
+): string | undefined {
+	const all = [...plugins, ...LISTED];
+	const [item] = planPluginUpdates(
+		{ [id]: pin },
+		new Map(all.map((p) => [p.id, p])),
+	);
+	return item?.note;
+}
+
+describe("pluginRowText — a status never depends on a displayable version", () => {
+	test("a sha-versioned unknown carries the CLI's reason verbatim", () => {
+		// The old row said "? not comparable" here; the CLI said the sentence
+		// below. Same state, different reason — the R2 violation.
+		const row = rows([CODE_REVIEW]).get(CODE_REVIEW.id);
+		const note = cliNote([CODE_REVIEW], CODE_REVIEW.id);
+		expect(note).toBe(
+			"its marketplace publishes no version for this plugin, so there is nothing to compare",
+		);
+		const { text } = pluginRowText(row as PluginPluginItem);
+		expect(text).toBe(` v3ea32df27be7 ? ${note}`);
+		expect(text).not.toContain("not comparable");
+	});
+
+	test('REGRESSION: a "0.0.0" unknown is no longer blank', () => {
+		// Every old status clause was gated on a displayable version, so this row
+		// printed nothing after its name and read as healthy.
+		const row = rows([ZERO]).get(ZERO.id) as PluginPluginItem;
+		expect(row.status?.action).toBe("unknown");
+		const { text, segments } = pluginRowText(row);
+		expect(text).toBe(` ? ${cliNote([ZERO], ZERO.id)}`);
+		// The version itself is still never printed.
+		expect(text).not.toContain("0.0.0");
+		expect(segments.at(-1)?.tone).toBe("warning");
+	});
+});
+
+describe("pluginRowText — orphans say what the CLI says (F9)", () => {
+	test("an orphan that moved names where it went", () => {
+		const seo = info({
+			id: "seo@magus",
+			version: "1.8.0",
+			installedVersion: "1.8.0",
+			isOrphaned: true,
+			movedTo: "magus-marketing",
+			projectScope: { enabled: true, version: "1.8.0" },
+		});
+		const row = rows([seo]).get(seo.id) as PluginPluginItem;
+		expect(cliNote([seo], seo.id)).toBe("moved to magus-marketing");
+		expect(pluginRowText(row).text).toBe(" v1.8.0 ? moved to magus-marketing");
+	});
+
+	test("an orphan with no movedTo, from a marketplace we read, is 'not offered'", () => {
+		const gone = info({
+			id: "gone@magus",
+			version: "2.0.0",
+			installedVersion: "2.0.0",
+			isOrphaned: true,
+			projectScope: { enabled: true, version: "2.0.0" },
+		});
+		const row = rows([gone]).get(gone.id) as PluginPluginItem;
+		expect(pluginRowText(row).text).toBe(
+			` v2.0.0 ? ${cliNote([gone], gone.id)}`,
+		);
+		expect(pluginRowText(row).text).toContain(
+			"not offered by any configured marketplace",
+		);
+	});
+
+	test("the old words are gone: no 'deprecated', no 'moved →'", () => {
+		const seo = info({
+			id: "seo@magus",
+			installedVersion: "1.8.0",
+			isOrphaned: true,
+			movedTo: "magus-marketing",
+			projectScope: { enabled: true, version: "1.8.0" },
+		});
+		const { text } = pluginRowText(rows([seo]).get(seo.id) as PluginPluginItem);
+		expect(text).not.toContain("deprecated");
+		expect(text).not.toContain("moved →");
+	});
+});
+
+describe("pluginRowText — history badges combine with the state", () => {
+	const updated = (over: Partial<PluginInfo>) =>
+		info({
+			id: "terminal@magus",
+			version: "3.3.1",
+			installedVersion: "3.0.1",
+			projectScope: { enabled: true, version: "3.0.1" },
+			author: { name: "MadAppGang" },
+			...over,
+		});
+
+	test("'updated' and a pending update are both shown", () => {
+		// An external update moved 2.9.0 → 3.0.1 while 3.3.1 is already out.
+		const p = updated({ recentlyUpdatedFrom: "2.9.0" });
+		const row = rows([p]).get(p.id) as PluginPluginItem;
+		const { text, segments } = pluginRowText(row);
+		expect(text).toBe(" v2.9.0 → v3.0.1 updated → v3.3.1 available");
+		expect(segments.map((s) => s.tone)).toEqual(["success", "warning"]);
+	});
+
+	test("'new' and a pending update are both shown", () => {
+		const p = updated({ recentlyInstalled: true });
+		const row = rows([p]).get(p.id) as PluginPluginItem;
+		expect(pluginRowText(row).text).toBe(" v3.0.1 new → v3.3.1 available");
+	});
+
+	test("'new' with no displayable version still says new", () => {
+		const p = updated({
+			recentlyInstalled: true,
+			version: "0.0.0",
+			installedVersion: "0.0.0",
+			projectScope: { enabled: true, version: "0.0.0" },
+		});
+		const row = rows([p]).get(p.id) as PluginPluginItem;
+		expect(pluginRowText(row).text).toBe(" new");
+	});
+
+	test("a current row shows only its version", () => {
+		const p = updated({
+			version: "3.0.1",
+		});
+		const row = rows([p]).get(p.id) as PluginPluginItem;
+		expect(row.status?.action).toBe("current");
+		expect(pluginRowText(row).text).toBe(" v3.0.1");
+	});
+});
+
+describe("pluginRowText — rows with no state claim none", () => {
+	test("an undeclared, uninstalled catalog entry has no status and no text", () => {
+		const browse = info({
+			id: "kanban@magus",
+			version: "1.6.2",
+			author: { name: "MadAppGang" },
+		});
+		const row = rows([browse]).get(browse.id) as PluginPluginItem;
+		expect(row.status).toBeNull();
+		expect(pluginRowText(row).text).toBe("");
+	});
+
+	test("the same entry DECLARED by the profile says the profile wants it", () => {
+		const declared = info({
+			id: "kanban@magus",
+			version: "1.6.2",
+			author: { name: "MadAppGang" },
+		});
+		const row = rows([declared], { "kanban@magus": "latest" }).get(
+			declared.id,
+		) as PluginPluginItem;
+		expect(pluginRowText(row).text).toBe(
+			" not installed — profile declares it",
+		);
+	});
+});
+
+describe("pluginStatusText — absent is not enabled-not-installed (LOW 6)", () => {
+	const status = (over: Partial<PluginUpdateItem>): PluginUpdateItem => ({
+		pluginId: "x@magus",
+		pinned: "latest",
+		installed: null,
+		available: "1.0.0",
+		target: "1.0.0",
+		action: "install",
+		reason: "absent",
+		scopes: [],
+		beforeVersions: {},
+		...over,
+	});
+
+	test("absent — only ever from a profile pin — may say the profile declares it", () => {
+		expect(pluginStatusText(status({}))).toEqual({
+			suffix: " not installed — profile declares it",
+			tone: "warning",
+		});
+	});
+
+	test("enabled-not-installed shows its note and never claims a declaration", () => {
+		const got = pluginStatusText(
+			status({
+				reason: "enabled-not-installed",
+				note: "enabled in settings, but no files on disk",
+			}),
+		);
+		expect(got).toEqual({
+			suffix: " not installed (enabled in settings, but no files on disk)",
+			tone: "danger",
+		});
+		expect(got.suffix).not.toContain("profile");
+	});
+
+	test("an undeclared enabled-but-not-installed ROW gets the enabled text", () => {
+		const broken = info({
+			id: "kanban@magus",
+			version: "1.6.2",
+			author: { name: "MadAppGang" },
+			localScope: { enabled: true },
+		});
+		const row = rows([broken]).get(broken.id) as PluginPluginItem;
+		expect(row.status?.reason).toBe("enabled-not-installed");
+		expect(pluginRowText(row).text).toBe(
+			" not installed (enabled in settings, but no files on disk)",
+		);
+	});
+
+	test("null status says nothing", () => {
+		expect(pluginStatusText(null)).toEqual({ suffix: "", tone: "muted" });
+	});
+
+	test("update with a pin-undeliverable note carries it", () => {
+		expect(
+			pluginStatusText(
+				status({
+					action: "update",
+					reason: "pin-undeliverable",
+					target: "9.9.9",
+					note: "manifest pins 4.6.1; the marketplace offers only 9.9.9",
+				}),
+			).suffix,
+		).toBe(
+			" → v9.9.9 available (manifest pins 4.6.1; the marketplace offers only 9.9.9)",
+		);
+	});
+
+	test("repair carries its note", () => {
+		expect(
+			pluginStatusText(
+				status({
+					action: "repair",
+					reason: "content-stale",
+					note: "files changed without a version bump",
+				}),
+			).suffix,
+		).toBe(" stale — reinstall (files changed without a version bump)");
+	});
+});