magmastream 2.10.2-dev.4 → 2.10.3-alpha.0

package/dist/structures/Node.d.ts

@@ -23,7 +23,8 @@ export declare class Node {
     private reconnectTimeout?;
     private reconnectAttempts;
     private redisPrefix?;
-    private sessionIdsMap;
+    /** Session ID sent in the reconnect header for resumption — cleared once the ready op is received. */
+    private pendingResumeSessionId;
     /**
      * Creates an instance of Node.
      * @param manager - The manager for the node.

package/dist/structures/Node.js

@@ -31,7 +31,8 @@ class Node {
     reconnectTimeout;
     reconnectAttempts = 1;
     redisPrefix;
-    sessionIdsMap = new Map();
+    /** Session ID sent in the reconnect header for resumption — cleared once the ready op is received. */
+    pendingResumeSessionId = null;
     /**
      * Creates an instance of Node.
      * @param manager - The manager for the node.
@@ -153,8 +154,6 @@ class Node {
                 try {
                     const raw = fs_1.default.readFileSync(filePath, "utf-8").trim();
                     this.sessionId = raw.length ? raw : null;
-                    if (this.sessionId)
-                        this.sessionIdsMap.set(this.getCompositeKey(), this.sessionId);
                 }
                 catch {
                     this.sessionId = null;
@@ -169,7 +168,6 @@ class Node {
                     const sid = await this.manager.redis.hget(key, compositeKey);
                     this.sessionId = sid ?? null;
                     if (this.sessionId) {
-                        this.sessionIdsMap.set(compositeKey, this.sessionId);
                         this.manager.emit(Enums_1.ManagerEventTypes.Debug, `[NODE] Restored sessionId for ${compositeKey}: ${this.sessionId}`);
                     }
                 }
@@ -210,7 +208,6 @@ class Node {
         if (this.sessionId) {
             fs_1.default.writeFileSync(tmpPath, this.sessionId, "utf-8");
             fs_1.default.renameSync(tmpPath, filePath);
-            this.sessionIdsMap.set(this.getCompositeKey(), this.sessionId);
         }
         else {
             try {
@@ -218,7 +215,6 @@ class Node {
                     fs_1.default.unlinkSync(filePath);
             }
             catch { }
-            this.sessionIdsMap.delete(this.getCompositeKey());
         }
     }
     async updateSessionIdRedis() {
@@ -228,11 +224,9 @@ class Node {
         try {
             if (this.sessionId) {
                 await this.manager.redis.hset(key, compositeKey, this.sessionId);
-                this.sessionIdsMap.set(compositeKey, this.sessionId);
             }
             else {
                 await this.manager.redis.hdel(key, compositeKey);
-                this.sessionIdsMap.delete(compositeKey);
             }
         }
         catch (err) {
@@ -262,8 +256,16 @@ class Node {
             "User-Id": this.manager.options.clientId,
             "Client-Name": this.manager.options.clientName,
         };
-        if (typeof this.sessionId === "string" && this.sessionId.length > 0) {
-            headers["Session-Id"] = this.sessionId;
+        // Capture resume session ID for the WS header, then clear this.sessionId.
+        // REST calls guard on this.sessionId being non-null — keeping the stale value
+        // would let updatePlayer/destroyPlayer fire with an invalid session during the
+        // reconnect window (between connect() and the 'ready' op).
+        // pendingResumeSessionId is kept so the 'ready' handler can still compute
+        // hadPreviousSession correctly. this.sessionId is re-set by 'ready'.
+        this.pendingResumeSessionId = this.sessionId;
+        this.sessionId = null;
+        if (typeof this.pendingResumeSessionId === "string" && this.pendingResumeSessionId.length > 0) {
+            headers["Session-Id"] = this.pendingResumeSessionId;
         }
         this.socket = new ws_1.default(`ws${this.options.useSSL ? "s" : ""}://${this.address}/v4/websocket`, { headers });
         this.socket.on("open", this.open.bind(this));
@@ -274,7 +276,7 @@ class Node {
         const debugInfo = {
             connected: this.connected,
             address: this.address,
-            sessionId: this.sessionId,
+            pendingResumeSessionId: this.pendingResumeSessionId,
             options: {
                 clientId: this.manager.options.clientId,
                 clientName: this.manager.options.clientName,
@@ -295,8 +297,6 @@ class Node {
      * @returns {Promise<void>} A promise that resolves when the node and its resources have been destroyed.
      */
     async destroy() {
-        if (!this.connected)
-            return;
         const debugInfo = {
             connected: this.connected,
             identifier: this.options.identifier,
@@ -310,10 +310,16 @@ class Node {
         if (players.size) {
             await Promise.all(Array.from(players.values(), (player) => player.autoMoveNode()));
         }
-        this.socket.close(1000, "destroy");
-        this.socket.removeAllListeners();
-        this.reconnectAttempts = 1;
+        // Always clear reconnect state regardless of connection status
         clearTimeout(this.reconnectTimeout);
+        this.reconnectTimeout = undefined;
+        this.reconnectAttempts = 1;
+        // Only close the socket if it is actually open
+        if (this.connected) {
+            this.socket.close(1000, "destroy");
+            this.socket.removeAllListeners();
+        }
+        this.socket = null;
         this.manager.emit(Enums_1.ManagerEventTypes.NodeDestroy, this);
         this.manager.nodes.delete(this.options.identifier);
     }
@@ -487,7 +493,11 @@ class Node {
             case "ready":
                 this.manager.emit(Enums_1.ManagerEventTypes.Debug, `[NODE] Node message: ${Utils_1.JSONUtils.safe(payload, 2)}`);
                 this.rest.setSessionId(payload.sessionId);
-                const hadPreviousSession = this.sessionId && this.sessionId !== payload.sessionId;
+                // pendingResumeSessionId holds what we sent in Session-Id header (if anything).
+                // Use it — not this.sessionId which was nulled in connect() — to detect whether
+                // we attempted resumption with a different session than what Lavalink gave back.
+                const hadPreviousSession = this.pendingResumeSessionId && this.pendingResumeSessionId !== payload.sessionId;
+                this.pendingResumeSessionId = null;
                 this.sessionId = payload.sessionId;
                 await this.updateSessionId();
                 this.info = await this.fetchInfo();
@@ -520,6 +530,11 @@ class Node {
             return;
         const track = await player.queue.getCurrent();
         const type = payload.type;
+        const TRACK_EVENTS = ["TrackStartEvent", "TrackEndEvent", "TrackStuckEvent", "TrackExceptionEvent"];
+        if (!track && TRACK_EVENTS.includes(type)) {
+            this.manager.emit(Enums_1.ManagerEventTypes.Debug, `[Node] Received ${type} for guild ${payload.guildId} but queue has no current track — ignoring.`);
+            return;
+        }
         let error;
         switch (type) {
             case "TrackStartEvent":

package/dist/structures/Player.js

@@ -943,7 +943,12 @@ class Player {
                     context: { guildId: this.guildId },
                 });
             }
-            await this.node.rest.destroyPlayer(this.guildId).catch(() => { });
+            // Only destroy the player on the old node if it is still reachable.
+            // If the server is down the REST call would fail anyway; skipping it
+            // also prevents a spurious error when switching nodes during an outage.
+            if (this.node.connected) {
+                await this.node.rest.destroyPlayer(this.guildId).catch(() => { });
+            }
             this.manager.players.delete(this.guildId);
             this.node = node;
             this.manager.players.set(this.guildId, this);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "magmastream",
-    "version": "2.10.2-dev.4",
+    "version": "2.10.3-alpha.0",
     "description": "A user-friendly Lavalink client designed for NodeJS.",
     "main": "dist/index.js",
     "types": "dist/index.d.ts",