magector 2.9.0 → 2.10.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "magector",
-  "version": "2.9.0",
+  "version": "2.10.0",
   "description": "Semantic code search for Magento 2 — index, search, MCP server",
   "type": "module",
   "main": "src/mcp-server.js",
@@ -33,10 +33,10 @@
     "ruvector": "^0.1.96"
   },
   "optionalDependencies": {
-    "@magector/cli-darwin-arm64": "2.9.0",
-    "@magector/cli-linux-x64": "2.9.0",
-    "@magector/cli-linux-arm64": "2.9.0",
-    "@magector/cli-win32-x64": "2.9.0"
+    "@magector/cli-darwin-arm64": "2.10.0",
+    "@magector/cli-linux-x64": "2.10.0",
+    "@magector/cli-linux-arm64": "2.10.0",
+    "@magector/cli-win32-x64": "2.10.0"
   },
   "keywords": [
     "magento",

package/src/mcp-server.js

@@ -1855,6 +1855,83 @@ const ERROR_PATTERNS = [
     type: 'invalid_plugin_method',
     extract: (m) => ({ class: m[1], type: m[2], method: m[3] }),
     suggestion: (ctx) => `Plugin method ${ctx.type}${ctx.method} in ${ctx.class} doesn't match any public method on the target class. Check method name spelling.`
+  },
+  // ── Business logic / configuration patterns ──
+  {
+    pattern: /rule\s+(?:did\s+)?not\s+(?:match|apply|work)|(?:sales|cart|price)\s*rule.*(?:not\s+applied|didn'?t\s+match|failed)/i,
+    type: 'rule_not_matching',
+    extract: () => ({}),
+    suggestion: () => [
+      'Sales/cart price rule not matching. Check BOTH code AND configuration:',
+      '',
+      '**Configuration checks (most common cause):**',
+      '- Rule Actions tab: are ALL required shipping methods selected?',
+      '- Rule Conditions: does the cart actually meet ALL conditions (customer group, subtotal threshold, date range)?',
+      '- Rule status: is it Active? Check date range (from/to).',
+      '- Rule priority/stop processing: is a higher-priority rule stopping this one?',
+      '- Coupon: if coupon-based, was the correct coupon applied?',
+      '- Website scope: is the rule assigned to the correct website?',
+      '',
+      '**Code checks (less common):**',
+      '- Custom condition types: check classes extending AbstractCondition in vendor/',
+      '- Plugins on Magento\\SalesRule\\Model\\Utility::canProcessRule() that may skip rules',
+      '- Plugins on Magento\\SalesRule\\Model\\Rule\\Condition\\Address::validate()',
+      '- DI preference overrides on Condition\\Address (e.g., marketplace container conditions)',
+      '- The condition_type stored in conditions_serialized — does the PHP class exist and validate correctly?',
+      '',
+      'Use magento_grep to find: custom conditions, plugins on validate/canProcessRule, and DI preferences on Address.',
+      '',
+      '**Ask the user for DB data:**',
+      'SELECT rule_id, name, conditions_serialized, actions_serialized, is_active, from_date, to_date',
+      'FROM salesrule WHERE rule_id = <ID>;',
+      'This lets you verify the exact condition_type classes and action configuration without guessing.'
+    ].join('\n')
+  },
+  {
+    pattern: /free\s*shipping.*(?:not|didn'?t|did\s+not)\s+(?:apply|work|match)|(?:not|didn'?t)\s+(?:get|receive)\s+free\s*shipping/i,
+    type: 'free_shipping_not_applied',
+    extract: () => ({}),
+    suggestion: () => [
+      'Free shipping not applied. Most common causes:',
+      '',
+      '**1. Rule Actions — shipping method not selected (MOST COMMON)**',
+      '   The free shipping rule must have the specific shipping method checked in Actions.',
+      '   If "home delivery" is not selected but the customer chose home delivery → rule won\'t apply.',
+      '',
+      '**2. Condition threshold mismatch**',
+      '   Check which subtotal attribute the condition uses: base_subtotal, subtotal_incl_tax,',
+      '   drmax_free_shipping_price (custom). Each calculates differently (with/without tax, discounts).',
+      '',
+      '**3. Custom condition type**',
+      '   Container attributes (SubtotalWithDiscountInclTax) aggregate per shop type.',
+      '   If condition uses :1p suffix instead of :whole, only 1P items count.',
+      '',
+      '**4. Plugin interference**',
+      '   Check plugins on Utility::canProcessRule() and Carrier::collectRates().',
+      '',
+      'Start with: check the rule\'s Actions tab in admin for shipping method selection.',
+      '',
+      '**Ask the user for DB data:**',
+      'SELECT rule_id, name, conditions_serialized, actions_serialized, simple_free_shipping',
+      'FROM salesrule WHERE rule_id = <ID>;',
+      'The actions_serialized will show which shipping methods are enabled for free shipping.'
+    ].join('\n')
+  },
+  {
+    pattern: /(?:condition|rule|promotion|discount).*(?:custom|type).*(?:not|fail|wrong|weird|unexpected)/i,
+    type: 'custom_condition_issue',
+    extract: () => ({}),
+    suggestion: () => [
+      'Possible custom condition type issue. Investigate:',
+      '',
+      '**1. Check the rule configuration FIRST** — most "condition not working" bugs are misconfiguration.',
+      '**2. Find custom condition classes:** grep for "extends AbstractCondition" in vendor/',
+      '**3. Check DI preference on Condition\\Address** — marketplace modules often override validate().',
+      '**4. Check if new attributes are registered in the Address override\'s switch/mapping.**',
+      '**5. Verify condition_type in DB:** the serialized condition must reference an existing PHP class.',
+      '',
+      'If code analysis finds no bugs, the root cause is likely rule configuration in admin panel.'
+    ].join('\n')
   }
 ];
 
@@ -4066,13 +4143,35 @@ server.setRequestHandler(ListToolsRequestSchema, async () => ({
           },
           context: {
             type: 'number',
-            description: 'Lines of context around each match (default: 0). Like grep -C.',
-            default: 0
+            description: 'Lines of context around each match (default: 2). Like grep -C.',
+            default: 2
           }
         },
         required: ['pattern']
       }
     },
+    {
+      name: 'magento_read',
+      description: 'Read a file from the Magento codebase. Use in magento_batch to read multiple files in a single MCP call (e.g., grep finds 5 files → read all 5 in one batch). Supports line ranges for large files.',
+      inputSchema: {
+        type: 'object',
+        properties: {
+          path: {
+            type: 'string',
+            description: 'File path relative to MAGENTO_ROOT. Example: "vendor/acme/module-sales/Model/OrderService.php"'
+          },
+          startLine: {
+            type: 'number',
+            description: 'Start reading from this line number (1-based). Default: 1 (beginning of file).'
+          },
+          endLine: {
+            type: 'number',
+            description: 'Stop reading at this line number (inclusive). Default: end of file. Use with startLine for large files.'
+          }
+        },
+        required: ['path']
+      }
+    },
   ]
 }));
 
@@ -4091,7 +4190,7 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
     // These tools have filesystem/di.xml fallbacks — work without serve process
     'magento_find_class', 'magento_find_method', 'magento_find_plugin',
     'magento_find_observer', 'magento_find_di_wiring', 'magento_module_structure',
-    'magento_batch', 'magento_find_config', 'magento_find_callers', 'magento_grep'];
+    'magento_batch', 'magento_find_config', 'magento_find_callers', 'magento_grep', 'magento_read'];
   if (warmupInProgress && !indexFreeTools.includes(name)) {
     logToFile('REQ', `${name} → blocked (warmup: loading index)`);
     return {
@@ -4892,7 +4991,22 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
           structure: structureOutput.categories
         });
 
-        return { content: [{ type: 'text', text: jsonOutput }] };
+        // Include README.md if it exists in the module directory
+        let readmeText = '';
+        if (results.length > 0) {
+          // Find module root from first result path
+          const firstPath = results[0].path || '';
+          const moduleRoot = firstPath.split('/').slice(0, 3).join('/');
+          if (moduleRoot) {
+            const readmePath = path.join(config.magentoRoot, moduleRoot, 'README.md');
+            try {
+              const readme = readFileSync(readmePath, 'utf-8');
+              readmeText = '\n\n## README.md\n\n' + readme.slice(0, 2000) + (readme.length > 2000 ? '\n...(truncated)' : '');
+            } catch { /* no README */ }
+          }
+        }
+
+        return { content: [{ type: 'text', text: jsonOutput + readmeText }] };
       }
 
       case 'magento_analyze_diff': {
@@ -5906,13 +6020,28 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
                 }
                 break;
               }
+              case 'magento_read': {
+                const filePath = path.join(config.magentoRoot, a.path);
+                let fileContent;
+                try { fileContent = readFileSync(filePath, 'utf-8'); } catch {
+                  text = `File not found: ${a.path}`;
+                  break;
+                }
+                const allLines = fileContent.split('\n');
+                const s = Math.max((a.startLine || 1) - 1, 0);
+                const e = a.endLine ? Math.min(a.endLine, allLines.length) : allLines.length;
+                const sl = allLines.slice(s, e);
+                text = sl.map((line, i) => `${s + i + 1}\t${line}`).join('\n');
+                break;
+              }
               case 'magento_grep': {
                 const searchPath = a.path || '.';
                 const include = a.include || '*.php';
                 const maxRes = Math.min(a.maxResults || 30, 100);
+                const batchCtx = a.context !== undefined ? a.context : 2;
                 const gArgs = ['-rn'];
                 if (a.ignoreCase) gArgs.push('-i');
-                if (a.context) gArgs.push('-C', String(a.context));
+                if (batchCtx > 0) gArgs.push('-C', String(batchCtx));
                 for (const pat of include.split(',').map(p => p.trim())) gArgs.push('--include=' + pat);
                 gArgs.push('--', a.pattern, searchPath);
                 let out;
@@ -5946,9 +6075,10 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
         const searchPath = args.path || '.';
         const include = args.include || '*.php';
         const maxResults = Math.min(args.maxResults || 50, 200);
+        const ctxLines = args.context !== undefined ? args.context : 2;
         const grepArgs = ['-rn'];
         if (args.ignoreCase) grepArgs.push('-i');
-        if (args.context) grepArgs.push('-C', String(args.context));
+        if (ctxLines > 0) grepArgs.push('-C', String(ctxLines));
         // Support multiple include patterns (e.g., "*.{php,xml}")
         for (const pat of include.split(',').map(p => p.trim())) {
           grepArgs.push('--include=' + pat);
@@ -5976,6 +6106,26 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
         return { content: [{ type: 'text', text }] };
       }
 
+      case 'magento_read': {
+        const root = config.magentoRoot;
+        if (!root) return { content: [{ type: 'text', text: 'MAGENTO_ROOT not set.' }], isError: true };
+        const filePath = path.join(root, args.path);
+        let content;
+        try { content = readFileSync(filePath, 'utf-8'); } catch (err) {
+          return { content: [{ type: 'text', text: `File not found: ${args.path}` }], isError: true };
+        }
+        const allLines = content.split('\n');
+        const start = Math.max((args.startLine || 1) - 1, 0);
+        const end = args.endLine ? Math.min(args.endLine, allLines.length) : allLines.length;
+        const sliced = allLines.slice(start, end);
+        // Format with line numbers
+        const numbered = sliced.map((line, i) => `${start + i + 1}\t${line}`).join('\n');
+        let text = `## ${args.path}`;
+        if (args.startLine || args.endLine) text += ` (lines ${start + 1}-${end})`;
+        text += `\n\n${numbered}`;
+        return { content: [{ type: 'text', text }] };
+      }
+
       default:
         return {
           content: [{