magector 2.8.1 → 2.9.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "magector",
-  "version": "2.8.1",
+  "version": "2.9.1",
   "description": "Semantic code search for Magento 2 — index, search, MCP server",
   "type": "module",
   "main": "src/mcp-server.js",
@@ -33,10 +33,10 @@
     "ruvector": "^0.1.96"
   },
   "optionalDependencies": {
-    "@magector/cli-darwin-arm64": "2.8.1",
-    "@magector/cli-linux-x64": "2.8.1",
-    "@magector/cli-linux-arm64": "2.8.1",
-    "@magector/cli-win32-x64": "2.8.1"
+    "@magector/cli-darwin-arm64": "2.9.1",
+    "@magector/cli-linux-x64": "2.9.1",
+    "@magector/cli-linux-arm64": "2.9.1",
+    "@magector/cli-win32-x64": "2.9.1"
   },
   "keywords": [
     "magento",

package/src/mcp-server.js

@@ -1855,6 +1855,83 @@ const ERROR_PATTERNS = [
     type: 'invalid_plugin_method',
     extract: (m) => ({ class: m[1], type: m[2], method: m[3] }),
     suggestion: (ctx) => `Plugin method ${ctx.type}${ctx.method} in ${ctx.class} doesn't match any public method on the target class. Check method name spelling.`
+  },
+  // ── Business logic / configuration patterns ──
+  {
+    pattern: /rule\s+(?:did\s+)?not\s+(?:match|apply|work)|(?:sales|cart|price)\s*rule.*(?:not\s+applied|didn'?t\s+match|failed)/i,
+    type: 'rule_not_matching',
+    extract: () => ({}),
+    suggestion: () => [
+      'Sales/cart price rule not matching. Check BOTH code AND configuration:',
+      '',
+      '**Configuration checks (most common cause):**',
+      '- Rule Actions tab: are ALL required shipping methods selected?',
+      '- Rule Conditions: does the cart actually meet ALL conditions (customer group, subtotal threshold, date range)?',
+      '- Rule status: is it Active? Check date range (from/to).',
+      '- Rule priority/stop processing: is a higher-priority rule stopping this one?',
+      '- Coupon: if coupon-based, was the correct coupon applied?',
+      '- Website scope: is the rule assigned to the correct website?',
+      '',
+      '**Code checks (less common):**',
+      '- Custom condition types: check classes extending AbstractCondition in vendor/',
+      '- Plugins on Magento\\SalesRule\\Model\\Utility::canProcessRule() that may skip rules',
+      '- Plugins on Magento\\SalesRule\\Model\\Rule\\Condition\\Address::validate()',
+      '- DI preference overrides on Condition\\Address (e.g., marketplace container conditions)',
+      '- The condition_type stored in conditions_serialized — does the PHP class exist and validate correctly?',
+      '',
+      'Use magento_grep to find: custom conditions, plugins on validate/canProcessRule, and DI preferences on Address.',
+      '',
+      '**Ask the user for DB data:**',
+      'SELECT rule_id, name, conditions_serialized, actions_serialized, is_active, from_date, to_date',
+      'FROM salesrule WHERE rule_id = <ID>;',
+      'This lets you verify the exact condition_type classes and action configuration without guessing.'
+    ].join('\n')
+  },
+  {
+    pattern: /free\s*shipping.*(?:not|didn'?t|did\s+not)\s+(?:apply|work|match)|(?:not|didn'?t)\s+(?:get|receive)\s+free\s*shipping/i,
+    type: 'free_shipping_not_applied',
+    extract: () => ({}),
+    suggestion: () => [
+      'Free shipping not applied. Most common causes:',
+      '',
+      '**1. Rule Actions — shipping method not selected (MOST COMMON)**',
+      '   The free shipping rule must have the specific shipping method checked in Actions.',
+      '   If "home delivery" is not selected but the customer chose home delivery → rule won\'t apply.',
+      '',
+      '**2. Condition threshold mismatch**',
+      '   Check which subtotal attribute the condition uses: base_subtotal, subtotal_incl_tax,',
+      '   drmax_free_shipping_price (custom). Each calculates differently (with/without tax, discounts).',
+      '',
+      '**3. Custom condition type**',
+      '   Container attributes (SubtotalWithDiscountInclTax) aggregate per shop type.',
+      '   If condition uses :1p suffix instead of :whole, only 1P items count.',
+      '',
+      '**4. Plugin interference**',
+      '   Check plugins on Utility::canProcessRule() and Carrier::collectRates().',
+      '',
+      'Start with: check the rule\'s Actions tab in admin for shipping method selection.',
+      '',
+      '**Ask the user for DB data:**',
+      'SELECT rule_id, name, conditions_serialized, actions_serialized, simple_free_shipping',
+      'FROM salesrule WHERE rule_id = <ID>;',
+      'The actions_serialized will show which shipping methods are enabled for free shipping.'
+    ].join('\n')
+  },
+  {
+    pattern: /(?:condition|rule|promotion|discount).*(?:custom|type).*(?:not|fail|wrong|weird|unexpected)/i,
+    type: 'custom_condition_issue',
+    extract: () => ({}),
+    suggestion: () => [
+      'Possible custom condition type issue. Investigate:',
+      '',
+      '**1. Check the rule configuration FIRST** — most "condition not working" bugs are misconfiguration.',
+      '**2. Find custom condition classes:** grep for "extends AbstractCondition" in vendor/',
+      '**3. Check DI preference on Condition\\Address** — marketplace modules often override validate().',
+      '**4. Check if new attributes are registered in the Address override\'s switch/mapping.**',
+      '**5. Verify condition_type in DB:** the serialized condition must reference an existing PHP class.',
+      '',
+      'If code analysis finds no bugs, the root cause is likely rule configuration in admin panel.'
+    ].join('\n')
   }
 ];
 
@@ -4035,6 +4112,44 @@ server.setRequestHandler(ListToolsRequestSchema, async () => ({
         required: ['queries']
       }
     },
+    {
+      name: 'magento_grep',
+      description: 'Exact text search (grep) across Magento PHP/XML/JS files. Unlike magento_search (semantic/vector), this finds EVERY occurrence of a literal string or regex pattern. Use for: finding all call sites of a method, all usages of a class name, all config references. Returns file:line:content for each match.',
+      inputSchema: {
+        type: 'object',
+        properties: {
+          pattern: {
+            type: 'string',
+            description: 'Text pattern to search for. Literal string or POSIX regex. Examples: "getPayment()->getMethod()", "removeButton", "sales_order_place_after", "class AddressConditions"'
+          },
+          path: {
+            type: 'string',
+            description: 'Subdirectory to search in (relative to MAGENTO_ROOT). Default: "." (entire codebase). Examples: "vendor/acme/", "app/code/", "vendor/magento/module-sales/"'
+          },
+          include: {
+            type: 'string',
+            description: 'File glob pattern to include. Default: "*.php". Examples: "*.xml", "*.{php,xml}", "*.js", "*.phtml"',
+            default: '*.php'
+          },
+          ignoreCase: {
+            type: 'boolean',
+            description: 'Case-insensitive search (default: false)',
+            default: false
+          },
+          maxResults: {
+            type: 'number',
+            description: 'Maximum number of matches to return (default: 50, max: 200)',
+            default: 50
+          },
+          context: {
+            type: 'number',
+            description: 'Lines of context around each match (default: 0). Like grep -C.',
+            default: 0
+          }
+        },
+        required: ['pattern']
+      }
+    },
   ]
 }));
 
@@ -4053,7 +4168,7 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
     // These tools have filesystem/di.xml fallbacks — work without serve process
     'magento_find_class', 'magento_find_method', 'magento_find_plugin',
     'magento_find_observer', 'magento_find_di_wiring', 'magento_module_structure',
-    'magento_batch', 'magento_find_config', 'magento_find_callers'];
+    'magento_batch', 'magento_find_config', 'magento_find_callers', 'magento_grep'];
   if (warmupInProgress && !indexFreeTools.includes(name)) {
     logToFile('REQ', `${name} → blocked (warmup: loading index)`);
     return {
@@ -5868,6 +5983,24 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
                 }
                 break;
               }
+              case 'magento_grep': {
+                const searchPath = a.path || '.';
+                const include = a.include || '*.php';
+                const maxRes = Math.min(a.maxResults || 30, 100);
+                const gArgs = ['-rn'];
+                if (a.ignoreCase) gArgs.push('-i');
+                if (a.context) gArgs.push('-C', String(a.context));
+                for (const pat of include.split(',').map(p => p.trim())) gArgs.push('--include=' + pat);
+                gArgs.push('--', a.pattern, searchPath);
+                let out;
+                try {
+                  out = execFileSync('grep', gArgs, { cwd: config.magentoRoot, encoding: 'utf-8', timeout: 15000, maxBuffer: 5 * 1024 * 1024, stdio: ['pipe', 'pipe', 'pipe'] });
+                } catch (err) { out = err.stdout || ''; }
+                const gLines = out.trim().split('\n').filter(Boolean);
+                text = `Found ${gLines.length} matches${gLines.length > maxRes ? ` (showing ${maxRes})` : ''}:\n`;
+                for (const gl of gLines.slice(0, maxRes)) text += gl + '\n';
+                break;
+              }
               default:
                 text = `Unsupported batch tool: ${q.tool}`;
             }
@@ -5884,6 +6017,42 @@ server.setRequestHandler(CallToolRequestSchema, async (request) => {
         return { content: [{ type: 'text', text }] };
       }
 
+      case 'magento_grep': {
+        const root = config.magentoRoot;
+        if (!root) return { content: [{ type: 'text', text: 'MAGENTO_ROOT not set.' }], isError: true };
+        const searchPath = args.path || '.';
+        const include = args.include || '*.php';
+        const maxResults = Math.min(args.maxResults || 50, 200);
+        const grepArgs = ['-rn'];
+        if (args.ignoreCase) grepArgs.push('-i');
+        if (args.context) grepArgs.push('-C', String(args.context));
+        // Support multiple include patterns (e.g., "*.{php,xml}")
+        for (const pat of include.split(',').map(p => p.trim())) {
+          grepArgs.push('--include=' + pat);
+        }
+        grepArgs.push('--', args.pattern, searchPath);
+        let output;
+        try {
+          output = execFileSync('grep', grepArgs, {
+            cwd: root, encoding: 'utf-8', timeout: 30000,
+            maxBuffer: 10 * 1024 * 1024,
+            stdio: ['pipe', 'pipe', 'pipe']
+          });
+        } catch (err) {
+          // grep returns exit code 1 when no matches found
+          output = err.stdout || '';
+        }
+        const lines = output.trim().split('\n').filter(Boolean);
+        const total = lines.length;
+        const truncated = lines.slice(0, maxResults);
+        let text = `## grep: \`${args.pattern}\`\n`;
+        text += `Found **${total}** matches${total > maxResults ? ` (showing first ${maxResults})` : ''}\n\n`;
+        for (const line of truncated) {
+          text += line + '\n';
+        }
+        return { content: [{ type: 'text', text }] };
+      }
+
       default:
         return {
           content: [{