magector 2.16.9 → 2.16.11

package/README.md

@@ -1029,9 +1029,15 @@ lib/internal
 The `magento_trace_config` tool can show actual database config values alongside code analysis. Export your `core_config_data` table as JSON and place files in `.magector/config-data/`:
 
 ```bash
-# Export from MySQL (one-time per environment)
+# MySQL 8.0+ with --json flag
 mysql -u user -p magento_db -e "SELECT scope, scope_id, path, value FROM core_config_data" --json > .magector/config-data/CZ-production.json
 
+# Older MySQL (no --json): pipe through python3
+mysql -u user -p magento_db -B -e "SELECT scope, scope_id, path, value FROM core_config_data" | \
+  python3 -c "import sys,json; lines=sys.stdin.read().strip().split('\n'); h=lines[0].split('\t'); \
+  rows=[dict(zip(h,l.split('\t'))) for l in lines[1:]]; [r.update({'scope_id':int(r['scope_id'])}) for r in rows]; \
+  json.dump(rows,sys.stdout,indent=2)" > .magector/config-data/CZ-production.json
+
 # Or from n8n/API/any tool that produces:
 # [{scope, scope_id, path, value}, ...]
 ```

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "magector",
-  "version": "2.16.9",
+  "version": "2.16.11",
   "description": "Semantic code search for Magento 2 — index, search, MCP server",
   "type": "module",
   "main": "src/mcp-server.js",
@@ -33,10 +33,10 @@
     "ruvector": "^0.1.96"
   },
   "optionalDependencies": {
-    "@magector/cli-darwin-arm64": "2.16.9",
-    "@magector/cli-linux-x64": "2.16.9",
-    "@magector/cli-linux-arm64": "2.16.9",
-    "@magector/cli-win32-x64": "2.16.9"
+    "@magector/cli-darwin-arm64": "2.16.11",
+    "@magector/cli-linux-x64": "2.16.11",
+    "@magector/cli-linux-arm64": "2.16.11",
+    "@magector/cli-win32-x64": "2.16.11"
   },
   "keywords": [
     "magento",

package/src/mcp-server.js

@@ -492,6 +492,26 @@ let reindexTotalFiles = 0;
 let reindexItemsToEmbed = 0;
 let reindexPhase2Start = null;
 
+/**
+ * Build a short reindex progress message for tool responses.
+ * Returns null when not reindexing.
+ */
+function getReindexWarning() {
+  if (!reindexInProgress) return null;
+  const phases = ['initializing', 'AST analysis', 'embedding generation', 'building HNSW graph'];
+  const phase = phases[reindexPhase] || 'in progress';
+  const elapsed = reindexStartTime ? Math.round((Date.now() - reindexStartTime) / 1000) : 0;
+  let msg = `⚠️ Re-indexing ${phase}`;
+  if (elapsed > 0) msg += ` (${elapsed}s elapsed)`;
+  if (reindexPhase === 2 && reindexPhase2Start && reindexItemsToEmbed > 0) {
+    const p2elapsed = (Date.now() - reindexPhase2Start) / 1000;
+    const rate = p2elapsed > 0 ? Math.round(reindexItemsToEmbed * (p2elapsed / reindexItemsToEmbed)) : 0;
+    if (rate > 0) msg += ` — ETA ~${Math.round((reindexItemsToEmbed / (p2elapsed > 0 ? reindexItemsToEmbed / p2elapsed : 1)) * (1 - p2elapsed / rate))}s`;
+  }
+  msg += '. Results may be from previous index or incomplete.';
+  return msg;
+}
+
 /**
  * Check if the database file is compatible with the current binary.
  * Uses a cached result to avoid running stats (30-60s) on every startup.
@@ -1978,6 +1998,7 @@ async function traceDependency(className, direction = 'both') {
     plugins: [],
     virtualTypes: [],
     argumentOverrides: [],
+    argumentInjections: [],
     totalDiFiles: diFiles.length
   };
 
@@ -2045,6 +2066,54 @@ async function traceDependency(className, direction = 'both') {
           }
         }
       }
+
+      // Find argument injections: className used as an argument VALUE in any <type> or <virtualType> block.
+      // Catches cases where an interface is injected via constructor argument, e.g.:
+      //   <virtualType name="SomeVT" type="SomeClass">
+      //     <argument name="validator" xsi:type="object">My\Interface</argument>
+      //   </virtualType>
+      const allBlockRegex = /<(?:type|virtualType)\s+name="([^"]+)"[^>]*(?:type="([^"]+)")?[^>]*>([\s\S]*?)<\/(?:type|virtualType)>/g;
+      let blockMatch;
+      while ((blockMatch = allBlockRegex.exec(content)) !== null) {
+        const blockName = blockMatch[1];
+        const blockType = blockMatch[2] || null;
+        const blockBody = blockMatch[3];
+        // Skip if this block IS the target (already covered above)
+        if (blockName.toLowerCase().includes(classLower)) continue;
+
+        // Search argument values for the className
+        const objArgRegex = /<argument\s+name="([^"]+)"[^>]*xsi:type="object"[^>]*>([^<]*)<\/argument>/g;
+        let oMatch;
+        while ((oMatch = objArgRegex.exec(blockBody)) !== null) {
+          const argValue = oMatch[2].trim();
+          if (argValue.toLowerCase().includes(classLower) || argValue.toLowerCase().includes(classShort)) {
+            result.argumentInjections.push({
+              injectedAs: argValue,
+              intoBlock: blockName,
+              blockType: blockType,
+              argumentName: oMatch[1],
+              file: relativePath
+            });
+          }
+        }
+
+        // Also check <item> values inside array arguments
+        const itemRegex = /<item\s+name="([^"]+)"[^>]*xsi:type="object"[^>]*>([^<]*)<\/item>/g;
+        let iMatch;
+        while ((iMatch = itemRegex.exec(blockBody)) !== null) {
+          const itemValue = iMatch[2].trim();
+          if (itemValue.toLowerCase().includes(classLower) || itemValue.toLowerCase().includes(classShort)) {
+            result.argumentInjections.push({
+              injectedAs: itemValue,
+              intoBlock: blockName,
+              blockType: blockType,
+              argumentName: iMatch[1],
+              isArrayItem: true,
+              file: relativePath
+            });
+          }
+        }
+      }
     }
   }
 
@@ -3945,9 +4014,11 @@ function formatTraceConfigResult(result) {
     let hasData = false;
     try { hasData = existsSync(dataDir) && readdirSync(dataDir).some(f => f.endsWith('.json')); } catch {}
     if (!hasData) {
-      text += '### Actual Values\nNo config-data exports found. Export `core_config_data` to `.magector/config-data/{env}.json` (format: `[{scope, scope_id, path, value}, ...]`).\n\n';
+      text += '### Actual Values\n**ACTION REQUIRED:** No config-data exports found. Ask the user to export `core_config_data` from their database and place the JSON file at `.magector/config-data/{country}-{environment}.json` (format: `[{scope, scope_id, path, value}, ...]`). Without this data, actual config values cannot be shown.\n\n';
     } else {
-      text += '### Actual Values\nNo matching values found in config-data exports.\n\n';
+      // Show which environments ARE available so agent knows what's missing
+      const availableEnvs = Object.keys(loadAllConfigData()).join(', ');
+      text += `### Actual Values\nNo matching values found in available exports (${availableEnvs}). If you need values from a different environment, ask the user to provide the export.\n\n`;
     }
   }
 
@@ -4789,7 +4860,7 @@ server.setRequestHandler(ListToolsRequestSchema, async () => ({
     },
     {
       name: 'magento_trace_config',
-      description: 'Trace a Magento config path end-to-end: finds system.xml admin definition (label, type, source_model), PHP classes that read the value, and actual DB values from config-data exports. Use when investigating config-driven behavior ("why is this feature enabled/disabled?", "what controls marketplace payment methods?"). Accepts either an exact config path or a keyword to search for.',
+      description: 'Trace a Magento config path end-to-end: finds system.xml admin definition (label, type, source_model), PHP classes that read the value, and actual DB values from config-data exports. Use when investigating config-driven behavior ("why is this feature enabled/disabled?", "what controls marketplace payment methods?"). Accepts either an exact config path or a keyword to search for. IMPORTANT: If the output says no config-data exports are available, or if the analysis needs config values from a country/environment not yet exported, ask the user to provide the export. They can run a one-time MySQL query and place the JSON file in .magector/config-data/{country}-{environment}.json.',
       inputSchema: {
         type: 'object',
         properties: {
@@ -4966,10 +5037,12 @@ const _callToolHandler = async (request) => {
         }
         // SONA: record search with results for follow-up tracking
         sessionTracker.recordToolCall(name, args || {}, arr);
+        const reindexWarn = getReindexWarning();
+        const searchOutput = formatSearchResults(results.slice(0, args.limit || 5));
         return {
           content: [{
             type: 'text',
-            text: formatSearchResults(results.slice(0, args.limit || 5))
+            text: reindexWarn ? `${reindexWarn}\n\n${searchOutput}` : searchOutput
           }]
         };
       }
@@ -6022,6 +6095,15 @@ const _callToolHandler = async (request) => {
         const result = await traceFlow(entryPoint, entryType, depth);
         result.summary = buildTraceSummary(result);
 
+        const reindexWarn = getReindexWarning();
+        if (reindexWarn) result.warning = reindexWarn;
+
+        // Detect empty trace — likely caused by search unavailability
+        const traceKeys = Object.keys(result.trace || {});
+        if (traceKeys.length === 0 && reindexInProgress) {
+          result.warning = '⚠️ Re-indexing in progress — trace returned empty results. Search-dependent tracing will produce accurate results once re-indexing completes.';
+        }
+
         return {
           content: [{
             type: 'text',
@@ -6068,8 +6150,21 @@ const _callToolHandler = async (request) => {
           text += '\n';
         }
 
-        if (diResult.preferences.length === 0 && diResult.plugins.length === 0 &&
-            diResult.virtualTypes.length === 0 && diResult.argumentOverrides.length === 0) {
+        if (diResult.argumentInjections && diResult.argumentInjections.length > 0) {
+          text += `### Argument Injections (${diResult.argumentInjections.length})\n`;
+          text += `_This class is injected as a constructor argument value in the following blocks:_\n`;
+          for (const a of diResult.argumentInjections) {
+            const blockLabel = a.blockType ? `\`${a.intoBlock}\` (type: \`${a.blockType}\`)` : `\`${a.intoBlock}\``;
+            const itemTag = a.isArrayItem ? ' [array item]' : '';
+            text += `- ${blockLabel} → argument \`${a.argumentName}\`${itemTag} = \`${a.injectedAs}\` (${a.file})\n`;
+          }
+          text += '\n';
+        }
+
+        const totalFound = diResult.preferences.length + diResult.plugins.length +
+            diResult.virtualTypes.length + diResult.argumentOverrides.length +
+            (diResult.argumentInjections?.length || 0);
+        if (totalFound === 0) {
           text += '_No DI configuration found for this class. It may use default Magento auto-resolution or be configured under a different name._\n';
         }