magector 1.3.2 → 1.3.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "magector",
-  "version": "1.3.2",
+  "version": "1.3.4",
   "description": "Semantic code search for Magento 2 — index, search, MCP server",
   "type": "module",
   "main": "src/mcp-server.js",
@@ -33,10 +33,10 @@
     "ruvector": "^0.1.96"
   },
   "optionalDependencies": {
-    "@magector/cli-darwin-arm64": "1.3.2",
-    "@magector/cli-linux-x64": "1.3.2",
-    "@magector/cli-linux-arm64": "1.3.2",
-    "@magector/cli-win32-x64": "1.3.2"
+    "@magector/cli-darwin-arm64": "1.3.4",
+    "@magector/cli-linux-x64": "1.3.4",
+    "@magector/cli-linux-arm64": "1.3.4",
+    "@magector/cli-win32-x64": "1.3.4"
   },
   "keywords": [
     "magento",

package/src/init.js

@@ -6,7 +6,7 @@ import { execFileSync } from 'child_process';
 import path from 'path';
 import { resolveBinary } from './binary.js';
 import { ensureModels } from './model.js';
-import { CURSORRULES } from './templates/cursorrules.js';
+import { CURSOR_RULES_MDC } from './templates/cursor-rules-mdc.js';
 import { CLAUDE_MD } from './templates/claude-md.js';
 
 /**
@@ -39,7 +39,7 @@ function isMagentoProject(projectPath) {
 function detectIDEs(projectPath) {
   const cursor =
     existsSync(path.join(projectPath, '.cursor')) ||
-    existsSync(path.join(projectPath, '.cursorrules'));
+    existsSync(path.join(projectPath, '.cursor', 'rules'));
   const claude =
     existsSync(path.join(projectPath, '.claude')) ||
     existsSync(path.join(projectPath, 'CLAUDE.md')) ||
@@ -131,9 +131,11 @@ function writeRules(projectPath, ides) {
   const writeClaude = ides.claude || (!ides.cursor && !ides.claude);
 
   if (writeCursor) {
-    const rulesPath = path.join(projectPath, '.cursorrules');
-    const result = upsertMagectorSection(rulesPath, CURSORRULES, MARKER_START, MARKER_END);
-    written.push(`.cursorrules (${result})`);
+    const rulesDir = path.join(projectPath, '.cursor', 'rules');
+    mkdirSync(rulesDir, { recursive: true });
+    const mdcPath = path.join(rulesDir, 'magector.mdc');
+    writeFileSync(mdcPath, CURSOR_RULES_MDC);
+    written.push('.cursor/rules/magector.mdc (created)');
   }
 
   if (writeClaude) {

package/src/mcp-server.js

@@ -72,8 +72,11 @@ let serveReady = false;
 let servePending = new Map();
 let serveNextId = 1;
 let serveReadline = null;
+let serveReadyPromise = null;
+let serveReadyResolve = null;
 
 function startServeProcess() {
+  serveReadyPromise = new Promise((resolve) => { serveReadyResolve = resolve; });
   try {
     const args = [
       'serve',
@@ -87,8 +90,8 @@ function startServeProcess() {
     const proc = spawn(config.rustBinary, args,
       { stdio: ['pipe', 'pipe', 'pipe'], env: rustEnv });
 
-    proc.on('error', () => { serveProcess = null; serveReady = false; });
-    proc.on('exit', () => { serveProcess = null; serveReady = false; });
+    proc.on('error', () => { serveProcess = null; serveReady = false; if (serveReadyResolve) { serveReadyResolve(false); serveReadyResolve = null; } });
+    proc.on('exit', () => { serveProcess = null; serveReady = false; if (serveReadyResolve) { serveReadyResolve(false); serveReadyResolve = null; } });
     proc.stderr.on('data', () => {}); // drain stderr
 
     serveReadline = createInterface({ input: proc.stdout });
@@ -99,6 +102,7 @@ function startServeProcess() {
       // First line is ready signal
       if (parsed.ready) {
         serveReady = true;
+        if (serveReadyResolve) { serveReadyResolve(true); serveReadyResolve = null; }
         return;
       }
 
@@ -114,6 +118,7 @@ function startServeProcess() {
   } catch {
     serveProcess = null;
     serveReady = false;
+    if (serveReadyResolve) { serveReadyResolve(false); serveReadyResolve = null; }
   }
 }
 
@@ -138,6 +143,11 @@ async function rustSearchAsync(query, limit = 10) {
     return searchCache.get(cacheKey);
   }
 
+  // Wait for serve process if it's starting up but not yet ready
+  if (serveProcess && !serveReady && serveReadyPromise) {
+    await Promise.race([serveReadyPromise, new Promise(r => setTimeout(() => r(false), 10000))]);
+  }
+
   // Try persistent serve process first
   if (serveProcess && serveReady) {
     try {
@@ -1176,8 +1186,18 @@ async function main() {
   // Try to start persistent Rust serve process for fast queries
   try {
     startServeProcess();
-    // Give it a moment to load model+index
-    await new Promise(r => setTimeout(r, 100));
+    // Wait for the serve process to load ONNX model + HNSW index (up to 15s)
+    if (serveReadyPromise) {
+      const ready = await Promise.race([
+        serveReadyPromise,
+        new Promise(r => setTimeout(() => r(false), 15000))
+      ]);
+      if (ready) {
+        console.error('Serve process ready (persistent mode)');
+      } else {
+        console.error('Serve process not ready in time, will use fallback');
+      }
+    }
   } catch {
     // Non-fatal: falls back to execFileSync per query
   }

package/src/templates/cursor-rules-mdc.js

@@ -0,0 +1,52 @@
+/**
+ * .cursor/rules/magector.mdc content for Magento projects using Magector.
+ * This is the new Cursor rules format (MDC) that replaces .cursorrules.
+ */
+export const CURSOR_RULES_MDC = `---
+description: Magento 2 semantic code search with Magector MCP tools
+globs:
+alwaysApply: true
+---
+
+# Magento 2 Development Rules (Magector)
+
+## Semantic Search First
+
+Before reading files manually, ALWAYS use Magector MCP tools to find relevant code:
+
+1. \`magento_search\` — Natural language search across the entire codebase
+2. \`magento_find_class\` — Find a PHP class, interface, or trait
+3. \`magento_find_method\` — Find method implementations
+4. \`magento_find_config\` — Find XML configuration (di.xml, events.xml, etc.)
+5. \`magento_find_template\` — Find PHTML templates
+6. \`magento_find_plugin\` — Find interceptor plugins
+7. \`magento_find_observer\` — Find event observers
+8. \`magento_find_preference\` — Find DI preference overrides
+9. \`magento_find_api\` — Find REST/SOAP API endpoints
+10. \`magento_find_controller\` — Find controllers by route
+11. \`magento_find_block\` — Find Block classes
+12. \`magento_find_cron\` — Find cron job definitions
+13. \`magento_find_graphql\` — Find GraphQL resolvers and schema
+14. \`magento_find_db_schema\` — Find database table definitions
+15. \`magento_module_structure\` — Get full module structure
+16. \`magento_index\` — Re-index the codebase
+17. \`magento_stats\` — View index statistics
+18. \`magento_analyze_diff\` — Analyze git diffs for risk
+19. \`magento_complexity\` — Analyze code complexity
+
+## Writing Effective Queries
+
+- Describe what the code DOES, not what it IS: "calculate product price" not "price file"
+- Include Magento terms: "plugin for save", "observer for order place", "checkout totals collector"
+- Be specific: "customer address validation before checkout" not just "validation"
+
+## Magento Development Patterns
+
+- Always check for existing plugins before modifying core behavior
+- Use dependency injection — never instantiate classes with \`new\`
+- Prefer interfaces over concrete classes
+- Check events.xml for observer hooks before adding plugins
+- Use repositories for entity CRUD, not direct model save
+- Follow PSR-4 autoloading: Vendor\\\\Module\\\\Path\\\\ClassName
+- Use db_schema.xml for database changes, not setup scripts
+`;