maestro-flow 0.5.40 → 0.5.42

package/.agents/skills/odyssey-review-test-fix/SKILL.md

@@ -17,21 +17,22 @@ allowed-tools:
 <base>@~/.maestro/workflows/odyssey-base.md</base>
 
 <purpose>
-Deep code review with exhaustive fix: archaeology → explore → multi-dimensional review →
-fix ALL findings → confirm → generalize → discover → persist. Zero-residual philosophy.
+archaeology → explore → multi-dimensional review → fix ALL findings → confirm → generalize → discover → persist. Zero-residual: every finding gets an action.
 </purpose>
 
 <boundary>
-**范围内:** 目标代码的多维度深度审查 → 穷尽修复 ALL 发现（按 severity 递降）→ 泛化 pattern 到全项目
-**范围外:** 深度根因调查 → `/odyssey-debug` | 需求实现 → `/odyssey-planex` | UI 视觉优化 → `/odyssey-ui`
-**探索自由度:** 边界内自由探索 — 跨维度关联、追溯 git 历史、泛化扫描全项目。修复 ALL findings within fix_threshold（默认 all）。
-**Zero-residual principle:** Every finding MUST have a concrete action (fix / issue / decision). "Report and shelve" and "pre-existing skip" are forbidden.
+**In scope:** Multi-dimensional deep review of target code → exhaustive fix ALL findings by severity → generalize patterns project-wide.
+**Out of scope:** Root cause debug → `/odyssey-debug` | Feature implementation → `/odyssey-planex` | UI visual optimization → `/odyssey-ui`
+
+**Exploration freedom:** Free within boundary — cross-dimension correlation, git history tracing, project-wide generalization scan. Fix ALL findings within fix_threshold (default: all).
+**Zero-residual:** Every finding MUST have a concrete action (fix / issue / decision). "Report and shelve" and "pre-existing skip" are forbidden.
 </boundary>
 
 <context>
-$ARGUMENTS — target and optional flags.
+$ARGUMENTS
 
 **Target resolution:**
+
 | Input | Resolution |
 |-------|-----------|
 | File/dir path | Review those files |
@@ -39,157 +40,194 @@ $ARGUMENTS — target and optional flags.
 | Phase number | state.json → changed files |
 | PR number | `git diff main...HEAD` |
 
-**Flags:**
-| Flag | Effect | Default |
-|------|--------|---------|
-| `--dimensions` | Comma-separated subset | correctness,security,performance,architecture |
-| `--fix-threshold` | 修复到哪个 severity 为止 | `all` |
-| `--skip-fix` | Skip S_FIX + S_CONFIRM | false |
-| `--skip-generalize` | Skip S_GENERALIZE + S_DISCOVER | false |
-| `--auto` `-y` `-c` `--heartbeat` | CLI auto / auto-confirm / resume / heartbeat | false |
+**Flags:** `--dimensions <list>` subset of review dimensions | `--fix-threshold <level>` severity cutoff (default: all) | `--skip-fix` skip S_FIX+S_CONFIRM | `--skip-generalize` skip S_GENERALIZE+S_DISCOVER | `--auto` no delegate confirmation | `-y` auto-confirm | `-c` resume | `--heartbeat` /loop heartbeat
 
 **Session**: `.workflow/scratch/{YYYYMMDD}-review-odyssey-{slug}/`
-**Output**: session.json, evidence.ndjson, explore.json, understanding.md (§1-§8)
-**session.json unique fields**: `target`, `dimensions`, `review_result` (with `remaining_actionable`), `patterns[]`, `confirmation`, `generalization_stats`
-**evidence.ndjson phases**: archaeology, explore, review, fix, discovery, decision, self-iteration
+**Output**: `session.json` | `evidence.ndjson` | `explore.json` | `understanding.md`
+
+**session.json — review-specific fields:**
+```json
+{ "target": "", "dimensions": [], "review_result": {"remaining_actionable": 0},
+  "patterns": [], "confirmation": null, "generalization_stats": null }
+```
+
+**evidence.ndjson phases:** `archaeology|explore|review|fix|discovery|decision|self-iteration`
 
 **phase_goals[]:**
-| ID | Goal | Done When | Phase | skip_when |
+
+| ID | Goal | done_when | phase | skip_when |
 |----|------|-----------|-------|-----------|
 | G1 | Review completed | all dimensions reviewed | S_REVIEW | — |
 | G2 | Explore context | explore.json populated | S_EXPLORE | — |
 | G3 | Zero remaining | `remaining_actionable == 0` | S_CONFIRM | skip_fix |
-| G4 | Pattern generalized | patterns[] ≥1 | S_GENERALIZE | skip_generalize |
+| G4 | Pattern generalized | patterns[] >=1 | S_GENERALIZE | skip_generalize |
 | G5 | Discoveries triaged | all hits classified | S_DISCOVER | skip_generalize |
 | G6 | Learnings persisted | spec entries or no actionable | S_RECORD | — |
 
-### Pre-load
-Specs: `maestro load --type spec --category review`。其余按 base Pre-load。
+**understanding.md — 8 sections:**
+1. Target & Scope ← S_INTAKE | 2. Archaeology ← S_ARCHAEOLOGY | 3. Exploration ← S_EXPLORE
+4. Review Results ← S_REVIEW | 5. Fix & Confirmation ← S_FIX+S_CONFIRM
+6. Generalization ← S_GENERALIZE | 7. Discoveries ← S_DISCOVER | 8. Learnings ← S_RECORD
+
+Specs: `maestro load --type spec --category review`
+
+**Knowledge Persistence categories (section 8):**
 
-### Knowledge Persistence
-| 分类 | 后续建议命令 |
-|------|-------------|
-| 跨维度反复 pattern | `/spec-add review "..."` |
-| 安全发现 | `/spec-add debug "..."` |
-| 架构违反 pattern | `/spec-add arch "..."` |
-| 可复用泛化 pattern | `/spec-add coding "..."` |
+| Category | Content | Follow-up |
+|----------|---------|-----------|
+| Cross-dimension recurring pattern | Pattern + affected dimensions + coding standard | `/spec-add review` |
+| Security finding | Vulnerability type + triggers + fix approach | `/spec-add debug` |
+| Architecture violation pattern | Violation + correct boundary + verification | `/spec-add arch` |
+| Reusable generalization pattern | Signature + risk + fix template + scope | `/spec-add coding` |
 </context>
 
+<invariants>
+All invariants defined in base.
+</invariants>
+
 <self_iteration>
-适用阶段: S_ARCHAEOLOGY, S_EXPLORE, S_REVIEW, S_FIX, S_GENERALIZE
+Applies to: **S_ARCHAEOLOGY, S_EXPLORE, S_REVIEW, S_FIX, S_GENERALIZE**. Logic in base.
 </self_iteration>
 
 <state_machine>
+
 <states>
 S_INTAKE → S_ARCHAEOLOGY → S_EXPLORE → S_REVIEW → S_FIX → S_CONFIRM → S_GENERALIZE → S_DISCOVER → S_RECORD → END
-Skip: --skip-fix skips S_FIX+S_CONFIRM | --skip-generalize skips S_GENERALIZE+S_DISCOVER
 </states>
 
 <transitions>
-S_INTAKE  → S_INTAKE (resume/-c) | S_ARCHAEOLOGY (target resolved) | ask_user (no target)
-S_REVIEW  → S_FIX (!skip_fix AND findings) | S_GENERALIZE (skip_fix/no findings, !skip_gen) | S_RECORD (both skip)
-S_CONFIRM → S_GENERALIZE (confirmed, !skip_gen) | S_RECORD (confirmed, skip_gen) | S_FIX (needs_rework)
-S_GENERALIZE → S_DISCOVER (hits) | S_RECORD (no hits)
-S_DISCOVER → S_FIX (fixable sibling) | S_REVIEW (new target, loops < max) | S_RECORD (done or max_loops)
+S_INTAKE → S_INTAKE       : -c + session found → A_RESUME_SESSION
+S_INTAKE → S_ARCHAEOLOGY  : target resolved → A_INTAKE
+S_INTAKE → S_INTAKE       : no target → ask_user
+
+S_ARCHAEOLOGY → S_EXPLORE     : complete
+S_EXPLORE     → S_REVIEW      : complete
+
+S_REVIEW  → S_FIX          : !skip_fix AND findings
+S_REVIEW  → S_GENERALIZE   : skip_fix OR no findings, !skip_generalize
+S_REVIEW  → S_RECORD       : both skip
+
+S_FIX     → S_CONFIRM      : tier complete
+S_CONFIRM → S_GENERALIZE   : confirmed, !skip_generalize
+S_CONFIRM → S_RECORD       : confirmed, skip_generalize
+S_CONFIRM → S_FIX          : needs_rework
+
+S_GENERALIZE → S_DISCOVER  : similar code found
+S_GENERALIZE → S_RECORD    : no similar code
+
+S_DISCOVER → S_FIX         : fixable sibling → cross_phase_loops++
+S_DISCOVER → S_REVIEW      : new target, loops < max_loops → cross_phase_loops++
+S_DISCOVER → S_RECORD      : remaining_actionable == 0 OR loops >= max_loops
 </transitions>
 
 <actions>
 
 ### A_INTAKE
-Parse target + flags → file list. Create SESSION_DIR, derive phase_goals[]. Search prior knowledge. Write session.json + §1. Display Goal Prompt.
-📌 `"odyssey-review({slug}): INTAKE — 目标解析与上下文加载"`
+1. Parse target + flags → file list. Create SESSION_DIR, derive phase_goals[]
+2. `maestro search "<keywords>"` + Glob prior sessions + ARCHITECTURE.md + Grep keywords
+3. Write `session.json` + `understanding.md` section 1, emit Goal Prompt
+
+Commit: `"odyssey-review({slug}): INTAKE — parse target and load context"`
+
+### A_RESUME_SESSION
+Glob latest session → read `session.json` → jump to `current_state`.
 
 ### A_ARCHAEOLOGY
-`git log --oneline -20` + `git blame` on key regions. CLI delegate `--role analyze`. Append evidence (archaeology). Update §2.
-📌 `"odyssey-review({slug}): ARCHAEOLOGY — git 考古分析"`
+2 parallel Agents: Timeline (`git log --oneline -20 -- {files}`) + Blame (top 3 files `git blame -L {region}`). Evidence phase=archaeology.
+
+`maestro delegate --role analyze --mode analysis` (`run_in_background: true`):
+- PURPOSE: Review recent modifications related to {target}
+- EXPECTED: JSON [{commit_sha, risk_level, analysis, could_cause_issue, explanation}]
+
+Update section 2. Commit: `"odyssey-review({slug}): ARCHAEOLOGY — git history analysis"`
 
 ### A_EXPLORE
-CLI delegate `--role explore` — call chains, error gaps, similar patterns. Write explore.json. Update §3. Mark G2.
-📌 `"odyssey-review({slug}): EXPLORE — 代码探索完成"`
+Skip if no CLI tools (W006).
+
+`maestro delegate --role explore --mode analysis` (`run_in_background: true`):
+- PURPOSE: Call chains, recent changes, error gaps, similar patterns
+- EXPECTED: JSON {call_chains, recent_changes, error_gaps, similar_patterns}
+
+Write `explore.json` + evidence phase=explore. Update section 3. Mark G2. Commit: `"odyssey-review({slug}): EXPLORE — codebase exploration"`
 
 ### A_REVIEW
-Spawn N parallel Agents (one per dimension):
+Spawn N parallel Agents, one per dimension:
 - **Correctness**: logic errors, boundary conditions, null/undefined, race conditions
 - **Security**: injection, XSS, CSRF, data exposure, auth bypass
 - **Performance**: hot paths, N+1, memory leaks, unnecessary recomputation
 - **Architecture**: layer violations, circular deps, interface contracts, SoC
 
-Each returns `[{title, severity, file, line, description, suggestion, cwe}]`. Merge → evidence (review). Write review_result + §4 (severity matrix). Mark G1.
-📌 `"odyssey-review({slug}): REVIEW — 多维度审查完成"`
+Each returns `[{title, severity, file, line, description, suggestion, cwe}]`. Merge → evidence phase=review. Write `review_result` + section 4 severity matrix. Mark G1.
+
+Commit: `"odyssey-review({slug}): REVIEW — multi-dimension review complete"`
 
 ### A_FIX
-**穷尽迭代修复** — 按 severity 递降，直到 `remaining_actionable == 0`。
+Exhaustive iterative fix — descend by severity until `remaining_actionable == 0`.
 
 ```
 for tier in [critical, high, medium, low].filter(>= threshold):
-  for each unfixed candidate: read ±20 → fix → evidence (fix)
-  re-review modified area ("改进即标准"): new → append, continue (max 2/tier)
+  for each unfixed candidate: read +/-20 lines → fix → evidence phase=fix
+  re-review modified area (new findings → append, continue; max 2 per tier)
   tier done → auto-commit
 ```
 
 Normal: ask_user per tier. `-y`: auto-fix all.
 Remaining > 0 → retry (no max_loops limit). Unchanged 2 rounds → classify each individually.
-❌ Blanket "pre-existing" forbidden.
-📌 per tier: `"odyssey-review({slug}): FIX-{tier} — {N}项修复"`
+Blanket "pre-existing" forbidden.
+
+Commit per tier: `"odyssey-review({slug}): FIX-{tier} — {N} items fixed"`
 
 ### A_CONFIRM
-Run tests + CLI delegate zero-residual review (`--role review`).
+Run tests + `maestro delegate --role review --mode analysis` (`run_in_background: true`) for zero-residual review.
 - `remaining == 0 AND new == 0` → confirmed, mark G3
 - Otherwise → needs_rework → S_FIX
-Update confirmation + remaining_actionable + §5.
-📌 `"odyssey-review({slug}): CONFIRM — 零遗留验证"`
 
-### A_GENERALIZE
-按 base A_GENERALIZE 执行。Pattern 来源: findings (severity >= medium)。Mark G4.
-📌 `"odyssey-review({slug}): GENERALIZE — 泛化扫描完成"`
+Update `confirmation` + `remaining_actionable` + section 5.
 
-### A_DISCOVER
-按 base A_DISCOVER 执行。Mark G5.
-📌 `"odyssey-review({slug}): DISCOVER — 发现分类完成"`
+Commit: `"odyssey-review({slug}): CONFIRM — zero-residual verified"`
 
-### A_RECORD
-Write learnings to §8 按 Knowledge Persistence 表分类。其余按 base A_RECORD。Mark G6.
+### A_GENERALIZE, A_DISCOVER, A_RECORD
+Base shared_actions. Review overrides:
+- **A_GENERALIZE** pattern source: findings with severity >= medium
+- **A_RECORD** learnings per Knowledge Persistence table
 
+**Completion summary:**
 ```
 --- REVIEW-TEST-FIX ODYSSEY COMPLETE ---
 Target:     {target}          Dimensions: {dims}
 Findings:   {C}C {H}H {M}M {L}L    Fix: {fixed}, confirmed={yes|skip}
 Patterns:   {N} ({by_layer})        Scan hits: {total} ({cross} cross-layer)
-Issues: {N}  Decisions: {N}r/{M}p/{K}d  Learnings: {N}  Self-iter: {N}×{M}
-Goals:  {done}/{total} ({skipped} skipped)
+Issues:     {N} created
+Decisions:  {N} resolved, {M} pending, {K} deferred
+Learnings:  {N} persisted
+Self-iter:  {N} rounds across {M} stages
+Goals:      {done}/{total} ({skipped} skipped)
 ---
 ```
-📌 `"odyssey-review({slug}): RECORD — 会话总结与知识沉淀"`
 
 </actions>
 
 <appendix>
 
-### Goal Prompt
-```
-📋 Review-Test-Fix Odyssey 会话已创建。可随时复制以下 /goal：
-
-/goal 完成以下目标：
-{for each G in phase_goals where status != "skipped":}
-- {G.id}: {G.goal} — {G.done_when}
-{end for}
-穷尽迭代：review_result.remaining_actionable == 0 且 confirmation == confirmed 且 phase_goals_all_done。
-修复按 severity 逐轮迭代，每轮 re-review 修改区域，新问题追加继续。
-每个 finding 必须有 action（fix/issue/decision），decision pending 必须 ask_user。
-```
+### `-y` review-specific points
 
-### `-y` (7 decision points)
 | Decision Point | Normal | `-y` |
-|----------------|--------|------|
-| S_FIX tier candidates | ask_user | auto-fix, `deferred` |
-| S_FIX re-review new | ask_user | auto-append |
+|---------------|--------|------|
+| S_FIX tier candidates | ask_user | auto-fix, deferred |
+| S_FIX re-review new findings | ask_user | auto-append |
 | S_CONFIRM needs_rework | Display → S_FIX | auto proceed |
-| S_DISCOVER bug routing | ask_user | auto issue, `deferred` |
-| S_DISCOVER ambiguous | ask_user | all `deferred` |
-| S_RECORD decisions | ask_user | skip |
-| S_RECORD goal audit | ask_user | auto accept |
+
+### Goal Prompt convergence rules
+
+```
+Stop when remaining_actionable == 0, confirmation == confirmed,
+generalization exhausted, phase_goals_all_done=true.
+Fix iterates by severity tier; each tier re-reviews modified area, new findings appended.
+Every finding must have action (fix/issue/decision). Decision pending must ask_user.
+```
 
 </appendix>
+
 </state_machine>
 
 <error_codes>
@@ -202,17 +240,25 @@ Goals:  {done}/{total} ({skipped} skipped)
 </error_codes>
 
 <success_criteria>
-- [ ] All dimensions reviewed, ALL findings fixed (remaining_actionable == 0), zero-residual confirmed
+- [ ] Session + 4 output files + prior knowledge searched
+- [ ] Archaeology + CLI review → evidence phase=archaeology
+- [ ] CLI exploration → explore.json + evidence phase=explore
+- [ ] All dimensions reviewed, ALL findings fixed (remaining_actionable == 0)
 - [ ] Per-tier re-review gate; every unfixed finding individually classified
-- [ ] Generalized with multi-layer scan (unless --skip-generalize); self-iteration on insufficient
-- [ ] understanding.md §1-§8, phase_goals G1-G6 audited, Goal Prompt once, `-y` no blocking, -c resumable
+- [ ] understanding.md sections 1-8 progressive
+- [ ] Fix + confirmed (unless --skip-fix)
+- [ ] Generalization + scan (unless --skip-generalize)
+- [ ] Discoveries classified; unfixed findings individually justified
+- [ ] phase_goals G1-G6 audited, Goal Prompt once, `-y` no blocking, -c resumable
+- [ ] Completion summary
 </success_criteria>
 
 <next_step_routing>
-| Condition | Next step |
-|-----------|-----------|
+| Condition | Next |
+|-----------|------|
 | Deeper debug needed | `/odyssey-debug "<finding>"` |
 | Issues created | `/manage-issue list --source review-odyssey` |
-| Pattern to document | `/learn-decompose <module>` |
+| Document pattern | `/learn-decompose <module>` |
 | Plan fixes | `/maestro-plan --gaps` |
 </next_step_routing>
+</output>