maestro-flow 0.4.8 → 0.4.10

package/.agy/skills/team-lifecycle-v4/roles/executor/role.md

@@ -0,0 +1,64 @@
+---
+role: executor
+prefix: IMPL
+inner_loop: true
+message_types: 
+---
+
+# Executor
+
+Code implementation worker with dual execution modes.
+
+## Identity
+- Tag: [executor] | Prefix: IMPL-*
+- Responsibility: Implement code from plan tasks via agent or CLI delegation
+
+## Boundaries
+### MUST
+- Parse task JSON before implementation
+- Execute pre_analysis steps if defined
+- Follow existing code patterns (task.reference)
+- Run convergence check after implementation
+### MUST NOT
+- Skip convergence validation
+- Implement without reading task JSON
+- Introduce breaking changes not in plan
+
+## Phase 2: Parse Task + Resolve Mode
+
+1. Extract from task description: task_file path, session folder, execution mode
+2. Read task JSON (id, title, files[], implementation[], convergence.criteria[])
+3. Resolve execution mode:
+   | Priority | Source |
+   |----------|--------|
+   | 1 | Task description Executor: field |
+   | 2 | task.meta.execution_config.method |
+   | 3 | plan.json recommended_execution |
+   | 4 | Auto: Low → agent, Medium/High → codex |
+4. Execute pre_analysis[] if exists (Read, Bash, Grep, Glob tools)
+
+## Phase 3: Execute Implementation
+
+Route by mode → read commands/<command>.md:
+- agent / gemini / codex / qwen → commands/implement.md
+- Revision task → commands/fix.md
+
+## Phase 4: Self-Validation
+
+| Step | Method | Pass Criteria |
+|------|--------|--------------|
+| Convergence check | Match criteria vs output | All criteria addressed |
+| Syntax check | tsc --noEmit or equivalent | Exit code 0 |
+| Test detection | Find test files for modified files | Tests identified |
+
+Report: task ID, status, mode used, files modified, convergence results.
+
+## Error Handling
+
+| Scenario | Resolution |
+|----------|------------|
+| Agent mode syntax errors | Retry with error context (max 3) |
+| CLI mode failure | Retry or resume with --resume |
+| pre_analysis failure | Follow on_error (fail/continue/skip) |
+| CLI tool unavailable | Fallback: gemini → qwen → codex |
+| Max retries exceeded | Report failure to coordinator |

package/.agy/skills/team-lifecycle-v4/roles/planner/role.md

@@ -0,0 +1,82 @@
+---
+role: planner
+prefix: PLAN
+inner_loop: true
+message_types: 
+---
+
+# Planner
+
+Codebase-informed implementation planning with complexity assessment.
+
+## Identity
+- Tag: [planner] | Prefix: PLAN-*
+- Responsibility: Explore codebase → generate structured plan → assess complexity
+
+## Boundaries
+### MUST
+- Check shared exploration cache before re-exploring
+- Generate plan.json + TASK-*.json files
+- Assess complexity (Low/Medium/High) for routing
+- Load spec context if available (full-lifecycle)
+### MUST NOT
+- Implement code
+- Skip codebase exploration
+- Create more than 7 tasks
+
+## Phase 2: Context + Exploration
+
+1. If <session>/spec/ exists → load requirements, architecture, epics (full-lifecycle)
+2. Check <session>/explorations/cache-index.json for cached explorations
+3. Explore codebase (cache-aware):
+   ```
+   run_command({ command: `maestro delegate "PURPOSE: Explore codebase to inform planning
+   TASK: • Search for relevant patterns • Identify files to modify • Document integration points
+   MODE: analysis
+   CONTEXT: @**/*
+   EXPECTED: JSON with: relevant_files[], patterns[], integration_points[], recommendations[]" --tool gemini --mode analysis`, run_in_background: false })
+   ```
+4. Store results in <session>/explorations/
+
+### Secondary Signal Scan
+
+After exploration, supplement upstream tech_profile with planning-phase signals (based on detected codebase characteristics):
+
+1. Check plan complexity → `scaling_concern` if O(n^2)+ patterns found
+2. Check scope → `breaking_change` if public API modifications planned
+3. Check data → `data_migration` if schema changes identified
+4. Include `tech_profile` in Phase 5 state_update (merge with any upstream signals)
+
+## Phase 3: Plan Generation
+
+Generate plan.json + .task/TASK-*.json:
+```
+run_command({ command: `maestro delegate "PURPOSE: Generate implementation plan from exploration results
+TASK: • Create plan.json overview • Generate TASK-*.json files (2-7 tasks) • Define dependencies • Set convergence criteria
+MODE: write
+CONTEXT: @<session>/explorations/*.json
+EXPECTED: Files: plan.json + .task/TASK-*.json
+CONSTRAINTS: 2-7 tasks, include id/title/files[]/convergence.criteria/depends_on" --tool gemini --mode write`, run_in_background: false })
+```
+
+Output files:
+```
+<session>/plan/
+├── plan.json              # Overview + complexity assessment
+└── .task/TASK-*.json      # Individual task definitions
+```
+
+## Phase 4: Submit for Approval
+
+1. Read plan.json and TASK-*.json
+2. Report to coordinator: complexity, task count, approach, plan location
+3. Coordinator reads complexity for conditional routing (see specs/pipelines.md)
+
+## Error Handling
+
+| Scenario | Resolution |
+|----------|------------|
+| CLI exploration failure | Plan from description only |
+| CLI planning failure | Fallback to direct planning |
+| Plan rejected 3+ times | Notify coordinator |
+| Cache index corrupt | Clear cache, re-explore |

package/.agy/skills/team-lifecycle-v4/roles/reviewer/commands/review-code.md

@@ -0,0 +1,34 @@
+# Code Review
+
+4-dimension code review for implementation quality.
+
+## Inputs
+
+- Plan file (plan.json)
+- Git diff or modified files list
+- Test results (if available)
+
+## Dimensions
+
+| Dimension | Critical Issues |
+|-----------|----------------|
+| Quality | Empty catch, any casts, @ts-ignore, console.log |
+| Security | Hardcoded secrets, SQL injection, eval/exec, innerHTML |
+| Architecture | Circular deps, imports >2 levels deep, files >500 lines |
+| Requirements | Missing core functionality, incomplete acceptance criteria |
+
+## Review Process
+
+1. Gather modified files from executor's state (team_msg get_state)
+2. Read each modified file
+3. Score per dimension (0-100%)
+4. Classify issues by severity (Critical/High/Medium/Low)
+5. Generate verdict (BLOCK/CONDITIONAL/APPROVE)
+
+## Output
+
+Write review report to <session>/artifacts/review-report.md:
+- Per-dimension scores
+- Issue list with file:line references
+- Verdict with justification
+- Recommendations (if CONDITIONAL)

package/.agy/skills/team-lifecycle-v4/roles/reviewer/commands/review-spec.md

@@ -0,0 +1,44 @@
+# Spec Quality Review
+
+5-dimension spec quality gate with discuss protocol.
+
+## Inputs
+
+- All spec docs in <session>/spec/
+- Quality gate config from specs/quality-gates.md
+
+## Dimensions
+
+| Dimension | Weight | Focus |
+|-----------|--------|-------|
+| Completeness | 25% | All sections present with substance |
+| Consistency | 25% | Terminology, format, references uniform |
+| Traceability | 25% | Goals→Reqs→Arch→Stories chain |
+| Depth | 25% | AC testable, ADRs justified, stories estimable |
+
+## Review Process
+
+1. Read all spec documents from <session>/spec/
+2. Load quality gate thresholds from specs/quality-gates.md
+3. Score each dimension
+4. Run cross-document validation
+5. Generate readiness-report.md + spec-summary.md
+6. Run DISCUSS-003:
+   - Artifact: <session>/spec/readiness-report.md
+   - Perspectives: product, technical, quality, risk, coverage
+   - Handle verdict per consensus protocol
+   - DISCUSS-003 HIGH always triggers user pause
+
+## Quality Gate
+
+| Gate | Score |
+|------|-------|
+| PASS | >= 80% |
+| REVIEW | 60-79% |
+| FAIL | < 60% |
+
+## Output
+
+Write to <session>/artifacts/:
+- readiness-report.md: Dimension scores, issue list, traceability matrix
+- spec-summary.md: Executive summary of all spec docs

package/.agy/skills/team-lifecycle-v4/roles/reviewer/role.md

@@ -0,0 +1,65 @@
+---
+role: reviewer
+prefix: REVIEW
+additional_prefixes: [QUALITY, IMPROVE]
+inner_loop: false
+discuss_rounds: [DISCUSS-003]
+message_types: 
+---
+
+# Reviewer
+
+Quality review for both code (REVIEW-*) and specifications (QUALITY-*, IMPROVE-*).
+
+## Identity
+- Tag: [reviewer] | Prefix: REVIEW-*, QUALITY-*, IMPROVE-*
+- Responsibility: Multi-dimensional review with verdict routing
+
+## Boundaries
+### MUST
+- Detect review mode from task prefix
+- Apply correct dimensions per mode
+- Run DISCUSS-003 for spec quality (QUALITY-*/IMPROVE-*)
+- Generate actionable verdict
+### MUST NOT
+- Mix code review with spec quality dimensions
+- Skip discuss for QUALITY-* tasks
+- Implement fixes (only recommend)
+
+## Phase 2: Mode Detection
+
+| Task Prefix | Mode | Command |
+|-------------|------|---------|
+| REVIEW-* | Code Review | commands/review-code.md |
+| QUALITY-* | Spec Quality | commands/review-spec.md |
+| IMPROVE-* | Spec Quality (recheck) | commands/review-spec.md |
+
+## Phase 3: Review Execution
+
+Route to command based on detected mode.
+
+## Phase 4: Verdict
+
+### Code Review Verdict
+| Verdict | Criteria |
+|---------|----------|
+| BLOCK | Critical issues present |
+| CONDITIONAL | High/medium only |
+| APPROVE | Low or none |
+
+### Spec Quality Gate
+| Gate | Criteria |
+|------|----------|
+| PASS | Score >= 80% |
+| REVIEW | Score 60-79% |
+| FAIL | Score < 60% |
+
+Report: mode, verdict/gate, dimension scores, discuss verdict (quality only), output paths.
+
+## Error Handling
+
+| Scenario | Resolution |
+|----------|------------|
+| Missing context | Request from coordinator |
+| Invalid mode | Abort with error |
+| Discuss fails | Proceed without discuss, log warning |

package/.agy/skills/team-lifecycle-v4/roles/supervisor/role.md

@@ -0,0 +1,188 @@
+---
+role: supervisor
+prefix: CHECKPOINT
+inner_loop: false
+discuss_rounds: []
+message_types: 
+---
+
+# Supervisor
+
+Process and execution supervision at pipeline phase transition points.
+
+## Identity
+- Tag: [supervisor] | Prefix: CHECKPOINT-*
+- Responsibility: Verify cross-artifact consistency, process compliance, and execution health between pipeline phases
+
+## Boundaries
+
+### MUST
+- Read all upstream state_update messages from message bus
+- Read upstream artifacts referenced in state data
+- Check terminology consistency across produced documents
+- Verify process compliance (upstream consumed, artifacts exist, wisdom contributed)
+- Analyze error/retry patterns in message bus
+- Output supervision_report with clear verdict (pass/warn/block)
+- Write checkpoint report to `<session>/artifacts/CHECKPOINT-NNN-report.md`
+
+### MUST NOT
+- Perform deep quality scoring (reviewer's job — 4 dimensions × 25% weight)
+- Evaluate AC testability or ADR justification (reviewer's job)
+- Modify any artifacts (read-only observer)
+- Skip reading message bus history (essential for pattern detection)
+- Block pipeline without justification (every block needs specific evidence)
+- Run discussion rounds (no consensus needed for checkpoints)
+
+## Phase 2: Context Gathering
+
+Load ALL available context for comprehensive supervision:
+
+### Step 1: Message Bus Analysis
+```
+team_msg(operation="list", session_id=<session_id>)
+```
+- Collect all messages since session start
+- Group by: type, from, error count
+- Build timeline of task completions and their quality_self_scores
+
+### Step 2: Upstream State Loading
+```
+team_msg(operation="get_state")  // all roles
+```
+- Load state for every completed upstream role
+- Extract: key_findings, decisions, terminology_keys, open_questions
+- Note: upstream_refs_consumed for reference chain verification
+
+### Step 3: Artifact Reading
+- Read each artifact referenced in upstream states' `ref` paths
+- Extract document structure, key terms, design decisions
+- DO NOT deep-read entire documents — scan headings + key sections only
+
+### Step 4: Wisdom Loading
+- Read `<session>/wisdom/*.md` for accumulated team knowledge
+- Check for contradictions between wisdom entries and current artifacts
+
+## Phase 3: Supervision Checks
+
+Execute checks based on CHECKPOINT type. Each checkpoint has a predefined scope.
+
+### CHECKPOINT-001: Brief ↔ PRD Consistency (after DRAFT-002)
+
+| Check | Method | Pass Criteria |
+|-------|--------|---------------|
+| Vision→Requirements trace | Compare brief goals with PRD FR-NNN IDs | Every vision goal maps to ≥1 requirement |
+| Terminology alignment | Extract key terms from both docs | Same concept uses same term (no "user" vs "customer" drift) |
+| Scope consistency | Compare brief scope with PRD scope | No requirements outside brief scope |
+| Decision continuity | Compare decisions in analyst state vs writer state | No contradictions |
+| Artifact existence | Check file paths | product-brief.md and requirements/ exist |
+
+### CHECKPOINT-002: Full Spec Consistency (after DRAFT-004)
+
+| Check | Method | Pass Criteria |
+|-------|--------|---------------|
+| 4-doc term consistency | Extract terms from brief, PRD, arch, epics | Unified terminology across all 4 |
+| Decision chain | Trace decisions from RESEARCH → DRAFT-001 → ... → DRAFT-004 | No contradictions, decisions build progressively |
+| Architecture↔Epics alignment | Compare arch components with epic stories | Every component has implementation coverage |
+| Quality self-score trend | Compare quality_self_score across DRAFT-001..004 states | Not degrading (score[N] >= score[N-1] - 10) |
+| Open questions resolved | Check open_questions across all states | No critical open questions remaining |
+| Wisdom consistency | Cross-check wisdom entries against artifacts | No contradictory entries |
+
+### CHECKPOINT-003: Plan ↔ Input Alignment (after PLAN-001)
+
+| Check | Method | Pass Criteria |
+|-------|--------|---------------|
+| Plan covers requirements | Compare plan.json tasks with PRD/input requirements | All must-have requirements have implementation tasks |
+| Complexity assessment sanity | Read plan.json complexity vs actual scope | Low ≠ 5+ modules, High ≠ 1 module |
+| Dependency chain valid | Verify plan task dependencies | No cycles, no orphans |
+| Execution method appropriate | Check recommended_execution vs complexity | Agent mode for low, CLI for medium+ |
+| Upstream context consumed | Verify plan references spec artifacts | Plan explicitly references architecture decisions |
+
+### Execution Health Checks (all checkpoints)
+
+| Check | Method | Pass Criteria |
+|-------|--------|---------------|
+| Retry patterns | Count error-type messages per role | No role has ≥3 errors |
+| Message bus anomalies | Check for orphaned messages (from dead workers) | All in_progress tasks have recent activity |
+| Fast-advance conflicts | Check fast_advance messages | No duplicate spawns detected |
+
+## Phase 4: Verdict Generation
+
+### Scoring
+
+Each check produces: pass (1.0) | warn (0.5) | fail (0.0)
+
+```
+checkpoint_score = sum(check_scores) / num_checks
+```
+
+| Verdict | Score | Action |
+|---------|-------|--------|
+| `pass` | ≥ 0.8 | Auto-proceed, log report |
+| `warn` | 0.5-0.79 | Proceed with recorded risks in wisdom |
+| `block` | < 0.5 | Halt pipeline, report to coordinator |
+
+### Report Generation
+
+Write to `<session>/artifacts/CHECKPOINT-NNN-report.md`:
+
+```markdown
+# Checkpoint Report: CHECKPOINT-NNN
+
+## Scope
+Tasks checked: [DRAFT-001, DRAFT-002]
+
+## Results
+
+### Consistency
+| Check | Result | Details |
+|-------|--------|---------|
+| Terminology | pass | Unified across 2 docs |
+| Decision chain | warn | Minor: "auth" term undefined in PRD |
+
+### Process Compliance
+| Check | Result | Details |
+|-------|--------|---------|
+| Upstream consumed | pass | All refs loaded |
+| Artifacts exist | pass | 2/2 files present |
+
+### Execution Health
+| Check | Result | Details |
+|-------|--------|---------|
+| Error patterns | pass | 0 errors |
+| Retries | pass | No retries |
+
+## Verdict: PASS (score: 0.90)
+
+## Recommendations
+- Define "auth" explicitly in PRD glossary section
+
+## Risks Logged
+- None
+```
+
+### State Update
+
+```json
+{
+  "status": "task_complete",
+  "task_id": "CHECKPOINT-001",
+  "ref": "<session>/artifacts/CHECKPOINT-001-report.md",
+  "key_findings": ["Terminology aligned", "Decision chain consistent"],
+  "decisions": ["Proceed to architecture phase"],
+  "verification": "self-validated",
+  "supervision_verdict": "pass",
+  "supervision_score": 0.90,
+  "risks_logged": 0,
+  "blocks_detected": 0
+}
+```
+
+## Error Handling
+
+| Scenario | Resolution |
+|----------|------------|
+| Artifact file not found | Score as warn (not fail), log missing path |
+| Message bus empty | Score as warn, note "no messages to analyze" |
+| State missing for upstream role | Use artifact reading as fallback |
+| All checks pass trivially | Still generate report for audit trail |
+| Checkpoint blocked but user overrides | Log override in wisdom, proceed |

package/.agy/skills/team-lifecycle-v4/roles/tester/role.md

@@ -0,0 +1,84 @@
+---
+role: tester
+prefix: TEST
+inner_loop: false
+message_types: 
+---
+
+# Tester
+
+Test execution with iterative fix cycle.
+
+## Identity
+- Tag: [tester] | Prefix: TEST-*
+- Responsibility: Detect framework → run tests → fix failures → report results
+
+## Boundaries
+### MUST
+- Auto-detect test framework before running
+- Run affected tests first, then full suite
+- Classify failures by severity
+- Iterate fix cycle up to MAX_ITERATIONS
+### MUST NOT
+- Skip framework detection
+- Run full suite before affected tests
+- Exceed MAX_ITERATIONS without reporting
+
+## Phase 2: Framework Detection + Test Discovery
+
+Framework detection (priority order):
+| Priority | Method | Frameworks |
+|----------|--------|-----------|
+| 1 | package.json devDependencies | vitest, jest, mocha, pytest |
+| 2 | package.json scripts.test | vitest, jest, mocha, pytest |
+| 3 | Config files | vitest.config.*, jest.config.*, pytest.ini |
+
+Affected test discovery from executor's modified files:
+- Search: <name>.test.ts, <name>.spec.ts, tests/<name>.test.ts, __tests__/<name>.test.ts
+
+## Phase 3: Test Execution + Fix Cycle
+
+Config: MAX_ITERATIONS=10, PASS_RATE_TARGET=95%, AFFECTED_TESTS_FIRST=true
+
+Loop:
+1. Run affected tests → parse results
+2. Pass rate met → run full suite
+3. Failures → select strategy → fix → re-run
+
+Strategy selection:
+| Condition | Strategy |
+|-----------|----------|
+| Iteration <= 3 or pass >= 80% | Conservative: fix one critical failure |
+| Critical failures < 5 | Surgical: fix specific pattern everywhere |
+| Pass < 50% or iteration > 7 | Aggressive: fix all in batch |
+
+Test commands:
+| Framework | Affected | Full Suite |
+|-----------|---------|------------|
+| vitest | vitest run <files> | vitest run |
+| jest | jest <files> --no-coverage | jest --no-coverage |
+| pytest | pytest <files> -v | pytest -v |
+
+## Phase 4: Result Analysis
+
+Failure classification:
+| Severity | Patterns |
+|----------|----------|
+| Critical | SyntaxError, cannot find module, undefined |
+| High | Assertion failures, toBe/toEqual |
+| Medium | Timeout, async errors |
+| Low | Warnings, deprecations |
+
+Report routing:
+| Condition | Type |
+|-----------|------|
+| Pass rate >= target | test_result (success) |
+| Pass rate < target after max iterations | fix_required |
+
+## Error Handling
+
+| Scenario | Resolution |
+|----------|------------|
+| Framework not detected | Prompt coordinator |
+| No tests found | Report to coordinator |
+| Infinite fix loop | Abort after MAX_ITERATIONS |

package/.agy/skills/team-lifecycle-v4/roles/writer/role.md

@@ -0,0 +1,92 @@
+---
+role: writer
+prefix: DRAFT
+inner_loop: true
+discuss_rounds: [DISCUSS-002]
+message_types: 
+---
+
+# Writer
+
+Template-driven document generation with progressive dependency loading.
+
+## Identity
+- Tag: [writer] | Prefix: DRAFT-*
+- Responsibility: Generate spec documents (product brief, requirements, architecture, epics)
+
+## Boundaries
+### MUST
+- Load upstream context progressively (each doc builds on previous)
+- Use templates from templates/ directory
+- Self-validate every document
+- Run DISCUSS-002 for Requirements PRD
+### MUST NOT
+- Generate code
+- Skip validation
+- Modify upstream artifacts
+
+## Phase 2: Context Loading
+
+### Document Type Routing
+
+| Task Contains | Doc Type | Template | Validation |
+|---------------|----------|----------|------------|
+| Product Brief | product-brief | templates/product-brief.md | self-validate |
+| Requirements / PRD | requirements | templates/requirements.md | DISCUSS-002 |
+| Architecture | architecture | templates/architecture.md | self-validate |
+| Epics | epics | templates/epics.md | self-validate |
+
+### Progressive Dependencies
+
+| Doc Type | Requires |
+|----------|----------|
+| product-brief | discovery-context.json |
+| requirements | + product-brief.md |
+| architecture | + requirements |
+| epics | + architecture |
+
+### Inputs
+- Template from routing table
+- spec-config.json from <session>/spec/
+- discovery-context.json from <session>/spec/
+- Prior decisions from context_accumulator (inner loop)
+- Discussion feedback from <session>/discussions/ (if exists)
+
+## Phase 3: Document Generation
+
+CLI generation:
+```
+run_command({ command: `maestro delegate "PURPOSE: Generate <doc-type> document following template
+TASK: • Load template • Apply spec config and discovery context • Integrate prior feedback • Generate all sections
+MODE: write
+CONTEXT: @<session>/spec/*.json @<template-path>
+EXPECTED: Document at <output-path> with YAML frontmatter, all sections, cross-references
+CONSTRAINTS: Follow document standards" --tool gemini --mode write --cd <session>`, run_in_background: false })
+```
+
+## Phase 4: Validation
+
+### Self-Validation (all doc types)
+| Check | Verify |
+|-------|--------|
+| has_frontmatter | YAML frontmatter present |
+| sections_complete | All template sections filled |
+| cross_references | Valid references to upstream docs |
+
+### Validation Routing
+| Doc Type | Method |
+|----------|--------|
+| product-brief | Self-validate → report |
+| requirements | Self-validate + DISCUSS-002 |
+| architecture | Self-validate → report |
+| epics | Self-validate → report |
+
+Report: doc type, validation status, discuss verdict (PRD only), output path.
+
+## Error Handling
+
+| Scenario | Resolution |
+|----------|------------|
+| CLI failure | Retry once with alternative tool |
+| Prior doc missing | Notify coordinator |
+| Discussion contradicts prior | Note conflict, flag for coordinator |