maestro-flow 0.3.1 → 0.3.3

package/.claude/skills/team-tech-debt/roles/validator/role.md

@@ -1,78 +1,78 @@
----
-role: validator
-prefix: TDVAL
-inner_loop: false
-message_types: [state_update]
----
-
-# Tech Debt Validator
-
-Cleanup result validator. Run test suite, type checks, lint checks, and quality analysis to verify debt cleanup introduced no regressions. Compare before/after debt scores, produce validation-report.json.
-
-## Phase 2: Load Context
-
-| Input | Source | Required |
-|-------|--------|----------|
-| Session path | task description (regex: `session:\s*(.+)`) | Yes |
-| .msg/meta.json | <session>/.msg/meta.json | Yes |
-| Fix log | <session>/fixes/fix-log.json | No |
-
-1. Extract session path from task description
-2. Read .msg/meta.json for: worktree.path, debt_inventory, fix_results, debt_score_before
-3. Determine command prefix: `cd "<worktree-path>" && ` if worktree exists
-4. Read fix-log.json for modified files list
-5. Detect available validation tools in worktree:
-
-| Signal | Tool | Method |
-|--------|------|--------|
-| package.json + npm | npm test | Test suite |
-| pytest available | python -m pytest | Test suite |
-| npx tsc available | npx tsc --noEmit | Type check |
-| npx eslint available | npx eslint | Lint check |
-
-## Phase 3: Run Validation Checks
-
-Execute 4-layer validation (all commands in worktree):
-
-**1. Test Suite**:
-- Run `npm test` or `python -m pytest` in worktree
-- PASS if no FAIL/error/failed keywords; FAIL with regression count otherwise
-- Skip with "no-tests" if no test runner available
-
-**2. Type Check**:
-- Run `npx tsc --noEmit` in worktree
-- Count `error TS` occurrences for error count
-
-**3. Lint Check**:
-- Run `npx eslint --no-error-on-unmatched-pattern <modified-files>` in worktree
-- Count error occurrences
-
-**4. Quality Analysis** (optional, when > 5 modified files):
-- Use gemini CLI to compare code quality before/after
-- Assess complexity, duplication, naming quality improvements
-
-**Debt Score Calculation**:
-- debt_score_after = debt items NOT in modified files (remaining unfixed items)
-- improvement_percentage = ((before - after) / before) * 100
-
-**Auto-fix attempt** (when total_regressions <= 3):
-- Use CLI tool to fix regressions in worktree:
-  ```
-  Bash({
-    command: `cd "${worktreePath}" && maestro cli -p "PURPOSE: Fix regressions found in validation
-  TASK: ${regressionDetails}
-  MODE: write
-  CONTEXT: @${modifiedFiles.join(' @')}
-  EXPECTED: Fixed regressions
-  CONSTRAINTS: Fix only regressions | Preserve debt cleanup changes | No suppressions" --tool gemini --mode write`,
-    run_in_background: false
-  })
-  ```
-- Re-run validation checks after fix attempt
-
-## Phase 4: Compare & Report
-
-1. Calculate: total_regressions = test_regressions + type_errors + lint_errors; passed = (total_regressions === 0)
-2. Write `<session>/validation/validation-report.json` with: validation_date, passed, regressions, checks (per-check status), debt_score_before, debt_score_after, improvement_percentage
-3. Update .msg/meta.json with `validation_results` and `debt_score_after`
-4. Select message type: `validation_complete` if passed, `regression_found` if not
+---
+role: validator
+prefix: TDVAL
+inner_loop: false
+message_types: [state_update]
+---
+
+# Tech Debt Validator
+
+Cleanup result validator. Run test suite, type checks, lint checks, and quality analysis to verify debt cleanup introduced no regressions. Compare before/after debt scores, produce validation-report.json.
+
+## Phase 2: Load Context
+
+| Input | Source | Required |
+|-------|--------|----------|
+| Session path | task description (regex: `session:\s*(.+)`) | Yes |
+| .msg/meta.json | <session>/.msg/meta.json | Yes |
+| Fix log | <session>/fixes/fix-log.json | No |
+
+1. Extract session path from task description
+2. Read .msg/meta.json for: worktree.path, debt_inventory, fix_results, debt_score_before
+3. Determine command prefix: `cd "<worktree-path>" && ` if worktree exists
+4. Read fix-log.json for modified files list
+5. Detect available validation tools in worktree:
+
+| Signal | Tool | Method |
+|--------|------|--------|
+| package.json + npm | npm test | Test suite |
+| pytest available | python -m pytest | Test suite |
+| npx tsc available | npx tsc --noEmit | Type check |
+| npx eslint available | npx eslint | Lint check |
+
+## Phase 3: Run Validation Checks
+
+Execute 4-layer validation (all commands in worktree):
+
+**1. Test Suite**:
+- Run `npm test` or `python -m pytest` in worktree
+- PASS if no FAIL/error/failed keywords; FAIL with regression count otherwise
+- Skip with "no-tests" if no test runner available
+
+**2. Type Check**:
+- Run `npx tsc --noEmit` in worktree
+- Count `error TS` occurrences for error count
+
+**3. Lint Check**:
+- Run `npx eslint --no-error-on-unmatched-pattern <modified-files>` in worktree
+- Count error occurrences
+
+**4. Quality Analysis** (optional, when > 5 modified files):
+- Use gemini CLI to compare code quality before/after
+- Assess complexity, duplication, naming quality improvements
+
+**Debt Score Calculation**:
+- debt_score_after = debt items NOT in modified files (remaining unfixed items)
+- improvement_percentage = ((before - after) / before) * 100
+
+**Auto-fix attempt** (when total_regressions <= 3):
+- Use CLI tool to fix regressions in worktree:
+  ```
+  Bash({
+    command: `cd "${worktreePath}" && maestro delegate "PURPOSE: Fix regressions found in validation
+  TASK: ${regressionDetails}
+  MODE: write
+  CONTEXT: @${modifiedFiles.join(' @')}
+  EXPECTED: Fixed regressions
+  CONSTRAINTS: Fix only regressions | Preserve debt cleanup changes | No suppressions" --tool gemini --mode write`,
+    run_in_background: false
+  })
+  ```
+- Re-run validation checks after fix attempt
+
+## Phase 4: Compare & Report
+
+1. Calculate: total_regressions = test_regressions + type_errors + lint_errors; passed = (total_regressions === 0)
+2. Write `<session>/validation/validation-report.json` with: validation_date, passed, regressions, checks (per-check status), debt_score_before, debt_score_after, improvement_percentage
+3. Update .msg/meta.json with `validation_results` and `debt_score_after`
+4. Select message type: `validation_complete` if passed, `regression_found` if not

package/.claude/skills/team-testing/SKILL.md

@@ -1,143 +1,143 @@
----
-name: team-testing
-description: Unified team skill for testing team. Progressive test coverage through Generator-Critic loops, shared memory, and dynamic layer selection. Triggers on "team testing".
-allowed-tools: TeamCreate(*), TeamDelete(*), SendMessage(*), TaskCreate(*), TaskUpdate(*), TaskList(*), TaskGet(*), Agent(*), AskUserQuestion(*), Read(*), Write(*), Edit(*), Bash(*), Glob(*), Grep(*), mcp__ccw-tools__team_msg(*)
----
-
-# Team Testing
-
-Orchestrate multi-agent test pipeline: strategist -> generator -> executor -> analyst. Progressive layer coverage (L1/L2/L3) with Generator-Critic loops for coverage convergence.
-
-## Architecture
-
-```
-Skill(skill="team-testing", args="task description")
-                    |
-         SKILL.md (this file) = Router
-                    |
-     +--------------+--------------+
-     |                             |
-  no --role flag              --role <name>
-     |                             |
-  Coordinator                  Worker
-  roles/coordinator/role.md    roles/<name>/role.md
-     |
-     +-- analyze -> dispatch -> spawn workers -> STOP
-                                    |
-                    +-------+-------+-------+-------+
-                    v       v       v       v
-                [strat] [gen]  [exec]  [analyst]
-                team-worker agents, each loads roles/<role>/role.md
-```
-
-## Role Registry
-
-| Role | Path | Prefix | Inner Loop |
-|------|------|--------|------------|
-| coordinator | [roles/coordinator/role.md](roles/coordinator/role.md) | — | — |
-| strategist | [roles/strategist/role.md](roles/strategist/role.md) | STRATEGY-* | false |
-| generator | [roles/generator/role.md](roles/generator/role.md) | TESTGEN-* | true |
-| executor | [roles/executor/role.md](roles/executor/role.md) | TESTRUN-* | true |
-| analyst | [roles/analyst/role.md](roles/analyst/role.md) | TESTANA-* | false |
-
-## Role Router
-
-Parse `$ARGUMENTS`:
-- Has `--role <name>` -> Read `roles/<name>/role.md`, execute Phase 2-4
-- No `--role` -> `@roles/coordinator/role.md`, execute entry router
-
-## Shared Constants
-
-- **Session prefix**: `TST`
-- **Session path**: `.workflow/.team/TST-<slug>-<date>/`
-- **Team name**: `testing`
-- **CLI tools**: `maestro cli --mode analysis` (read-only), `maestro cli --mode write` (modifications)
-- **Message bus**: `mcp__ccw-tools__team_msg(session_id=<session-id>, ...)`
-
-## Worker Spawn Template
-
-Coordinator spawns workers using this template:
-
-```
-Agent({
-  subagent_type: "team-worker",
-  description: "Spawn <role> worker",
-  team_name: "testing",
-  name: "<role>",
-  run_in_background: true,
-  prompt: `## Role Assignment
-role: <role>
-role_spec: <skill_root>/roles/<role>/role.md
-session: <session-folder>
-session_id: <session-id>
-team_name: testing
-requirement: <task-description>
-inner_loop: <true|false>
-
-## Progress Milestones
-session_id: <session-id>
-Report progress via team_msg at natural phase boundaries (context loaded -> core work done -> verification).
-Report blockers immediately via team_msg type="blocker".
-Report completion via team_msg type="task_complete" after final SendMessage.
-
-Read role_spec file (@<skill_root>/roles/<role>/role.md) to load Phase 2-4 domain instructions.
-Execute built-in Phase 1 (task discovery) -> role Phase 2-4 -> built-in Phase 5 (report).`
-})
-```
-
-## User Commands
-
-| Command | Action |
-|---------|--------|
-| `check` / `status` | View pipeline status graph |
-| `resume` / `continue` | Advance to next step |
-| `revise <TASK-ID>` | Revise specific task |
-| `feedback <text>` | Inject feedback for revision |
-
-## Completion Action
-
-When pipeline completes, coordinator presents:
-
-```
-AskUserQuestion({
-  questions: [{
-    question: "Testing pipeline complete. What would you like to do?",
-    header: "Completion",
-    multiSelect: false,
-    options: [
-      { label: "Archive & Clean (Recommended)", description: "Archive session, clean up team" },
-      { label: "Keep Active", description: "Keep session for follow-up work" },
-      { label: "Deepen Coverage", description: "Add more test layers or increase coverage targets" }
-    ]
-  }]
-})
-```
-
-## Session Directory
-
-```
-.workflow/.team/TST-<slug>-<date>/
-├── .msg/messages.jsonl     # Team message bus
-├── .msg/meta.json          # Session metadata
-├── wisdom/                 # Cross-task knowledge
-├── strategy/               # Strategist output
-├── tests/                  # Generator output (L1-unit/, L2-integration/, L3-e2e/)
-├── results/                # Executor output
-└── analysis/               # Analyst output
-```
-
-## Specs Reference
-
-- [specs/pipelines.md](specs/pipelines.md) — Pipeline definitions and task registry
-- [specs/team-config.json](specs/team-config.json) — Team configuration
-
-## Error Handling
-
-| Scenario | Resolution |
-|----------|------------|
-| Unknown --role value | Error with available role list |
-| Role not found | Error with expected path (roles/<name>/role.md) |
-| CLI tool fails | Worker fallback to direct implementation |
-| GC loop exceeded | Accept current coverage with warning |
-| Fast-advance conflict | Coordinator reconciles on next callback |
-| Completion action fails | Default to Keep Active |
+---
+name: team-testing
+description: Unified team skill for testing team. Progressive test coverage through Generator-Critic loops, shared memory, and dynamic layer selection. Triggers on "team testing".
+allowed-tools: TeamCreate(*), TeamDelete(*), SendMessage(*), TaskCreate(*), TaskUpdate(*), TaskList(*), TaskGet(*), Agent(*), AskUserQuestion(*), Read(*), Write(*), Edit(*), Bash(*), Glob(*), Grep(*), mcp__ccw-tools__team_msg(*)
+---
+
+# Team Testing
+
+Orchestrate multi-agent test pipeline: strategist -> generator -> executor -> analyst. Progressive layer coverage (L1/L2/L3) with Generator-Critic loops for coverage convergence.
+
+## Architecture
+
+```
+Skill(skill="team-testing", args="task description")
+                    |
+         SKILL.md (this file) = Router
+                    |
+     +--------------+--------------+
+     |                             |
+  no --role flag              --role <name>
+     |                             |
+  Coordinator                  Worker
+  roles/coordinator/role.md    roles/<name>/role.md
+     |
+     +-- analyze -> dispatch -> spawn workers -> STOP
+                                    |
+                    +-------+-------+-------+-------+
+                    v       v       v       v
+                [strat] [gen]  [exec]  [analyst]
+                team-worker agents, each loads roles/<role>/role.md
+```
+
+## Role Registry
+
+| Role | Path | Prefix | Inner Loop |
+|------|------|--------|------------|
+| coordinator | [roles/coordinator/role.md](roles/coordinator/role.md) | — | — |
+| strategist | [roles/strategist/role.md](roles/strategist/role.md) | STRATEGY-* | false |
+| generator | [roles/generator/role.md](roles/generator/role.md) | TESTGEN-* | true |
+| executor | [roles/executor/role.md](roles/executor/role.md) | TESTRUN-* | true |
+| analyst | [roles/analyst/role.md](roles/analyst/role.md) | TESTANA-* | false |
+
+## Role Router
+
+Parse `$ARGUMENTS`:
+- Has `--role <name>` -> Read `roles/<name>/role.md`, execute Phase 2-4
+- No `--role` -> `@roles/coordinator/role.md`, execute entry router
+
+## Shared Constants
+
+- **Session prefix**: `TST`
+- **Session path**: `.workflow/.team/TST-<slug>-<date>/`
+- **Team name**: `testing`
+- **CLI tools**: `maestro delegate --mode analysis` (read-only), `maestro delegate --mode write` (modifications)
+- **Message bus**: `mcp__ccw-tools__team_msg(session_id=<session-id>, ...)`
+
+## Worker Spawn Template
+
+Coordinator spawns workers using this template:
+
+```
+Agent({
+  subagent_type: "team-worker",
+  description: "Spawn <role> worker",
+  team_name: "testing",
+  name: "<role>",
+  run_in_background: true,
+  prompt: `## Role Assignment
+role: <role>
+role_spec: <skill_root>/roles/<role>/role.md
+session: <session-folder>
+session_id: <session-id>
+team_name: testing
+requirement: <task-description>
+inner_loop: <true|false>
+
+## Progress Milestones
+session_id: <session-id>
+Report progress via team_msg at natural phase boundaries (context loaded -> core work done -> verification).
+Report blockers immediately via team_msg type="blocker".
+Report completion via team_msg type="task_complete" after final SendMessage.
+
+Read role_spec file (@<skill_root>/roles/<role>/role.md) to load Phase 2-4 domain instructions.
+Execute built-in Phase 1 (task discovery) -> role Phase 2-4 -> built-in Phase 5 (report).`
+})
+```
+
+## User Commands
+
+| Command | Action |
+|---------|--------|
+| `check` / `status` | View pipeline status graph |
+| `resume` / `continue` | Advance to next step |
+| `revise <TASK-ID>` | Revise specific task |
+| `feedback <text>` | Inject feedback for revision |
+
+## Completion Action
+
+When pipeline completes, coordinator presents:
+
+```
+AskUserQuestion({
+  questions: [{
+    question: "Testing pipeline complete. What would you like to do?",
+    header: "Completion",
+    multiSelect: false,
+    options: [
+      { label: "Archive & Clean (Recommended)", description: "Archive session, clean up team" },
+      { label: "Keep Active", description: "Keep session for follow-up work" },
+      { label: "Deepen Coverage", description: "Add more test layers or increase coverage targets" }
+    ]
+  }]
+})
+```
+
+## Session Directory
+
+```
+.workflow/.team/TST-<slug>-<date>/
+├── .msg/messages.jsonl     # Team message bus
+├── .msg/meta.json          # Session metadata
+├── wisdom/                 # Cross-task knowledge
+├── strategy/               # Strategist output
+├── tests/                  # Generator output (L1-unit/, L2-integration/, L3-e2e/)
+├── results/                # Executor output
+└── analysis/               # Analyst output
+```
+
+## Specs Reference
+
+- [specs/pipelines.md](specs/pipelines.md) — Pipeline definitions and task registry
+- [specs/team-config.json](specs/team-config.json) — Team configuration
+
+## Error Handling
+
+| Scenario | Resolution |
+|----------|------------|
+| Unknown --role value | Error with available role list |
+| Role not found | Error with expected path (roles/<name>/role.md) |
+| CLI tool fails | Worker fallback to direct implementation |
+| GC loop exceeded | Accept current coverage with warning |
+| Fast-advance conflict | Coordinator reconciles on next callback |
+| Completion action fails | Default to Keep Active |

package/.claude/skills/team-testing/roles/executor/role.md

@@ -1,99 +1,99 @@
----
-role: executor
-prefix: TESTRUN
-inner_loop: true
-message_types:
-  success: tests_passed
-  failure: tests_failed
-  coverage: coverage_report
-  error: error
----
-
-# Test Executor
-
-Execute tests, collect coverage, attempt auto-fix for failures. Acts as the Critic in the Generator-Critic loop. Reports pass rate and coverage for coordinator GC decisions.
-
-## Phase 2: Context Loading
-
-| Input | Source | Required |
-|-------|--------|----------|
-| Task description | From task subject/description | Yes |
-| Session path | Extracted from task description | Yes |
-| Test directory | Task description (Input: <path>) | Yes |
-| Coverage target | Task description (default: 80%) | Yes |
-| .msg/meta.json | <session>/wisdom/.msg/meta.json | No |
-
-1. Extract session path and test directory from task description
-2. Load test specs: Run `ccw spec load --category test` for test framework conventions and coverage targets
-3. Extract coverage target (default: 80%)
-3. Read .msg/meta.json for framework info (from strategist namespace)
-4. Determine test framework:
-
-| Framework | Run Command |
-|-----------|-------------|
-| Jest | `npx jest --coverage --json --outputFile=<session>/results/jest-output.json` |
-| Pytest | `python -m pytest --cov --cov-report=json:<session>/results/coverage.json -v` |
-| Vitest | `npx vitest run --coverage --reporter=json` |
-
-5. Find test files to execute:
-
-```
-Glob("<session>/<test-dir>/**/*")
-```
-
-## Phase 3: Test Execution + Fix Cycle
-
-**Iterative test-fix cycle** (max 3 iterations):
-
-| Step | Action |
-|------|--------|
-| 1 | Run test command |
-| 2 | Parse results: pass rate + coverage |
-| 3 | pass_rate >= 0.95 AND coverage >= target -> success, exit |
-| 4 | Extract failing test details |
-| 5 | Delegate fix to CLI tool (gemini write mode) |
-| 6 | Increment iteration; >= 3 -> exit with failures |
-
-```
-Bash("<test-command> 2>&1 || true")
-```
-
-**Auto-fix delegation** (on failure):
-
-```
-Bash({
-  command: `maestro cli -p "PURPOSE: Fix test failures to achieve pass rate >= 0.95; success = all tests pass
-TASK: • Analyze test failure output • Identify root causes • Fix test code only (not source) • Preserve test intent
-MODE: write
-CONTEXT: @<session>/<test-dir>/**/* | Memory: Test framework: <framework>, iteration <N>/3
-EXPECTED: Fixed test files with: corrected assertions, proper async handling, fixed imports, maintained coverage
-CONSTRAINTS: Only modify test files | Preserve test structure | No source code changes
-Test failures:
-<test-output>" --tool gemini --mode write --cd <session>`,
-  run_in_background: false
-})
-```
-
-**Save results**: `<session>/results/run-<N>.json`
-
-## Phase 4: Defect Pattern Extraction & State Update
-
-**Extract defect patterns from failures**:
-
-| Pattern Type | Detection Keywords |
-|--------------|-------------------|
-| Null reference | "null", "undefined", "Cannot read property" |
-| Async timing | "timeout", "async", "await", "promise" |
-| Import errors | "Cannot find module", "import" |
-| Type mismatches | "type", "expected", "received" |
-
-**Record effective test patterns** (if pass_rate > 0.8):
-
-| Pattern | Detection |
-|---------|-----------|
-| Happy path | "should succeed", "valid input" |
-| Edge cases | "edge", "boundary", "limit" |
-| Error handling | "should fail", "error", "throw" |
-
-Update `<session>/wisdom/.msg/meta.json` under `executor` namespace:
-- Merge `{ "executor": { pass_rate, coverage, defect_patterns, effective_patterns, coverage_history_entry } }`
+---
+role: executor
+prefix: TESTRUN
+inner_loop: true
+message_types:
+  success: tests_passed
+  failure: tests_failed
+  coverage: coverage_report
+  error: error
+---
+
+# Test Executor
+
+Execute tests, collect coverage, attempt auto-fix for failures. Acts as the Critic in the Generator-Critic loop. Reports pass rate and coverage for coordinator GC decisions.
+
+## Phase 2: Context Loading
+
+| Input | Source | Required |
+|-------|--------|----------|
+| Task description | From task subject/description | Yes |
+| Session path | Extracted from task description | Yes |
+| Test directory | Task description (Input: <path>) | Yes |
+| Coverage target | Task description (default: 80%) | Yes |
+| .msg/meta.json | <session>/wisdom/.msg/meta.json | No |
+
+1. Extract session path and test directory from task description
+2. Load test specs: Run `ccw spec load --category test` for test framework conventions and coverage targets
+3. Extract coverage target (default: 80%)
+3. Read .msg/meta.json for framework info (from strategist namespace)
+4. Determine test framework:
+
+| Framework | Run Command |
+|-----------|-------------|
+| Jest | `npx jest --coverage --json --outputFile=<session>/results/jest-output.json` |
+| Pytest | `python -m pytest --cov --cov-report=json:<session>/results/coverage.json -v` |
+| Vitest | `npx vitest run --coverage --reporter=json` |
+
+5. Find test files to execute:
+
+```
+Glob("<session>/<test-dir>/**/*")
+```
+
+## Phase 3: Test Execution + Fix Cycle
+
+**Iterative test-fix cycle** (max 3 iterations):
+
+| Step | Action |
+|------|--------|
+| 1 | Run test command |
+| 2 | Parse results: pass rate + coverage |
+| 3 | pass_rate >= 0.95 AND coverage >= target -> success, exit |
+| 4 | Extract failing test details |
+| 5 | Delegate fix to CLI tool (gemini write mode) |
+| 6 | Increment iteration; >= 3 -> exit with failures |
+
+```
+Bash("<test-command> 2>&1 || true")
+```
+
+**Auto-fix delegation** (on failure):
+
+```
+Bash({
+  command: `maestro delegate "PURPOSE: Fix test failures to achieve pass rate >= 0.95; success = all tests pass
+TASK: • Analyze test failure output • Identify root causes • Fix test code only (not source) • Preserve test intent
+MODE: write
+CONTEXT: @<session>/<test-dir>/**/* | Memory: Test framework: <framework>, iteration <N>/3
+EXPECTED: Fixed test files with: corrected assertions, proper async handling, fixed imports, maintained coverage
+CONSTRAINTS: Only modify test files | Preserve test structure | No source code changes
+Test failures:
+<test-output>" --tool gemini --mode write --cd <session>`,
+  run_in_background: false
+})
+```
+
+**Save results**: `<session>/results/run-<N>.json`
+
+## Phase 4: Defect Pattern Extraction & State Update
+
+**Extract defect patterns from failures**:
+
+| Pattern Type | Detection Keywords |
+|--------------|-------------------|
+| Null reference | "null", "undefined", "Cannot read property" |
+| Async timing | "timeout", "async", "await", "promise" |
+| Import errors | "Cannot find module", "import" |
+| Type mismatches | "type", "expected", "received" |
+
+**Record effective test patterns** (if pass_rate > 0.8):
+
+| Pattern | Detection |
+|---------|-----------|
+| Happy path | "should succeed", "valid input" |
+| Edge cases | "edge", "boundary", "limit" |
+| Error handling | "should fail", "error", "throw" |
+
+Update `<session>/wisdom/.msg/meta.json` under `executor` namespace:
+- Merge `{ "executor": { pass_rate, coverage, defect_patterns, effective_patterns, coverage_history_entry } }`