maestro-flow-one 0.2.0 → 0.2.2

package/maestro-flow/commands/learn/decompose.md

@@ -0,0 +1,176 @@
+---
+name: learn-decompose
+description: Extract design patterns from code into specs and wiki
+argument-hint: "<path|module> [--patterns <list>] [--save-spec] [--save-wiki]"
+allowed-tools:
+  - Read
+  - Write
+  - Bash
+  - Glob
+  - Grep
+  - Agent
+  - AskUserQuestion
+---
+<purpose>
+Systematic pattern extraction from code. Analyzes a module or directory across 4 dimensions (structural, behavioral, data, error) using parallel agents, then catalogs findings with code anchors. Discovered patterns can be persisted to specs (via `spec-add`) and wiki (via `maestro wiki create`).
+
+Unlike `learn-follow` which reads code with forcing questions, this command is purpose-built for pattern identification and cataloging. It produces a reusable pattern catalog that feeds into the spec system.
+</purpose>
+
+<context>
+Arguments: $ARGUMENTS
+
+**Target resolution:**
+- File path → analyze that file
+- Directory path → analyze all source files in it
+- Module name → Glob for matching directory under `src/`
+
+**Flags:**
+- `--patterns <list>` — Comma-separated pattern names to look for (e.g., "observer,factory,middleware"). If omitted, detect all.
+- `--save-spec` — Invoke `Skill({ skill: "spec-add" })` for each newly discovered pattern
+- `--save-wiki` — Create wiki note entries per pattern group via `maestro wiki create --type note`
+
+**Storage written:**
+- `.workflow/learning/decompose-{slug}-{YYYY-MM-DD}.md` — Pattern decomposition report
+- `.workflow/learning/lessons.jsonl` — One insight per discovered pattern (source: "decompose")
+- `.workflow/learning/learning-index.json` — Updated index
+- If `--save-spec`: entries appended to `.workflow/specs/coding-conventions.md`
+- If `--save-wiki`: new wiki note entries
+
+**Storage read:**
+- Source files at target path
+- `.workflow/specs/coding-conventions.md` — Existing documented patterns (for dedup)
+- `.workflow/learning/lessons.jsonl` — Previously identified patterns (for dedup)
+</context>
+
+<execution>
+
+### Stage 1: Resolve Target
+- If argument is a file: verify exists, use as single-file target
+- If argument is a directory: list all `.ts`, `.tsx`, `.js`, `.jsx` files (exclude `node_modules`, `dist`, `.test.`)
+- If argument is a module name: Glob `src/**/{module}*` to find matching directory
+- If target unresolvable, AskUserQuestion with suggestions
+
+### Stage 2: Load Existing Patterns
+- Read `.workflow/specs/coding-conventions.md` — extract documented patterns
+- Search `lessons.jsonl` for entries with `category: "pattern"` — previously discovered
+- Build dedup set: pattern names already known
+
+### Stage 3: Parallel Agent Analysis (4 dimensions)
+Spawn 4 Agents in a single message, each analyzing the target from one dimension:
+
+**Agent 1 — Structural Patterns:**
+- Class hierarchy and composition relationships
+- Module boundaries and encapsulation
+- Dependency injection / inversion of control
+- Builder, Factory, Singleton patterns
+- Export structure (barrel files, re-exports)
+
+**Agent 2 — Behavioral Patterns:**
+- Event flow (EventEmitter, pub/sub, callbacks)
+- Middleware chains and interceptors
+- Observer/subscriber patterns
+- Command/strategy patterns
+- State machines
+
+**Agent 3 — Data Patterns:**
+- Repository / data access patterns
+- DTO / transformation pipelines
+- Caching strategies (memoization, LRU, TTL)
+- Serialization / deserialization
+- Schema validation approaches
+
+**Agent 4 — Error Patterns:**
+- Error boundary and propagation
+- Retry / backoff / circuit breaker
+- Fallback chains
+- Validation and guard clauses
+- Logging and observability patterns
+
+Each agent returns findings as structured list:
+```json
+[{
+  "name": "pattern name",
+  "dimension": "structural|behavioral|data|error",
+  "confidence": "high|medium|low",
+  "anchors": ["file:line", "file:line"],
+  "description": "what it does",
+  "rationale": "why this approach",
+  "tradeoffs": "what was given up"
+}]
+```
+
+If `--patterns` specified, instruct agents to focus only on named patterns.
+
+### Stage 4: Cross-Reference & Dedup
+- Match agent findings against existing pattern set from Stage 2
+- Mark each finding: `documented` (already in specs), `known` (in lessons), or `new`
+- Flag contradictions: finding conflicts with documented convention
+- Merge duplicate findings across agents (same pattern found by multiple dimensions)
+
+### Stage 5: Produce Pattern Catalog
+Build the decomposition report grouped by dimension:
+
+```markdown
+# Pattern Decomposition: {target}
+
+## Summary
+- Patterns found: N (M new, K documented, J known)
+- Dimensions analyzed: structural, behavioral, data, error
+- Contradictions: N
+
+## Structural Patterns
+| Pattern | Confidence | Location | Status |
+|---------|-----------|----------|--------|
+| {name} | high | {file:line} | new / documented / known |
+
+### {Pattern Name}
+**Description:** ...
+**Code example:** (inline snippet from anchor)
+**Trade-offs:** ...
+
+## Behavioral Patterns
+...
+```
+
+### Stage 6: Persist
+1. Write `.workflow/learning/decompose-{slug}-{date}.md`
+2. Append each **new** pattern to `lessons.jsonl`:
+   - `source: "decompose"`, `category: "pattern"`, `confidence: <level>`
+   - Tags: `["decompose", "{dimension}", "{target-slug}"]`
+   - Stable INS-id from `hash("decompose" + target + pattern_name)`
+3. Update `learning-index.json`
+4. If `--save-spec`: for each new pattern, invoke `Skill({ skill: "spec-add", args: "pattern {description}" })`
+5. If `--save-wiki`: create wiki note per dimension group via `maestro wiki create --type note --slug decompose-{dimension}-{slug}`
+6. Display summary with counts and next steps
+
+**Next-step routing:**
+- Follow-along on a specific pattern → `/learn-follow <anchor-file>`
+- Get second opinion on findings → `/learn-second-opinion <target>`
+- Add all new patterns to specs → `/spec-add coding ...` per pattern
+</execution>
+
+<error_codes>
+| Code | Severity | Condition | Recovery |
+|------|----------|-----------|----------|
+| E001 | error | Target path not found | Check path exists, or use a module name |
+| E002 | error | No source files found in target directory | Check target has .ts/.js files, exclude filters may be too aggressive |
+| W001 | warning | One or more dimension agents failed — partial results | Proceed with available dimensions, retry failed ones |
+| W002 | warning | coding-conventions.md not found — skipping dedup against specs | All patterns marked as "new" |
+| W003 | warning | Large target (>50 files) — analysis may be slow | Consider narrowing scope with --patterns filter |
+</error_codes>
+
+<success_criteria>
+- [ ] Target resolved to concrete file list
+- [ ] Existing patterns loaded for dedup
+- [ ] All 4 dimension agents spawned in parallel
+- [ ] Each finding has: name, dimension, confidence, anchors, description, tradeoffs
+- [ ] Cross-reference performed (documented / known / new status assigned)
+- [ ] Pattern catalog written to `decompose-{slug}-{date}.md`
+- [ ] New patterns appended to `lessons.jsonl` with stable INS-ids
+- [ ] `learning-index.json` updated
+- [ ] If --save-spec: spec entries created for new patterns
+- [ ] If --save-wiki: wiki notes created per dimension group
+- [ ] No files modified outside `.workflow/learning/` (and optionally specs/wiki)
+- [ ] Summary displayed with pattern counts and next-step routing
+</success_criteria>

package/maestro-flow/commands/learn/follow.md

@@ -0,0 +1,167 @@
+---
+name: learn-follow
+description: Guided reading of code or wiki to extract patterns
+argument-hint: "<path|wiki-id|topic> [--depth shallow|deep] [--save-wiki]"
+allowed-tools:
+  - Read
+  - Write
+  - Bash
+  - Glob
+  - Grep
+  - Agent
+  - AskUserQuestion
+---
+<purpose>
+Guided reading experience for code files, wiki entries, or topics. Instead of just reading code, this command walks through content section by section using forcing questions (inspired by gstack `/office-hours` brainstorming) to extract patterns, identify assumptions, and build a structured understanding map.
+
+Outputs reading notes with extracted patterns, open questions, and connection points. Insights persist to `lessons.jsonl` and optionally become wiki note entries for the knowledge graph.
+</purpose>
+
+<context>
+Arguments: $ARGUMENTS
+
+**Target resolution (auto-detected from first argument):**
+- File path (e.g., `src/commands/wiki.ts`) → Read source file
+- Wiki ID (e.g., `spec-auth`, `phase-planning`) → Fetch via `maestro wiki get`
+- Topic string (e.g., `"authentication flow"`) → Search via `maestro wiki search`, use top result
+
+**Flags:**
+- `--depth shallow` — Quick pass: key patterns and structure only (default)
+- `--depth deep` — Thorough: every function, every branch, every assumption
+- `--save-wiki` — Create a wiki note entry with the reading notes via `maestro wiki create --type note`
+
+**Storage written:**
+- `.workflow/learning/follow-{slug}-{YYYY-MM-DD}.md` — Reading notes with understanding map
+- `.workflow/learning/lessons.jsonl` — Appended pattern/technique insights
+- `.workflow/learning/learning-index.json` — Updated index
+- If `--save-wiki`: new wiki note entry
+
+**Storage read:**
+- Target source file or wiki entry
+- `maestro wiki backlinks <id>` / `maestro wiki forward <id>` — Relationship context
+- `.workflow/specs/coding-conventions.md` — Convention reference for pattern matching
+- `.workflow/learning/lessons.jsonl` — Prior insights for dedup and cross-reference
+</context>
+
+<execution>
+
+### Stage 1: Resolve Target
+- If argument looks like a file path (contains `/` or `\`, or matches a glob): verify file exists via Read
+- If argument matches wiki ID pattern (`<type>-<slug>`): fetch via `maestro wiki get <id>` (offline mode)
+- Otherwise: treat as topic string, run `maestro wiki search "<topic>"`, take the top result. If no result, fall back to Grep across `src/` for the topic.
+- If target cannot be resolved, AskUserQuestion with suggestions.
+
+### Stage 2: Load Context Web
+For the resolved target, build a 1-hop context neighborhood:
+
+**If wiki entry:**
+- `maestro wiki forward <id>` — What this entry references
+- `maestro wiki backlinks <id>` — What references this entry
+- Read the body of top 3 related entries for context
+
+**If code file:**
+- Parse imports/requires to identify dependency files
+- Grep for exports used by other files (reverse dependencies)
+- Read the first 50 lines of top 3 dependent files for context
+
+**If directory:**
+- List files, identify entry points (index.ts, main.ts, cli.ts)
+- Build reading order: entry point → core modules → utilities → tests
+
+### Stage 3: Build Reading Order
+- For a single file: split into logical sections (function boundaries, class boundaries, export groups)
+- For a wiki entry: split by markdown headings
+- For a directory: order files by dependency (entry points first, leaf modules last)
+- For `--depth shallow`: limit to top-level structure (function signatures, section headers)
+- For `--depth deep`: include every function body, every branch
+
+### Stage 4: Guided Reading with Forcing Questions
+Walk through each section in reading order. For each section, apply 4 forcing questions:
+
+1. **"What pattern is being used here?"** — Identify design patterns, idioms, conventions. Compare against `coding-conventions.md`.
+2. **"Why this approach instead of alternatives?"** — What trade-offs were made? What was the simpler approach not chosen?
+3. **"What assumption does this depend on?"** — What must be true for this code/content to be correct? External state? Input shape? Ordering?
+4. **"What would break if this changed?"** — Fragility analysis. What downstream effects would a change have?
+
+Record answers as structured annotations per section.
+
+### Stage 5: Extract Patterns
+From the forcing question answers, extract:
+- **Design patterns**: named patterns with code anchors (file:line)
+- **Naming conventions**: how things are named and why
+- **Error handling approach**: how errors flow through this code/content
+- **Data flow**: how data enters, transforms, and exits
+- **Assumptions**: explicit and implicit assumptions identified
+
+Cross-reference each pattern against existing `coding-conventions.md` entries:
+- Already documented → note as "confirmed convention"
+- Not documented → flag as "undocumented pattern" (candidate for `spec-add`)
+
+### Stage 6: Produce Understanding Map
+Build a structured summary document:
+
+```markdown
+# Follow-Along: {target name}
+
+## Key Concepts
+- {concept}: {one-line explanation}
+
+## Patterns Identified
+| Pattern | Location | Convention Status |
+|---------|----------|-------------------|
+| {name} | {file:line} | documented / undocumented |
+
+## Assumptions
+- {assumption}: {what depends on it}
+
+## Open Questions
+- {question}: {why it matters}
+
+## Connections
+- Links to: {forward link entries}
+- Referenced by: {backlink entries}
+- Related lessons: {matching lessons.jsonl entries}
+```
+
+### Stage 7: Persist
+1. Write `.workflow/learning/follow-{slug}-{date}.md` with the understanding map
+2. Append each new pattern/technique as an insight to `lessons.jsonl`:
+   - `source: "follow"`, `category: "pattern"` or `"technique"`
+   - Tags: `["follow", "{target-slug}"]`
+   - Stable INS-id from `hash("follow" + target + pattern_name)`
+3. Update `learning-index.json`
+4. If `--save-wiki`: run `maestro wiki create --type note --slug follow-{slug} --title "Follow-Along: {target}" --body-file .workflow/learning/follow-{slug}-{date}.md`
+5. Display summary with key findings and next steps
+
+**Next-step routing:**
+- Deep dive into a discovered pattern → `/learn-decompose <path>`
+- Add undocumented pattern to specs → `/spec-add coding <description>`
+- Get second opinion on a finding → `/learn-second-opinion <file>`
+- Browse related wiki entries → `/wiki-digest <topic>`
+</execution>
+
+<error_codes>
+| Code | Severity | Condition | Recovery |
+|------|----------|-----------|----------|
+| E001 | error | Target not resolvable (file not found, wiki ID not found, search returned 0) | Check path/ID, or rephrase topic for search |
+| E002 | error | `.workflow/` not initialized | Run `/maestro-init` first |
+| W001 | warning | Wiki graph unavailable (no .workflow/ wiki entries) — skipping context web | Proceed with code-only context (imports/exports) |
+| W002 | warning | coding-conventions.md not found — skipping convention comparison | Patterns flagged as "unknown convention status" |
+| W003 | warning | Target is very large (>1000 lines) — auto-switching to shallow depth | Use --depth deep to override |
+</error_codes>
+
+<success_criteria>
+- [ ] Target resolved to concrete content (file, wiki entry, or search result)
+- [ ] Context web loaded (forward/backlinks for wiki, imports/exports for code)
+- [ ] Reading order established (sections/files ordered logically)
+- [ ] All 4 forcing questions applied per section
+- [ ] Patterns extracted with file:line anchors
+- [ ] Convention comparison performed against coding-conventions.md
+- [ ] Understanding map produced with: concepts, patterns, assumptions, questions, connections
+- [ ] `follow-{slug}-{date}.md` written
+- [ ] `lessons.jsonl` appended with discovered patterns (stable INS-ids)
+- [ ] `learning-index.json` updated
+- [ ] If --save-wiki: wiki note entry created
+- [ ] No files modified outside `.workflow/learning/` (and optionally wiki)
+- [ ] Summary displayed with next-step routing
+</success_criteria>

package/maestro-flow/commands/learn/investigate.md

@@ -0,0 +1,221 @@
+---
+name: learn-investigate
+description: Investigate questions with hypothesis testing and evidence logging
+argument-hint: "<question> [--scope <path>] [--max-hypotheses N]"
+allowed-tools:
+  - Read
+  - Write
+  - Bash
+  - Glob
+  - Grep
+  - Agent
+  - AskUserQuestion
+---
+<purpose>
+Systematic investigation workflow for understanding questions (not bug-fixing). Inspired by gstack `/investigate` with its 4-phase approach, scope lock, and 3-strike escalation rule.
+
+Unlike `quality-debug` which is designed for fixing bugs during execution phases, this command is for answering "how does X work?", "why does Y happen?", "what would happen if Z?" questions. It produces structured evidence trails and understanding documents that persist to the learning system.
+</purpose>
+
+<context>
+Arguments: $ARGUMENTS
+
+**Target:** First argument is the question or topic to investigate (quoted string or keywords).
+
+**Flags:**
+- `--scope <path>` — Restrict investigation to files under this directory (default: entire project)
+- `--max-hypotheses N` — Maximum hypotheses to test before escalating (default: 3)
+
+**Storage written:**
+- `.workflow/learning/investigate-{slug}/evidence.ndjson` — Structured evidence log (one JSON line per evidence)
+- `.workflow/learning/investigate-{slug}/understanding.md` — Evolving understanding document
+- `.workflow/learning/investigate-{slug}/report.md` — Final investigation report
+- `.workflow/learning/lessons.jsonl` — Investigation findings as insights (source: "investigate")
+- `.workflow/learning/learning-index.json` — Updated index
+
+**Storage read:**
+- Source files within scope
+- `maestro wiki search "<question>"` — Prior knowledge about the topic
+- `.workflow/learning/lessons.jsonl` — Prior related investigations
+- `.workflow/specs/debug-notes.md` — Known gotchas and patterns
+- `.workflow/codebase/architecture.md` — Structural context (if exists)
+</context>
+
+<execution>
+
+### Stage 1: Frame the Question
+- Parse question from arguments
+- Determine scope (--scope or full project)
+- Generate investigation slug from question keywords
+- Create `.workflow/learning/investigate-{slug}/` directory
+- Search prior knowledge:
+  - `maestro wiki search "<question>"` for related entries
+  - Grep `lessons.jsonl` for related insights
+  - Read `debug-notes.md` for known gotchas
+
+Write initial `understanding.md`:
+```markdown
+# Investigation: {question}
+## Initial Understanding
+- Prior knowledge: {summary of wiki/lessons findings}
+- Scope: {path or "full project"}
+- Started: {timestamp}
+```
+
+### Stage 2: Evidence Collection
+Systematically gather evidence related to the question:
+
+1. **Code search**: Grep for keywords from the question across the scoped files
+2. **File inspection**: Read the most relevant files identified by search
+3. **Import/dependency tracing**: Follow imports to understand the dependency chain
+4. **Git history**: `git log --oneline -10 -- <relevant-files>` for recent changes
+
+For each piece of evidence, append to `evidence.ndjson`:
+```json
+{"ts": "ISO", "type": "code|git|search|doc", "source": "file:line", "relevance": "high|medium|low", "content": "...", "note": "why this matters"}
+```
+
+### Stage 3: Pattern Matching
+Compare collected evidence against known patterns:
+- Check `debug-notes.md` entries for matching situations
+- Check `lessons.jsonl` for related technique/pattern/gotcha entries
+- Identify: does this match a documented pattern, or is it novel?
+
+Update `understanding.md` with pattern analysis section.
+
+### Stage 4: Hypothesis Formation
+From evidence and patterns, generate ranked hypotheses:
+- Each hypothesis: a specific, testable claim about "how/why"
+- Rank by plausibility (evidence strength)
+- Write hypotheses to `understanding.md`
+
+```markdown
+## Hypotheses
+1. **[HIGH]** {hypothesis 1} — Evidence: {refs}
+2. **[MEDIUM]** {hypothesis 2} — Evidence: {refs}
+3. **[LOW]** {hypothesis 3} — Evidence: {refs}
+```
+
+### Stage 4.5: CLI Supplementary Exploration (optional)
+
+**Skip if** no enabled CLI tools or hypotheses are trivially testable.
+
+```
+IF no CLI tools enabled: skip to Stage 5
+
+hypothesis_summary = hypotheses.map(h => "${h.rank}: ${h.claim}").join("\n")
+
+Bash({
+  command: 'maestro delegate "PURPOSE: Gather evidence for investigation hypotheses
+TASK: For each hypothesis, trace relevant call chains and data flows | Find corroborating or contradicting code patterns
+MODE: analysis
+CONTEXT: @${scope_path}/**/*
+EXPECTED: JSON array of { hypothesis_rank, evidence: [{ file, line, supports: bool, explanation }] }
+CONSTRAINTS: Focus on code-level evidence only | Max 5 evidence items per hypothesis
+
+Hypotheses:
+${hypothesis_summary}
+" --role explore --mode analysis',
+  run_in_background: true
+})
+```
+
+**On callback:** Parse result, append each evidence item to `evidence.ndjson` with `type: "cli-exploration"`. Pass as supplementary context to Stage 5 testing.
+
+### Stage 5: Hypothesis Testing
+For each hypothesis (in rank order):
+
+1. **Design test**: What specific evidence would confirm or disprove this?
+2. **Execute test**: Code trace, targeted search, data inspection, or experiment
+3. **Record result**: Append to `evidence.ndjson` with `type: "test"`
+4. **Update understanding**: Mark hypothesis as confirmed / disproved / inconclusive
+
+```markdown
+## Test Results
+### Hypothesis 1: {claim}
+- Test: {what was done}
+- Result: CONFIRMED / DISPROVED / INCONCLUSIVE
+- Evidence: {file:line references}
+```
+
+### Stage 6: 3-Strike Escalation
+If `--max-hypotheses` hypotheses all fail:
+
+1. **Broaden scope**: If scope was restricted, suggest expanding. AskUserQuestion:
+   ```
+   {N} hypotheses tested, none confirmed.
+   A) Broaden scope to full project
+   B) I have a new hypothesis: [user provides]
+   C) Escalate — this needs deeper investigation
+   ```
+2. **Search wiki for clues**: `maestro wiki search` with alternative keywords
+3. **If still stuck**: Mark as INCONCLUSIVE with what was learned and what remains unknown
+
+### Stage 7: Synthesize & Report
+Write final `report.md`:
+
+```markdown
+# Investigation Report: {question}
+
+## Answer
+{confirmed understanding or "INCONCLUSIVE: ..."}
+
+## Evidence Trail
+| # | Type | Source | Relevance | Finding |
+|---|------|--------|-----------|---------|
+| 1 | code | file:line | high | ... |
+
+## Hypotheses Tested
+| Hypothesis | Result | Key Evidence |
+|-----------|--------|-------------|
+| ... | confirmed/disproved | file:line |
+
+## Key Learnings
+- {learning 1}
+- {learning 2}
+
+## Open Questions
+- {what remains unknown}
+```
+
+### Stage 8: Persist
+1. Append findings to `lessons.jsonl`:
+   - Confirmed hypotheses → `category: "technique"` or `"pattern"`
+   - Disproved hypotheses → `category: "gotcha"` (what looked true but wasn't)
+   - `source: "investigate"`, tags: `["investigate", "{question-slug}"]`
+   - Stable INS-id from `hash("investigate" + question + finding_title)`
+2. Update `learning-index.json`
+3. Display summary with answer and next steps
+
+**Next-step routing:**
+- Save finding to specs → `/spec-add debug <finding>`
+- Follow-along on discovered code → `/learn-follow <path>`
+- Decompose patterns found → `/learn-decompose <module>`
+- Create wiki entry for understanding → `maestro wiki create --type note`
+</execution>
+
+<error_codes>
+| Code | Severity | Condition | Recovery |
+|------|----------|-----------|----------|
+| E001 | error | No question provided | Provide a question as the first argument |
+| E002 | error | Scope path does not exist | Check --scope path is valid |
+| W001 | warning | No prior knowledge found in wiki/lessons | Proceed with fresh investigation |
+| W002 | warning | Evidence collection found very few matches (<3) | Broaden search terms or expand scope |
+| W003 | warning | All hypotheses inconclusive — escalating | Investigation marked INCONCLUSIVE |
+</error_codes>
+
+<success_criteria>
+- [ ] Question parsed and investigation slug generated
+- [ ] Investigation directory created under `.workflow/learning/`
+- [ ] Prior knowledge loaded from wiki and lessons
+- [ ] Evidence collected and logged to `evidence.ndjson` (structured NDJSON)
+- [ ] Pattern matching performed against debug-notes and lessons
+- [ ] At least 1 hypothesis formed and tested
+- [ ] `understanding.md` tracks evolving understanding with timestamps
+- [ ] `report.md` written with answer, evidence trail, hypothesis results
+- [ ] Findings appended to `lessons.jsonl` with stable INS-ids
+- [ ] `learning-index.json` updated
+- [ ] 3-strike escalation triggered if all hypotheses fail
+- [ ] No files modified outside `.workflow/learning/`
+- [ ] Summary displayed with answer and next-step routing
+</success_criteria>