macro-agent 0.2.5 → 0.2.6

package/src/__tests__/e2e/acp-over-map-live.e2e.test.ts

@@ -1,496 +0,0 @@
-/**
- * ACP-over-MAP Live Agent E2E Tests
- *
- * Tests the full ACP-over-MAP flow with REAL Claude Code agents.
- * Exercises: initialize, newSession, prompt, streaming updates,
- * permission handling, and session lifecycle.
- *
- * REQUIRES: RUN_FULL_AGENT_TESTS=true
- * REQUIRES: Claude Code CLI installed and API access configured
- *
- * Run:
- *   RUN_FULL_AGENT_TESTS=true npx vitest run --config vitest.e2e.config.ts src/__tests__/e2e/acp-over-map-live.e2e.test.ts
- */
-
-import { describe, it, expect, beforeAll, afterAll } from "vitest";
-import * as fs from "fs";
-import * as path from "path";
-import * as os from "os";
-import { bootV2, type MacroAgentSystemV2 } from "../../boot-v2.js";
-import {
-  ClientConnection,
-  createACPStream,
-  type ACPStreamConnection,
-} from "@multi-agent-protocol/sdk";
-
-const IS_LIVE = process.env.RUN_FULL_AGENT_TESTS === "true";
-const describeLive = IS_LIVE ? describe : describe.skip;
-
-const TEST_DIR = fs.mkdtempSync(
-  path.join(os.tmpdir(), "acp-map-live-e2e-"),
-);
-
-describeLive("ACP-over-MAP Live Agent", () => {
-  let system: MacroAgentSystemV2;
-  let client: ClientConnection;
-  let mapUrl: string;
-
-  beforeAll(async () => {
-    system = await bootV2({
-      cwd: TEST_DIR,
-      baseDir: TEST_DIR,
-      defaultPermissionMode: "auto-approve", // No permission prompts
-      inbox: {
-        socketPath: path.join(TEST_DIR, "inbox.sock"),
-      },
-      mapServer: {
-        enabled: true,
-        port: 0,
-        host: "127.0.0.1",
-      },
-    });
-
-    mapUrl = system.mapServerInstance!.getUrl();
-    console.log(`[live-test] MAP server at ${mapUrl}`);
-
-    client = await ClientConnection.connect(mapUrl, {
-      name: "Live Agent E2E",
-      capabilities: {
-        observation: { canObserve: true, canQuery: true },
-        messaging: { canSend: true, canReceive: true },
-        lifecycle: { canSpawn: true, canStop: true },
-      },
-    });
-  }, 30000);
-
-  afterAll(async () => {
-    try {
-      await client?.disconnect();
-    } catch { /* ignore */ }
-    try {
-      await system?.shutdown();
-    } catch { /* ignore */ }
-    try {
-      fs.rmSync(TEST_DIR, { recursive: true, force: true });
-    } catch { /* ignore */ }
-  });
-
-  it("lists agents (initially empty or head manager)", async () => {
-    const result = await client.listAgents();
-    expect(result.agents).toBeDefined();
-    console.log(
-      `[live-test] Initial agents: ${result.agents.length}`,
-    );
-  });
-
-  it("creates ACP session via ACP-over-MAP and prompts", async () => {
-    // For ACP-over-MAP, we target "server" as the agent.
-    // The createMacroAgent handler creates a head manager on newSession().
-    // We need to use a MAP-registered agent as the target.
-    // First, let's see what agents are available or register a "server" agent.
-
-    // The ACP handler is attached to ANY local agent. When the client
-    // sends an ACP stream to a local agent, the bridge creates a
-    // createMacroAgent() instance for that stream. The ACP handler's
-    // newSession() then spawns a head manager internally.
-    //
-    // We need at least one agent registered in the MAP server.
-    // Spawn one so it appears in listAgents.
-    const spawnResult = (await client.callExtension(
-      "_macro/spawnAgent",
-      { task: "ACP target agent", role: "worker" },
-    )) as { agent: { id: string; localId: string } };
-
-    const targetAgent = spawnResult.agent.id;
-    console.log(`[live-test] Target agent: ${targetAgent}`);
-
-    // Track events
-    const sessionUpdates: any[] = [];
-    const permissionRequests: any[] = [];
-
-    const acpStream = createACPStream(client, {
-      targetAgent,
-      timeout: 60000, // 60s for live agents
-      client: {
-        requestPermission: async (req) => {
-          console.log(
-            `[live-test] Permission request: ${req.toolCall?.name ?? "unknown"}`,
-          );
-          permissionRequests.push(req);
-          // Auto-approve everything
-          return {
-            outcome: {
-              outcome: "allow",
-            },
-          } as any;
-        },
-        sessionUpdate: async (update) => {
-          const type = (update as any)?.update?.sessionUpdate ?? "unknown";
-          sessionUpdates.push(update);
-          if (type === "assistant") {
-            const text =
-              (update as any)?.update?.text?.slice(0, 100) ?? "";
-            console.log(
-              `[live-test] Assistant: ${text}...`,
-            );
-          } else {
-            console.log(`[live-test] Update: ${type}`);
-          }
-        },
-      },
-    });
-
-    // Pre-spawn a head manager so newSession() reuses it (avoids 30s MAP send timeout)
-    console.log("[live-test] Pre-spawning head manager...");
-    await client.callExtension("_macro/spawnAgent", {
-      task: "Head manager",
-      role: "coordinator",
-    });
-    await new Promise((r) => setTimeout(r, 2000));
-
-    // Initialize
-    const initResult = await acpStream.initialize({
-      protocolVersion: 1,
-      clientInfo: { name: "Live E2E", version: "1.0.0" },
-    });
-    expect(initResult).toBeDefined();
-    expect(initResult.protocolVersion).toBe(1);
-    console.log(
-      `[live-test] Initialized: ${initResult.agentInfo?.name}`,
-    );
-
-    // Create session — should reuse the pre-spawned head manager
-    const sessionResult = await acpStream.newSession({
-      mcpServers: [],
-      cwd: TEST_DIR,
-    });
-    expect(sessionResult).toBeDefined();
-    expect((sessionResult as any).sessionId).toBeTruthy();
-    console.log(
-      `[live-test] Session: ${(sessionResult as any).sessionId}`,
-    );
-
-    // Send a simple prompt
-    console.log("[live-test] Sending prompt...");
-    const promptResult = await acpStream.prompt({
-      sessionId: (sessionResult as any).sessionId,
-      prompt: [
-        {
-          type: "text",
-          text: 'Reply with exactly "hello from live test" and nothing else.',
-        },
-      ],
-    });
-    console.log(
-      `[live-test] Prompt result: stopReason=${promptResult.stopReason}`,
-    );
-    expect(promptResult).toBeDefined();
-
-    // Check we got session updates
-    console.log(
-      `[live-test] Received ${sessionUpdates.length} session updates, ${permissionRequests.length} permission requests`,
-    );
-
-    // With auto-approve mode, there should be no permission requests
-    // Session updates should include at least an assistant response
-    expect(sessionUpdates.length).toBeGreaterThan(0);
-
-    // Clean up
-    await acpStream.close();
-  }, 120000); // 2 minute timeout for live agents
-
-  it("can prompt via ACP-over-MAP and get streaming updates", async () => {
-    // Get agents
-    const agents = await client.listAgents();
-    if (agents.agents.length === 0) {
-      console.log("[live-test] No agents, skipping prompt test");
-      return;
-    }
-
-    const targetAgent = agents.agents[0].id;
-    const updates: string[] = [];
-
-    const acpStream = createACPStream(client, {
-      targetAgent,
-      timeout: 60000,
-      client: {
-        requestPermission: async () =>
-          ({ outcome: { outcome: "allow" } }) as any,
-        sessionUpdate: async (update) => {
-          const type = (update as any)?.update?.sessionUpdate;
-          if (type) updates.push(type);
-        },
-      },
-    });
-
-    await acpStream.initialize({
-      protocolVersion: 1,
-      clientInfo: { name: "Prompt Test", version: "1.0.0" },
-    });
-
-    const session = await acpStream.newSession({
-      mcpServers: [],
-      cwd: TEST_DIR,
-    });
-
-    const result = await acpStream.prompt({
-      sessionId: (session as any).sessionId,
-      prompt: [
-        {
-          type: "text",
-          text: "What is 2+2? Reply with just the number.",
-        },
-      ],
-    });
-
-    console.log(
-      `[live-test] Prompt completed: ${result.stopReason}, ${updates.length} updates`,
-    );
-    console.log(
-      `[live-test] Update types: ${[...new Set(updates)].join(", ")}`,
-    );
-
-    expect(result.stopReason).toBeTruthy();
-    expect(updates.length).toBeGreaterThan(0);
-
-    await acpStream.close();
-  }, 120000);
-});
-
-// =============================================================================
-// Permission Flow Tests
-// =============================================================================
-
-const PERM_TEST_DIR = fs.mkdtempSync(
-  path.join(os.tmpdir(), "acp-map-perm-e2e-"),
-);
-
-describeLive("ACP-over-MAP Permission Flow", () => {
-  let system: MacroAgentSystemV2;
-  let client: ClientConnection;
-  let mapUrl: string;
-
-  beforeAll(async () => {
-    system = await bootV2({
-      cwd: PERM_TEST_DIR,
-      baseDir: PERM_TEST_DIR,
-      // Use "interactive" mode so acp-factory yields PermissionRequestUpdate
-      defaultPermissionMode: "interactive",
-      inbox: {
-        socketPath: path.join(PERM_TEST_DIR, "inbox.sock"),
-      },
-      mapServer: {
-        enabled: true,
-        port: 0,
-        host: "127.0.0.1",
-      },
-    });
-
-    mapUrl = system.mapServerInstance!.getUrl();
-    console.log(`[perm-test] MAP server at ${mapUrl}`);
-
-    client = await ClientConnection.connect(mapUrl, {
-      name: "Permission Flow E2E",
-      capabilities: {
-        observation: { canObserve: true, canQuery: true },
-        messaging: { canSend: true, canReceive: true },
-        lifecycle: { canSpawn: true, canStop: true },
-      },
-    });
-  }, 30000);
-
-  afterAll(async () => {
-    try {
-      await client?.disconnect();
-    } catch { /* ignore */ }
-    try {
-      await system?.shutdown();
-    } catch { /* ignore */ }
-    try {
-      fs.rmSync(PERM_TEST_DIR, { recursive: true, force: true });
-    } catch { /* ignore */ }
-  });
-
-  it("receives permission requests and approves tool calls", async () => {
-    // Spawn an agent that will be the ACP target
-    const spawnResult = (await client.callExtension(
-      "_macro/spawnAgent",
-      { task: "Permission test agent", role: "worker" },
-    )) as { agent: { id: string; localId: string } };
-
-    const targetAgent = spawnResult.agent.id;
-    console.log(`[perm-test] Target agent: ${targetAgent}`);
-
-    // Track events
-    const sessionUpdates: any[] = [];
-    const permissionRequests: any[] = [];
-
-    const acpStream = createACPStream(client, {
-      targetAgent,
-      timeout: 120000, // 2 min for live agents with permission prompts
-      client: {
-        requestPermission: async (req) => {
-          console.log(
-            `[perm-test] Permission request received!`,
-          );
-          console.log(
-            `[perm-test]   Tool: ${req.toolCall?.title ?? "unknown"}`,
-          );
-          console.log(
-            `[perm-test]   Options: ${JSON.stringify(req.options?.map((o: any) => ({ optionId: o.optionId, kind: o.kind, name: o.name })))}`,
-          );
-          permissionRequests.push(req);
-
-          // Find the "allow" option and select it
-          const allowOption = req.options?.find(
-            (o: any) => o.kind === "allow",
-          );
-          if (allowOption) {
-            console.log(
-              `[perm-test]   Approving with optionId: ${allowOption.optionId}`,
-            );
-            return {
-              outcome: {
-                outcome: "selected" as const,
-                optionId: allowOption.optionId,
-              },
-            };
-          }
-
-          // Fallback: approve with first option
-          const firstOption = req.options?.[0];
-          if (firstOption) {
-            console.log(
-              `[perm-test]   Approving with first option: ${firstOption.optionId}`,
-            );
-            return {
-              outcome: {
-                outcome: "selected" as const,
-                optionId: firstOption.optionId,
-              },
-            };
-          }
-
-          // Last resort: cancel
-          console.log(`[perm-test]   No options found, cancelling`);
-          return { outcome: { outcome: "cancelled" as const } };
-        },
-        sessionUpdate: async (update) => {
-          const type = (update as any)?.update?.sessionUpdate ?? "unknown";
-          sessionUpdates.push(update);
-          // Log ALL update types for debugging
-          const toolName = (update as any)?.update?.title ?? (update as any)?.update?.toolCallId ?? "";
-          const text = (update as any)?.update?.text?.slice(0, 80) ?? "";
-          console.log(`[perm-test] Update: ${type}${toolName ? ` [${toolName}]` : ""}${text ? ` "${text}..."` : ""}`);
-        },
-      },
-    });
-
-    // Pre-spawn a head manager via extension (avoids MAP send timeout on newSession).
-    // The extension call is a direct RPC with no 30s MAP send timeout.
-    console.log("[perm-test] Pre-spawning head manager...");
-    await client.callExtension("_macro/spawnAgent", {
-      task: "Head manager for permission test",
-      role: "coordinator",
-    });
-    // Wait for agent to be fully ready
-    await new Promise((r) => setTimeout(r, 2000));
-    console.log("[perm-test] Head manager ready");
-
-    // Initialize
-    const initResult = await acpStream.initialize({
-      protocolVersion: 1,
-      clientInfo: { name: "Permission E2E", version: "1.0.0" },
-    });
-    expect(initResult).toBeDefined();
-    console.log(
-      `[perm-test] Initialized: ${initResult.agentInfo?.name}`,
-    );
-
-    // Create session — should reuse the pre-spawned head manager.
-    // Pass settingSources: [] to disable reading ~/.claude/settings.json
-    // which may have rules that auto-approve tools (bypassing permission requests).
-    const sessionResult = await acpStream.newSession({
-      mcpServers: [],
-      cwd: PERM_TEST_DIR,
-      _meta: {
-        claudeCode: {
-          options: {
-            settingSources: [], // No pre-configured permissions — ask for everything
-          },
-        },
-      },
-    } as any);
-    expect(sessionResult).toBeDefined();
-    const sessionId = (sessionResult as any).sessionId;
-    console.log(`[perm-test] Session: ${sessionId}`);
-
-    // Send a prompt that triggers tool use requiring permission.
-    // Claude Code auto-approves many tools when running headless with
-    // auto-approve. To ensure permission is requested, we use a
-    // command that's more restrictive — writing to /tmp (outside CWD)
-    // or running an unrestricted bash command.
-    //
-    // Note: If the agent still auto-approves, the test verifies the
-    // prompt completes and session updates are received — the permission
-    // forwarding code is architecturally correct even if this particular
-    // invocation doesn't trigger it.
-    console.log("[perm-test] Sending prompt that triggers tool use...");
-    const promptResult = await acpStream.prompt({
-      sessionId,
-      prompt: [
-        {
-          type: "text",
-          text: `Write the text "permission test" to the file /tmp/perm-test-${Date.now()}.txt using the Write tool.`,
-        },
-      ],
-    });
-
-    console.log(
-      `[perm-test] Prompt result: stopReason=${promptResult.stopReason}`,
-    );
-    console.log(
-      `[perm-test] Session updates: ${sessionUpdates.length}`,
-    );
-    console.log(
-      `[perm-test] Permission requests: ${permissionRequests.length}`,
-    );
-
-    // The prompt should complete successfully
-    expect(promptResult.stopReason).toBeTruthy();
-
-    // Should have received session updates including tool calls
-    expect(sessionUpdates.length).toBeGreaterThan(0);
-
-    // Log permission flow results
-    if (permissionRequests.length > 0) {
-      console.log(
-        `[perm-test] Permission flow VERIFIED: ${permissionRequests.length} requests`,
-      );
-      console.log(
-        `[perm-test] First permission: ${permissionRequests[0]?.toolCall?.title}`,
-      );
-    } else {
-      console.log(
-        `[perm-test] No permissions triggered — agent auto-approved all tools.`,
-      );
-      console.log(
-        `[perm-test] Permission forwarding code is in place but was not exercised.`,
-      );
-      console.log(
-        `[perm-test] Update types seen: ${[...new Set(sessionUpdates.map((u: any) => u?.update?.sessionUpdate))].join(", ")}`,
-      );
-    }
-
-    // Verify tool calls were made (proves the agent used tools)
-    const toolCallUpdates = sessionUpdates.filter(
-      (u: any) => u?.update?.sessionUpdate === "tool_call",
-    );
-    expect(toolCallUpdates.length).toBeGreaterThan(0);
-    console.log(
-      `[perm-test] Tool calls observed: ${toolCallUpdates.length}`,
-    );
-
-    await acpStream.close();
-  }, 180000); // 3 minute timeout for live agent with permission flow
-});