macro-agent 0.2.4 → 0.2.6

package/src/__tests__/e2e/pull-mode.e2e.test.ts

@@ -1,632 +0,0 @@
-/**
- * Pull Mode E2E Tests
- *
- * Tests that pull-mode claim tools are properly registered, gated by
- * task.claim capability, and that pull-mode done() keeps workers alive.
- *
- * REQUIRES: RUN_E2E_TESTS=true
- *
- * Run with:
- *   RUN_E2E_TESTS=true npx vitest run --config vitest.e2e.config.ts src/__tests__/e2e/pull-mode.e2e.test.ts
- */
-
-import {
-  describe,
-  it,
-  expect,
-  beforeEach,
-  afterEach,
-  vi,
-} from "vitest";
-import * as path from "path";
-import * as os from "os";
-import * as fs from "fs";
-import { bootV2, type MacroAgentSystemV2 } from "../../boot-v2.js";
-import { createMCPServerV2 } from "../../mcp/mcp-server-v2.js";
-import { DefaultRoleRegistry } from "../../roles/registry.js";
-import { TASK_CAPABILITIES } from "../../roles/capabilities.js";
-import type { RoleDefinition } from "../../roles/types.js";
-import type { ToolContext } from "../../mcp/types.js";
-import { dispatchDoneV2 } from "../../lifecycle/handlers-v2.js";
-import type { LifecycleContext, DoneArgs, CleanupStatus } from "../../lifecycle/types.js";
-
-// ─────────────────────────────────────────────────────────────────
-// Configuration
-// ─────────────────────────────────────────────────────────────────
-
-const RUN_E2E = !!process.env.RUN_E2E_TESTS;
-const describeFn = RUN_E2E ? describe : describe.skip;
-
-// Mock acp-factory
-vi.mock("acp-factory", () => ({
-  AgentFactory: {
-    spawn: vi.fn().mockResolvedValue({
-      createSession: vi.fn().mockResolvedValue({
-        id: `session-${Date.now()}`,
-        prompt: vi.fn().mockReturnValue({
-          [Symbol.asyncIterator]: () => ({
-            next: () => Promise.resolve({ done: true, value: undefined }),
-          }),
-        }),
-        forkWithFlush: vi.fn().mockResolvedValue({
-          id: `forked-${Date.now()}`,
-        }),
-      }),
-      loadSession: vi.fn().mockResolvedValue({
-        id: `loaded-${Date.now()}`,
-      }),
-      close: vi.fn().mockResolvedValue(undefined),
-      isRunning: vi.fn().mockReturnValue(true),
-    }),
-  },
-}));
-
-// Mock opentasks
-vi.mock("opentasks", () => ({
-  OpenTasksClient: vi.fn().mockImplementation(() => ({
-    connect: vi.fn().mockRejectedValue(new Error("No daemon")),
-    disconnect: vi.fn(),
-    query: vi.fn().mockResolvedValue({ items: [] }),
-    link: vi.fn().mockResolvedValue({ success: true }),
-    task: vi.fn().mockResolvedValue({ id: "t-1" }),
-  })),
-}));
-
-// ─────────────────────────────────────────────────────────────────
-// Helpers
-// ─────────────────────────────────────────────────────────────────
-
-function createTestDir(): string {
-  const dir = path.join(
-    os.tmpdir(),
-    `pull-mode-e2e-${Date.now()}-${Math.random().toString(36).slice(2)}`
-  );
-  fs.mkdirSync(dir, { recursive: true });
-  return dir;
-}
-
-/**
- * Create a mock TasksAdapter with controllable behavior.
- */
-function createMockTasksAdapter() {
-  const mockTask = {
-    id: "task-claim-1",
-    title: "Claimable task",
-    status: "in_progress" as const,
-    assignee: "test-agent",
-    tags: ["frontend"],
-  };
-
-  return {
-    createTask: vi.fn().mockResolvedValue("t-new"),
-    assignTask: vi.fn().mockResolvedValue(undefined),
-    transitionTask: vi.fn().mockResolvedValue(undefined),
-    getTask: vi.fn().mockResolvedValue(mockTask),
-    queryReady: vi.fn().mockResolvedValue([mockTask]),
-    listTasks: vi.fn().mockResolvedValue([mockTask]),
-    addBlocker: vi.fn().mockResolvedValue(undefined),
-    removeBlocker: vi.fn().mockResolvedValue(undefined),
-    claimTask: vi.fn().mockResolvedValue(mockTask),
-    unclaimTask: vi.fn().mockResolvedValue(undefined),
-    listClaimable: vi.fn().mockResolvedValue([mockTask]),
-    connect: vi.fn().mockResolvedValue(undefined),
-    disconnect: vi.fn(),
-    connected: true,
-  };
-}
-
-/**
- * Create a mock InboxAdapter.
- */
-function createMockInboxAdapter() {
-  return {
-    registerAgent: vi.fn().mockResolvedValue(undefined),
-    deregisterAgent: vi.fn().mockResolvedValue(undefined),
-    send: vi.fn().mockResolvedValue("msg-1"),
-    onDelivery: vi.fn(),
-    offDelivery: vi.fn(),
-    checkInbox: vi.fn().mockResolvedValue([]),
-    readThread: vi.fn().mockResolvedValue([]),
-    setSignalFilter: vi.fn(),
-    setEmissionValidator: vi.fn(),
-    socketPath: "/tmp/test.sock",
-    stop: vi.fn().mockResolvedValue(undefined),
-  };
-}
-
-// ─────────────────────────────────────────────────────────────────
-// Tests
-// ─────────────────────────────────────────────────────────────────
-
-describeFn("Pull Mode E2E", () => {
-  let system: MacroAgentSystemV2;
-  let testDir: string;
-
-  beforeEach(async () => {
-    testDir = createTestDir();
-    system = await bootV2({
-      cwd: testDir,
-      baseDir: testDir,
-      inbox: {
-        socketPath: path.join(testDir, "inbox.sock"),
-      },
-    });
-  });
-
-  afterEach(async () => {
-    if (system) {
-      await system.shutdown();
-    }
-    if (fs.existsSync(testDir)) {
-      fs.rmSync(testDir, { recursive: true, force: true });
-    }
-  });
-
-  // ── Test 1: Claim tools registered for workers with task.claim ──
-
-  describe("CLAIM TOOLS: Registration gated by task.claim capability", () => {
-    it("should register claim_task, unclaim_task, list_claimable_tasks for role with task.claim", () => {
-      // Create a role registry with a custom worker role that has task.claim
-      const registry = new DefaultRoleRegistry();
-      const workerWithClaim: RoleDefinition = {
-        name: "pull-worker",
-        displayName: "Pull Worker",
-        description: "Worker with pull mode capabilities",
-        extends: "worker",
-        capabilities: [
-          "file.read",
-          "file.write",
-          "lifecycle.done",
-          "exec.command",
-          "msg.send",
-          TASK_CAPABILITIES.CLAIM, // This grants claim tools
-        ],
-      };
-      registry.registerRole(workerWithClaim);
-
-      // Create a mock agent store that returns the pull-worker role
-      const agentId = "agent-pull-1";
-      const mockAgentStore = {
-        getAgent: vi.fn().mockReturnValue({
-          id: agentId,
-          role: "pull-worker",
-          state: "running",
-        }),
-        getChildren: vi.fn().mockReturnValue([]),
-        getDescendants: vi.fn().mockReturnValue([]),
-        listAgents: vi.fn().mockReturnValue([]),
-      } as any;
-
-      const mockTasksAdapter = createMockTasksAdapter();
-      const mockInboxAdapter = createMockInboxAdapter();
-
-      const context: ToolContext = {
-        agent_id: agentId,
-        session_id: "session-1",
-        lineage: [],
-        cwd: testDir,
-      };
-
-      const mcpServer = createMCPServerV2(context, {
-        agentStore: mockAgentStore,
-        agentManager: {} as any, // Not needed for registration check
-        inboxAdapter: mockInboxAdapter as any,
-        tasksAdapter: mockTasksAdapter as any,
-        roleRegistry: registry,
-        taskMode: "pull",
-      });
-
-      // Access the internal server to check registered tools
-      const server = mcpServer.server as any;
-
-      // The McpServer stores tools internally. We verify by checking
-      // the server's _registeredTools or similar internal structure.
-      // Since we can't easily introspect McpServer, we verify by
-      // calling the tools and checking they don't throw "unknown tool".
-      expect(server).toBeDefined();
-
-      // Alternatively, verify the mock adapter methods are callable via the tools
-      // by checking the server was created without error
-      expect(mcpServer).toBeDefined();
-    });
-
-    it("should NOT register claim tools for role WITHOUT task.claim", () => {
-      const registry = new DefaultRoleRegistry();
-
-      // Default worker role does not have task.claim
-      const agentId = "agent-no-claim-1";
-      const mockAgentStore = {
-        getAgent: vi.fn().mockReturnValue({
-          id: agentId,
-          role: "worker",
-          state: "running",
-        }),
-        getChildren: vi.fn().mockReturnValue([]),
-        getDescendants: vi.fn().mockReturnValue([]),
-        listAgents: vi.fn().mockReturnValue([]),
-      } as any;
-
-      const mockTasksAdapter = createMockTasksAdapter();
-      const mockInboxAdapter = createMockInboxAdapter();
-
-      const context: ToolContext = {
-        agent_id: agentId,
-        session_id: "session-2",
-        lineage: [],
-        cwd: testDir,
-      };
-
-      // Verify that default worker does NOT have task.claim
-      const resolvedWorker = registry.resolveRole("worker");
-      const hasClaim = resolvedWorker.capabilities?.includes(
-        TASK_CAPABILITIES.CLAIM
-      );
-      expect(hasClaim).toBeFalsy();
-
-      // Create MCP server — claim tools should not be registered
-      const mcpServer = createMCPServerV2(context, {
-        agentStore: mockAgentStore,
-        agentManager: {} as any,
-        inboxAdapter: mockInboxAdapter as any,
-        tasksAdapter: mockTasksAdapter as any,
-        roleRegistry: registry,
-      });
-
-      expect(mcpServer).toBeDefined();
-    });
-  });
-
-  // ── Test 2: claim_task calls through to TasksAdapter ──
-
-  describe("CLAIM TOOLS: Functional behavior", () => {
-    it("should call tasksAdapter.claimTask when claim_task tool is invoked", async () => {
-      const registry = new DefaultRoleRegistry();
-      const workerWithClaim: RoleDefinition = {
-        name: "pull-worker",
-        displayName: "Pull Worker",
-        description: "Worker with pull mode capabilities",
-        extends: "worker",
-        capabilities: [
-          "file.read",
-          "file.write",
-          "lifecycle.done",
-          "exec.command",
-          "msg.send",
-          TASK_CAPABILITIES.CLAIM,
-        ],
-      };
-      registry.registerRole(workerWithClaim);
-
-      const agentId = "agent-claim-test";
-      const mockAgentStore = {
-        getAgent: vi.fn().mockReturnValue({
-          id: agentId,
-          role: "pull-worker",
-          state: "running",
-        }),
-        getChildren: vi.fn().mockReturnValue([]),
-        getDescendants: vi.fn().mockReturnValue([]),
-        listAgents: vi.fn().mockReturnValue([]),
-      } as any;
-
-      const mockTasksAdapter = createMockTasksAdapter();
-      const mockInboxAdapter = createMockInboxAdapter();
-
-      const context: ToolContext = {
-        agent_id: agentId,
-        session_id: "session-3",
-        lineage: [],
-        cwd: testDir,
-      };
-
-      const mcpServer = createMCPServerV2(context, {
-        agentStore: mockAgentStore,
-        agentManager: {} as any,
-        inboxAdapter: mockInboxAdapter as any,
-        tasksAdapter: mockTasksAdapter as any,
-        roleRegistry: registry,
-        taskMode: "pull",
-      });
-
-      // Access registered tools via McpServer internal structure (plain object)
-      const server = mcpServer.server as any;
-      const toolHandlers = server._registeredTools;
-
-      expect(toolHandlers["claim_task"]).toBeDefined();
-
-      const toolEntry = toolHandlers["claim_task"];
-      const result = await toolEntry.handler({ tags: ["frontend"] }, {});
-      expect(mockTasksAdapter.claimTask).toHaveBeenCalledWith(
-        agentId,
-        { tags: ["frontend"] }
-      );
-      expect(result.content[0].type).toBe("text");
-      const parsed = JSON.parse(result.content[0].text);
-      expect(parsed.id).toBe("task-claim-1");
-    });
-
-    it("should call tasksAdapter.unclaimTask when unclaim_task tool is invoked", async () => {
-      const registry = new DefaultRoleRegistry();
-      const workerWithClaim: RoleDefinition = {
-        name: "pull-worker",
-        displayName: "Pull Worker",
-        description: "Worker with pull mode capabilities",
-        extends: "worker",
-        capabilities: [
-          "file.read",
-          "file.write",
-          "lifecycle.done",
-          "exec.command",
-          "msg.send",
-          TASK_CAPABILITIES.CLAIM,
-        ],
-      };
-      registry.registerRole(workerWithClaim);
-
-      const agentId = "agent-unclaim-test";
-      const mockAgentStore = {
-        getAgent: vi.fn().mockReturnValue({
-          id: agentId,
-          role: "pull-worker",
-          state: "running",
-        }),
-        getChildren: vi.fn().mockReturnValue([]),
-        getDescendants: vi.fn().mockReturnValue([]),
-        listAgents: vi.fn().mockReturnValue([]),
-      } as any;
-
-      const mockTasksAdapter = createMockTasksAdapter();
-      const mockInboxAdapter = createMockInboxAdapter();
-
-      const context: ToolContext = {
-        agent_id: agentId,
-        session_id: "session-4",
-        lineage: [],
-        cwd: testDir,
-      };
-
-      const mcpServer = createMCPServerV2(context, {
-        agentStore: mockAgentStore,
-        agentManager: {} as any,
-        inboxAdapter: mockInboxAdapter as any,
-        tasksAdapter: mockTasksAdapter as any,
-        roleRegistry: registry,
-        taskMode: "pull",
-      });
-
-      const server = mcpServer.server as any;
-      const toolHandlers = server._registeredTools;
-
-      expect(toolHandlers["unclaim_task"]).toBeDefined();
-
-      const toolEntry = toolHandlers["unclaim_task"];
-      const result = await toolEntry.handler({ task_id: "task-claim-1" }, {});
-      expect(mockTasksAdapter.unclaimTask).toHaveBeenCalledWith("task-claim-1");
-      const parsed = JSON.parse(result.content[0].text);
-      expect(parsed.success).toBe(true);
-    });
-
-    it("should call tasksAdapter.listClaimable when list_claimable_tasks tool is invoked", async () => {
-      const registry = new DefaultRoleRegistry();
-      const workerWithClaim: RoleDefinition = {
-        name: "pull-worker",
-        displayName: "Pull Worker",
-        description: "Worker with pull mode capabilities",
-        extends: "worker",
-        capabilities: [
-          "file.read",
-          "file.write",
-          "lifecycle.done",
-          "exec.command",
-          "msg.send",
-          TASK_CAPABILITIES.CLAIM,
-        ],
-      };
-      registry.registerRole(workerWithClaim);
-
-      const agentId = "agent-list-test";
-      const mockAgentStore = {
-        getAgent: vi.fn().mockReturnValue({
-          id: agentId,
-          role: "pull-worker",
-          state: "running",
-        }),
-        getChildren: vi.fn().mockReturnValue([]),
-        getDescendants: vi.fn().mockReturnValue([]),
-        listAgents: vi.fn().mockReturnValue([]),
-      } as any;
-
-      const mockTasksAdapter = createMockTasksAdapter();
-      const mockInboxAdapter = createMockInboxAdapter();
-
-      const context: ToolContext = {
-        agent_id: agentId,
-        session_id: "session-5",
-        lineage: [],
-        cwd: testDir,
-      };
-
-      const mcpServer = createMCPServerV2(context, {
-        agentStore: mockAgentStore,
-        agentManager: {} as any,
-        inboxAdapter: mockInboxAdapter as any,
-        tasksAdapter: mockTasksAdapter as any,
-        roleRegistry: registry,
-        taskMode: "pull",
-      });
-
-      const server = mcpServer.server as any;
-      const toolHandlers = server._registeredTools;
-
-      expect(toolHandlers["list_claimable_tasks"]).toBeDefined();
-
-      const toolEntry = toolHandlers["list_claimable_tasks"];
-      const result = await toolEntry.handler({ tags: ["frontend"], limit: 5 }, {});
-      expect(mockTasksAdapter.listClaimable).toHaveBeenCalledWith({
-        tags: ["frontend"],
-        limit: 5,
-      });
-      const parsed = JSON.parse(result.content[0].text);
-      expect(parsed.tasks).toHaveLength(1);
-      expect(parsed.count).toBe(1);
-    });
-  });
-
-  // ── Test 3: Pull mode done() returns shouldTerminate=false ──
-
-  describe("PULL MODE: done() handler keeps worker alive", () => {
-    it("should return shouldTerminate=false for completed worker in pull mode", async () => {
-      const lifecycleContext: LifecycleContext = {
-        agentId: "worker-pull-1",
-        role: "worker",
-        taskId: "task-1",
-        parentId: "coordinator-1",
-      };
-
-      const args: DoneArgs = {
-        status: "completed",
-        summary: "Task completed successfully",
-      };
-
-      const cleanupStatus: CleanupStatus = {
-        ready: true,
-      };
-
-      const mockInboxAdapter = createMockInboxAdapter();
-      const mockTasksAdapter = createMockTasksAdapter();
-
-      const result = await dispatchDoneV2(
-        lifecycleContext,
-        args,
-        cleanupStatus,
-        {
-          inboxAdapter: mockInboxAdapter as any,
-          tasksAdapter: mockTasksAdapter as any,
-          agentManager: {
-            getChildren: vi.fn().mockReturnValue([]),
-          } as any,
-          taskMode: "pull", // Pull mode!
-        }
-      );
-
-      // In pull mode, completed workers should NOT terminate (stay alive to claim more)
-      expect(result.shouldTerminate).toBe(false);
-      expect(result.signalsEmitted).toContain("WORKER_DONE");
-    });
-
-    it("should return shouldTerminate=true for completed worker in push mode", async () => {
-      const lifecycleContext: LifecycleContext = {
-        agentId: "worker-push-1",
-        role: "worker",
-        taskId: "task-2",
-        parentId: "coordinator-1",
-      };
-
-      const args: DoneArgs = {
-        status: "completed",
-        summary: "Task completed",
-      };
-
-      const cleanupStatus: CleanupStatus = {
-        ready: true,
-      };
-
-      const mockInboxAdapter = createMockInboxAdapter();
-      const mockTasksAdapter = createMockTasksAdapter();
-
-      const result = await dispatchDoneV2(
-        lifecycleContext,
-        args,
-        cleanupStatus,
-        {
-          inboxAdapter: mockInboxAdapter as any,
-          tasksAdapter: mockTasksAdapter as any,
-          agentManager: {
-            getChildren: vi.fn().mockReturnValue([]),
-          } as any,
-          taskMode: "push", // Push mode
-        }
-      );
-
-      // In push mode, completed workers should terminate
-      expect(result.shouldTerminate).toBe(true);
-    });
-
-    it("should return shouldTerminate=true for failed worker in pull mode", async () => {
-      const lifecycleContext: LifecycleContext = {
-        agentId: "worker-pull-fail",
-        role: "worker",
-        taskId: "task-3",
-        parentId: "coordinator-1",
-      };
-
-      const args: DoneArgs = {
-        status: "failed",
-        summary: "Task failed",
-      };
-
-      const cleanupStatus: CleanupStatus = {
-        ready: true,
-      };
-
-      const mockInboxAdapter = createMockInboxAdapter();
-      const mockTasksAdapter = createMockTasksAdapter();
-
-      const result = await dispatchDoneV2(
-        lifecycleContext,
-        args,
-        cleanupStatus,
-        {
-          inboxAdapter: mockInboxAdapter as any,
-          tasksAdapter: mockTasksAdapter as any,
-          agentManager: {
-            getChildren: vi.fn().mockReturnValue([]),
-          } as any,
-          taskMode: "pull",
-        }
-      );
-
-      // Failed workers should still terminate even in pull mode
-      expect(result.shouldTerminate).toBe(true);
-    });
-
-    it("should return shouldTerminate=false for blocked worker regardless of mode", async () => {
-      const lifecycleContext: LifecycleContext = {
-        agentId: "worker-blocked",
-        role: "worker",
-        taskId: "task-4",
-        parentId: "coordinator-1",
-      };
-
-      const args: DoneArgs = {
-        status: "blocked",
-        summary: "Waiting for dependency",
-      };
-
-      const cleanupStatus: CleanupStatus = {
-        ready: true,
-      };
-
-      const mockInboxAdapter = createMockInboxAdapter();
-      const mockTasksAdapter = createMockTasksAdapter();
-
-      const result = await dispatchDoneV2(
-        lifecycleContext,
-        args,
-        cleanupStatus,
-        {
-          inboxAdapter: mockInboxAdapter as any,
-          tasksAdapter: mockTasksAdapter as any,
-          agentManager: {
-            getChildren: vi.fn().mockReturnValue([]),
-          } as any,
-          taskMode: "push",
-        }
-      );
-
-      // Blocked workers never terminate
-      expect(result.shouldTerminate).toBe(false);
-      expect(result.signalsEmitted).toContain("HELP_NEEDED");
-    });
-  });
-});