ma-agents 3.6.2 → 3.8.0

package/test/config-storage.test.js

@@ -1,275 +0,0 @@
-#!/usr/bin/env node
-/**
- * Tests for Story 16.2: Config Storage and Cross-Reference File
- * Tests writeRepoLayoutConfig(), writeProjectLayoutYaml(), writeConfigField(), normalizePath()
- */
-'use strict';
-
-const assert = require('assert');
-const path = require('path');
-const fs = require('fs');
-const os = require('os');
-
-let passed = 0;
-let failed = 0;
-const errors = [];
-
-function test(name, fn) {
-  try {
-    fn();
-    console.log(`  \u2713 ${name}`);
-    passed++;
-  } catch (err) {
-    console.error(`  \u2717 ${name}: ${err.message}`);
-    failed++;
-    errors.push({ name, error: err.message });
-  }
-}
-
-// ─── Load module ─────────────────────────────────────────────────────────────
-let writeConfigField, normalizePath, writeRepoLayoutConfig, writeProjectLayoutYaml;
-try {
-  ({ writeConfigField, normalizePath, writeRepoLayoutConfig, writeProjectLayoutYaml } = require('../bin/cli.js'));
-} catch (e) {
-  console.error('\n  FATAL: Cannot load exports from cli.js');
-  console.error(' ', e.message);
-  process.exit(1);
-}
-
-// ─── normalizePath ──────────────────────────────────────────────────────────
-console.log('\nnormalizePath');
-
-test('converts backslashes to forward slashes', () => {
-  assert.strictEqual(normalizePath('d:\\Code\\agents'), 'd:/Code/agents');
-});
-
-test('leaves forward slashes unchanged', () => {
-  assert.strictEqual(normalizePath('/path/to/repo'), '/path/to/repo');
-});
-
-test('handles dot path', () => {
-  assert.strictEqual(normalizePath('.'), '.');
-});
-
-// ─── writeConfigField ───────────────────────────────────────────────────────
-console.log('\nwriteConfigField');
-
-test('appends field when not present', () => {
-  const result = writeConfigField('existing: value', 'new_field', '/some/path');
-  assert.ok(result.includes('new_field: "/some/path"'), `Got: ${result}`);
-  assert.ok(result.includes('existing: value'), 'preserves existing content');
-});
-
-test('replaces existing field in place', () => {
-  const content = 'knowledgebase_path: "old/path"\nother: value';
-  const result = writeConfigField(content, 'knowledgebase_path', 'new/path');
-  assert.ok(result.includes('knowledgebase_path: "new/path"'), `Got: ${result}`);
-  assert.ok(!result.includes('old/path'), 'old value should be replaced');
-  assert.ok(result.includes('other: value'), 'other fields preserved');
-});
-
-test('does not duplicate field on second write', () => {
-  let content = 'knowledgebase_path: "."\n';
-  content = writeConfigField(content, 'knowledgebase_path', '/new/path');
-  const count = (content.match(/knowledgebase_path/g) || []).length;
-  assert.strictEqual(count, 1, `Field duplicated: count=${count}`);
-});
-
-test('double-quotes path values', () => {
-  const result = writeConfigField('', 'path_field', 'C:/Code/repo');
-  assert.ok(result.includes('"C:/Code/repo"'), 'Path should be double-quoted');
-});
-
-// ─── writeProjectLayoutYaml ─────────────────────────────────────────────────
-console.log('\nwriteProjectLayoutYaml');
-
-test('single-repo: does not create project-layout.yaml', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-test-'));
-  const origCwd = process.cwd();
-  try {
-    process.chdir(tmpDir);
-    fs.mkdirSync('_bmad-output', { recursive: true });
-    writeProjectLayoutYaml({
-      knowledgebase: { mode: 'same', path: '.' },
-      sprintManagement: { mode: 'same', path: '.' }
-    });
-    assert.ok(!fs.existsSync(path.join(tmpDir, '_bmad-output', 'project-layout.yaml')),
-      'project-layout.yaml should NOT be created for single-repo');
-  } finally {
-    process.chdir(origCwd);
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('single-repo: deletes stale project-layout.yaml', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-test-'));
-  const origCwd = process.cwd();
-  try {
-    process.chdir(tmpDir);
-    fs.mkdirSync('_bmad-output', { recursive: true });
-    fs.writeFileSync(path.join(tmpDir, '_bmad-output', 'project-layout.yaml'), 'stale content');
-    writeProjectLayoutYaml({
-      knowledgebase: { mode: 'same', path: '.' },
-      sprintManagement: { mode: 'same', path: '.' }
-    });
-    assert.ok(!fs.existsSync(path.join(tmpDir, '_bmad-output', 'project-layout.yaml')),
-      'stale project-layout.yaml should be deleted');
-  } finally {
-    process.chdir(origCwd);
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('multi-repo: creates project-layout.yaml with correct structure', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-test-'));
-  const origCwd = process.cwd();
-  try {
-    process.chdir(tmpDir);
-    writeProjectLayoutYaml({
-      knowledgebase: { mode: 'local', path: 'd:\\Code\\kb-repo' },
-      sprintManagement: { mode: 'same', path: '.' }
-    });
-    const content = fs.readFileSync(path.join(tmpDir, '_bmad-output', 'project-layout.yaml'), 'utf-8');
-    assert.ok(content.includes('knowledgebase:'), 'should have knowledgebase section');
-    assert.ok(content.includes('mode: local'), 'should have mode: local');
-    assert.ok(content.includes('"d:/Code/kb-repo"'), 'should normalize backslashes and quote');
-    assert.ok(content.includes('sprint_management:'), 'should have sprint_management section');
-    assert.ok(content.includes('mode: same'), 'should have mode: same for sprint');
-    assert.ok(content.includes('generated:'), 'should have generated date');
-  } finally {
-    process.chdir(origCwd);
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('multi-repo remote: includes gitUrl only for remote mode', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-test-'));
-  const origCwd = process.cwd();
-  try {
-    process.chdir(tmpDir);
-    writeProjectLayoutYaml({
-      knowledgebase: { mode: 'remote', path: '/tmp/kb', gitUrl: 'https://git.example.com/kb.git' },
-      sprintManagement: { mode: 'local', path: '/tmp/sprint' }
-    });
-    const content = fs.readFileSync(path.join(tmpDir, '_bmad-output', 'project-layout.yaml'), 'utf-8');
-    assert.ok(content.includes('gitUrl: "https://git.example.com/kb.git"'), 'should include gitUrl for remote');
-    // sprint_management section should NOT have gitUrl
-    const sprintSection = content.split('sprint_management:')[1];
-    assert.ok(!sprintSection.includes('gitUrl'), 'local mode should not have gitUrl');
-  } finally {
-    process.chdir(origCwd);
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('path normalization: backslashes converted in YAML output', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-test-'));
-  const origCwd = process.cwd();
-  try {
-    process.chdir(tmpDir);
-    writeProjectLayoutYaml({
-      knowledgebase: { mode: 'local', path: 'C:\\Users\\dev\\kb' },
-      sprintManagement: { mode: 'same', path: '.' }
-    });
-    const content = fs.readFileSync(path.join(tmpDir, '_bmad-output', 'project-layout.yaml'), 'utf-8');
-    assert.ok(!content.includes('\\'), 'should not contain backslashes');
-    assert.ok(content.includes('C:/Users/dev/kb'), 'should contain normalized path');
-  } finally {
-    process.chdir(origCwd);
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('idempotency: same config produces identical output (except date)', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-test-'));
-  const origCwd = process.cwd();
-  try {
-    process.chdir(tmpDir);
-    const layout = {
-      knowledgebase: { mode: 'local', path: '/stable/path' },
-      sprintManagement: { mode: 'local', path: '/stable/sprint' }
-    };
-    writeProjectLayoutYaml(layout);
-    const first = fs.readFileSync(path.join(tmpDir, '_bmad-output', 'project-layout.yaml'), 'utf-8');
-    writeProjectLayoutYaml(layout);
-    const second = fs.readFileSync(path.join(tmpDir, '_bmad-output', 'project-layout.yaml'), 'utf-8');
-    assert.strictEqual(first, second, 'identical config should produce identical output');
-  } finally {
-    process.chdir(origCwd);
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-// ─── writeRepoLayoutConfig ──────────────────────────────────────────────────
-console.log('\nwriteRepoLayoutConfig');
-
-test('writes path fields to config.yaml', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-test-'));
-  const origCwd = process.cwd();
-  try {
-    process.chdir(tmpDir);
-    const configDir = path.join(tmpDir, '_bmad', 'bmm');
-    fs.mkdirSync(configDir, { recursive: true });
-    fs.writeFileSync(path.join(configDir, 'config.yaml'), '# existing config\n{}');
-    writeRepoLayoutConfig({
-      knowledgebase: { mode: 'local', path: 'd:\\Code\\kb' },
-      sprintManagement: { mode: 'same', path: '.' }
-    });
-    const content = fs.readFileSync(path.join(configDir, 'config.yaml'), 'utf-8');
-    assert.ok(content.includes('knowledgebase_path: "d:/Code/kb"'), `Got: ${content}`);
-    assert.ok(content.includes('sprint_management_path: "."'), `Got: ${content}`);
-  } finally {
-    process.chdir(origCwd);
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('updates existing fields in place', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-test-'));
-  const origCwd = process.cwd();
-  try {
-    process.chdir(tmpDir);
-    const configDir = path.join(tmpDir, '_bmad', 'bmm');
-    fs.mkdirSync(configDir, { recursive: true });
-    fs.writeFileSync(path.join(configDir, 'config.yaml'),
-      '# config\nknowledgebase_path: "."\nsprint_management_path: "."\n');
-    writeRepoLayoutConfig({
-      knowledgebase: { mode: 'local', path: '/new/kb' },
-      sprintManagement: { mode: 'local', path: '/new/sprint' }
-    });
-    const content = fs.readFileSync(path.join(configDir, 'config.yaml'), 'utf-8');
-    assert.ok(content.includes('knowledgebase_path: "/new/kb"'), `Got: ${content}`);
-    assert.ok(content.includes('sprint_management_path: "/new/sprint"'), `Got: ${content}`);
-    const kbCount = (content.match(/knowledgebase_path/g) || []).length;
-    assert.strictEqual(kbCount, 1, 'should not duplicate field');
-  } finally {
-    process.chdir(origCwd);
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-test('handles missing config.yaml gracefully', () => {
-  const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'ma-test-'));
-  const origCwd = process.cwd();
-  try {
-    process.chdir(tmpDir);
-    // No _bmad/bmm/config.yaml — should not throw
-    writeRepoLayoutConfig({
-      knowledgebase: { mode: 'same', path: '.' },
-      sprintManagement: { mode: 'same', path: '.' }
-    });
-    // If we get here without throwing, the test passes
-    assert.ok(true, 'should handle missing config gracefully');
-  } finally {
-    process.chdir(origCwd);
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  }
-});
-
-// ─── Summary ────────────────────────────────────────────────────────────────
-console.log(`\n${passed} passed, ${failed} failed`);
-if (errors.length > 0) {
-  console.log('\nFailed tests:');
-  errors.forEach(e => console.log(`  - ${e.name}: ${e.error}`));
-}
-if (failed > 0) process.exit(1);

package/test/convert-agents-to-skills.test.js

@@ -1,255 +0,0 @@
-#!/usr/bin/env node
-/**
- * Tests for Story 15-3: Convert 5 Custom Agents to BMAD 6.2.0 Skill Folders
- *
- * Verifies:
- * - Each agent has SKILL.md and bmad-skill-manifest.yaml
- * - SKILL.md contains Persona, Menu, Critical Actions sections
- * - bmad-skill-manifest.yaml has all required fields
- * - Menu items reference new skill names (not old paths)
- */
-'use strict';
-
-const assert = require('assert');
-const path = require('path');
-const fs = require('fs');
-
-const PROJECT_ROOT = path.join(__dirname, '..');
-const SKILLS_DIR = path.join(PROJECT_ROOT, 'lib', 'bmad-extension', 'skills');
-
-let passed = 0;
-let failed = 0;
-const errors = [];
-
-function test(name, fn) {
-  try {
-    fn();
-    console.log(`  \u2713 ${name}`);
-    passed++;
-  } catch (err) {
-    console.error(`  \u2717 ${name}: ${err.message}`);
-    failed++;
-    errors.push({ name, error: err.message });
-  }
-}
-
-// ─── Agent definitions ───────────────────────────────────────────────────────
-const AGENTS = [
-  {
-    folder: 'bmad-ma-agent-sre',
-    name: 'bmad-ma-agent-sre',
-    displayName: 'Alex',
-    title: 'SRE Agent',
-    skillNames: ['sre-health-check', 'sre-fix-deployments', 'sre-performance-opt'],
-    oldPaths: ['bmm/workflows/sre/', '_bmad/bmm/workflows/sre/'],
-    chatTopic: 'reliability',
-    menuItemCount: 6 // MH, CH, HC, FD, PO, DA
-  },
-  {
-    folder: 'bmad-ma-agent-devops',
-    name: 'bmad-ma-agent-devops',
-    displayName: 'Amit',
-    title: 'DevOps Agent',
-    skillNames: ['devops-configure-infrastructure', 'devops-optimize-pipelines', 'devops-manage-helm'],
-    oldPaths: ['bmm/workflows/devops/', '_bmad/bmm/workflows/devops/'],
-    chatTopic: 'DevOps',
-    menuItemCount: 6 // MH, CH, CO, PL, MH(helm), DA
-  },
-  {
-    folder: 'bmad-ma-agent-cyber',
-    name: 'bmad-ma-agent-cyber',
-    displayName: 'Yael',
-    title: 'Cyber Analyst',
-    skillNames: ['cyber-vulnerability-scan', 'cyber-security-audit', 'cyber-threat-modeling'],
-    oldPaths: ['bmm/workflows/cyber/', '_bmad/custom/workflows/cyber/'],
-    chatTopic: 'security',
-    menuItemCount: 6 // MH, CH, VS, SA, TM, DA
-  },
-  {
-    folder: 'bmad-ma-agent-sqa',
-    name: 'bmad-ma-agent-sqa',
-    displayName: 'Gad',
-    title: 'Software Quality Assurance & Standards Expert',
-    skillNames: ['sqa-audit', 'sqa-ieee12207', 'sqa-requirements-quality'],
-    oldPaths: ['bmm/workflows/sqa/', '_bmad/bmm/workflows/sqa/'],
-    chatTopic: 'quality assurance',
-    menuItemCount: 14 // MH, CH, AU, IC, RQ, GS, GD, GP, GO, SS, GT, SD, MR, DA
-  },
-  {
-    folder: 'bmad-ma-agent-ml',
-    name: 'bmad-ma-agent-ml',
-    displayName: 'Demerzel',
-    title: 'ML Scientist',
-    skillNames: ['ml-ideation', 'ml-eda', 'ml-architecture', 'ml-detailed-design', 'ml-techspec', 'ml-infra', 'ml-experiment', 'ml-analysis', 'ml-hparam', 'ml-revision', 'ml-advise', 'ml-retrospective'],
-    oldPaths: ['bmm/workflows/ml/', '_bmad/bmm/workflows/ml/'],
-    chatTopic: 'Machine Learning',
-    menuItemCount: 15 // MH, CH, MLI, MLE, MLA, MLD, MLS, MLNF, MLX, MLAN, MLH, MLR, MLAD, MLRT, DA
-  }
-];
-
-const REQUIRED_MANIFEST_FIELDS = [
-  'type', 'name', 'displayName', 'title', 'capabilities',
-  'role', 'identity', 'communicationStyle', 'principles', 'module'
-];
-
-// ─── File existence tests ────────────────────────────────────────────────────
-console.log('\n File existence tests\n');
-
-for (const agent of AGENTS) {
-  const skillDir = path.join(SKILLS_DIR, agent.folder);
-
-  test(`${agent.folder}: SKILL.md exists`, () => {
-    const skillMdPath = path.join(skillDir, 'SKILL.md');
-    assert.ok(fs.existsSync(skillMdPath), `Missing: ${skillMdPath}`);
-  });
-
-  test(`${agent.folder}: bmad-skill-manifest.yaml exists`, () => {
-    const manifestPath = path.join(skillDir, 'bmad-skill-manifest.yaml');
-    assert.ok(fs.existsSync(manifestPath), `Missing: ${manifestPath}`);
-  });
-}
-
-// ─── SKILL.md content tests ─────────────────────────────────────────────────
-console.log('\n SKILL.md content tests\n');
-
-for (const agent of AGENTS) {
-  const skillDir = path.join(SKILLS_DIR, agent.folder);
-  const skillMdPath = path.join(skillDir, 'SKILL.md');
-
-  let content = '';
-  try {
-    content = fs.readFileSync(skillMdPath, 'utf8');
-  } catch (e) {
-    // File not found — tests will fail naturally
-  }
-
-  test(`${agent.folder}: SKILL.md contains Persona section`, () => {
-    assert.ok(content.includes('## Persona'), 'Missing ## Persona section');
-  });
-
-  test(`${agent.folder}: SKILL.md contains Menu section`, () => {
-    assert.ok(content.includes('## Menu'), 'Missing ## Menu section');
-  });
-
-  test(`${agent.folder}: SKILL.md contains Critical Actions section`, () => {
-    assert.ok(content.includes('## Critical Actions'), 'Missing ## Critical Actions section');
-  });
-
-  test(`${agent.folder}: SKILL.md contains Activation Sequence section`, () => {
-    assert.ok(content.includes('## Activation Sequence'), 'Missing ## Activation Sequence section');
-  });
-
-  test(`${agent.folder}: SKILL.md contains agent display name (${agent.displayName})`, () => {
-    assert.ok(content.includes(agent.displayName), `Missing display name: ${agent.displayName}`);
-  });
-
-  test(`${agent.folder}: SKILL.md contains Role field`, () => {
-    assert.ok(content.includes('**Role:**'), 'Missing **Role:** field');
-  });
-
-  test(`${agent.folder}: SKILL.md contains Identity field`, () => {
-    assert.ok(content.includes('**Identity:**'), 'Missing **Identity:** field');
-  });
-
-  test(`${agent.folder}: SKILL.md contains Communication Style field`, () => {
-    assert.ok(content.includes('**Communication Style:**'), 'Missing **Communication Style:** field');
-  });
-
-  test(`${agent.folder}: SKILL.md contains Principles field`, () => {
-    assert.ok(content.includes('**Principles:**'), 'Missing **Principles:** field');
-  });
-
-  // Verify menu references new skill names
-  for (const skillName of agent.skillNames) {
-    test(`${agent.folder}: Menu references skill "${skillName}"`, () => {
-      assert.ok(content.includes(skillName), `Missing skill reference: ${skillName}`);
-    });
-  }
-
-  // Verify NO old workflow paths remain in menu
-  for (const oldPath of agent.oldPaths) {
-    test(`${agent.folder}: No old path references "${oldPath}" in SKILL.md`, () => {
-      assert.ok(!content.includes(oldPath), `Old path still referenced: ${oldPath}`);
-    });
-  }
-}
-
-// ─── bmad-skill-manifest.yaml content tests ──────────────────────────────────
-console.log('\n bmad-skill-manifest.yaml content tests\n');
-
-for (const agent of AGENTS) {
-  const skillDir = path.join(SKILLS_DIR, agent.folder);
-  const manifestPath = path.join(skillDir, 'bmad-skill-manifest.yaml');
-
-  let content = '';
-  try {
-    content = fs.readFileSync(manifestPath, 'utf8');
-  } catch (e) {
-    // File not found — tests will fail naturally
-  }
-
-  // Parse simple YAML key-value pairs (no nested structures expected)
-  const fields = {};
-  for (const line of content.split('\n')) {
-    const match = line.match(/^(\w+):\s*(.+)$/);
-    if (match) {
-      fields[match[1]] = match[2].replace(/^["']|["']$/g, '');
-    }
-  }
-
-  for (const field of REQUIRED_MANIFEST_FIELDS) {
-    test(`${agent.folder}: manifest has required field "${field}"`, () => {
-      assert.ok(fields[field], `Missing or empty field: ${field}`);
-    });
-  }
-
-  test(`${agent.folder}: manifest type is "agent"`, () => {
-    assert.strictEqual(fields.type, 'agent', `Expected type: agent, got: ${fields.type}`);
-  });
-
-  test(`${agent.folder}: manifest name matches "${agent.name}"`, () => {
-    assert.strictEqual(fields.name, agent.name, `Expected name: ${agent.name}, got: ${fields.name}`);
-  });
-
-  test(`${agent.folder}: manifest displayName is "${agent.displayName}"`, () => {
-    assert.strictEqual(fields.displayName, agent.displayName, `Expected displayName: ${agent.displayName}, got: ${fields.displayName}`);
-  });
-
-  test(`${agent.folder}: manifest module is "ma-skills"`, () => {
-    assert.strictEqual(fields.module, 'ma-skills', `Expected module: ma-skills, got: ${fields.module}`);
-  });
-}
-
-// ─── Cross-validation: Critical Actions match extension customize.yaml ────────
-console.log('\n Critical Actions cross-validation\n');
-
-for (const agent of AGENTS) {
-  const skillDir = path.join(SKILLS_DIR, agent.folder);
-  const skillMdPath = path.join(skillDir, 'SKILL.md');
-
-  let content = '';
-  try {
-    content = fs.readFileSync(skillMdPath, 'utf8');
-  } catch (e) {
-    // File not found
-  }
-
-  test(`${agent.folder}: Critical Actions includes MANIFEST reading`, () => {
-    assert.ok(content.includes('Read the skills MANIFEST'), 'Missing MANIFEST reading action');
-  });
-
-  test(`${agent.folder}: Critical Actions includes always_load skill reading`, () => {
-    assert.ok(content.includes('always_load: true'), 'Missing always_load skill reading action');
-  });
-
-  test(`${agent.folder}: Critical Actions includes project-context check`, () => {
-    assert.ok(content.includes('project-context.md'), 'Missing project-context check');
-  });
-}
-
-// ─── Results ──────────────────────────────────────────────────────────────────
-console.log(`\n  ${passed} passed, ${failed} failed\n`);
-if (failed > 0) {
-  errors.forEach(e => console.error(`  \u2717 ${e.name}: ${e.error}`));
-  process.exit(1);
-}