ma-agents 3.4.5 → 3.4.7

package/lib/bmad.js

@@ -207,37 +207,26 @@ async function updateBmad(modules = ['bmm', 'bmb'], tools = [], projectRoot = pr
     // the files-manifest, finds module "custom", and fails because it can't locate
     // the source for a module named "custom". Fix: strip stale "custom" module
     // entries from the manifest so the module gets cleanly reinstalled via --custom-content.
-    const filesManifestPath = path.join(projectRoot, BMAD_DIR, '_config', 'files-manifest.csv');
-    if (fs.existsSync(filesManifestPath)) {
-        try {
-            let csv = await fs.readFile(filesManifestPath, 'utf-8');
-            const before = csv.split('\n').length;
-            csv = csv.split('\n').filter(line => {
-                const fields = line.split(',');
-                return !(fields[2] && fields[2].replace(/"/g, '') === 'custom');
-            }).join('\n');
-            const after = csv.split('\n').length;
-            if (after < before) {
-                await fs.writeFile(filesManifestPath, csv, 'utf-8');
-                console.log(chalk.gray(`  Cleaned ${before - after} stale "custom" module entries from files-manifest.csv`));
-            }
-        } catch (err) {
-            // Non-fatal — worst case the update fails and user retries
-        }
-    }
-
-    // The real trigger: manifest.yaml lists "custom" and "bmb" as previously
-    // installed modules. In --yes (non-interactive) mode, bmad-method preserves
-    // all previously installed modules and tries to reinstall them. "custom" has
-    // no source (it's actually "ma-skills"), and "bmb" has a broken directory
-    // structure in 6.2.2. Fix: remove both from manifest.yaml before update.
+    // bmad-method 6.2.2 bug: on --action update --yes, the installer reads
+    // manifest.yaml to discover previously installed modules, then preserves them
+    // all (non-interactive default). It then tries to reinstall each one.
+    // "custom" fails because there's no source under that name (it's "ma-skills"),
+    // and "bmb" fails due to a broken directory structure in 6.2.2.
+    //
+    // Fix: before running bmad-method, clean all three persistence layers:
+    //   1. manifest.yaml   — remove stale module entries
+    //   2. files-manifest.csv — remove stale file tracking entries
+    //   3. physical directories — remove _bmad/bmb/ and _bmad/_config/custom/
+
+    const staleModules = ['custom', 'bmb'];
+
+    // 1. Clean manifest.yaml (the primary trigger for the re-install loop)
     const yamlManifestPath = path.join(projectRoot, BMAD_DIR, '_config', 'manifest.yaml');
     if (fs.existsSync(yamlManifestPath)) {
         try {
             const yamlContent = await fs.readFile(yamlManifestPath, 'utf-8');
             const manifest = yaml.parse(yamlContent);
             if (manifest?.modules && Array.isArray(manifest.modules)) {
-                const staleModules = ['custom', 'bmb'];
                 const before = manifest.modules.length;
                 manifest.modules = manifest.modules.filter(
                     m => !staleModules.includes(typeof m === 'string' ? m : m.name)
@@ -253,17 +242,46 @@ async function updateBmad(modules = ['bmm', 'bmb'], tools = [], projectRoot = pr
         }
     }
 
-    // Remove stale _config/custom/ cache directory that can confuse module scanning
-    const customCacheDir = path.join(projectRoot, BMAD_DIR, '_config', 'custom');
-    if (fs.existsSync(customCacheDir)) {
+    // 2. Clean files-manifest.csv (prevents stale file-tracking references)
+    const filesManifestPath = path.join(projectRoot, BMAD_DIR, '_config', 'files-manifest.csv');
+    if (fs.existsSync(filesManifestPath)) {
         try {
-            await fs.remove(customCacheDir);
-            console.log(chalk.gray('  Removed stale _config/custom/ cache directory'));
+            let csv = await fs.readFile(filesManifestPath, 'utf-8');
+            const before = csv.split('\n').length;
+            csv = csv.split('\n').filter(line => {
+                const fields = line.split(',');
+                const mod = fields[2] && fields[2].replace(/"/g, '');
+                return !staleModules.includes(mod);
+            }).join('\n');
+            const after = csv.split('\n').length;
+            if (after < before) {
+                await fs.writeFile(filesManifestPath, csv, 'utf-8');
+                console.log(chalk.gray(`  Cleaned ${before - after} stale entries from files-manifest.csv`));
+            }
         } catch (err) {
             // Non-fatal
         }
     }
 
+    // 3. Remove physical directories so bmad-method's manifest-generator
+    //    doesn't re-discover them via scanInstalledModules().
+    //    _bmad/custom/ is safe to remove — applyCustomizations() recreates it after.
+    const staleDirs = [
+        path.join(projectRoot, BMAD_DIR, 'bmb'),
+        path.join(projectRoot, BMAD_DIR, 'custom'),
+        path.join(projectRoot, BMAD_DIR, '_config', 'custom'),
+    ];
+    for (const dir of staleDirs) {
+        if (fs.existsSync(dir)) {
+            try {
+                await fs.remove(dir);
+                console.log(chalk.gray(`  Removed stale directory: ${path.relative(projectRoot, dir)}`));
+            } catch (err) {
+                // Non-fatal
+            }
+        }
+    }
+
     console.log(chalk.gray(`  Running: ${command}`));
     try {
         runCommand(command, { cwd: projectRoot, env: { ...process.env, GIT_TERMINAL_PROMPT: '0' } });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ma-agents",
-  "version": "3.4.5",
+  "version": "3.4.7",
   "description": "NPX tool to install skills for AI coding agents (Claude Code, Gemini, Copilot, Kilocode, Cline, Cursor, Roo Code)",
   "main": "index.js",
   "bin": {