ma-agents 3.4.4 → 3.4.5

package/lib/bmad.js

@@ -3,6 +3,7 @@ const path = require('path');
 const os = require('os');
 const { execSync } = require('child_process');
 const chalk = require('chalk');
+const yaml = require('yaml');
 
 const BMAD_DIR = '_bmad';
 const CONFIG_DIR = path.join(BMAD_DIR, '_config', 'agents');
@@ -206,10 +207,10 @@ async function updateBmad(modules = ['bmm', 'bmb'], tools = [], projectRoot = pr
     // the files-manifest, finds module "custom", and fails because it can't locate
     // the source for a module named "custom". Fix: strip stale "custom" module
     // entries from the manifest so the module gets cleanly reinstalled via --custom-content.
-    const manifestPath = path.join(projectRoot, BMAD_DIR, '_config', 'files-manifest.csv');
-    if (fs.existsSync(manifestPath)) {
+    const filesManifestPath = path.join(projectRoot, BMAD_DIR, '_config', 'files-manifest.csv');
+    if (fs.existsSync(filesManifestPath)) {
         try {
-            let csv = await fs.readFile(manifestPath, 'utf-8');
+            let csv = await fs.readFile(filesManifestPath, 'utf-8');
             const before = csv.split('\n').length;
             csv = csv.split('\n').filter(line => {
                 const fields = line.split(',');
@@ -217,7 +218,7 @@ async function updateBmad(modules = ['bmm', 'bmb'], tools = [], projectRoot = pr
             }).join('\n');
             const after = csv.split('\n').length;
             if (after < before) {
-                await fs.writeFile(manifestPath, csv, 'utf-8');
+                await fs.writeFile(filesManifestPath, csv, 'utf-8');
                 console.log(chalk.gray(`  Cleaned ${before - after} stale "custom" module entries from files-manifest.csv`));
             }
         } catch (err) {
@@ -225,6 +226,44 @@ async function updateBmad(modules = ['bmm', 'bmb'], tools = [], projectRoot = pr
         }
     }
 
+    // The real trigger: manifest.yaml lists "custom" and "bmb" as previously
+    // installed modules. In --yes (non-interactive) mode, bmad-method preserves
+    // all previously installed modules and tries to reinstall them. "custom" has
+    // no source (it's actually "ma-skills"), and "bmb" has a broken directory
+    // structure in 6.2.2. Fix: remove both from manifest.yaml before update.
+    const yamlManifestPath = path.join(projectRoot, BMAD_DIR, '_config', 'manifest.yaml');
+    if (fs.existsSync(yamlManifestPath)) {
+        try {
+            const yamlContent = await fs.readFile(yamlManifestPath, 'utf-8');
+            const manifest = yaml.parse(yamlContent);
+            if (manifest?.modules && Array.isArray(manifest.modules)) {
+                const staleModules = ['custom', 'bmb'];
+                const before = manifest.modules.length;
+                manifest.modules = manifest.modules.filter(
+                    m => !staleModules.includes(typeof m === 'string' ? m : m.name)
+                );
+                const removed = before - manifest.modules.length;
+                if (removed > 0) {
+                    await fs.writeFile(yamlManifestPath, yaml.stringify(manifest), 'utf-8');
+                    console.log(chalk.gray(`  Cleaned ${removed} stale module(s) from manifest.yaml`));
+                }
+            }
+        } catch (err) {
+            // Non-fatal
+        }
+    }
+
+    // Remove stale _config/custom/ cache directory that can confuse module scanning
+    const customCacheDir = path.join(projectRoot, BMAD_DIR, '_config', 'custom');
+    if (fs.existsSync(customCacheDir)) {
+        try {
+            await fs.remove(customCacheDir);
+            console.log(chalk.gray('  Removed stale _config/custom/ cache directory'));
+        } catch (err) {
+            // Non-fatal
+        }
+    }
+
     console.log(chalk.gray(`  Running: ${command}`));
     try {
         runCommand(command, { cwd: projectRoot, env: { ...process.env, GIT_TERMINAL_PROMPT: '0' } });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ma-agents",
-  "version": "3.4.4",
+  "version": "3.4.5",
   "description": "NPX tool to install skills for AI coding agents (Claude Code, Gemini, Copilot, Kilocode, Cline, Cursor, Roo Code)",
   "main": "index.js",
   "bin": {