ma-agents 3.16.0 → 3.17.0-beta.1

package/lib/installer.js

@@ -14,6 +14,11 @@ const TEMPLATE_PATH = path.join(__dirname, 'templates', 'project-context.templat
 const UNIVERSAL_INSTRUCTION_TEMPLATE_PATH = path.join(__dirname, 'templates', 'instruction-block-universal.template.md');
 const GIT_INSTRUCTION_TEMPLATE_PATH = path.join(__dirname, 'templates', 'instruction-block-git.template.md');
 const ONPREM_INSTRUCTION_TEMPLATE_PATH = path.join(__dirname, 'templates', 'instruction-block-onprem.template.md');
+// Retained for test reference (test/clinerules.test.js asserts the template's
+// existence + body). Production template selection is now registry-driven via
+// agent.injectionStrategy.framingTemplate + EXTRA_TEMPLATE_DIR (Story 30.9), so
+// this constant is no longer read by install logic — do not reintroduce an
+// agent-id literal that consumes it directly.
 const CLINERULES_TEMPLATE_PATH = path.join(__dirname, 'templates', 'clinerules.template.md');
 const EXTRA_TEMPLATE_DIR = path.join(__dirname, 'templates');
 
@@ -1238,21 +1243,28 @@ async function updateAgentInstructions(agent, projectRoot, opts = {}) {
   const wrappedInstruction = `${markerStart}${planningInstruction}${markerEnd}`;
   const wrappedInstructionWithTrailingNewline = wrappedInstruction + '\n';
 
-  // Story 21.5 AC #6 — Cline dual-file drift detection.
+  // Story 21.5 AC #6 / Story 30.9 — dual-file drift detection, driven by the
+  // registry's injectionStrategy.dualFileDriftCheck flag rather than a
+  // hardcoded agent-id literal (test/agent-injection-strategy.test.js #3.3).
   // Runs BEFORE the file loop so we abort cleanly without partial writes.
   // `--yes` does NOT bypass (explicit documented exception, AC #6).
-  if (agent.id === 'cline') {
+  if (agent.injectionStrategy?.dualFileDriftCheck) {
     checkClinerulesDualFileDrift(projectRoot);
   }
 
-  // Story 21.5 AC #1, #2 — optional framing template for fresh Cline file creation.
-  // The composer produces the universal body once; the framing supplies the
-  // Cline-flavored header paragraph + Architect-mode guidance line. Framing is
+  // Story 21.5 AC #1, #2 / Story 30.9 — optional framing template for fresh
+  // file creation. The composer produces the universal body once; the
+  // framing supplies an agent-flavored header/guidance wrapper. Framing is
   // only used when creating a NEW file — existing files go through the normal
   // marker-replace path so user content outside markers is preserved (AC #4).
+  // The template name is registry-driven (injectionStrategy.framingTemplate),
+  // not gated on the agent id literal.
   let frameworkTemplate = null;
-  if (agent.id === 'cline' && fs.existsSync(CLINERULES_TEMPLATE_PATH)) {
-    frameworkTemplate = fs.readFileSync(CLINERULES_TEMPLATE_PATH, 'utf-8');
+  if (agent.injectionStrategy?.framingTemplate) {
+    const framingTemplatePath = path.join(EXTRA_TEMPLATE_DIR, agent.injectionStrategy.framingTemplate);
+    if (fs.existsSync(framingTemplatePath)) {
+      frameworkTemplate = fs.readFileSync(framingTemplatePath, 'utf-8');
+    }
   }
 
   for (const fileName of agent.instructionFiles) {