ma-agents 3.16.0 → 3.17.0-beta.0

package/lib/bmad-extension/.claude-plugin/marketplace.json.template

@@ -11,7 +11,7 @@
   "owner": {
     "name": "Alon Mayaffit"
   },
-  "description": "ma-agents BMAD extension — enterprise SDLC personas (Yael, Amit, Alex, Demerzel, Gadi) plus MIL-STD-498, SRE, DevOps, Cyber, ML, and SQA workflow skills.",
+  "description": "ma-agents BMAD extension — enterprise SDLC personas (Yael, Amit, Alex, Gadi) plus MIL-STD-498, SRE, DevOps, Cyber, and SQA workflow skills.",
   "license": "MIT",
   "homepage": "https://github.com/mayafit/AI_Agents",
   "repository": "https://github.com/mayafit/AI_Agents",
@@ -39,7 +39,7 @@
     "roo-code",
     "kilocode"
   ],
-  "bmad_min_version": "6.9.0",
+  "bmad_min_version": "6.10.0",
   "plugins": [
     {
       "name": "ma-skills",
@@ -52,7 +52,6 @@
       "skills": [
         "./skills/ma-agent-cyber",
         "./skills/ma-agent-devops",
-        "./skills/ma-agent-ml",
         "./skills/ma-agent-sqa",
         "./skills/ma-agent-sre",
         "./skills/mil498-ocd",
@@ -85,18 +84,6 @@
         "./skills/cyber-verify-docker-users",
         "./skills/cyber-verify-image-signature",
         "./skills/cyber-vulnerability-scan",
-        "./skills/ml-advise",
-        "./skills/ml-analysis",
-        "./skills/ml-architecture",
-        "./skills/ml-detailed-design",
-        "./skills/ml-eda",
-        "./skills/ml-experiment",
-        "./skills/ml-hparam",
-        "./skills/ml-ideation",
-        "./skills/ml-infra",
-        "./skills/ml-retrospective",
-        "./skills/ml-revision",
-        "./skills/ml-techspec",
         "./skills/add-sprint",
         "./skills/add-to-sprint",
         "./skills/bmad-dev-epic",

package/lib/bmad-extension/skills/module-help.csv

@@ -2,7 +2,6 @@ module,phase,name,code,sequence,workflow-file,command,required,agent,options,des
 ma-skills,anytime,SRE Agent,ma-agent-sre,,skill:ma-agent-sre,ma-agent-sre,false,bmm-sre,,"Site Reliability Engineer agent for system availability, reliability, and Kubernetes operations.",output_folder,"agent customization",
 ma-skills,anytime,DevOps Agent,ma-agent-devops,,skill:ma-agent-devops,ma-agent-devops,false,bmm-devops,,"DevOps Engineer agent for CI/CD pipeline automation, Infrastructure as Code, and cloud-native technologies.",output_folder,"agent customization",
 ma-skills,anytime,Cyber Agent,ma-agent-cyber,,skill:ma-agent-cyber,ma-agent-cyber,false,bmm-cyber,,"Cyber Security Analyst agent for vulnerability assessment, threat modeling, and system hardening.",output_folder,"agent customization",
-ma-skills,anytime,ML Scientist Agent,ma-agent-ml,,skill:ma-agent-ml,ma-agent-ml,false,bmm-demerzel,,"Machine Learning Scientist agent for hypothesis-driven ML lifecycle with scientific rigor.",output_folder,"agent customization",
 ma-skills,anytime,SQA Agent,ma-agent-sqa,,skill:ma-agent-sqa,ma-agent-sqa,false,bmm-qa,,"Software Quality Assurance agent (Gadi) for project auditing, compliance verification, and quality reporting.",output_folder,"agent customization",
 ma-skills,4-implementation,Generate SSS,mil498-sss,,skill:mil498-sss,bmad-mil-generate-sss,false,bmm-mil498,,"Generate a MIL-STD-498 System/Subsystem Specification (SSS).",output_folder,"MIL-498 document",
 ma-skills,4-implementation,Generate SSDD,mil498-ssdd,,skill:mil498-ssdd,bmad-mil-generate-ssdd,false,bmm-mil498,,"Generate a MIL-STD-498 System/Subsystem Design Description (SSDD).",output_folder,"MIL-498 document",
@@ -31,18 +30,6 @@ ma-skills,4-implementation,Vault Secrets,cyber-vault-secrets,,skill:cyber-vault-
 ma-skills,4-implementation,Verify Docker Users,cyber-verify-docker-users,,skill:cyber-verify-docker-users,bmad-cyber-verify-docker-users,false,bmm-cyber,,"Verify Docker image user configurations and hardening compliance.",output_folder,"verification report",
 ma-skills,4-implementation,Verify Image Signature,cyber-verify-image-signature,,skill:cyber-verify-image-signature,bmad-cyber-verify-image-signature,false,bmm-cyber,,"Verify Docker image signatures for supply chain integrity.",output_folder,"verification report",
 ma-skills,4-implementation,Vulnerability Scan,cyber-vulnerability-scan,,skill:cyber-vulnerability-scan,bmad-cyber-vulnerability-scan,false,bmm-cyber,,"Orchestrate vulnerability scanning across project components.",output_folder,"scan report",
-ma-skills,4-implementation,ML Ideation,ml-ideation,,skill:ml-ideation,ml-ideation,false,bmm-demerzel,,"Frame an ML research problem, produce a Research Thesis and PRD.",_bmad-output,"research thesis",
-ma-skills,4-implementation,ML EDA,ml-eda,,skill:ml-eda,ml-eda,false,bmm-demerzel,,"Exploratory Data Analysis — establish baselines and produce an EDA report.",_bmad-output,"EDA report",
-ma-skills,4-implementation,ML Architecture,ml-architecture,,skill:ml-architecture,ml-architecture,false,bmm-demerzel,,"Define model architecture, stack, and experiment tracking strategy.",_bmad-output,"architecture spec",
-ma-skills,4-implementation,ML Detailed Design,ml-detailed-design,,skill:ml-detailed-design,ml-detailed-design,false,bmm-demerzel,,"Break implementation into INF-* and EXP-* tasks.",_bmad-output,"task breakdown",
-ma-skills,4-implementation,ML TechSpec,ml-techspec,,skill:ml-techspec,ml-techspec,false,bmm-demerzel,,"Lock experiment parameters and performance tiers before training.",_bmad-output,"TechSpec",
-ma-skills,4-implementation,ML Infra,ml-infra,,skill:ml-infra,ml-infra,false,bmm-demerzel,,"Build ML infrastructure, manage dependencies, and run smoke tests.",_bmad-output,"infra report",
-ma-skills,4-implementation,ML Experiment,ml-experiment,,skill:ml-experiment,ml-experiment,false,bmm-demerzel,,"Execute training experiments against locked TechSpec and log metrics.",_bmad-output,"experiment log",
-ma-skills,4-implementation,ML Analysis,ml-analysis,,skill:ml-analysis,ml-analysis,false,bmm-demerzel,,"Evaluate experiment outcomes against TechSpec success tiers.",_bmad-output,"analysis report",
-ma-skills,4-implementation,ML Hyperparameter Optimization,ml-hparam,,skill:ml-hparam,ml-hparam,false,bmm-demerzel,,"Automated hyperparameter optimization (Optuna, W&B Sweeps, Ray Tune).",_bmad-output,"hparam report",
-ma-skills,4-implementation,ML Revision,ml-revision,,skill:ml-revision,ml-revision,false,bmm-demerzel,,"Amend hypothesis and requirements based on experiment findings.",_bmad-output,"revision doc",
-ma-skills,4-implementation,ML Advise,ml-advise,,skill:ml-advise,ml-advise,false,bmm-demerzel,,"Search past experiments, surface findings and failure warnings.",_bmad-output,"advisory report",
-ma-skills,4-implementation,ML Retrospective,ml-retrospective,,skill:ml-retrospective,ml-retrospective,false,bmm-demerzel,,"Capture session learnings and update project context.",_bmad-output,"retrospective",
 ma-skills,4-implementation,SQA Audit,sqa-audit,,skill:sqa-audit,sqa-audit,false,bmm-qa,,"Comprehensive project quality audit covering code-to-story traceability, story-to-architecture alignment, process compliance, sprint health, and release state.",_bmad-output,"audit report",
 ma-skills,4-implementation,IEEE 12207 Compliance,sqa-ieee12207,,skill:sqa-ieee12207,sqa-ieee12207,false,bmm-qa,,"Evaluate the project against IEEE/ISO/IEC 12207:2017 software lifecycle processes — produces a compliance matrix and gap analysis report.",_bmad-output,"compliance report",
 ma-skills,4-implementation,Create Bug Story,create-bug-story,,skill:create-bug-story,create-bug-story,false,bmm-dev,,"Create a structured bug story from a detected defect and add to backlog.",_bmad-output/implementation-artifacts,"bug story",

package/lib/bmad-extension-plugin/.claude-plugin/marketplace.json

@@ -3,7 +3,7 @@
   "owner": {
     "name": "Alon Mayaffit"
   },
-  "description": "ma-agents BMAD extension — enterprise SDLC personas (Yael, Amit, Alex, Demerzel, Gadi) plus MIL-STD-498, SRE, DevOps, Cyber, ML, and SQA workflow skills.",
+  "description": "ma-agents BMAD extension — enterprise SDLC personas (Yael, Amit, Alex, Gadi) plus MIL-STD-498, SRE, DevOps, Cyber, and SQA workflow skills.",
   "license": "MIT",
   "homepage": "https://github.com/mayafit/AI_Agents",
   "repository": "https://github.com/mayafit/AI_Agents",
@@ -31,20 +31,19 @@
     "roo-code",
     "kilocode"
   ],
-  "bmad_min_version": "6.9.0",
+  "bmad_min_version": "6.10.0",
   "plugins": [
     {
       "name": "ma-skills",
       "source": "./",
       "description": "ma-agents extension module providing enterprise SDLC personas and operational workflow skills.",
-      "version": "3.16.0",
+      "version": "3.17.0-beta.0",
       "author": {
         "name": "Alon Mayaffit"
       },
       "skills": [
         "./skills/ma-agent-cyber",
         "./skills/ma-agent-devops",
-        "./skills/ma-agent-ml",
         "./skills/ma-agent-sqa",
         "./skills/ma-agent-sre",
         "./skills/mil498-ocd",
@@ -77,18 +76,6 @@
         "./skills/cyber-verify-docker-users",
         "./skills/cyber-verify-image-signature",
         "./skills/cyber-vulnerability-scan",
-        "./skills/ml-advise",
-        "./skills/ml-analysis",
-        "./skills/ml-architecture",
-        "./skills/ml-detailed-design",
-        "./skills/ml-eda",
-        "./skills/ml-experiment",
-        "./skills/ml-hparam",
-        "./skills/ml-ideation",
-        "./skills/ml-infra",
-        "./skills/ml-retrospective",
-        "./skills/ml-revision",
-        "./skills/ml-techspec",
         "./skills/add-sprint",
         "./skills/add-to-sprint",
         "./skills/bmad-dev-epic",

package/lib/bmad-extension-plugin/skills/module-help.csv

@@ -2,7 +2,6 @@ module,phase,name,code,sequence,workflow-file,command,required,agent,options,des
 ma-skills,anytime,SRE Agent,ma-agent-sre,,skill:ma-agent-sre,ma-agent-sre,false,bmm-sre,,"Site Reliability Engineer agent for system availability, reliability, and Kubernetes operations.",output_folder,"agent customization",
 ma-skills,anytime,DevOps Agent,ma-agent-devops,,skill:ma-agent-devops,ma-agent-devops,false,bmm-devops,,"DevOps Engineer agent for CI/CD pipeline automation, Infrastructure as Code, and cloud-native technologies.",output_folder,"agent customization",
 ma-skills,anytime,Cyber Agent,ma-agent-cyber,,skill:ma-agent-cyber,ma-agent-cyber,false,bmm-cyber,,"Cyber Security Analyst agent for vulnerability assessment, threat modeling, and system hardening.",output_folder,"agent customization",
-ma-skills,anytime,ML Scientist Agent,ma-agent-ml,,skill:ma-agent-ml,ma-agent-ml,false,bmm-demerzel,,"Machine Learning Scientist agent for hypothesis-driven ML lifecycle with scientific rigor.",output_folder,"agent customization",
 ma-skills,anytime,SQA Agent,ma-agent-sqa,,skill:ma-agent-sqa,ma-agent-sqa,false,bmm-qa,,"Software Quality Assurance agent (Gadi) for project auditing, compliance verification, and quality reporting.",output_folder,"agent customization",
 ma-skills,4-implementation,Generate SSS,mil498-sss,,skill:mil498-sss,bmad-mil-generate-sss,false,bmm-mil498,,"Generate a MIL-STD-498 System/Subsystem Specification (SSS).",output_folder,"MIL-498 document",
 ma-skills,4-implementation,Generate SSDD,mil498-ssdd,,skill:mil498-ssdd,bmad-mil-generate-ssdd,false,bmm-mil498,,"Generate a MIL-STD-498 System/Subsystem Design Description (SSDD).",output_folder,"MIL-498 document",
@@ -31,18 +30,6 @@ ma-skills,4-implementation,Vault Secrets,cyber-vault-secrets,,skill:cyber-vault-
 ma-skills,4-implementation,Verify Docker Users,cyber-verify-docker-users,,skill:cyber-verify-docker-users,bmad-cyber-verify-docker-users,false,bmm-cyber,,"Verify Docker image user configurations and hardening compliance.",output_folder,"verification report",
 ma-skills,4-implementation,Verify Image Signature,cyber-verify-image-signature,,skill:cyber-verify-image-signature,bmad-cyber-verify-image-signature,false,bmm-cyber,,"Verify Docker image signatures for supply chain integrity.",output_folder,"verification report",
 ma-skills,4-implementation,Vulnerability Scan,cyber-vulnerability-scan,,skill:cyber-vulnerability-scan,bmad-cyber-vulnerability-scan,false,bmm-cyber,,"Orchestrate vulnerability scanning across project components.",output_folder,"scan report",
-ma-skills,4-implementation,ML Ideation,ml-ideation,,skill:ml-ideation,ml-ideation,false,bmm-demerzel,,"Frame an ML research problem, produce a Research Thesis and PRD.",_bmad-output,"research thesis",
-ma-skills,4-implementation,ML EDA,ml-eda,,skill:ml-eda,ml-eda,false,bmm-demerzel,,"Exploratory Data Analysis — establish baselines and produce an EDA report.",_bmad-output,"EDA report",
-ma-skills,4-implementation,ML Architecture,ml-architecture,,skill:ml-architecture,ml-architecture,false,bmm-demerzel,,"Define model architecture, stack, and experiment tracking strategy.",_bmad-output,"architecture spec",
-ma-skills,4-implementation,ML Detailed Design,ml-detailed-design,,skill:ml-detailed-design,ml-detailed-design,false,bmm-demerzel,,"Break implementation into INF-* and EXP-* tasks.",_bmad-output,"task breakdown",
-ma-skills,4-implementation,ML TechSpec,ml-techspec,,skill:ml-techspec,ml-techspec,false,bmm-demerzel,,"Lock experiment parameters and performance tiers before training.",_bmad-output,"TechSpec",
-ma-skills,4-implementation,ML Infra,ml-infra,,skill:ml-infra,ml-infra,false,bmm-demerzel,,"Build ML infrastructure, manage dependencies, and run smoke tests.",_bmad-output,"infra report",
-ma-skills,4-implementation,ML Experiment,ml-experiment,,skill:ml-experiment,ml-experiment,false,bmm-demerzel,,"Execute training experiments against locked TechSpec and log metrics.",_bmad-output,"experiment log",
-ma-skills,4-implementation,ML Analysis,ml-analysis,,skill:ml-analysis,ml-analysis,false,bmm-demerzel,,"Evaluate experiment outcomes against TechSpec success tiers.",_bmad-output,"analysis report",
-ma-skills,4-implementation,ML Hyperparameter Optimization,ml-hparam,,skill:ml-hparam,ml-hparam,false,bmm-demerzel,,"Automated hyperparameter optimization (Optuna, W&B Sweeps, Ray Tune).",_bmad-output,"hparam report",
-ma-skills,4-implementation,ML Revision,ml-revision,,skill:ml-revision,ml-revision,false,bmm-demerzel,,"Amend hypothesis and requirements based on experiment findings.",_bmad-output,"revision doc",
-ma-skills,4-implementation,ML Advise,ml-advise,,skill:ml-advise,ml-advise,false,bmm-demerzel,,"Search past experiments, surface findings and failure warnings.",_bmad-output,"advisory report",
-ma-skills,4-implementation,ML Retrospective,ml-retrospective,,skill:ml-retrospective,ml-retrospective,false,bmm-demerzel,,"Capture session learnings and update project context.",_bmad-output,"retrospective",
 ma-skills,4-implementation,SQA Audit,sqa-audit,,skill:sqa-audit,sqa-audit,false,bmm-qa,,"Comprehensive project quality audit covering code-to-story traceability, story-to-architecture alignment, process compliance, sprint health, and release state.",_bmad-output,"audit report",
 ma-skills,4-implementation,IEEE 12207 Compliance,sqa-ieee12207,,skill:sqa-ieee12207,sqa-ieee12207,false,bmm-qa,,"Evaluate the project against IEEE/ISO/IEC 12207:2017 software lifecycle processes — produces a compliance matrix and gap analysis report.",_bmad-output,"compliance report",
 ma-skills,4-implementation,Create Bug Story,create-bug-story,,skill:create-bug-story,create-bug-story,false,bmm-dev,,"Create a structured bug story from a detected defect and add to backlog.",_bmad-output/implementation-artifacts,"bug story",

package/lib/bmad.js

@@ -1670,6 +1670,119 @@ async function deployClineWorkflows(projectRoot, tools = []) {
     }
 }
 
+/**
+ * Story 30.6b — install the user's selected custom-marketplace subset
+ * (30.6a's wizard selection, pruned + staged by
+ * `lib/custom-marketplace.js#stageCustomMarketplaceSubset`) via bmad-method's
+ * own `--custom-source`, reusing this module's EXISTING install-invocation
+ * primitives (`buildBmadArgs`, `runCommand`, `buildChildSpawnEnv`,
+ * `deployClineWorkflows`) — no new child-process or git logic is hand-rolled.
+ *
+ * Callers MUST gate this on the preceding base BMAD install/update step
+ * having left a usable installation (AC 6, 30.6b) — this function assumes
+ * `_bmad/` already exists and only ever passes `--action update`.
+ *
+ * @param {Object} ctx
+ * @param {string} ctx.projectRoot
+ * @param {string[]} ctx.modules - The same bmad module set used for the base install.
+ * @param {string[]} ctx.tools - The same IDE/tool set used for the base install.
+ * @param {{ source: string, mode: 'discovery'|'direct', selectedCodes: string[],
+ *   plugins: Array<Object>, rootDir: string, sourceUrl: string|null }} ctx.selection -
+ *   30.6a's `promptCustomMarketplace()` return value (extended with `rootDir`/`sourceUrl`).
+ * @returns {Promise<boolean>} true on success; false on any failure (logged, never thrown).
+ */
+async function installCustomMarketplaceSubset({ projectRoot, modules, tools, selection, deps = {} }) {
+    // Lazy require — mirrors the ensurePluginStageGitignoredForProject()
+    // pattern above (avoids a load-order circular dependency, since this
+    // function is the only bmad.js call site that needs the adapter).
+    const customMarketplace = require('./custom-marketplace');
+    const { CustomMarketplaceError } = customMarketplace;
+
+    // Injectable seam (defaults to the real implementations) — lets unit
+    // tests exercise this function's own orchestration logic (staging
+    // failure handling, success/failure branching, Cline reconcile,
+    // stage-cleanup-vs-leave-in-place policy) without spawning a real
+    // bmad-method child process or fighting Node's require-cache semantics
+    // to stub out module-internal function bindings.
+    const stageFn = deps.stageCustomMarketplaceSubset || customMarketplace.stageCustomMarketplaceSubset;
+    const runCommandFn = deps.runCommand || runCommand;
+    const deployClineWorkflowsFn = deps.deployClineWorkflows || deployClineWorkflows;
+    const cleanupStageFn = deps.cleanupStage || cleanupStage;
+    const buildChildSpawnEnvFn = deps.buildChildSpawnEnv || buildChildSpawnEnv;
+    // Story 30.7 (FR242) — persist the source + selection (+ SHA pin) once the
+    // subset is actually installed. Lazy-required for the same load-order
+    // reason as `./custom-marketplace` above; injectable so tests can assert
+    // the persisted shape without depending on the real .ma-agents.json path.
+    const setCustomMarketplaceSelectionFn = deps.setCustomMarketplaceSelection || require('./profile').setCustomMarketplaceSelection;
+
+    let stagePath;
+    let customSourceArg;
+    let resolvedModules;
+    try {
+        ({ stagePath, customSourceArg, resolvedModules } = await stageFn({
+            source: selection.source,
+            mode: selection.mode,
+            rootDir: selection.rootDir,
+            sourceUrl: selection.sourceUrl,
+            plugins: selection.plugins,
+            selectedCodes: selection.selectedCodes,
+            projectRoot,
+        }));
+    } catch (err) {
+        const message = err instanceof CustomMarketplaceError ? err.message : `Custom marketplace staging error: ${err.message}`;
+        console.error(chalk.red(`  Custom marketplace subset staging failed: ${message}`));
+        return false;
+    }
+
+    const command = buildBmadArgs({
+        projectRoot,
+        modules,
+        tools,
+        action: 'update',
+        customSource: customSourceArg,
+    });
+
+    console.log(chalk.cyan(`  Installing custom marketplace subset (${selection.selectedCodes.join(', ')})...`));
+    console.log(chalk.gray(`  Running: ${command}`));
+
+    try {
+        runCommandFn(command, { cwd: projectRoot, env: buildChildSpawnEnvFn() });
+        // FR242 — reconcile Cline workflow wrappers for any newly-installed
+        // custom module, same mechanism official-module installs already use.
+        await deployClineWorkflowsFn(projectRoot, tools);
+        // Only clean up the stage once BOTH the bmad-method invocation and the
+        // Cline reconcile succeeded — mirrors installBmad()'s "leave the stage
+        // for diagnostics on any post-invoke failure" policy (AC 8, 30.6b).
+        cleanupStageFn(stagePath);
+
+        // Story 30.7 (FR242) — persist source + selection (+ SHA pin) now that
+        // the subset is actually installed. `resolvedModules[].cloneSha` is
+        // only stamped for Git-URL sources (see custom-module-manager.js
+        // `resolvePlugin()`); local-path sources persist `sha: null`, which is
+        // the correct value (no commit concept applies). A persistence
+        // failure is logged as a warning only — it must never turn an
+        // otherwise-successful install into a reported failure.
+        try {
+            const sha = (resolvedModules || []).map((m) => m.cloneSha).find((s) => s) || null;
+            setCustomMarketplaceSelectionFn(projectRoot, {
+                source: selection.source,
+                sourceUrl: selection.sourceUrl ?? null,
+                mode: selection.mode,
+                selectedCodes: selection.selectedCodes,
+                sha,
+            });
+        } catch (persistErr) {
+            console.warn(chalk.yellow(`  Warning: could not persist custom marketplace selection: ${persistErr.message}`));
+        }
+
+        return true;
+    } catch (error) {
+        console.error(chalk.red(`  Custom marketplace subset install failed: ${error.message}`));
+        console.error(chalk.yellow(`  Custom marketplace stage left in place for inspection: ${stagePath}`));
+        return false;
+    }
+}
+
 /**
  * Write bmad-method's `.bmad-channel.json` marker for an offline-cached
  * module if one is not already present.
@@ -2142,7 +2255,7 @@ function ensureCanonicalConfigLocation(projectRoot) {
 
 // ── Migration constants ─────────────────────────────────────────────────────
 
-const BMAD_TARGET_VERSION = '6.9.0';
+const BMAD_TARGET_VERSION = '6.10.0';
 const BMAD_MIGRATION_THRESHOLD = '6.2.0'; // versions below this need migration
 const BACKUP_DIR_NAME = '.backup-pre-migration';
 
@@ -3121,6 +3234,8 @@ module.exports = {
     stagePlugin,
     cleanupStage,
     PLUGIN_STAGE_DIR_NAME,
+    // Story 30.6b — custom-marketplace subset install (exported for unit tests)
+    installCustomMarketplaceSubset,
     // F2a — Story 22.8 gitignore policy (project-root only). Exported so the
     // regression test can invoke it directly without spinning up the full
     // CLI / bmad-method pipeline.