lynkr 9.9.0 → 9.10.0

package/src/agents/decomposition/dispatcher.js

@@ -1,185 +0,0 @@
-/**
- * Subtask dispatcher (Phase 3).
- *
- * Executes a validated plan respecting its dependency DAG:
- *   - subtasks are grouped into topological "levels" (Kahn's algorithm)
- *   - subtasks in the same level have no dependency on each other → run in
- *     parallel via the existing ParallelCoordinator (spawnParallel)
- *   - a subtask receives ONLY its own prompt plus the compressed results of the
- *     subtasks it depends on (context isolation — the token win)
- *
- * The spawn functions are injectable for testing.
- */
-
-const logger = require("../../logger");
-
-// Cap how much of a dependency's result we forward, to preserve the
-// context-isolation savings (subagents already return summaries; this bounds
-// pathological cases).
-const MAX_CONTEXT_CHARS = 2000;
-
-/**
- * Group subtasks into dependency levels. Returns array of arrays of ids.
- * Throws if the graph is unresolvable (should not happen — planner validated).
- */
-function topologicalLevels(subtasks) {
-  const byId = new Map(subtasks.map((s) => [s.id, s]));
-  const indegree = new Map(subtasks.map((s) => [s.id, 0]));
-  const dependents = new Map(subtasks.map((s) => [s.id, []]));
-
-  for (const s of subtasks) {
-    for (const dep of s.dependsOn) {
-      if (!byId.has(dep)) continue;
-      indegree.set(s.id, indegree.get(s.id) + 1);
-      dependents.get(dep).push(s.id);
-    }
-  }
-
-  const levels = [];
-  let frontier = subtasks.filter((s) => indegree.get(s.id) === 0).map((s) => s.id);
-  const resolved = new Set();
-
-  while (frontier.length > 0) {
-    levels.push(frontier);
-    const next = [];
-    for (const id of frontier) {
-      resolved.add(id);
-      for (const child of dependents.get(id)) {
-        indegree.set(child, indegree.get(child) - 1);
-        if (indegree.get(child) === 0) next.push(child);
-      }
-    }
-    frontier = next;
-  }
-
-  if (resolved.size !== subtasks.length) {
-    throw new Error("Unresolvable subtask graph (cycle or dangling dependency)");
-  }
-  return levels;
-}
-
-function compressResult(text) {
-  if (typeof text !== "string") return String(text ?? "");
-  if (text.length <= MAX_CONTEXT_CHARS) return text;
-  return text.slice(0, MAX_CONTEXT_CHARS) + "\n…[truncated]";
-}
-
-function buildContextForSubtask(subtask, resultsById) {
-  if (!subtask.dependsOn || subtask.dependsOn.length === 0) return null;
-  const parts = [];
-  for (const dep of subtask.dependsOn) {
-    const r = resultsById.get(dep);
-    if (r && r.success && r.result) {
-      parts.push(`Result of subtask ${dep}:\n${compressResult(r.result)}`);
-    } else if (r) {
-      parts.push(`Subtask ${dep} did not complete successfully.`);
-    }
-  }
-  return parts.length > 0 ? parts.join("\n\n") : null;
-}
-
-/**
- * Dispatch a validated plan.
- * @param {Object} plan - { subtasks: [...] }
- * @param {Object} [options]
- * @param {string} [options.sessionId]
- * @param {string} [options.cwd]
- * @param {Function} [options.spawnParallel] - (agentTypes[], prompts[], opts) => results[]
- * @returns {Promise<{results: Array, levels: Array, stats: Object}>}
- */
-async function dispatchPlan(plan, options = {}) {
-  const spawnParallel = options.spawnParallel || require("../index").spawnParallel;
-  const subtasks = plan.subtasks;
-  const byId = new Map(subtasks.map((s) => [s.id, s]));
-  const levels = topologicalLevels(subtasks);
-  const resultsById = new Map();
-
-  let totalInputTokens = 0;
-  let totalOutputTokens = 0;
-  let totalSubagents = 0;
-
-  for (let li = 0; li < levels.length; li++) {
-    const levelIds = levels[li];
-    const levelSubtasks = levelIds.map((id) => byId.get(id));
-
-    const agentTypes = levelSubtasks.map((s) => s.agentType);
-    const prompts = levelSubtasks.map((s) => s.prompt);
-    const perTaskContext = levelSubtasks.map((s) => buildContextForSubtask(s, resultsById));
-
-    logger.info(
-      { level: li, count: levelIds.length, ids: levelIds },
-      "[Decomposition] Dispatching subtask level"
-    );
-
-    // spawnParallel shares one options object; pass per-task context by spawning
-    // the level as individual parallel calls when contexts differ.
-    const levelResults = await runLevel(
-      spawnParallel,
-      agentTypes,
-      prompts,
-      perTaskContext,
-      options
-    );
-
-    levelResults.forEach((res, idx) => {
-      const st = levelSubtasks[idx];
-      totalSubagents += 1;
-      totalInputTokens += res?.stats?.inputTokens || 0;
-      totalOutputTokens += res?.stats?.outputTokens || 0;
-      resultsById.set(st.id, {
-        id: st.id,
-        agentType: st.agentType,
-        success: !!res?.success,
-        result: res?.success ? res.result : null,
-        error: res?.success ? null : res?.error || "unknown error",
-        stats: res?.stats || {},
-      });
-    });
-  }
-
-  const results = subtasks.map((s) => resultsById.get(s.id));
-  return {
-    results,
-    levels,
-    stats: {
-      subagents: totalSubagents,
-      inputTokens: totalInputTokens,
-      outputTokens: totalOutputTokens,
-    },
-  };
-}
-
-/**
- * Run one level. When subtasks in the level have differing injected contexts we
- * spawn them as separate parallel calls (each with its own mainContext), then
- * await all. When none need context, a single spawnParallel batch is used.
- */
-async function runLevel(spawnParallel, agentTypes, prompts, perTaskContext, options) {
-  const anyContext = perTaskContext.some((c) => c);
-
-  if (!anyContext) {
-    return spawnParallel(agentTypes, prompts, {
-      sessionId: options.sessionId,
-      cwd: options.cwd,
-    });
-  }
-
-  // Mixed/with-context: one spawnParallel call per subtask so each gets its own
-  // mainContext, executed concurrently.
-  const calls = agentTypes.map((type, i) =>
-    spawnParallel([type], [prompts[i]], {
-      sessionId: options.sessionId,
-      cwd: options.cwd,
-      mainContext: perTaskContext[i] ? { relevant_context: perTaskContext[i] } : undefined,
-    }).then((arr) => arr[0])
-  );
-  return Promise.all(calls);
-}
-
-module.exports = {
-  dispatchPlan,
-  topologicalLevels,
-  buildContextForSubtask,
-  compressResult,
-  MAX_CONTEXT_CHARS,
-};

package/src/agents/decomposition/gate.js

@@ -1,136 +0,0 @@
-/**
- * Decomposition gate (Phase 1).
- *
- * Decides whether breaking a task into isolated-context subtasks is actually
- * worth it. This is the make-or-break of the feature: naive "decompose
- * everything" loses money, because every subagent carries fixed overhead
- * (planning + per-agent handoff/summarisation). Decomposition only pays off
- * when the task is (a) genuinely complex, (b) large enough to amortise that
- * overhead, and (c) divisible into reasonably independent units.
- *
- * Pure and synchronous so it can be unit-tested without a model. The caller
- * supplies a pre-computed complexity `analysis` (from routing/complexity-analyzer)
- * and the raw payload.
- */
-
-const DEFAULTS = {
-  minComplexity: 60, // 0-100; only decompose genuinely complex work
-  minTokens: 3000, // estimated monolithic tokens; below this the overhead wins
-  minIndependentUnits: 2, // need at least 2 separable pieces to bother
-  maxSubtasks: 6,
-};
-
-const ENUMERATION_RE = /^\s*(?:[-*+]|\d+[.)]|step\s+\d+\b)/gim;
-const CONJUNCTION_RE = /\b(?:and then|then|also|additionally|as well as|after that|finally|next,)\b/gi;
-const IMPERATIVE_RE = /\b(?:add|create|build|implement|write|refactor|update|fix|remove|delete|migrate|test|document|configure|set up|wire|integrate|generate)\b/gi;
-const FILE_PATH_RE = /\b[\w./-]+\.(?:js|ts|tsx|jsx|py|go|rs|java|rb|c|cpp|h|json|yaml|yml|md|sql|sh|css|html)\b/gi;
-
-function _uniqueMatches(text, re) {
-  const set = new Set();
-  const matches = text.match(re) || [];
-  for (const m of matches) set.add(m.toLowerCase().trim());
-  return set;
-}
-
-/**
- * Heuristically estimate how many independent units a task contains.
- * Conservative: takes the strongest of several weak signals rather than summing
- * them, so a single rambling sentence doesn't look like five subtasks.
- * @param {string} text
- * @returns {number}
- */
-function estimateIndependentUnits(text) {
-  if (!text || typeof text !== "string") return 1;
-
-  const enumerated = (text.match(ENUMERATION_RE) || []).length;
-  const conjunctions = (text.match(CONJUNCTION_RE) || []).length;
-  const imperatives = _uniqueMatches(text, IMPERATIVE_RE).size;
-  const files = _uniqueMatches(text, FILE_PATH_RE).size;
-
-  // Each signal is an independent lower-bound estimate of separable units.
-  const signals = [
-    enumerated, // explicit list items
-    conjunctions + 1, // "do A and then B" → 2 units
-    imperatives, // distinct action verbs
-    files, // distinct files usually map to distinct work
-  ];
-
-  const estimate = Math.max(...signals, 1);
-  return estimate;
-}
-
-/**
- * Decide whether to decompose.
- * @param {Object} analysis - result of analyzeComplexity(payload)
- * @param {Object} payload - the request payload
- * @param {Object} [options]
- * @param {Object} [options.config] - threshold overrides (see DEFAULTS)
- * @param {string} [options.riskLevel] - 'low'|'medium'|'high'; 'high' disables decomposition
- * @param {string} [options.taskText] - explicit task text (else derived from analysis/payload)
- * @returns {{ decompose: boolean, reason: string, signals: Object }}
- */
-function shouldDecompose(analysis, payload = {}, options = {}) {
-  const cfg = { ...DEFAULTS, ...(options.config || {}) };
-
-  const score = Number(analysis?.score ?? 0);
-  const estimatedTokens = Number(
-    analysis?.breakdown?.tokens?.estimated ?? options.estimatedTokens ?? 0
-  );
-
-  const taskText =
-    options.taskText ||
-    analysis?.content ||
-    _firstUserText(payload) ||
-    "";
-
-  const independentUnits = estimateIndependentUnits(taskText);
-
-  const signals = {
-    score,
-    estimatedTokens,
-    independentUnits,
-    riskLevel: options.riskLevel || "low",
-    thresholds: cfg,
-  };
-
-  // Never decompose high-risk work — keep it in one capable context where the
-  // exempt-from-laziness concerns (validation/security) stay coherent.
-  if (options.riskLevel === "high") {
-    return { decompose: false, reason: "high_risk_skip", signals };
-  }
-
-  if (score < cfg.minComplexity) {
-    return { decompose: false, reason: "below_complexity_threshold", signals };
-  }
-
-  if (estimatedTokens < cfg.minTokens) {
-    return { decompose: false, reason: "too_small_to_amortise_overhead", signals };
-  }
-
-  if (independentUnits < cfg.minIndependentUnits) {
-    return { decompose: false, reason: "not_divisible", signals };
-  }
-
-  return { decompose: true, reason: "decompose_worthwhile", signals };
-}
-
-function _firstUserText(payload) {
-  const messages = payload?.messages;
-  if (!Array.isArray(messages)) return "";
-  const user = [...messages].reverse().find((m) => m.role === "user");
-  if (!user) return "";
-  if (typeof user.content === "string") return user.content;
-  if (Array.isArray(user.content)) {
-    return user.content
-      .filter((b) => b?.type === "text" || typeof b?.text === "string")
-      .map((b) => b.text || "")
-      .join("\n");
-  }
-  return "";
-}
-
-module.exports = {
-  shouldDecompose,
-  estimateIndependentUnits,
-  DEFAULTS,
-};

package/src/agents/decomposition/index.js

@@ -1,183 +0,0 @@
-/**
- * Task decomposition — orchestration entry point.
- *
- * Ties the phases together:
- *   1. gate        — decide if decomposing is worth it (cost-aware)
- *   2. planner     — produce a validated subtask DAG (one model call)
- *   3. dispatcher  — run subtasks (parallel within dependency levels, isolated context)
- *   4. synthesizer — combine results into the final answer (one model call)
- *   5. quality     — confidence-score the synthesis; flag low-confidence output
- *   6. telemetry   — record decision + estimated net token savings; shadow mode
- *
- * Opt-in via TASK_DECOMPOSITION_ENABLED=true. Requires AGENTS_ENABLED=true
- * (it builds on the subagent machinery). Any failure degrades gracefully to a
- * non-decomposed result so the caller can solve monolithically.
- */
-
-const config = require("../../config");
-const logger = require("../../logger");
-const { shouldDecompose } = require("./gate");
-const { generatePlan } = require("./planner");
-const { dispatchPlan } = require("./dispatcher");
-const { synthesize } = require("./synthesizer");
-const telemetry = require("./telemetry");
-const { analyzeComplexity } = require("../../routing/complexity-analyzer");
-const confidenceScorer = require("../../routing/confidence-scorer");
-
-const CODE_HINT_RE = /\b(code|function|implement|refactor|bug|class|api|module|test)\b/i;
-
-function getConfig() {
-  return (
-    config.taskDecomposition || {
-      enabled: false,
-      shadow: false,
-      planModel: "sonnet",
-      synthModel: "sonnet",
-      minConfidence: 0.5,
-      gate: {},
-    }
-  );
-}
-
-/**
- * @param {string} task - the task text to (maybe) decompose
- * @param {Object} [options]
- * @param {string} [options.sessionId]
- * @param {string} [options.cwd]
- * @param {string} [options.riskLevel] - 'high' disables decomposition
- * @param {Object} [options._inject] - test seams { generatePlan, dispatchPlan, synthesize, analyze }
- * @returns {Promise<Object>} result object (see below)
- */
-async function runDecomposedTask(task, options = {}) {
-  const cfg = getConfig();
-  const inject = options._inject || {};
-
-  if (!cfg.enabled) {
-    return { decomposed: false, reason: "disabled" };
-  }
-  if (!config.agents?.enabled) {
-    return { decomposed: false, reason: "agents_disabled" };
-  }
-  if (!task || typeof task !== "string") {
-    return { decomposed: false, reason: "empty_task" };
-  }
-
-  const payload = { messages: [{ role: "user", content: task }] };
-
-  let analysis;
-  try {
-    analysis = await (inject.analyze || analyzeComplexity)(payload);
-  } catch (err) {
-    logger.warn({ err: err.message }, "[Decomposition] Complexity analysis failed");
-    return { decomposed: false, reason: "analysis_failed" };
-  }
-
-  const monolithicTokens =
-    analysis?.breakdown?.tokens?.estimated || telemetry.estimateTokens(task);
-
-  const gate = shouldDecompose(analysis, payload, {
-    config: cfg.gate,
-    riskLevel: options.riskLevel,
-    taskText: task,
-  });
-
-  // Shadow mode: record what we WOULD do, but never actually decompose.
-  if (cfg.shadow) {
-    telemetry.record({
-      mode: "shadow",
-      sessionId: options.sessionId,
-      gate,
-      monolithicTokens,
-    });
-    return { decomposed: false, reason: "shadow_mode", gate };
-  }
-
-  if (!gate.decompose) {
-    telemetry.record({ mode: "live", decision: "skip", gate, monolithicTokens });
-    return { decomposed: false, reason: gate.reason, gate };
-  }
-
-  // Phase 2: plan
-  const plan = await (inject.generatePlan || generatePlan)({
-    task,
-    model: cfg.planModel,
-    maxSubtasks: cfg.gate?.maxSubtasks || 6,
-  });
-  if (!plan) {
-    telemetry.record({ mode: "live", decision: "plan_failed", gate, monolithicTokens });
-    return { decomposed: false, reason: "plan_failed", gate };
-  }
-
-  // Phase 3: dispatch
-  const dispatch = await (inject.dispatchPlan || dispatchPlan)(plan, {
-    sessionId: options.sessionId,
-    cwd: options.cwd,
-  });
-
-  // Phase 4: synthesize
-  const synth = await (inject.synthesize || synthesize)({
-    task,
-    subtaskResults: dispatch.results,
-    model: cfg.synthModel,
-  });
-
-  // Phase 5: quality gate
-  const taskType = CODE_HINT_RE.test(task) ? "code" : "reasoning";
-  let confidence = 1;
-  try {
-    confidence = await confidenceScorer.score(
-      { content: [{ type: "text", text: synth.text }] },
-      { taskType }
-    );
-  } catch (err) {
-    logger.debug({ err: err.message }, "[Decomposition] Confidence scoring failed");
-  }
-  const belowThreshold = confidence < (cfg.minConfidence ?? 0.5);
-
-  const savings = telemetry.estimateSavings({
-    monolithicTokens,
-    planUsage: plan.usage,
-    dispatchStats: dispatch.stats,
-    synthUsage: synth.usage,
-  });
-
-  telemetry.record({
-    mode: "live",
-    decision: "decomposed",
-    sessionId: options.sessionId,
-    gate,
-    subtasks: plan.subtasks.length,
-    levels: dispatch.levels.length,
-    strategy: plan.strategy,
-    confidence,
-    belowThreshold,
-    synthesisFallback: synth.fallback,
-    savings,
-  });
-
-  logger.info(
-    {
-      subtasks: plan.subtasks.length,
-      levels: dispatch.levels.length,
-      confidence: confidence.toFixed(2),
-      savedTokens: savings.savedTokens,
-    },
-    "[Decomposition] Task decomposed"
-  );
-
-  return {
-    decomposed: true,
-    result: synth.text,
-    reason: "decomposed",
-    plan,
-    subtaskResults: dispatch.results,
-    quality: { confidence, belowThreshold, taskType },
-    // When confidence is low, the caller should prefer a monolithic re-solve.
-    recommendFallback: belowThreshold,
-    stats: { ...dispatch.stats, levels: dispatch.levels.length },
-    savings,
-    gate,
-  };
-}
-
-module.exports = { runDecomposedTask, getConfig };

package/src/agents/decomposition/model-call.js

@@ -1,75 +0,0 @@
-/**
- * Thin model-call helper for the decomposition planner/synthesizer.
- *
- * Mirrors the provider-forcing logic in agents/executor.js so planning and
- * synthesis use the configured MODEL_PROVIDER rather than hard-falling back to
- * Azure. The actual invoker is injectable (`opts.invoke`) so the planner and
- * synthesizer can be unit-tested without a live provider.
- */
-
-const logger = require("../../logger");
-
-function resolveForceProvider(model) {
-  const modelLower = String(model || "").toLowerCase();
-  const isClaudeFamily =
-    modelLower.includes("claude") ||
-    modelLower.includes("sonnet") ||
-    modelLower.includes("haiku") ||
-    modelLower.includes("opus");
-  const isGptFamily = modelLower.includes("gpt");
-
-  if (isClaudeFamily || isGptFamily) {
-    const config = require("../../config");
-    return config.modelProvider?.type || config.modelProvider?.provider || null;
-  }
-  return null;
-}
-
-/**
- * Call the model and return the Anthropic-format response JSON.
- * @param {Object} params
- * @param {Array} params.messages
- * @param {string} params.model
- * @param {number} [params.maxTokens=2048]
- * @param {number} [params.temperature=0.2]
- * @param {Function} [params.invoke] - injectable invoker (default: clients/databricks.invokeModel)
- * @returns {Promise<Object>} Anthropic-format response JSON
- */
-async function callModel({ messages, model, maxTokens = 2048, temperature = 0.2, invoke } = {}) {
-  const invoker = invoke || require("../../clients/databricks").invokeModel;
-  const payload = {
-    model,
-    messages,
-    max_tokens: maxTokens,
-    temperature,
-  };
-  const forceProvider = resolveForceProvider(model);
-
-  const response = await invoker(payload, { forceProvider });
-  if (!response || !response.json) {
-    throw new Error("Invalid model response in decomposition model-call");
-  }
-  return response.json;
-}
-
-/**
- * Extract concatenated text from an Anthropic-format response.
- */
-function extractText(responseJson) {
-  const content = responseJson?.content;
-  if (!Array.isArray(content)) return "";
-  return content
-    .filter((b) => b?.type === "text")
-    .map((b) => b.text || "")
-    .join("\n")
-    .trim();
-}
-
-function sumUsage(responseJson) {
-  return {
-    inputTokens: responseJson?.usage?.input_tokens || 0,
-    outputTokens: responseJson?.usage?.output_tokens || 0,
-  };
-}
-
-module.exports = { callModel, extractText, sumUsage, resolveForceProvider, logger };