lula2 0.6.3-nightly.0 → 0.6.3-nightly.2

package/dist/cli/commands/crawl.js

@@ -123,155 +123,209 @@ function containsLulaAnnotations(text) {
   const lines = text.split("\n");
   return lines.some((line) => line.includes("@lulaStart") || line.includes("@lulaEnd"));
 }
-function crawlCommand() {
-  return new Command().command("crawl").description("Detect compliance-related changes between @lulaStart and @lulaEnd in PR files").addOption(
-    new Option("--post-mode <mode>", "How to post findings").choices(["review", "comment"]).default("review")
-  ).action(async (opts) => {
-    let leavePost = false;
-    const { owner, repo, pull_number } = getPRContext();
-    console.log(`Analyzing PR #${pull_number} in ${owner}/${repo} for compliance changes...`);
-    const octokit = new Octokit({ auth: process.env.GITHUB_TOKEN });
-    const pr = await octokit.pulls.get({ owner, repo, pull_number });
-    const prBranch = pr.data.head.ref;
-    const { data: files } = await octokit.pulls.listFiles({ owner, repo, pull_number });
-    let commentBody = `${LULA_SIGNATURE}
+function createInitialCommentBody(filesCount) {
+  return `${LULA_SIGNATURE}
 ## Lula Compliance Overview
 
 Please review the changes to ensure they meet compliance standards.
 
 ### Reviewed Changes
 
-Lula reviewed ${files.length} files changed that affect compliance.
+Lula reviewed ${filesCount} files changed that affect compliance.
 
 `;
-    const deletedFilesWithAnnotations = [];
-    for (const file of files) {
-      if (file.status === "removed") {
-        try {
-          const oldText = await fetchRawFileViaAPI({
-            octokit,
-            owner,
-            repo,
-            path: file.filename,
-            ref: "main"
-          });
-          if (containsLulaAnnotations(oldText)) {
-            deletedFilesWithAnnotations.push(file.filename);
-          }
-        } catch (err) {
-          console.error(`Error checking deleted file ${file.filename}: ${err}`);
+}
+async function analyzeDeletedFiles(context) {
+  const { octokit, owner, repo, files } = context;
+  const deletedFilesWithAnnotations = [];
+  for (const file of files) {
+    if (file.status === "removed") {
+      try {
+        const oldText = await fetchRawFileViaAPI({
+          octokit,
+          owner,
+          repo,
+          path: file.filename,
+          ref: "main"
+        });
+        if (containsLulaAnnotations(oldText)) {
+          deletedFilesWithAnnotations.push(file.filename);
         }
+      } catch (err) {
+        console.error(`Error checking deleted file ${file.filename}: ${err}`);
       }
     }
-    if (deletedFilesWithAnnotations.length > 0) {
-      leavePost = true;
-      commentBody += `
+  }
+  if (deletedFilesWithAnnotations.length === 0) {
+    return { hasFindings: false, warningContent: "" };
+  }
+  let warningContent = `
 
 **Compliance Warning: Files with Lula annotations were deleted**
 
 `;
-      commentBody += `The following files contained compliance annotations (\`@lulaStart\`/\`@lulaEnd\`) and were deleted in this PR. This may affect compliance coverage:
+  warningContent += `The following files contained compliance annotations (\`@lulaStart\`/\`@lulaEnd\`) and were deleted in this PR. This may affect compliance coverage:
 
 `;
-      for (const filename of deletedFilesWithAnnotations) {
-        commentBody += `- \`${filename}\`
+  for (const filename of deletedFilesWithAnnotations) {
+    warningContent += `- \`${filename}\`
 `;
-      }
-      commentBody += `
+  }
+  warningContent += `
 Please review whether:
 `;
-      commentBody += `- The compliance coverage provided by these files is still needed
+  warningContent += `- The compliance coverage provided by these files is still needed
 `;
-      commentBody += `- Alternative compliance measures have been implemented
+  warningContent += `- Alternative compliance measures have been implemented
 `;
-      commentBody += `- The deletion is intentional and compliance-approved
+  warningContent += `- The deletion is intentional and compliance-approved
 
 `;
-      commentBody += `---
+  warningContent += `---
 
 `;
-    }
-    for (const file of files) {
-      if (file.status === "added" || file.status === "removed") continue;
-      try {
-        const [oldText, newText] = await Promise.all([
-          fetchRawFileViaAPI({ octokit, owner, repo, path: file.filename, ref: "main" }),
-          fetchRawFileViaAPI({ octokit, owner, repo, path: file.filename, ref: prBranch })
-        ]);
-        const changedBlocks = getChangedBlocks(oldText, newText);
-        const removedBlocks = getRemovedBlocks(oldText, newText);
-        for (const block of changedBlocks) {
-          console.log(`Commenting regarding \`${file.filename}\`.`);
-          leavePost = true;
-          commentBody += `
+  return { hasFindings: true, warningContent };
+}
+function generateChangedBlocksContent(filename, changedBlocks, newText) {
+  let content = "";
+  for (const block of changedBlocks) {
+    console.log(`Commenting regarding \`${filename}\`.`);
+    content += `
 
 ---
 | File | Lines Changed |
 | ---- | ------------- |
 `;
-          const newBlockText = newText.split("\n").slice(block.startLine, block.endLine).join("\n");
-          const blockSha256 = createHash("sha256").update(newBlockText).digest("hex");
-          commentBody += `| \`${file.filename}\` | \`${block.startLine + 1}\u2013${block.endLine}\` |
+    const newBlockText = newText.split("\n").slice(block.startLine, block.endLine).join("\n");
+    const blockSha256 = createHash("sha256").update(newBlockText).digest("hex");
+    content += `| \`${filename}\` | \`${block.startLine + 1}\u2013${block.endLine}\` |
 > **uuid**-\`${block.uuid}\`
  **sha256** \`${blockSha256}\`
 
 `;
-        }
-        if (removedBlocks.length > 0) {
-          leavePost = true;
-          console.log(`Found removed annotations in \`${file.filename}\`.`);
-          commentBody += `
+  }
+  return content;
+}
+function generateRemovedBlocksContent(filename, removedBlocks, oldText) {
+  if (removedBlocks.length === 0) {
+    return "";
+  }
+  console.log(`Found removed annotations in \`${filename}\`.`);
+  let content = `
 
-**Compliance Warning: Lula annotations were removed from \`${file.filename}\`**
+**Compliance Warning: Lula annotations were removed from \`${filename}\`**
 
 `;
-          commentBody += `The following compliance annotation blocks were present in the original file but are missing in the updated version:
+  content += `The following compliance annotation blocks were present in the original file but are missing in the updated version:
 
 `;
-          commentBody += `| File | Original Lines | UUID |
+  content += `| File | Original Lines | UUID |
 `;
-          commentBody += `| ---- | -------------- | ---- |
+  content += `| ---- | -------------- | ---- |
 `;
-          for (const block of removedBlocks) {
-            const oldBlockText = oldText.split("\n").slice(block.startLine, block.endLine).join("\n");
-            const blockSha256 = createHash("sha256").update(oldBlockText).digest("hex");
-            commentBody += `| \`${file.filename}\` | \`${block.startLine + 1}\u2013${block.endLine}\` | \`${block.uuid}\` |
+  for (const block of removedBlocks) {
+    const oldBlockText = oldText.split("\n").slice(block.startLine, block.endLine).join("\n");
+    const blockSha256 = createHash("sha256").update(oldBlockText).digest("hex");
+    content += `| \`${filename}\` | \`${block.startLine + 1}\u2013${block.endLine}\` | \`${block.uuid}\` |
 `;
-            commentBody += `> **sha256** \`${blockSha256}\`
+    content += `> **sha256** \`${blockSha256}\`
 
 `;
-          }
-          commentBody += `Please review whether:
+  }
+  content += `Please review whether:
 `;
-          commentBody += `- The removal of these compliance annotations is intentional
+  content += `- The removal of these compliance annotations is intentional
 `;
-          commentBody += `- Alternative compliance measures have been implemented
+  content += `- Alternative compliance measures have been implemented
 `;
-          commentBody += `- The compliance coverage is still adequate
+  content += `- The compliance coverage is still adequate
 
 `;
-          commentBody += `---
+  content += `---
 
 `;
-        }
-      } catch (err) {
-        console.error(`Error processing ${file.filename}: ${err}`);
+  return content;
+}
+async function analyzeModifiedFiles(context) {
+  const { octokit, owner, repo, prBranch, files } = context;
+  let changesContent = "";
+  let hasFindings = false;
+  for (const file of files) {
+    if (file.status === "added" || file.status === "removed") continue;
+    try {
+      const [oldText, newText] = await Promise.all([
+        fetchRawFileViaAPI({ octokit, owner, repo, path: file.filename, ref: "main" }),
+        fetchRawFileViaAPI({ octokit, owner, repo, path: file.filename, ref: prBranch })
+      ]);
+      const changedBlocks = getChangedBlocks(oldText, newText);
+      const removedBlocks = getRemovedBlocks(oldText, newText);
+      if (changedBlocks.length > 0) {
+        hasFindings = true;
+        changesContent += generateChangedBlocksContent(file.filename, changedBlocks, newText);
       }
+      if (removedBlocks.length > 0) {
+        hasFindings = true;
+        changesContent += generateRemovedBlocksContent(file.filename, removedBlocks, oldText);
+      }
+    } catch (err) {
+      console.error(`Error processing ${file.filename}: ${err}`);
     }
-    if (opts.postMode === "comment") {
-      await deleteOldIssueComments({ octokit, owner, repo, pull_number });
-    } else {
-      await dismissOldReviews({ octokit, owner, repo, pull_number });
-      await deleteOldReviewComments({ octokit, owner, repo, pull_number });
-    }
-    if (leavePost) {
+  }
+  return { hasFindings, changesContent };
+}
+async function performComplianceAnalysis(context) {
+  let commentBody = createInitialCommentBody(context.files.length);
+  let hasFindings = false;
+  const deletedAnalysis = await analyzeDeletedFiles(context);
+  if (deletedAnalysis.hasFindings) {
+    hasFindings = true;
+    commentBody += deletedAnalysis.warningContent;
+  }
+  const modifiedAnalysis = await analyzeModifiedFiles(context);
+  if (modifiedAnalysis.hasFindings) {
+    hasFindings = true;
+    commentBody += modifiedAnalysis.changesContent;
+  }
+  return { hasFindings, commentBody };
+}
+async function cleanupOldPosts(context, postMode) {
+  const { octokit, owner, repo, pull_number } = context;
+  if (postMode === "comment") {
+    await deleteOldIssueComments({ octokit, owner, repo, pull_number });
+  } else {
+    await dismissOldReviews({ octokit, owner, repo, pull_number });
+    await deleteOldReviewComments({ octokit, owner, repo, pull_number });
+  }
+}
+function crawlCommand() {
+  return new Command().command("crawl").description("Detect compliance-related changes between @lulaStart and @lulaEnd in PR files").addOption(
+    new Option("--post-mode <mode>", "How to post findings").choices(["review", "comment"]).default("review")
+  ).action(async (opts) => {
+    const { owner, repo, pull_number } = getPRContext();
+    console.log(`Analyzing PR #${pull_number} in ${owner}/${repo} for compliance changes...`);
+    const octokit = new Octokit({ auth: process.env.GITHUB_TOKEN });
+    const pr = await octokit.pulls.get({ owner, repo, pull_number });
+    const prBranch = pr.data.head.ref;
+    const { data: files } = await octokit.pulls.listFiles({ owner, repo, pull_number });
+    const context = {
+      octokit,
+      owner,
+      repo,
+      pull_number,
+      prBranch,
+      files
+    };
+    const analysisResult = await performComplianceAnalysis(context);
+    await cleanupOldPosts(context, opts.postMode);
+    if (analysisResult.hasFindings) {
+      const finalBody = analysisResult.commentBody + closingBody;
       await postFinding({
         octokit,
         postMode: opts.postMode,
         owner,
         repo,
         pull_number,
-        body: commentBody + closingBody
+        body: finalBody
       });
       const header = `Posted (${opts.postMode})`;
       const underline = "-".repeat(header.length);
@@ -279,7 +333,7 @@ Please review whether:
 ${header}
 ${underline}
 
-${commentBody + closingBody}
+${finalBody}
 
 `);
     }
@@ -372,15 +426,22 @@ async function dismissOldReviews({
 }
 export {
   LULA_SIGNATURE,
+  analyzeDeletedFiles,
+  analyzeModifiedFiles,
+  cleanupOldPosts,
   containsLulaAnnotations,
   crawlCommand,
+  createInitialCommentBody,
   deleteOldIssueComments,
   deleteOldReviewComments,
   dismissOldReviews,
   extractMapBlocks,
   fetchRawFileViaAPI,
+  generateChangedBlocksContent,
+  generateRemovedBlocksContent,
   getChangedBlocks,
   getPRContext,
   getRemovedBlocks,
+  performComplianceAnalysis,
   postFinding
 };

package/dist/index.html

@@ -6,28 +6,28 @@
 		<link rel="icon" href="/lula.png" />
 		<meta name="viewport" content="width=device-width, initial-scale=1" />
 		
-		<link rel="modulepreload" href="/_app/immutable/entry/start.D2hMBZNv.js">
-		<link rel="modulepreload" href="/_app/immutable/chunks/rc9CiIba.js">
-		<link rel="modulepreload" href="/_app/immutable/chunks/DTWPdvjs.js">
-		<link rel="modulepreload" href="/_app/immutable/entry/app.C9fkwjMz.js">
+		<link rel="modulepreload" href="/_app/immutable/entry/start.DWsnY-61.js">
+		<link rel="modulepreload" href="/_app/immutable/chunks/D74fr9ax.js">
+		<link rel="modulepreload" href="/_app/immutable/chunks/DmBJsPtc.js">
+		<link rel="modulepreload" href="/_app/immutable/entry/app.CY89YrVW.js">
 		<link rel="modulepreload" href="/_app/immutable/chunks/DsnmJJEf.js">
-		<link rel="modulepreload" href="/_app/immutable/chunks/BXUi170M.js">
-		<link rel="modulepreload" href="/_app/immutable/chunks/WlyXjfrM.js">
-		<link rel="modulepreload" href="/_app/immutable/chunks/CRa0j_Fx.js">
+		<link rel="modulepreload" href="/_app/immutable/chunks/BaV6jU6m.js">
+		<link rel="modulepreload" href="/_app/immutable/chunks/DBdrJbLi.js">
+		<link rel="modulepreload" href="/_app/immutable/chunks/CynYS-Ma.js">
 	</head>
 	<body data-sveltekit-preload-data="hover">
 		<div style="display: contents">
 			<script>
 				{
-					__sveltekit_1jux1ml = {
+					__sveltekit_1iek8ky = {
 						base: ""
 					};
 
 					const element = document.currentScript.parentElement;
 
 					Promise.all([
-						import("/_app/immutable/entry/start.D2hMBZNv.js"),
-						import("/_app/immutable/entry/app.C9fkwjMz.js")
+						import("/_app/immutable/entry/start.DWsnY-61.js"),
+						import("/_app/immutable/entry/app.CY89YrVW.js")
 					]).then(([kit, app]) => {
 						kit.start(app, element);
 					});