lucid-extension-sdk 0.0.198 → 0.0.200

package/commandtypes.d.ts

@@ -19,6 +19,8 @@ import { PanelLocation } from './ui/panel';
  * exposed through appropriate classes and methods elsewhere in this SDK.
  *
  * To use these directly, use [EditorClient.sendCommand](#classes_editorclient-EditorClient_sendcommand).
+ *
+ * IMPORTANT - Before you add a new command bring it up in #api-committee to get feedback
  */
 export declare const enum CommandName {
     AddCardIntegration = "aci",
@@ -143,6 +145,8 @@ export declare const commandTitles: Map<CommandName, string>;
  * This is a type declaration whose purpose is to allow TypeScript to enforce the correct parameter and
  * return types from [EditorClient.sendCommand](#classes_editorclient-EditorClient_sendcommand) based on
  * which command name you pass in as the first parameter.
+ *
+ * IMPORTANT - Before you add a new command bring it up in #api-committee to get feedback
  */
 export type CommandArgs = {
     [CommandName.AddCardIntegration]: {

package/core/validators/validators.js

@@ -12,16 +12,17 @@ const object_1 = require("../object");
  * and is one of the values in the specified enum (object).
  */
 function stringEnumValidator(enumMap) {
-    return (x) => {
-        if (!(0, checks_1.isString)(x)) {
-            return false;
+    const enumValues = new Set();
+    for (const key in enumMap) {
+        const enumValue = enumMap[key];
+        if ((0, checks_1.isString)(enumValue)) {
+            enumValues.add(enumValue);
         }
-        for (const key in enumMap) {
-            if (enumMap[key] === x) {
-                return true;
-            }
-        }
-        return false;
+    }
+    // this allows using Set:has on unknown type
+    const unknownEnumValues = enumValues;
+    return (x) => {
+        return unknownEnumValues.has(x);
     };
 }
 exports.stringEnumValidator = stringEnumValidator;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "lucid-extension-sdk",
-    "version": "0.0.198",
+    "version": "0.0.200",
     "description": "Utility classes for writing Lucid Software editor extensions",
     "main": "index.js",
     "types": "index.d.ts",