loopengine 0.1.86 → 0.1.88

package/README.md

@@ -185,9 +185,12 @@ only their own message to tell whether it's a decision, and anything
 unclear is treated as a question. An approver can also change a request
 first ("make it $40"): the change is checked against the tool's schema
 and the permission rules and shown with **Approve as changed / Keep
-original / Deny**, and nothing runs until they approve it. A typed reply
-never runs anything by itself: a "yes" shows exactly what will run with
-a **Confirm** button, and only that click runs it. Arguments are shown
+original / Deny**, and nothing runs until they approve it. A plain "yes"
+("approve", "go ahead", "好的", "はい", "sí", 👍…: the whole message,
+matched against a fixed list of phrases in common languages, not by a
+model) runs it; any other reply read as approval ("sure, send
+it", "yes but check the amount") shows exactly what will run with a
+**Confirm** button, and only that click runs it. Arguments are shown
 as labelled fields, with long text such as an email body quoted, not as
 JSON. Once approvers are listed, only their button clicks count too. The same tab lists every decision
 still waiting with Approve/Deny buttons (its count shows on the tab), and

package/dist/core/messaging/decide.d.ts

@@ -15,9 +15,14 @@ export type ReplyDecision = {
 } | {
     decision: 'continue';
 };
-export type DecisionRequest = {
+export type DecisionRequest = 
+/** `changeShown`: the person was just shown a proposed change to the
+ * arguments, waiting for their approval (our own fixed fact, not text
+ * anyone else wrote). */
+{
     kind: 'approval';
     tool: string;
+    changeShown?: boolean;
 } | {
     kind: 'question';
     question: string;

package/dist/core/messaging/decide.js

@@ -18,7 +18,7 @@ function recordTool(kind) {
 }
 export function decisionPrompt(request) {
     const about = request.kind === 'approval'
-        ? `An AI agent is waiting for approval to run the tool \`${request.tool}\`.`
+        ? `An AI agent is waiting for approval to run the tool \`${request.tool}\`.${request.changeShown ? ' The person was just shown a proposed change to its arguments, waiting for their approval: a plain yes or ok approves that change.' : ''}`
         : `An AI agent asked this question and is waiting for the answer: ${JSON.stringify(request.question)}${request.options?.length ? `\nOptions it offered: ${request.options.map((o) => JSON.stringify(o)).join(', ')}` : ''}`;
     const rules = request.kind === 'approval'
         ? [

package/dist/core/messaging/engine.d.ts

@@ -55,6 +55,11 @@ export interface DecisionOutcome {
 /** Handles one person's message: a reply in a request's thread gets an
  * answer; anything else is left alone. */
 export declare function handleInboundMessage(message: InboundMessage, deps: MessagingDeps): Promise<void>;
+/** Whether a reply is a plain approval: lower-cased, a leading @mention,
+ * emoji skin tones and "please" dropped, punctuation and spaces
+ * (full-width ones too) ignored, then compared with the fixed list. A
+ * trailing question mark keeps it from matching ("yes?"). */
+export declare function isPlainApproval(text: string): boolean;
 /** A click on one of the engine's own buttons (Approve as changed, Keep
  * original, Confirm, Cancel) — the caller has already checked the
  * person may decide. Returns what the clicked message should now say. */

package/dist/core/messaging/engine.js

@@ -54,7 +54,7 @@ export async function handleInboundMessage(message, deps) {
         }
         const modelCall = deps.createModelCall();
         const request = link.kind === 'approval'
-            ? { kind: 'approval', tool: item.tool }
+            ? { kind: 'approval', tool: item.tool, changeShown: Boolean(link.proposedArgs) }
             : {
                 kind: 'question',
                 question: typeof item.args.question === 'string' ? item.args.question : JSON.stringify(item.args),
@@ -94,6 +94,12 @@ export async function handleInboundMessage(message, deps) {
             }
             if (verdict.decision === 'approve') {
                 const args = link.proposedArgs ?? item.args;
+                // A plain "yes" runs it; anything less clear that still reads as
+                // approval asks for a Confirm click first.
+                if (isPlainApproval(message.text)) {
+                    await runApproved(deps, link, item.tool, args, who);
+                    return;
+                }
                 await connector.postChoice(message.conversation, threadTs, `Confirm to run \`${item.tool}\` with:\n${formatArgs(args, connector.escape, await deps.toolSchema(item.tool))}`, [
                     { action: 'confirm', label: 'Confirm', style: 'primary', pendingId: link.pendingId },
                     { action: 'cancel_confirm', label: 'Cancel', pendingId: link.pendingId },
@@ -133,6 +139,58 @@ export async function handleInboundMessage(message, deps) {
             await say(reply);
     });
 }
+// Whole messages that approve and nothing else, in the languages people
+// most often reply in. Matched exactly after the clean-up in
+// isPlainApproval, so a condition or a second thought ("yes but…",
+// "好的，但是…") never counts as plain; a phrase that isn't here just gets
+// a Confirm click. Words that can also mean "hmm", "understood" or "no
+// thanks" (嗯, 了解, いいです) are left out on purpose.
+const PLAIN_APPROVAL_PHRASES = [
+    // English
+    'yes', 'y', 'yep', 'yeah', 'yup', 'sure', 'yes go ahead', 'go ahead', 'approve', 'approved', 'i approve', 'do it', 'yes do it',
+    'ok', 'okay', 'ok go ahead', 'lgtm', 'confirm', 'confirmed', 'send it', 'run it',
+    // Chinese (simplified and traditional)
+    '是', '是的', '好', '好的', '可以', '行', '同意', '批准', '确认', '確認', '没问题', '沒問題', '发吧', '發吧', '执行', '執行', '执行吧', '執行吧',
+    '请执行', '請執行', '好的发吧', '好的發吧', '可以执行', '可以執行', '同意执行', '同意執行',
+    // Japanese
+    'はい', '承認', '承認します', 'お願いします', 'はいお願いします', 'okです', '進めて', '進めてください', '実行してください',
+    // Korean
+    '네', '예', '승인', '승인합니다', '좋아요', '진행해주세요', '네진행해주세요',
+    // Spanish, Portuguese, Italian
+    'sí', 'si', 'aprobado', 'apruebo', 'adelante', 'sí adelante', 'dale', 'de acuerdo',
+    'sim', 'aprovado', 'aprovo', 'pode', 'pode mandar', 'manda', 'pode seguir',
+    'sì', 'approvato', 'approvo', 'vai', 'procedi', 'va bene',
+    // French, German
+    'oui', 'approuvé', "j'approuve", 'vas-y', 'allez-y', "d'accord", 'ok vas-y',
+    'ja', 'genehmigt', 'freigegeben', 'mach es', 'mach das', 'einverstanden', 'passt',
+    // Russian
+    'да', 'одобряю', 'одобрено', 'подтверждаю', 'давай',
+    // Emoji, typed or as Slack shortcodes
+    '👍', '✅', '👌', ':+1:', ':thumbsup:', ':white_check_mark:', ':heavy_check_mark:', ':ok_hand:',
+];
+// "Please" at either end of a reply doesn't change it.
+const PLEASE = /^(please|pls|por favor|bitte|svp|s'il vous plaît|per favore)\s+|\s+(please|pls|por favor|bitte|svp|s'il vous plaît|per favore)$/g;
+function approvalKey(text) {
+    return text
+        .toLowerCase()
+        .replace(/^\s*<@[a-z0-9]+>\s*/, '')
+        .replace(/:skin-tone-\d:/g, '')
+        .replace(/[\u{1F3FB}-\u{1F3FF}\u{FE0F}]/gu, '')
+        .replace(/[\u2018\u2019]/g, "'")
+        .replace(/[,，、;；]+/g, ' ')
+        .replace(/[.!?。！～~]+$/, (m) => (m.includes('?') ? '?' : ''))
+        .trim()
+        .replace(PLEASE, '')
+        .replace(/\s+/g, '');
+}
+const PLAIN_APPROVALS = new Set(PLAIN_APPROVAL_PHRASES.map(approvalKey));
+/** Whether a reply is a plain approval: lower-cased, a leading @mention,
+ * emoji skin tones and "please" dropped, punctuation and spaces
+ * (full-width ones too) ignored, then compared with the fixed list. A
+ * trailing question mark keeps it from matching ("yes?"). */
+export function isPlainApproval(text) {
+    return PLAIN_APPROVALS.has(approvalKey(text));
+}
 /** Says what will run, runs it, reports the outcome and updates the
  * request message. `args` differing from the request's own means it was
  * approved as changed. */

package/dist/index.d.ts

@@ -12,7 +12,7 @@ export { listDeliveries, recordDelivery, type NotifierDelivery } from '#core/not
 export { describeNotifier } from '#core/http-notifier.js';
 export { Scheduler, ScheduleError, FileSchedulerStore, getSchedulerStore, setSchedulerStore, createScheduledTask, listScheduledTasks, getScheduledTask, cancelScheduledTask, pauseScheduledTask, resumeScheduledTask, runScheduledTaskNow, deleteScheduledTask, nextScheduledWakeAt, importLegacyScheduledTasks, parseEvery, describeSchedule, type ScheduledTask, type ScheduledTaskRun, type ScheduledTaskStatus, type Schedule, type SchedulerStore, type FireTask, type CreateScheduledTaskInput } from '#core/scheduler.js';
 export { NOTIFIER_SLACK_SIGNING_SECRET_VAR } from '#core/notifier-file.js';
-export { firstSighting, handleInboundMessage, handleMessagingAction, type MessagingDeps, type MessagingDecision, type DecisionOutcome } from '#core/messaging/engine.js';
+export { firstSighting, handleInboundMessage, handleMessagingAction, isPlainApproval, type MessagingDeps, type MessagingDecision, type DecisionOutcome } from '#core/messaging/engine.js';
 export { formatArgs, formatChange, labelFor } from '#core/messaging/format-args.js';
 export { decideReply, proposeEdit, describeChange, type ReplyDecision, type DecisionRequest } from '#core/messaging/decide.js';
 export { recordThread, findThread, findThreadByPending, type ThreadLink } from '#core/messaging/threads.js';

package/dist/index.js

@@ -14,7 +14,7 @@ export { listDeliveries, recordDelivery } from '#core/notifier-deliveries.js';
 export { describeNotifier } from '#core/http-notifier.js';
 export { Scheduler, ScheduleError, FileSchedulerStore, getSchedulerStore, setSchedulerStore, createScheduledTask, listScheduledTasks, getScheduledTask, cancelScheduledTask, pauseScheduledTask, resumeScheduledTask, runScheduledTaskNow, deleteScheduledTask, nextScheduledWakeAt, importLegacyScheduledTasks, parseEvery, describeSchedule } from '#core/scheduler.js';
 export { NOTIFIER_SLACK_SIGNING_SECRET_VAR } from '#core/notifier-file.js';
-export { firstSighting, handleInboundMessage, handleMessagingAction } from '#core/messaging/engine.js';
+export { firstSighting, handleInboundMessage, handleMessagingAction, isPlainApproval } from '#core/messaging/engine.js';
 export { formatArgs, formatChange, labelFor } from '#core/messaging/format-args.js';
 export { decideReply, proposeEdit, describeChange } from '#core/messaging/decide.js';
 export { recordThread, findThread, findThreadByPending } from '#core/messaging/threads.js';

package/dist/web/agents-config-page.js

@@ -1194,7 +1194,7 @@ ${consoleShellScript}
         '<td><button type="button" class="delete-btn approver-remove" data-user="' + escapeHtml(a.user) + '"' + (n.canSave === false ? ' disabled' : '') + '>Remove</button></td></tr>';
     }).join('');
     return '<section id="approversSection"><h3>Approvers</h3>' +
-      '<p class="muted" style="margin:0 0 10px">People who can approve, deny, change or answer a request by replying in its thread, like &ldquo;yes, go ahead&rdquo; or &ldquo;make it $40&rdquo;. Nothing runs on a typed reply alone: a yes shows exactly what will run with a Confirm button, and a change is shown to approve first. Once anyone is listed, only approvers&#39; button clicks count too. Anyone in the channel can still ask about a request.</p>' +
+      '<p class="muted" style="margin:0 0 10px">People who can approve, deny, change or answer a request by replying in its thread, like &ldquo;yes, go ahead&rdquo; or &ldquo;make it $40&rdquo;. A plain &ldquo;yes&rdquo; runs it; a reply that&#39;s less clear (&ldquo;sure, send it&rdquo;, &ldquo;yes but check the amount&rdquo;) shows exactly what will run with a Confirm button first, and a change is shown to approve first. Once anyone is listed, only approvers&#39; button clicks count too. Anyone in the channel can still ask about a request.</p>' +
       (approvers.length
         ? '<div class="le-table-wrap" style="max-width:560px"><table><thead><tr><th>Name</th><th>Slack ID</th><th></th></tr></thead><tbody>' + rows + '</tbody></table></div>'
         : '<p class="hint">No approvers yet. Until you add someone, anyone in the channel can use the buttons, and deciding by reply is off.</p>') +

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "loopengine",
-  "version": "0.1.86",
+  "version": "0.1.88",
   "type": "module",
   "description": "Runtime for tool-using AI agents with a transparent ReAct loop.",
   "license": "MIT",