loom-agent 1.2.27 → 1.2.33

package/CHANGELOG.md

@@ -4,6 +4,31 @@ All notable changes to **Loom Code** are documented here.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.2.33] — fix frozen splash on global installs + stable model picker
+
+### Fixed
+- **Global npm installs froze on the splash screen** ("Build … no key", no
+  keyboard input) while repo checkouts worked. Root cause: the launch chain
+  started Bun at the package root and later ran `process.chdir()` back to the
+  user's project inside `tui-open.tsx`. That mid-flight chdir killed OpenTUI's
+  repaint/input pipeline after the first frame — signals kept updating and
+  Solid effects kept firing (verified with runtime instrumentation), but no
+  frame ever reached the terminal again.
+- The launcher now registers the Solid JSX preloader with **absolute
+  `--preload` paths** and starts Bun **directly in the user's project
+  directory**, so no chdir ever happens: `bin/loom-bun.js`, `bin/loom-tui.js`,
+  the postinstall-rewritten shims, and the core-CLI TUI spawn
+  (`src/core/cli.js`) were all switched to that scheme.
+- **Model picker jitter** — scrolling `/models` (and every `SelectModal`:
+  `/connect`, theme pickers, MCP preset picker) bounced the whole modal.
+  Section headers added an extra margin row, so the centered frame's height
+  flipped between 12/13/14 rows on every page of a header-heavy list. The
+  list window is now a fixed 12 rows (headers are plain one-row entries), the
+  window is computed once per change instead of mutating during render, and
+  mouse-hover no longer yanks the selection while a keyboard/wheel scroll is
+  settling. Regression test added (29b: modal title row must never move while
+  scrolling).
+
 ## [Unreleased]
 
 ### Added

package/bin/loom-bun.js

@@ -5,21 +5,28 @@ const path = require("path");
 const fs = require("fs");
 const { spawnSync } = require("child_process");
 
-// Bun discovers bunfig.toml ONLY from its starting cwd, and the Solid JSX
-// plugin ONLY works when loaded through that bunfig preload phase — runtime
-// registration from another cwd silently no-ops (proven). So unless bun is
-// ALREADY sitting in the package root, respawn it there once. The user's
-// real directory rides along in LOOM_START_CWD and is restored by
-// tui-open.tsx after its imports finish loading.
+// The Solid JSX transform must register in Bun's preload phase, so the
+// preloads are passed as ABSOLUTE paths. That lets Bun start directly in the
+// user's project directory — the old "spawn at the package root, then chdir
+// to the project inside tui-open.tsx" dance froze the TUI after the first
+// frame (splash paints once, then no repaints and no keyboard input; proven
+// by A/B-launching the identical entry with and without the mid-flight
+// process.chdir). No chdir ever happens now: LOOM_START_CWD always equals
+// the starting directory, so the restore in tui-open.tsx is a no-op kept
+// only as a safety net.
 const pkgRoot = path.join(__dirname, "..");
 const underBun = typeof Bun !== "undefined" && !!process.versions.bun;
 if (!underBun) {
   const result = spawnSync(
     process.platform === "win32" ? "bun.exe" : "bun",
-    [__filename, ...process.argv.slice(2)],
+    [
+      "--preload", path.join(pkgRoot, "src", "tui-preload.js"),
+      __filename,
+      ...process.argv.slice(2),
+    ],
     {
       stdio: "inherit",
-      cwd: pkgRoot,
+      cwd: process.env.LOOM_START_CWD || process.cwd(),
       env: { ...process.env, LOOM_START_CWD: process.env.LOOM_START_CWD || process.cwd() },
       windowsHide: false,
     }
@@ -58,4 +65,4 @@ process.title = "loom-code";
     console.error(err && err.message ? err.message : String(err));
     process.exit(1);
   }
-})();
+})();

package/bin/loom-tui.js

@@ -4,30 +4,35 @@
 const path = require("path");
 const { spawnSync } = require("child_process");
 
-// Respawn from the package root so bunfig.toml's preload chain (Solid JSX
-// transform) loads natively — see bin/loom-bun.js.
+// Preloads are ABSOLUTE paths so Bun starts directly in the user's project
+// directory — see bin/loom-bun.js for why the package-root + chdir dance is
+// gone (it froze the TUI after the first frame).
 const pkgRoot = path.join(__dirname, "..");
 const underBun = typeof Bun !== "undefined" && !!process.versions.bun;
 if (!underBun) {
-	const result = spawnSync(
-		process.platform === "win32" ? "bun.exe" : "bun",
-		[__filename, ...process.argv.slice(2)],
-		{
-			stdio: "inherit",
-			cwd: pkgRoot,
-			env: { ...process.env, LOOM_START_CWD: process.env.LOOM_START_CWD || process.cwd() },
-			windowsHide: false,
-		}
-	);
-	if (result.error) {
-		console.error("[loom] Bun is required for the TUI. Install it from https://bun.sh/");
-		process.exit(1);
-	}
-	process.exit(result.status == null ? 1 : result.status);
+  const result = spawnSync(
+    process.platform === "win32" ? "bun.exe" : "bun",
+    [
+      "--preload", path.join(pkgRoot, "src", "tui-preload.js"),
+      __filename,
+      ...process.argv.slice(2),
+    ],
+    {
+      stdio: "inherit",
+      cwd: process.env.LOOM_START_CWD || process.cwd(),
+      env: { ...process.env, LOOM_START_CWD: process.env.LOOM_START_CWD || process.cwd() },
+      windowsHide: false,
+    }
+  );
+  if (result.error) {
+    console.error("[loom] Bun is required for the TUI. Install it from https://bun.sh/");
+    process.exit(1);
+  }
+  process.exit(result.status == null ? 1 : result.status);
 }
 
 (async () => {
-	await import("../src/tui-preload.js");
-	await import("@opentui/solid/preload");
-	await import("../src/tui-open.tsx");
-})();
+  await import("../src/tui-preload.js");
+  await import("@opentui/solid/preload");
+  await import("../src/tui-open.tsx");
+})();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "loom-agent",
-  "version": "1.2.27",
+  "version": "1.2.33",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/toshalkumbhar8979-design/loomcode.git"
@@ -9,7 +9,7 @@
   "bugs": {
     "url": "https://github.com/toshalkumbhar8979-design/loomcode/issues"
   },
-  "description": "Loom Code — AI-powered coding agent for the terminal. Multi-provider support including NVIDIA. OpenTUI interface.",
+  "description": "Loom Code — AI-powered coding agent for the terminal. Multi-provider support including NVIDIA. OpenTUI interface.",
   "main": "src/index.js",
   "publishConfig": {
     "access": "public",
@@ -30,6 +30,7 @@
     "tui": "bun bin/loom-tui.js",
     "tui:win": "\"%USERPROFILE%\\..\\bun\\bin\\bun.exe\" run src/tui-open.tsx",
     "prepublishOnly": "npm test",
+    "postinstall": "node scripts/postinstall.js",
     "lint": "tsc --noEmit"
   },
   "dependencies": {
@@ -90,6 +91,7 @@
     "LOOM.md",
     "docs/acp.md",
     "scripts/acp-smoke.js",
+    "scripts/postinstall.js",
     "docs/web.md",
     "src/web/index.html",
     "src/web/graph-view.html"

package/scripts/postinstall.js

@@ -0,0 +1,88 @@
+// Postinstall: rewrite the npm-generated bin shims so `loom` starts ONE bun
+// process directly IN THE USER'S PROJECT DIRECTORY. The Solid JSX preloader
+// is registered with absolute --preload paths (the package-root cwd trick is
+// gone — starting at the package root forced a later process.chdir back to
+// the project inside tui-open.tsx, which froze the TUI after the first frame:
+// splash painted once, then no repaints and no keyboard input).
+const fs = require("fs");
+const path = require("path");
+
+const pkgRoot = path.resolve(__dirname, "..");
+
+function shimDirs() {
+    const dirs = new Set();
+    if (path.basename(path.resolve(pkgRoot, "..")) !== "node_modules") return [];
+    dirs.add(path.resolve(pkgRoot, "..", ".."));
+    dirs.add(path.join(path.resolve(pkgRoot, ".."), ".bin"));
+    return [...dirs].filter(function(d) {
+        try {
+            return fs.existsSync(path.join(d, "loom.cmd")) || fs.existsSync(path.join(d, "loom"));
+        } catch {
+            return false;
+        }
+    });
+}
+
+function cmdShim(pkg, script) {
+    var pkgEscaped = pkg.replace(/\//g, "\\");
+    return [
+        "@ECHO off",
+        "SETLOCAL",
+        'SET "LOOM_START_CWD=%CD%"',
+        'IF EXIST "%~dp0bun.exe" (SET "_prog=%~dp0bun.exe") ELSE (SET "_prog=bun")',
+        '"%_prog%" --preload "%~dp0' + pkgEscaped + '\\src\\tui-preload.js" "%~dp0' + pkgEscaped + '\\bin\\' + script + '" %*',
+        "EXIT /b %ERRORLEVEL%",
+        ""
+    ].join("\r\n");
+}
+
+function psShim(pkg, script) {
+    return [
+        "#!/usr/bin/env pwsh",
+        "# rewritten by loom-agent postinstall (no-cwd-change TUI launch)",
+        "$env:LOOM_START_CWD = (Get-Location).Path",
+        "$pkg = Join-Path $PSScriptRoot '" + pkg + "'",
+        "& bun --preload (Join-Path $pkg 'src/tui-preload.js') (Join-Path $pkg 'bin/" + script + "') @args",
+        "exit $LASTEXITCODE",
+        ""
+    ].join("\n");
+}
+
+function shShim(pkg, script) {
+    return [
+        "#!/bin/sh",
+        "# rewritten by loom-agent postinstall (no-cwd-change TUI launch)",
+        'LOOM_START_CWD="$(pwd)"',
+        "export LOOM_START_CWD",
+        'PKG="$(dirname "$0")/' + pkg + '"',
+        'exec bun --preload "$PKG/src/tui-preload.js" "$PKG/bin/' + script + '" "$@"',
+        ""
+    ].join("\n");
+}
+
+try {
+    for (var i = 0; i < shimDirs().length; i++) {
+        var dir = shimDirs()[i];
+        var relPkg = path.relative(dir, pkgRoot).split(path.sep).join("/");
+        if (!relPkg || relPkg.startsWith("..")) continue;
+        for (var j = 0; j < 2; j++) {
+            var name = j === 0 ? "loom" : "loom-tui";
+            var script = name === "loom" ? "loom-bun.js" : "loom-tui.js";
+            var targets = [
+                [name + ".cmd", cmdShim(relPkg, script)],
+                [name + ".ps1", psShim(relPkg, script)],
+                [name, shShim(relPkg, script)]
+            ];
+            for (var k = 0; k < targets.length; k++) {
+                var file = targets[k][0];
+                var content = targets[k][1];
+                var p = path.join(dir, file);
+                if (!fs.existsSync(p)) continue;
+                fs.writeFileSync(p, content, { mode: 0o755 });
+                console.log("[loom-agent] rewrote shim " + p);
+            }
+        }
+    }
+} catch (err) {
+    console.warn("[loom-agent] shim rewrite skipped: " + (err && err.message));
+}

package/src/core/cli.js

@@ -38,7 +38,7 @@ class LoomCLI {
       terminal: true,
     });
     console.log(LOOM_BASE);
-    console.log(`\n  Loom Code v1.2.27 — AI Coding Agent for the terminal`);
+    console.log(`\n  Loom Code v1.2.28 — AI Coding Agent for the terminal`);
     console.log(`  Press Ctrl+C or ESC to interrupt | /help for commands\n`);
 
     process.stdin.on('keypress', (str, key) => {
@@ -575,19 +575,22 @@ if (args.includes('--help') || args.includes('-h')) {
       const tuiEntry = path.join(__dirname, '..', 'tui-open.tsx');
       if (bunPath && fs.existsSync(tuiEntry)) {
         const { spawnSync } = require('child_process');
-        // Start bun from the package root so it discovers bunfig.toml /
-        // tsconfig.json (Solid JSX preloader) even for global installs;
-        // LOOM_START_CWD restores the user's project dir in tui-bootstrap.js.
+        // The Solid JSX preloader is registered inside src/tui-preload.js
+        // (passed as an ABSOLUTE --preload path), so bun starts directly in
+        // the user's project directory. The old "start at the package root,
+        // chdir to the project inside tui-open" dance froze the TUI after
+        // the first frame (no repaints, no keyboard input) — see
+        // bin/loom-bun.js.
         const pkgRoot = path.join(__dirname, '..', '..');
+        const tuiPreload = path.join(pkgRoot, 'src', 'tui-preload.js');
         process.env.LOOM_START_CWD = process.cwd();
         process.env.LOOM_BIN_NAME = "loom";
-        process.env.BUN_CONFIG = path.join(pkgRoot, "bunfig.toml");
-        const tuiArgs = [tuiEntry];
+        const tuiArgs = ['--preload', tuiPreload, tuiEntry];
         if (sessionId) tuiArgs.push('-s', sessionId);
         if (autoMode) tuiArgs.push('--auto');
         const prompt = promptArgs.join(' ');
         if (prompt) tuiArgs.push(...prompt.split(/\s+/));
-        process.exit(spawnSync(bunPath, tuiArgs, { stdio: 'inherit', cwd: pkgRoot, env: process.env }).status ?? 0);
+        process.exit(spawnSync(bunPath, tuiArgs, { stdio: 'inherit', cwd: process.cwd(), env: process.env }).status ?? 0);
       }
       console.error('[loom] bun not found — full TUI requires bun (https://bun.sh/). Falling back to line-mode REPL.');
       console.error('[loom] Use --basic to skip this warning.\n');

package/src/tui/components/Modals.tsx

@@ -1,5 +1,5 @@
 // Modals -- provider picker, model picker, key input, base URL, settings, palette.
-import { createSignal, onMount } from "solid-js";
+import { createSignal, createMemo, onMount } from "solid-js";
 import { useKeyboard, usePaste } from "@opentui/solid";
 import { palette } from "../theme.ts";
 import * as kbs from "../keybinds.ts";
@@ -206,17 +206,25 @@ export function SelectModal(props: {
   // Start on the first real row (not a header).
   setIndex(firstSelectable());
 
+  // Hover must not fight scrolling: any keyboard/wheel/search index change
+  // locks hover-selection briefly, so the list sliding under a stationary
+  // cursor cannot yank the selection back (this feedback loop read as
+  // "jitter" while scrolling the model picker).
+  let hoverLockUntil = 0;
+  const lockHover = () => { hoverLockUntil = Date.now() + 250; };
+  const setIndexByKey = (fn: (i: number) => number) => { setIndex(fn); lockHover(); };
+
   const nav = kbNav();
 
   useKeyboard(key => {
     const ks = kbs.keyString(key);
     if (kbs.is("modal_cancel", ks)) { closeModal(); if (props.onCancel) props.onCancel(); return; }
-    if (kbs.dialogIs("dialog_select_prev", ks)) { setIndex(i => stepSelectable(i, -1)); firePreview(); return; }
-    if (kbs.dialogIs("dialog_select_next", ks)) { setIndex(i => stepSelectable(i, 1)); firePreview(); return; }
-    if (kbs.dialogIs("dialog_select_page_up", ks)) { setIndex(i => pageJump(i, -1)); firePreview(); return; }
-    if (kbs.dialogIs("dialog_select_page_down", ks)) { setIndex(i => pageJump(i, 1)); firePreview(); return; }
-    if (kbs.dialogIs("dialog_select_home", ks)) { setIndex(firstSelectable()); firePreview(); return; }
-    if (kbs.dialogIs("dialog_select_end", ks)) { setIndex(lastSelectable()); firePreview(); return; }
+    if (kbs.dialogIs("dialog_select_prev", ks)) { setIndexByKey(i => stepSelectable(i, -1)); firePreview(); return; }
+    if (kbs.dialogIs("dialog_select_next", ks)) { setIndexByKey(i => stepSelectable(i, 1)); firePreview(); return; }
+    if (kbs.dialogIs("dialog_select_page_up", ks)) { setIndexByKey(i => pageJump(i, -1)); firePreview(); return; }
+    if (kbs.dialogIs("dialog_select_page_down", ks)) { setIndexByKey(i => pageJump(i, 1)); firePreview(); return; }
+    if (kbs.dialogIs("dialog_select_home", ks)) { setIndexByKey(firstSelectable); firePreview(); return; }
+    if (kbs.dialogIs("dialog_select_end", ks)) { setIndexByKey(lastSelectable); firePreview(); return; }
     if (kbs.dialogIs("dialog_select_submit", ks)) {
       const opt = filtered()[index()];
       if (!opt || opt.isHeader) return;
@@ -226,11 +234,11 @@ export function SelectModal(props: {
     if (props.searchable) {
       // Reset to 0, not firstSelectable(): setQ is batched, so firstSelectable()
       // would read the STALE list and land past its end (dead arrows/blank row).
-      if (key.name === "backspace") { setQ(v => v.slice(0, -1)); setIndex(0); firePreview(); return; }
+      if (key.name === "backspace") { setQ(v => v.slice(0, -1)); setIndexByKey(() => 0); firePreview(); return; }
       const s = key.sequence;
       if (!key.ctrl && !key.meta && s && s.length <= 10 && s !== "\r" && s !== "\n") {
         setQ(v => v + s);
-        setIndex(0);
+        setIndexByKey(() => 0);
         firePreview();
         return;
       }
@@ -246,7 +254,7 @@ export function SelectModal(props: {
       if (j === i) break;
       i = j;
     }
-    setIndex(i);
+    setIndexByKey(() => i);
   };
   const clickRow = (i: number) => {
     if (i !== index()) {
@@ -257,12 +265,14 @@ export function SelectModal(props: {
     if (o?.isHeader) return;
     props.onPick(o?.value, o);
   };
-  let winStart = 0;
-  const win = () => {
+  // Window of 12 rows, computed ONCE per reactive change (the old version
+  // mutated `winStart` from inside the JSX — called three times per render).
+  let lastStart = 0;
+  const win = createMemo(() => {
     const total = filtered().length;
-    winStart = windowFor(index(), total, 12, winStart);
-    return { total, start: winStart, items: filtered().slice(winStart, winStart + 12) };
-  };
+    lastStart = windowFor(index(), total, 12, lastStart);
+    return { total, start: lastStart, items: filtered().slice(lastStart, lastStart + 12) };
+  });
   const rangeSub = () => {
     const w = win();
     if (w.total <= 12) return "";
@@ -271,21 +281,27 @@ export function SelectModal(props: {
 
   return (
     <ModalFrame title={props.title} subtitle={(props.searchable ? "search: " + (q() || "_") + rangeSub() : rangeSub())} footer={nav.prev + "/" + nav.next + " navigate  |  " + nav.submit + " select  |  wheel scroll  |  " + nav.cancel + " cancel" + (props.searchable ? "  |  type to search" : "")}>
-      <box onMouseScroll={scrollBy}>
+      {/* Fixed height: the modal frame must not resize while scrolling.
+          Headers used to add an extra margin row, so the centered modal
+          bounced between 12/13/14 rows on every page of a header-heavy list
+          (the model picker) — the "jitter". Every item is now exactly one
+          row and the window is always 12 rows tall. */}
+      <box onMouseScroll={scrollBy} height={12} flexShrink={0}>
         {win().items.map((opt, i) => {
           const abs = win().start + i;
           if (opt.isHeader) return (
-            <text fg={ui.secondary} marginTop={i === 0 ? 0 : 1}>
+            <text fg={ui.secondary}>
               {opt.header + ":"}
             </text>
           );
           const active = abs === index();
           return (
             <box
- flexDirection="row" paddingLeft={2}
-              // Hover moves the selection (live theme preview via onPreview);
-              // a click on the hovered row still selects+submits.
-              onMouseOver={() => { if (abs !== index()) { setIndex(abs); firePreview(); } }}
+              flexDirection="row" paddingLeft={2}
+              // Hover moves the selection (live theme preview via onPreview) —
+              // but only for genuine pointer movement, never while a
+              // keyboard/wheel scroll is settling (see hoverLockUntil).
+              onMouseOver={() => { if (Date.now() >= hoverLockUntil && abs !== index()) { setIndex(abs); firePreview(); } }}
               onMouseDown={() => setIndex(abs)}
               onMouseUp={() => clickRow(abs)}
             >

package/src/tui-preload.js

@@ -51,6 +51,61 @@ globalThis.__loomTrace = record;
 process.on("uncaughtException", (e) => record("uncaughtException", e));
 process.on("unhandledRejection", (r) => record("unhandledRejection", r));
 
+// Global npm installs live INSIDE node_modules, and @opentui/solid's loader
+// filter deliberately skips every node_modules path — so for installs the
+// app's own TSX would fall through to Bun's default React JSX transform and
+// crash at startup ("Cannot find module 'react/jsx-dev-runtime'").
+//
+// This preload is THE single registration point for the TUI launch chain
+// (shims and respawns pass ONLY this file via --preload, with an absolute
+// path), so it registers both plugins itself:
+//   1. The Solid JSX plugin — via the bare "@opentui/solid/bun-plugin"
+//      specifier, which resolves by walking up from this file and therefore
+//      works whether the dependency is nested inside the package or hoisted
+//      to the install root. Idempotent (symbol-guarded upstream).
+//   2. A supplemental loader scoped to THIS package's src directory only —
+//      real dependencies are never touched. It is a no-op in repo checkouts,
+//      where the solid plugin (non-node_modules paths) already handles these
+//      files first.
+if (typeof Bun !== "undefined" && Bun.plugin) {
+  try {
+    require("@opentui/solid/bun-plugin").ensureSolidTransformPlugin();
+  } catch {}
+  if (!globalThis.__loomAppTsxPlugin) {
+    try {
+      globalThis.__loomAppTsxPlugin = true;
+      const pkgSrc = __dirname; // tui-preload.js lives in src/
+      const pkgRoot = path.join(pkgSrc, "..");
+      const esc = pkgSrc.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+      // Layout-proof transform lookup: nested (npm i -g default observed)
+      // and hoisted (top-level install node_modules) candidates.
+      const candidates = [
+        path.join(pkgRoot, "node_modules", "@opentui", "solid", "scripts", "solid-transform.js"),
+        path.join(pkgRoot, "..", "..", "@opentui", "solid", "scripts", "solid-transform.js"),
+      ];
+      let transformSolidSource = null;
+      for (const c of candidates) {
+        try { transformSolidSource = require(c).transformSolidSource; break; } catch {}
+      }
+      if (transformSolidSource) {
+        Bun.plugin({
+          name: "loom-app-solid-tsx",
+          setup(build) {
+            build.onLoad({ filter: new RegExp("^" + esc + "[\\\\/].+\\.tsx$") }, async (args) => {
+              const code = await Bun.file(args.path).text();
+              const contents = await transformSolidSource(code, {
+                filename: args.path,
+                moduleName: "@opentui/solid",
+              });
+              return { contents, loader: "js" };
+            });
+          },
+        });
+      }
+    } catch {}
+  }
+}
+
 // stdout byte-counter: frames flowing = counter climbs. This splits the two
 // remaining frozen-splash suspects with certainty — if the counter climbs but
 // the screen is frozen, the console is dropping VT repaints (mode flags); if