loki-mode 6.61.0 → 6.62.1

package/SKILL.md

@@ -3,7 +3,7 @@ name: loki-mode
 description: Multi-agent autonomous startup system. Triggers on "Loki Mode". Takes PRD to deployed product with minimal human intervention. Requires --dangerously-skip-permissions flag.
 ---
 
-# Loki Mode v6.61.0
+# Loki Mode v6.62.1
 
 **You are an autonomous agent. You make decisions. You do not ask questions. You do not stop.**
 
@@ -267,4 +267,4 @@ The following features are documented in skill modules but not yet fully automat
 | Quality gates 3-reviewer system | Implemented (v5.35.0) | 5 specialist reviewers in `skills/quality-gates.md`; execution in run.sh |
 | Benchmarks (HumanEval, SWE-bench) | Infrastructure only | Runner scripts and datasets exist in `benchmarks/`; no published results |
 
-**v6.61.0 | [Autonomi](https://www.autonomi.dev/) flagship product | ~260 lines core**
+**v6.62.1 | [Autonomi](https://www.autonomi.dev/) flagship product | ~260 lines core**

package/VERSION

@@ -1 +1 @@
-6.61.0
+6.62.1

package/autonomy/app-runner.sh

@@ -42,6 +42,7 @@ _APP_RUNNER_PORT=""
 _APP_RUNNER_PID=""
 _APP_RUNNER_URL=""
 _APP_RUNNER_IS_DOCKER=false
+_APP_RUNNER_DOCKER_CONTAINER=""
 _APP_RUNNER_HAS_SETSID=false
 _APP_RUNNER_CRASH_COUNT=0
 _APP_RUNNER_RESTART_COUNT=0
@@ -145,7 +146,8 @@ _detect_port() {
             fi
             local port
             # Handle both simple (HOST:CONTAINER) and IP-bound (IP:HOST:CONTAINER) port formats
-            port=$(grep -E '^\s*-\s*"?[0-9]' "$compose_file" 2>/dev/null | head -1 | sed 's/.*- *"*//;s/".*//;' | awk -F: '{print $(NF-1)}')
+            # Also handle port ranges like "8080-8090:8080-8090" by taking the first port
+            port=$(grep -E '^\s*-\s*"?[0-9]' "$compose_file" 2>/dev/null | head -1 | sed 's/.*- *"*//;s/".*//;' | awk -F: '{print $(NF-1)}' | awk -F- '{print $1}')
             _APP_RUNNER_PORT="${port:-8080}"
             ;;
         *docker\ build*)
@@ -244,7 +246,11 @@ app_runner_init() {
     if [ -f "$dir/Dockerfile" ]; then
         if command -v docker >/dev/null 2>&1 && docker info >/dev/null 2>&1; then
             _detect_port "docker build"
-            _APP_RUNNER_METHOD="docker build -t loki-app . && docker run -d -p ${_APP_RUNNER_PORT}:${_APP_RUNNER_PORT} --name loki-app-container loki-app"
+            # Include project hash in container name to avoid collisions across projects
+            local _project_hash
+            _project_hash=$(echo "$dir" | (md5sum 2>/dev/null || md5 -r 2>/dev/null || echo "$$") | cut -c1-8)
+            _APP_RUNNER_DOCKER_CONTAINER="loki-app-${_project_hash}"
+            _APP_RUNNER_METHOD="docker build -t loki-app . && docker run -d -p ${_APP_RUNNER_PORT}:${_APP_RUNNER_PORT} --name ${_APP_RUNNER_DOCKER_CONTAINER} loki-app"
             _APP_RUNNER_IS_DOCKER=true
             _write_detection "dockerfile" "$_APP_RUNNER_METHOD"
             log_info "App Runner: detected Dockerfile"
@@ -431,12 +437,28 @@ app_runner_start() {
     # Start the process in a new process group
     if command -v setsid >/dev/null 2>&1; then
         _APP_RUNNER_HAS_SETSID=true
-        (cd "$dir" && setsid bash -c "$_APP_RUNNER_METHOD" >> "$_APP_RUNNER_DIR/app.log" 2>&1) &
+        # Use setsid with a PID file so we capture the actual child PID (the process
+        # group leader) rather than the subshell PID, which would orphan the app.
+        local _pgid_file="$_APP_RUNNER_DIR/app.pgid.$$"
+        (cd "$dir" && setsid bash -c 'echo $$ > "'"$_pgid_file"'"; exec '"$_APP_RUNNER_METHOD" >> "$_APP_RUNNER_DIR/app.log" 2>&1) &
+        local _subshell_pid=$!
+        # Wait briefly for the pgid file to appear, then read the real PGID
+        local _pgid_wait=0
+        while [ ! -s "$_pgid_file" ] && [ "$_pgid_wait" -lt 10 ]; do
+            sleep 0.1
+            _pgid_wait=$(( _pgid_wait + 1 ))
+        done
+        if [ -s "$_pgid_file" ]; then
+            _APP_RUNNER_PID=$(cat "$_pgid_file")
+        else
+            _APP_RUNNER_PID=$_subshell_pid
+        fi
+        rm -f "$_pgid_file"
     else
         _APP_RUNNER_HAS_SETSID=false
         (cd "$dir" && bash -c "$_APP_RUNNER_METHOD" >> "$_APP_RUNNER_DIR/app.log" 2>&1) &
+        _APP_RUNNER_PID=$!
     fi
-    _APP_RUNNER_PID=$!
     # Register with central PID registry if available
     if type register_pid &>/dev/null; then
         register_pid "$_APP_RUNNER_PID" "app-runner" "method=$_APP_RUNNER_METHOD"
@@ -494,8 +516,10 @@ app_runner_stop() {
 
     # Docker cleanup
     if [ "$_APP_RUNNER_IS_DOCKER" = true ]; then
-        docker stop loki-app-container 2>/dev/null || true
-        docker rm loki-app-container 2>/dev/null || true
+        if [ -n "$_APP_RUNNER_DOCKER_CONTAINER" ]; then
+            docker stop "$_APP_RUNNER_DOCKER_CONTAINER" 2>/dev/null || true
+            docker rm "$_APP_RUNNER_DOCKER_CONTAINER" 2>/dev/null || true
+        fi
         if echo "$_APP_RUNNER_METHOD" | grep -q "docker compose"; then
             (cd "${TARGET_DIR:-.}" && docker compose down 2>/dev/null) || true
         fi
@@ -704,8 +728,10 @@ app_runner_cleanup() {
 
     # Docker-specific cleanup
     if [ "$_APP_RUNNER_IS_DOCKER" = true ]; then
-        docker stop loki-app-container 2>/dev/null || true
-        docker rm loki-app-container 2>/dev/null || true
+        if [ -n "$_APP_RUNNER_DOCKER_CONTAINER" ]; then
+            docker stop "$_APP_RUNNER_DOCKER_CONTAINER" 2>/dev/null || true
+            docker rm "$_APP_RUNNER_DOCKER_CONTAINER" 2>/dev/null || true
+        fi
         if echo "$_APP_RUNNER_METHOD" | grep -q "docker compose"; then
             (cd "${TARGET_DIR:-.}" && docker compose down 2>/dev/null) || true
         fi

package/autonomy/completion-council.sh

@@ -48,6 +48,10 @@ if ! [[ "$COUNCIL_CHECK_INTERVAL" =~ ^[1-9][0-9]*$ ]]; then
     COUNCIL_CHECK_INTERVAL=5
 fi
 COUNCIL_MIN_ITERATIONS=${LOKI_COUNCIL_MIN_ITERATIONS:-3}
+# BUG-QG-012: Enforce minimum of 1 to prevent council approving at iteration 0
+if [ "$COUNCIL_MIN_ITERATIONS" -lt 1 ] 2>/dev/null; then
+    COUNCIL_MIN_ITERATIONS=1
+fi
 COUNCIL_CONVERGENCE_WINDOW=${LOKI_COUNCIL_CONVERGENCE_WINDOW:-3}
 COUNCIL_STAGNATION_LIMIT=${LOKI_COUNCIL_STAGNATION_LIMIT:-5}
 COUNCIL_DONE_SIGNAL_LIMIT=${LOKI_COUNCIL_DONE_SIGNAL_LIMIT:-10}
@@ -84,6 +88,7 @@ council_init() {
     COUNCIL_PRD_PATH="$prd_path"
     COUNCIL_CONSECUTIVE_NO_CHANGE=0
     COUNCIL_DONE_SIGNALS=0
+    COUNCIL_TOTAL_DONE_SIGNALS=0
     COUNCIL_LAST_DIFF_HASH=""
 
     mkdir -p "$COUNCIL_STATE_DIR"
@@ -131,7 +136,11 @@ council_track_iteration() {
     local staged_hash
     staged_hash=$(git diff --cached --stat 2>/dev/null | (md5sum 2>/dev/null || md5 -r 2>/dev/null) | cut -d' ' -f1 || echo "unknown")
 
-    local combined_hash="${current_diff_hash}-${staged_hash}"
+    # Include latest commit hash so committed changes are detected (BUG-QG-004)
+    local commit_hash
+    commit_hash=$(git log --oneline -1 2>/dev/null | cut -d' ' -f1 || echo "unknown")
+
+    local combined_hash="${current_diff_hash}-${staged_hash}-${commit_hash}"
 
     if [ "$combined_hash" = "$COUNCIL_LAST_DIFF_HASH" ]; then
         ((COUNCIL_CONSECUTIVE_NO_CHANGE++))
@@ -248,6 +257,9 @@ council_vote() {
     log_header "COMPLETION COUNCIL - Iteration $ITERATION_COUNT"
     log_info "Convening ${COUNCIL_SIZE}-member council..."
 
+    # Compute threshold using ceiling(2/3) formula, consistent with council_aggregate_votes
+    local effective_threshold=$(( (COUNCIL_SIZE * 2 + 2) / 3 ))
+
     # Gather evidence for council members
     local evidence_file="$vote_dir/evidence.md"
     council_gather_evidence "$evidence_file" "$prd_path"
@@ -287,30 +299,57 @@ council_vote() {
         # is based only on issues below the severity threshold
         if [ "$vote_result" = "REJECT" ] && [ "$COUNCIL_SEVERITY_THRESHOLD" != "low" ] && [ -n "$member_issues" ]; then
             local has_blocking_issue=false
+            local non_blocking_count=0
+            local total_issue_count=0
             local severity_order="critical high medium low"
             local threshold_reached=false
 
             while IFS= read -r issue_line; do
                 local issue_severity
                 issue_severity=$(echo "$issue_line" | grep -oE "(CRITICAL|HIGH|MEDIUM|LOW)" | head -1 | tr '[:upper:]' '[:lower:]')
+                [ -z "$issue_severity" ] && continue
+                ((total_issue_count++))
                 # Reset per issue line so previous iterations don't poison the check
                 threshold_reached=false
                 # Check if this severity meets or exceeds the threshold
+                local is_blocking=false
                 for sev in $severity_order; do
                     if [ "$sev" = "$issue_severity" ] && [ "$threshold_reached" = "false" ]; then
                         has_blocking_issue=true
+                        is_blocking=true
                         break
                     fi
                     if [ "$sev" = "$COUNCIL_SEVERITY_THRESHOLD" ]; then
                         threshold_reached=true
                     fi
                 done
+                if [ "$is_blocking" = "false" ]; then
+                    ((non_blocking_count++))
+                fi
             done <<< "$member_issues"
 
+            # Apply error budget: if no blocking issues, check non-blocking ratio
             if [ "$has_blocking_issue" = "false" ]; then
-                log_info "  Member $member ($role): REJECT overridden to APPROVE (issues below ${COUNCIL_SEVERITY_THRESHOLD} threshold)"
-                vote_result="APPROVE"
+                local budget_exceeded=false
+                if [ "$total_issue_count" -gt 0 ] && [ "$COUNCIL_ERROR_BUDGET" != "0.0" ] && [ "$COUNCIL_ERROR_BUDGET" != "0" ]; then
+                    # Check if non-blocking issue ratio exceeds the error budget
+                    budget_exceeded=$(_NB="$non_blocking_count" _TOTAL="$total_issue_count" _BUDGET="$COUNCIL_ERROR_BUDGET" python3 -c "
+import os
+nb = int(os.environ['_NB'])
+total = int(os.environ['_TOTAL'])
+budget = float(os.environ['_BUDGET'])
+ratio = nb / total if total > 0 else 0.0
+print('true' if ratio > budget else 'false')
+" 2>/dev/null || echo "false")
+                fi
+                if [ "$budget_exceeded" = "true" ]; then
+                    log_info "  Member $member ($role): REJECT maintained (non-blocking issue ratio exceeds error budget ${COUNCIL_ERROR_BUDGET})"
+                else
+                    log_info "  Member $member ($role): REJECT overridden to APPROVE (issues below ${COUNCIL_SEVERITY_THRESHOLD} threshold, within error budget)"
+                    vote_result="APPROVE"
+                fi
             fi
+
         fi
 
         if [ "$vote_result" = "APPROVE" ]; then
@@ -333,7 +372,7 @@ council_vote() {
     done
 
     # Anti-sycophancy check: if unanimous APPROVE, run devil's advocate
-    if [ $approve_count -eq $COUNCIL_SIZE ] && [ $COUNCIL_SIZE -ge 3 ]; then
+    if [ $approve_count -eq $COUNCIL_SIZE ] && [ $COUNCIL_SIZE -ge 2 ]; then
         log_warn "Unanimous approval detected - running anti-sycophancy check..."
         local contrarian_verdict
         contrarian_verdict=$(council_devils_advocate "$evidence_file" "$vote_dir")
@@ -356,7 +395,7 @@ council_vote() {
     _COUNCIL_APPROVE="$approve_count" \
     _COUNCIL_REJECT="$reject_count" \
     _COUNCIL_ITERATION="${ITERATION_COUNT:-0}" \
-    _COUNCIL_THRESHOLD="$COUNCIL_THRESHOLD" \
+    _COUNCIL_THRESHOLD="$effective_threshold" \
     python3 -c "
 import json, os
 from datetime import datetime, timezone
@@ -387,7 +426,7 @@ with open(state_file, 'w') as f:
 " || log_warn "Failed to record council vote results"
 
     echo ""
-    log_info "Council verdict: $approve_count APPROVE / $reject_count REJECT (threshold: $COUNCIL_THRESHOLD)"
+    log_info "Council verdict: $approve_count APPROVE / $reject_count REJECT (threshold: $effective_threshold)"
     echo -e "$verdicts"
     echo ""
 
@@ -396,10 +435,10 @@ with open(state_file, 'w') as f:
         "iteration=$ITERATION_COUNT" \
         "approve=$approve_count" \
         "reject=$reject_count" \
-        "threshold=$COUNCIL_THRESHOLD" \
-        "result=$([ $approve_count -ge $COUNCIL_THRESHOLD ] && echo 'APPROVED' || echo 'REJECTED')" 2>/dev/null || true
+        "threshold=$effective_threshold" \
+        "result=$([ $approve_count -ge $effective_threshold ] && echo 'APPROVED' || echo 'REJECTED')" 2>/dev/null || true
 
-    if [ $approve_count -ge $COUNCIL_THRESHOLD ]; then
+    if [ $approve_count -ge $effective_threshold ]; then
         return 0  # Council says DONE
     fi
     return 1  # Council says CONTINUE
@@ -754,27 +793,27 @@ ISSUES: CRITICAL:description (optional, one per line per issue)"
         claude)
             if command -v claude &>/dev/null; then
                 local council_model="${PROVIDER_MODEL_FAST:-haiku}"
-                verdict=$(echo "$prompt" | claude --model "$council_model" -p 2>/dev/null | tail -5)
+                verdict=$(echo "$prompt" | claude --model "$council_model" -p 2>/dev/null | tail -20)
             fi
             ;;
         codex)
             if command -v codex &>/dev/null; then
-                verdict=$(codex exec --full-auto "$prompt" 2>/dev/null | tail -5)
+                verdict=$(codex exec --full-auto "$prompt" 2>/dev/null | tail -20)
             fi
             ;;
         gemini)
             if command -v gemini &>/dev/null; then
-                verdict=$(echo "$prompt" | gemini 2>/dev/null | tail -5)
+                verdict=$(echo "$prompt" | gemini 2>/dev/null | tail -20)
             fi
             ;;
         cline)
             if command -v cline &>/dev/null; then
-                verdict=$(cline -y "$prompt" 2>/dev/null | tail -5)
+                verdict=$(cline -y "$prompt" 2>/dev/null | tail -20)
             fi
             ;;
         aider)
             if command -v aider &>/dev/null; then
-                verdict=$(aider --message "$prompt" --yes-always --no-auto-commits --no-git 2>/dev/null | tail -5)
+                verdict=$(aider --message "$prompt" --yes-always --no-auto-commits --no-git 2>/dev/null | tail -20)
             fi
             ;;
     esac
@@ -808,19 +847,13 @@ council_devils_advocate() {
     local evidence
     evidence=$(cat "$evidence_file" 2>/dev/null || echo "No evidence available")
 
-    # Read all previous approvals
-    local prev_verdicts=""
-    for f in "$vote_dir"/member-*.txt; do
-        [ -f "$f" ] && prev_verdicts="${prev_verdicts}\n$(cat "$f")"
-    done
+    # BUG-QG-009: Do NOT show prior verdicts to devil's advocate (blind review)
+    # Previous code read member-*.txt files here, biasing the contrarian reviewer
 
     local prompt="ANTI-SYCOPHANCY CHECK: All council members unanimously APPROVED this project.
 
 Your job is to be the CONTRARIAN. Find ANY reason this should NOT be approved.
 
-Previous verdicts:
-${prev_verdicts}
-
 EVIDENCE:
 ${evidence}
 
@@ -843,27 +876,27 @@ REASON: your reasoning"
         claude)
             if command -v claude &>/dev/null; then
                 local council_model="${PROVIDER_MODEL_FAST:-haiku}"
-                verdict=$(echo "$prompt" | claude --model "$council_model" -p 2>/dev/null | tail -5)
+                verdict=$(echo "$prompt" | claude --model "$council_model" -p 2>/dev/null | tail -20)
             fi
             ;;
         codex)
             if command -v codex &>/dev/null; then
-                verdict=$(codex exec --full-auto "$prompt" 2>/dev/null | tail -5)
+                verdict=$(codex exec --full-auto "$prompt" 2>/dev/null | tail -20)
             fi
             ;;
         gemini)
             if command -v gemini &>/dev/null; then
-                verdict=$(echo "$prompt" | gemini 2>/dev/null | tail -5)
+                verdict=$(echo "$prompt" | gemini 2>/dev/null | tail -20)
             fi
             ;;
         cline)
             if command -v cline &>/dev/null; then
-                verdict=$(cline -y "$prompt" 2>/dev/null | tail -5)
+                verdict=$(cline -y "$prompt" 2>/dev/null | tail -20)
             fi
             ;;
         aider)
             if command -v aider &>/dev/null; then
-                verdict=$(aider --message "$prompt" --yes-always --no-auto-commits --no-git 2>/dev/null | tail -5)
+                verdict=$(aider --message "$prompt" --yes-always --no-auto-commits --no-git 2>/dev/null | tail -20)
             fi
             ;;
     esac
@@ -985,10 +1018,15 @@ council_evaluate_member() {
     # If code is still changing, work may not be done
     local current_diff_hash
     current_diff_hash=$(git diff --stat HEAD 2>/dev/null | (md5sum 2>/dev/null || md5 -r 2>/dev/null) | cut -d' ' -f1 || echo "unknown")
-    if [ "$COUNCIL_CONSECUTIVE_NO_CHANGE" -eq 0 ] && [ "$ITERATION_COUNT" -gt "$COUNCIL_MIN_ITERATIONS" ]; then
-        # Code is still actively changing -- likely not done
-        vote="CONTINUE"
-        reasons="${reasons}code still changing between iterations; "
+    if [ "$COUNCIL_CONSECUTIVE_NO_CHANGE" -gt 0 ] && [ "$ITERATION_COUNT" -gt "$COUNCIL_MIN_ITERATIONS" ]; then
+        # Code has stopped changing -- stagnation, not necessarily done
+        # (BUG-QG-011: previously inverted -- forced CONTINUE when code was changing,
+        # which penalized active progress. Now: stagnation with no passing checks = CONTINUE)
+        if [ "$vote" = "COMPLETE" ]; then
+            : # Other checks passed despite stagnation -- allow COMPLETE
+        else
+            reasons="${reasons}code stagnated with failing checks; "
+        fi
     fi
 
     # Check 3: Are there uncaught errors in logs?
@@ -1296,7 +1334,7 @@ council_evaluate() {
             complete_count=$(_RF="$round_file" python3 -c "import json, os; print(json.load(open(os.environ['_RF'])).get('complete_votes', 0))" 2>/dev/null || echo "0")
         fi
 
-        if [ "$complete_count" -eq "$COUNCIL_SIZE" ] && [ "$COUNCIL_SIZE" -ge 3 ]; then
+        if [ "$complete_count" -eq "$COUNCIL_SIZE" ] && [ "$COUNCIL_SIZE" -ge 2 ]; then
             # Step 3: Unanimous -- run devil's advocate
             local da_result
             da_result=$(council_devils_advocate_review "$ITERATION_COUNT")

package/autonomy/hooks/migration-hooks.sh

@@ -31,6 +31,7 @@
 
 set -euo pipefail
 
+# shellcheck disable=SC2034
 HOOKS_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # Load project-specific hook config if it exists
@@ -38,14 +39,22 @@ load_migration_hook_config() {
     local codebase_path="${1:-.}"
     local config_file="${codebase_path}/.loki/migration-hooks.yaml"
 
-    # Defaults
+    # Defaults (used by other functions in this file; SC2034 disabled for globals-via-function pattern)
+    # shellcheck disable=SC2034
     HOOK_POST_FILE_EDIT_ENABLED=true
+    # shellcheck disable=SC2034
     HOOK_POST_STEP_ENABLED=true
+    # shellcheck disable=SC2034
     HOOK_PRE_PHASE_GATE_ENABLED=true
+    # shellcheck disable=SC2034
     HOOK_ON_AGENT_STOP_ENABLED=true
+    # shellcheck disable=SC2034
     HOOK_POST_FILE_EDIT_ACTION="run_tests"
+    # shellcheck disable=SC2034
     HOOK_POST_FILE_EDIT_ON_FAILURE="block_and_rollback"
+    # shellcheck disable=SC2034
     HOOK_POST_STEP_ON_FAILURE="reject_completion"
+    # shellcheck disable=SC2034
     HOOK_ON_AGENT_STOP_ON_FAILURE="force_continue"
 
     if [[ -f "$config_file" ]] && command -v python3 &>/dev/null; then

package/autonomy/issue-parser.sh

@@ -258,8 +258,7 @@ parse_github_issue() {
 
     # Parse the reference
     local parsed_ref
-    parsed_ref=$(parse_issue_ref "$issue_ref")
-    if [ $? -ne 0 ]; then
+    if ! parsed_ref=$(parse_issue_ref "$issue_ref"); then
         return 1
     fi
 
@@ -272,9 +271,7 @@ parse_github_issue() {
 
     # Fetch issue data
     local issue_data
-    issue_data=$(gh issue view "$number" --repo "$owner/$repo" --json number,title,body,labels,assignees,milestone,state,url,createdAt,author 2>&1)
-
-    if [ $? -ne 0 ]; then
+    if ! issue_data=$(gh issue view "$number" --repo "$owner/$repo" --json number,title,body,labels,assignees,milestone,state,url,createdAt,author 2>&1); then
         log_error "Failed to fetch issue: $issue_data"
         return 1
     fi
@@ -612,8 +609,8 @@ main() {
 
     # Parse the issue
     local result
-    result=$(parse_github_issue "$issue_ref" "$format")
-    local exit_code=$?
+    local exit_code=0
+    result=$(parse_github_issue "$issue_ref" "$format") || exit_code=$?
 
     if [ $exit_code -ne 0 ]; then
         exit $exit_code

package/autonomy/issue-providers.sh

@@ -15,14 +15,19 @@
 #   JSON with normalized fields: provider, number, title, body, labels, author, url, created_at
 #===============================================================================
 
-# Colors (safe to re-source)
+# Colors (safe to re-source; used by scripts that source this file)
+# shellcheck disable=SC2034
 RED='\033[0;31m'
+# shellcheck disable=SC2034
 GREEN='\033[0;32m'
+# shellcheck disable=SC2034
 YELLOW='\033[1;33m'
+# shellcheck disable=SC2034
 CYAN='\033[0;36m'
 NC='\033[0m'
 
-# Supported issue providers
+# Supported issue providers (exported for sourcing scripts)
+# shellcheck disable=SC2034
 ISSUE_PROVIDERS=("github" "gitlab" "jira" "azure_devops")
 
 # Detect issue provider from a URL or reference