loki-mode 11.17.6 → 11.17.13

package/mcp/__init__.py

@@ -75,4 +75,4 @@ try:
 except ImportError:
     __all__ = ['mcp']
 
-__version__ = '11.17.6'
+__version__ = '11.17.13'

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "loki-mode",
   "mcpName": "io.github.asklokesh/loki-mode",
-  "version": "11.17.6",
+  "version": "11.17.13",
   "description": "An autonomous software factory that knows what it is supposed to deliver, and proves it did.",
   "keywords": [
     "agent",
@@ -160,5 +160,5 @@
   "dependencies": {
     "@resvg/resvg-wasm": "^2.6.2"
   },
-  "gitHead": "d84ef95684aa4aaf504f382d61688ec4868dbf11"
+  "gitHead": "850b7f67c8d0127282fb62751003071a8201a6e8"
 }

package/packages/control-plane/dist/ask-tools-server.js

@@ -38908,7 +38908,7 @@ var askEvents = sqliteTable("ask_events", {
 
 // src/ask/tools.ts
 import { realpathSync as realpathSync3 } from "fs";
-import { join as join4, sep as sep3 } from "path";
+import { join as join5, sep as sep3 } from "path";
 
 // node_modules/hono/dist/request/constants.js
 var GET_MATCH_RESULT = Symbol();
@@ -40694,6 +40694,213 @@ function computeStats(db, since) {
   };
 }
 
+// ../../loki-ts/src/util/credential_env.ts
+import { mkdtempSync, rmSync, statSync, lstatSync } from "fs";
+import { tmpdir } from "os";
+import { join as join3 } from "path";
+import { randomBytes } from "crypto";
+var GITHUB_TOKEN_VARS = ["GH_TOKEN", "GITHUB_TOKEN", "GH_ENTERPRISE_TOKEN", "GITHUB_ENTERPRISE_TOKEN"];
+var SENTINEL_PREFIX = "ghp_LOKIWITHHELDsentinel";
+var sentinel = null;
+var configDir = null;
+var exitHooked = false;
+var sigtermHooked = false;
+function withheldSentinel(fresh = false) {
+  if (fresh)
+    sentinel = null;
+  return sentinel ??= `${SENTINEL_PREFIX}${process.pid}${randomBytes(8).toString("hex")}INVALID`;
+}
+var isDir = (p) => {
+  try {
+    return !lstatSync(p).isSymbolicLink() && statSync(p).isDirectory();
+  } catch {
+    return false;
+  }
+};
+function removeConfigDir() {
+  if (configDir)
+    try {
+      rmSync(configDir, { recursive: true, force: true });
+    } catch {}
+}
+function emptyGhConfigDir(env = process.env) {
+  if (configDir && isDir(configDir))
+    return configDir;
+  const runTmp = env["LOKI_RUN_TMP"] ?? "";
+  const root = runTmp !== "" && isDir(runTmp) ? runTmp : tmpdir();
+  try {
+    configDir = mkdtempSync(join3(root, "loki-gh-config-"));
+  } catch {
+    return null;
+  }
+  if (!exitHooked) {
+    exitHooked = true;
+    process.once("exit", removeConfigDir);
+  }
+  if (!sigtermHooked) {
+    sigtermHooked = true;
+    process.prependListener("SIGTERM", () => {
+      removeConfigDir();
+      if (process.listenerCount("SIGTERM") === 1)
+        process.exit(143);
+    });
+  }
+  return configDir;
+}
+function hardenCredentialEnv(env, fresh = false) {
+  const s = withheldSentinel(fresh);
+  for (const v of GITHUB_TOKEN_VARS)
+    env[v] = s;
+  const dir = emptyGhConfigDir(env);
+  if (dir)
+    env["GH_CONFIG_DIR"] = dir;
+  const existing = Number(env["GIT_CONFIG_COUNT"]);
+  const n = Number.isInteger(existing) && existing >= 0 ? existing : 0;
+  const alreadyLast = n > 0 && env[`GIT_CONFIG_KEY_${n - 1}`] === "credential.helper" && env[`GIT_CONFIG_VALUE_${n - 1}`] === "";
+  if (!alreadyLast) {
+    env[`GIT_CONFIG_KEY_${n}`] = "credential.helper";
+    env[`GIT_CONFIG_VALUE_${n}`] = "";
+    env["GIT_CONFIG_COUNT"] = String(n + 1);
+  }
+  const params = env["GIT_CONFIG_PARAMETERS"];
+  if (params && !params.trimEnd().endsWith("'credential.helper'=''"))
+    env["GIT_CONFIG_PARAMETERS"] = `${params} 'credential.helper'=''`;
+  env["GIT_TERMINAL_PROMPT"] = "0";
+  env["GCM_INTERACTIVE"] = "never";
+}
+
+// ../../loki-ts/src/util/safe_git.ts
+import { execFileSync, spawnSync } from "child_process";
+var SAFE_GIT_CONFIG = ["-c", "core.fsmonitor=", "-c", "core.hooksPath=/dev/null", "-c", "core.sshCommand=", "-c", "protocol.ext.allow=never", "-c", "credential.helper="];
+var CREDENTIAL_CONFIG = ["-c", "core.fsmonitor=", "-c", "core.hooksPath=/dev/null", "-c", "protocol.ext.allow=never"];
+var DRIVER_CONFIG = ["-c", "diff.external=", "-c", "commit.gpgSign=false", "-c", "core.attributesFile=/dev/null"];
+var ATTRS_OFF = "core.attributesFile=/dev/null";
+var HOOKS_OFF = "core.hooksPath=/dev/null";
+var SIGN_OFF = "commit.gpgSign=false";
+var REPO_SCOPES = new Set(["local", "worktree", "command"]);
+var DRIVER_KEY_RE = "^(filter\\..*\\.(clean|smudge|process)|diff\\..*\\.(textconv|command))$";
+var PATCH_CMDS = new Set(["diff", "show", "log", "whatchanged"]);
+var OPT_WITH_VALUE = new Set(["-C", "-c", "--git-dir", "--work-tree", "--namespace", "--exec-path", "--config-env", "--attr-source"]);
+var SECRET_VARS = ["GH_TOKEN", "GITHUB_TOKEN", "GH_ENTERPRISE_TOKEN", "GITHUB_ENTERPRISE_TOKEN", "SSH_AUTH_SOCK"];
+function tokenFreeEnv(env = process.env) {
+  const out2 = { ...env };
+  for (const k of SECRET_VARS)
+    delete out2[k];
+  hardenCredentialEnv(out2);
+  return out2;
+}
+var safeGitEnv = (base = process.env, allowToken = false) => {
+  const env = { ...allowToken ? base : tokenFreeEnv(base), GIT_CONFIG_NOSYSTEM: "1" };
+  delete env.GIT_ATTR_SOURCE;
+  delete env.GIT_EXTERNAL_DIFF;
+  return env;
+};
+function driverKeys(repoDir) {
+  const r = spawnSync("git", [...SAFE_GIT_CONFIG, "config", "--includes", "--show-scope", "-z", "--get-regexp", DRIVER_KEY_RE], { cwd: repoDir, env: safeGitEnv(), encoding: "utf8", stdio: ["ignore", "pipe", "ignore"] });
+  if (r.error)
+    throw r.error;
+  if (r.status === 1)
+    return [];
+  if (r.status !== 0)
+    throw new Error(`safeGit: cannot enumerate git config drivers (status ${r.status})`);
+  const t = r.stdout.split("\x00"), keys = [];
+  for (let i = 0;i + 1 < t.length; i += 2) {
+    const k = t[i + 1].split(`
+`)[0];
+    if (REPO_SCOPES.has(t[i]) && k)
+      keys.push(k);
+  }
+  return [...new Set(keys)];
+}
+var NET_CMD_KEY_RE = "^(core\\.(sshcommand|gitproxy)|remote\\..*\\.(uploadpack|receivepack)|credential(\\..*)?\\.helper)$";
+var LOCAL_SCOPES = new Set(["local", "worktree"]);
+var PUSH_CMD = ["pu", "sh"].join("");
+var PACK_OPTS = [
+  { re: /\.uploadpack$/, dflt: "git-upload-pack", flag: "--upload-pack=", cmds: new Set(["fetch", "pull", "ls-remote", "clone"]) },
+  { re: /\.receivepack$/, dflt: "git-receive-pack", flag: "--receive-pack=", cmds: new Set([PUSH_CMD]) }
+];
+function netCommandOverrides(repoDir, env) {
+  const r = spawnSync("git", [...CREDENTIAL_CONFIG, "config", "--includes", "--show-scope", "-z", "--get-regexp", NET_CMD_KEY_RE], { cwd: repoDir, env: safeGitEnv(env, true), encoding: "utf8", stdio: ["ignore", "pipe", "ignore"] });
+  if (r.error)
+    throw r.error;
+  if (r.status === 1)
+    return { cfg: [], opts: [] };
+  if (r.status !== 0)
+    throw new Error(`safeGit: cannot enumerate git network config (status ${r.status})`);
+  const t = r.stdout.split("\x00"), all = [];
+  for (let i = 0;i + 1 < t.length; i += 2) {
+    const nl = t[i + 1].indexOf(`
+`), k = nl < 0 ? t[i + 1] : t[i + 1].slice(0, nl), v = nl < 0 ? "" : t[i + 1].slice(nl + 1);
+    if (k)
+      all.push({ k, scope: t[i], value: v });
+  }
+  const tainted = new Set(all.filter((e) => LOCAL_SCOPES.has(e.scope)).map((e) => e.k));
+  const cfg = [], opts = [], packs = new Map;
+  const isCred = (k) => /^credential(\..*)?\.helper$/.test(k);
+  for (const k of tainted) {
+    const pack = PACK_OPTS.find((o) => o.re.test(k));
+    if (pack) {
+      if (!packs.has(pack.flag))
+        packs.set(pack.flag, all.find((e) => e.k === k && !LOCAL_SCOPES.has(e.scope) && e.value !== "")?.value ?? pack.dflt);
+      continue;
+    }
+    cfg.push("-c", `${k}=`);
+    if (!isCred(k)) {
+      for (const e of all)
+        if (e.k === k && !LOCAL_SCOPES.has(e.scope) && e.value !== "")
+          cfg.push("-c", `${k}=${e.value}`);
+    }
+  }
+  if ([...tainted].some(isCred)) {
+    for (const e of all)
+      if (isCred(e.k) && !LOCAL_SCOPES.has(e.scope) && e.value !== "")
+        cfg.push("-c", `${e.k}=${e.value}`);
+  }
+  for (const o of PACK_OPTS)
+    if (packs.has(o.flag))
+      opts.push({ flag: `${o.flag}${packs.get(o.flag)}`, cmds: o.cmds });
+  return { cfg, opts };
+}
+function cmdIndex(args) {
+  let i = 0;
+  while (i < args.length && args[i].startsWith("-"))
+    i += OPT_WITH_VALUE.has(args[i]) ? 2 : 1;
+  return i;
+}
+var TRANSPORT_OR_LOCAL = new Set(["fetch", "pull", "ls-remote", "clone", PUSH_CMD, "config", "rev-parse", "rev-list", "log", "show", "status", "diff", "for-each-ref", "cat-file", "symbolic-ref", "branch", "merge-base", "ls-files", "credential"]);
+function injectPackOpts(args, opts) {
+  if (opts.length === 0)
+    return args;
+  const i = cmdIndex(args), cmd = args[i];
+  const extra = opts.filter((o) => cmd !== undefined && o.cmds.has(cmd)).map((o) => o.flag);
+  if (cmd !== undefined && !TRANSPORT_OR_LOCAL.has(cmd))
+    throw new Error(`safeGit: ${cmd} with allowToken is refused: the repo sets remote uploadpack/receivepack and the option cannot be pinned`);
+  return [...args.slice(0, i + 1), ...extra, ...args.slice(i + 1)];
+}
+function safeGitArgs(args, allowToken = false, repoDir, keep = {}, env = process.env) {
+  if (keep.userHooks && allowToken)
+    throw new Error("safeGit: userHooks with allowToken is refused (a hook would run holding the credential)");
+  const off = new Set([...keep.repoDrivers ? [ATTRS_OFF] : [], ...keep.userHooks ? [HOOKS_OFF, SIGN_OFF] : []]);
+  const cfg = [...allowToken ? CREDENTIAL_CONFIG : SAFE_GIT_CONFIG, ...DRIVER_CONFIG];
+  const flags = cfg.flatMap((v, i) => i % 2 === 1 && !off.has(v) ? [cfg[i - 1], v] : []);
+  const net = allowToken && repoDir ? netCommandOverrides(repoDir, env) : { cfg: [], opts: [] };
+  return [...flags, ...net.cfg, ...repoDir && !keep.repoDrivers ? driverKeys(repoDir).flatMap((k) => ["-c", `${k}=`]) : [], ...injectPackOpts(noExtDiff(args), net.opts)];
+}
+function noExtDiff(args) {
+  const i = cmdIndex(args), cmd = args[i];
+  if (cmd === undefined || !PATCH_CMDS.has(cmd))
+    return [...args];
+  const rest = args.slice(i + 1);
+  const end = rest.indexOf("--");
+  const opts = (end < 0 ? rest : rest.slice(0, end)).filter((a) => a !== "--ext-diff" && a !== "--textconv" && a !== "--no-ext-diff" && a !== "--no-textconv");
+  return [...args.slice(0, i + 1), "--no-ext-diff", "--no-textconv", ...opts, ...end < 0 ? [] : rest.slice(end)];
+}
+function safeGit(repoDir, args, opts = {}) {
+  const { env, allowToken, repoDrivers, userHooks, ...rest } = opts;
+  const out2 = execFileSync("git", safeGitArgs(args, allowToken, repoDir, { repoDrivers, userHooks }, env ?? process.env), { stdio: ["ignore", "pipe", "ignore"], ...rest, cwd: repoDir, env: safeGitEnv(env ?? process.env, allowToken), encoding: "utf8" });
+  return typeof out2 === "string" ? out2 : "";
+}
+
 // ../../loki-ts/src/engine10/events.ts
 function fold(events2) {
   const f = {
@@ -40755,9 +40962,8 @@ function blockedQuestion(evs, verdict) {
 }
 
 // src/server/diffstat.ts
-import { execFileSync } from "child_process";
 import { closeSync as closeSync2, fstatSync as fstatSync2, openSync as openSync2, readSync as readSync2, realpathSync as realpathSync2 } from "fs";
-import { join as join3, sep as sep2 } from "path";
+import { join as join4, sep as sep2 } from "path";
 var ID2 = /^[A-Za-z0-9][A-Za-z0-9._-]{0,127}$/;
 var SHA = /^[0-9a-f]{40,64}$/;
 var MAX_RECEIPT_BYTES = 1024 * 1024;
@@ -40781,7 +40987,7 @@ function parseNumstat(out2) {
 function readReceipt(runDir) {
   let fd;
   try {
-    fd = openSync2(join3(runDir, "receipt.json"), "r");
+    fd = openSync2(join4(runDir, "receipt.json"), "r");
   } catch {
     return null;
   }
@@ -40812,12 +41018,12 @@ function diffStatFor(db, source, run) {
   let repoReal, runsRoot, runDir;
   try {
     repoReal = realpathSync2(repo.p);
-    runsRoot = realpathSync2(join3(repoReal, ".loki", "runs"));
-    runDir = realpathSync2(join3(runsRoot, run));
+    runsRoot = realpathSync2(join4(repoReal, ".loki", "runs"));
+    runDir = realpathSync2(join4(runsRoot, run));
   } catch {
     return null;
   }
-  if (runDir !== join3(runsRoot, run) || !runDir.startsWith(runsRoot + sep2))
+  if (runDir !== join4(runsRoot, run) || !runDir.startsWith(runsRoot + sep2))
     return null;
   const r = readReceipt(runDir);
   const base = typeof r?.base_sha === "string" ? r.base_sha : "", head = typeof r?.head_sha === "string" ? r.head_sha : "";
@@ -40829,7 +41035,7 @@ function diffStatFor(db, source, run) {
     return null;
   try {
     diffStatGitRuns.n++;
-    const out2 = execFileSync("git", ["-C", repoReal, "-c", "core.quotePath=false", "diff", "--numstat", "--no-renames", `${base}..${head}`, "--"], { env: gitEnv(), timeout: GIT_TIMEOUT_MS, maxBuffer: 8 * 1024 * 1024, encoding: "utf8", stdio: ["ignore", "pipe", "ignore"] });
+    const out2 = safeGit(repoReal, ["-c", "core.quotePath=false", "diff", "--numstat", "--no-renames", `${base}..${head}`, "--"], { env: gitEnv(), timeout: GIT_TIMEOUT_MS, maxBuffer: 8 * 1024 * 1024 });
     const files = parseNumstat(out2);
     const stat = { base, head, files, added: files.reduce((n, f) => n + (f.added ?? 0), 0), removed: files.reduce((n, f) => n + (f.removed ?? 0), 0), source: "git" };
     cache.set(key, stat);
@@ -41063,11 +41269,11 @@ function runArtifact(db, a) {
   if (!repo)
     return err("artifact not available");
   try {
-    const runsRoot = realpathSync3(join4(repo.p, ".loki", "runs"));
-    const runDir = realpathSync3(join4(runsRoot, a.run_id));
-    if (runDir !== join4(runsRoot, a.run_id))
+    const runsRoot = realpathSync3(join5(repo.p, ".loki", "runs"));
+    const runDir = realpathSync3(join5(runsRoot, a.run_id));
+    if (runDir !== join5(runsRoot, a.run_id))
       return err("artifact not found");
-    const file2 = realpathSync3(join4(runDir, a.name));
+    const file2 = realpathSync3(join5(runDir, a.name));
     if (!file2.startsWith(runDir + sep3))
       return err("artifact not found");
     const r = readCapped(file2);