login-plus 1.9.2 → 1.9.4

package/README.md

@@ -5,6 +5,7 @@ login service for express
 [![downloads](https://img.shields.io/npm/dm/login-plus.svg)](https://npmjs.org/package/login-plus)
 [![build](https://github.com/codenautas/login-plus/actions/workflows/build-and-test.yml/badge.svg)](https://github.com/codenautas/login-plus/actions/workflows/build-and-test.yml)
 [![coverage](https://img.shields.io/coveralls/codenautas/login-plus/master.svg)](https://coveralls.io/r/codenautas/login-plus)
+[![sonar](https://sonarcloud.io/api/project_badges/measure?project=codenautas_login-plus&metric=alert_status)](https://sonarcloud.io/summary/overall?id=codenautas_login-plus)
 [![qa-control](https://github.com/codenautas/login-plus/actions/workflows/qa-control.yml/badge.svg)](https://github.com/codenautas/login-plus/actions/workflows/qa-control.yml)
 
 

package/for-client/auto-login.js

@@ -5,12 +5,12 @@ window.addEventListener('load',function(){
     (window.location.hash||"").split(/[#&]/g).forEach(function(pair){
         var pos=pair.indexOf('=');
         if(pos>=0){
-            params[pair.substr(0,pos)]=pair.substr(pos+1);
+            params[pair.substring(0,pos)]=pair.substring(pos+1);
         }
     });
     ['username','password'].forEach(function(fieldName){
         var elem=document.getElementById(fieldName);
-        var parameterName=fieldName.substr(0,1)
+        var parameterName=fieldName.substring(0,1)
         if(params[parameterName]){
             elem.value=params[parameterName];
         }

package/lib/login-plus.js

@@ -2,8 +2,8 @@
 
 var loginPlus = {};
 
-var util = require('util');
-var crypto = require('crypto');
+var util = require('node:util');
+var crypto = require('node:crypto');
 
 var connectFlash = require('connect-flash');
 var MiniTools = require('mini-tools');
@@ -12,7 +12,7 @@ var session = require('express-session');
 var fs = require('fs-extra');
 var bestGlobals = require('best-globals');
 var changing = bestGlobals.changing;
-var Path = require('path');
+var Path = require('node:path');
 var Regexplicit = require('regexplicit');
 
 loginPlus.init = function AlertDeprecated(){
@@ -43,7 +43,7 @@ function serveJade(url, opts){
 }
 
 function completeOptions(opts){
-    if(!opts || !opts.successRedirect){
+    if(!opts?.successRedirect){
         console.log('login-plus lack of mandatory: opts.successRedirect');
         throw new Error('login-plus lack of mandatory: opts.successRedirect');
     }
@@ -112,7 +112,7 @@ function completeOptions(opts){
 
 function SetInitialOptions(app,opts){
     var Passport = require('passport').Passport;
-    var passport = this.passport = new Passport();
+    this.passport = new Passport();
     this.LocalStrategy = require('passport-local').Strategy;
     opts = this.opts = completeOptions(opts);
     var sessionOpts=opts.session||{};
@@ -131,7 +131,7 @@ function SetInitialOptions(app,opts){
             maxAge: opts.maxAge,
             httpOnly: true,
             sameSite: 'lax',
-            secure:(opts.allowHttpLogin?false:true)
+            secure:!opts.allowHttpLogin
         }
     },sessionOpts);
 }
@@ -161,7 +161,7 @@ loginPlus.Manager.prototype.phpInit = function phpInit(app,opts){
     */
     var ensureMiddlewareWihtoutPHP = this.ensureMiddleware;
     this.ensureMiddleware = function(req, res, next){
-        if(req.$SESSION && req.$SESSION[opts.php.varLogged]){
+        if(req.$SESSION?.[opts.php.varLogged]){
             return next();
         }else{
             ensureMiddlewareWihtoutPHP(req, res, next);
@@ -181,7 +181,7 @@ function checkAlreadyLoggedIn(app, opts){
 }
 
 loginPlus.Manager.prototype.init = function init(app,opts){ // eslint-disable-line max-statements
-    var thisManager = this;
+    var thisManager = this; // eslint-disable-line unicorn/no-this-assignment
     if(!this.passport){
         var router = '_router' in app ? app._router : app.router;
         if(router){
@@ -215,7 +215,7 @@ loginPlus.Manager.prototype.init = function init(app,opts){ // eslint-disable-li
         return fs.exists(fileNameLogin);
     }).then(function(exists){
         if(!exists){
-            throw Error('login-plus.init fail "'+fileNameLogin+'" does not exists');
+            throw new Error('login-plus.init fail "'+fileNameLogin+'" does not exists');
         }
     });
     app.get(opts.baseUrl+opts.logoutUrlPath, function(req,res,next){
@@ -243,6 +243,7 @@ loginPlus.Manager.prototype.init = function init(app,opts){ // eslint-disable-li
         failureFlash: true,
         keepSessionInfo: true,
     }
+    // TODO: validar req.session.returnTo con isLocalPath (exportarla desde ensure-login) antes de que passport redirija, por si se guardó sin validar
     authenticateOptions[opts.successReturns?'successReturnToOrRedirect':'successRedirect'] = opts.redirBaseUrl+opts.successRedirect
     app.post(opts.baseUrl+opts.loginUrlPath,
         this.passport.authenticate('local', authenticateOptions)
@@ -268,7 +269,7 @@ loginPlus.Manager.prototype.init = function init(app,opts){ // eslint-disable-li
     /////// ATENCIÓN NUNCA METER ensureLoggedIn dentro de una cadena de promesas. Necesitamos que se ejecute sí o sí
     app.use(opts.baseUrl,this.ensureMiddleware);
     //// NOW is logged in
-    app.post(opts.baseUrl+opts.chPassUrlPath, function(req,res){
+    app.post(opts.baseUrl+opts.chPassUrlPath, function(req,res,next){
         if (!req.body.newPassword) {
             req.flash('error', (opts.messages?.passCantBeEmpty || "new pass cant be empty"));
             res.redirect(opts.redirBaseUrl+opts.chPassUrlPath)
@@ -289,7 +290,7 @@ loginPlus.Manager.prototype.init = function init(app,opts){ // eslint-disable-li
                             res.redirect(opts.redirBaseUrl+opts.loginUrlPath);
                         });
                     }else{
-                        if(err && opts.log.errors.getTime() > new Date().getTime()){
+                        if(err && opts.log.errors.getTime() > Date.now()){
                             console.log('chpass error',err);
                         }
                         req.flash('error', flashMessage || opts.messages?.internalError || 'internal error');

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "login-plus",
   "description": "login service for express",
-  "version": "1.9.2",
+  "version": "1.9.4",
   "author": "Codenautas <codenautas@googlegroups.com>",
   "license": "MIT",
   "repository": "codenautas/login-plus",
@@ -31,31 +31,34 @@
   "dependencies": {
     "best-globals": "^2.2.3",
     "connect-flash": "^0.1.1",
-    "ensure-login": "^0.1.6",
+    "ensure-login": "^0.1.8",
     "express-session": "^1.19.0",
     "fs-extra": "^11.4.1",
-    "mini-tools": "^1.13.12",
+    "mini-tools": "^1.13.14",
     "passport": "^0.7.0",
     "passport-local": "^1.0.0",
-    "regexplicit": "^0.1.3",
+    "regexplicit": "^0.2.0",
     "session-file-store": "^1.5.0"
   },
   "devDependencies": {
-    "ajax-best-promise": "^0.4.5",
-    "body-parser": "^2.3.0",
+    "ajax-best-promise": "^0.4.7",
+    "body-parser": "^2.4.0",
     "concat-stream": "^2.0.0",
     "cookie-parser": "^1.4.7",
+    "escape-html": "^1.0.3",
+    "eslint-plugin-sonarjs": "^4.2.2",
+    "eslint-plugin-unicorn": "^79.0.0",
     "expect.js": "^0.3.1",
     "express": "^5.3.0",
     "mocha": "^12.0.3",
     "nyc": "^18.0.0",
-    "pg-promise-strict": "^1.5.3",
+    "pg-promise-strict": "^1.7.1",
     "php-session": "^0.1.0",
     "pug": "^3.0.4",
-    "qa-control": "^0.14.0",
+    "qa-control": "^0.14.2",
     "read-yaml-promise": "^1.0.2",
     "self-explain": "^0.11.0",
-    "serve-content": "^1.0.8",
+    "serve-content": "^1.1.1",
     "sinon": "^22.1.0",
     "stylus": "^0.64.0",
     "supertest": "^7.3.1"
@@ -81,6 +84,10 @@
     "run-in": "server",
     "type": "lib",
     "coverage": 100,
-    "gha": "all"
+    "gha": "all",
+    "silenced": [
+      "file_1_does_not_match_custom_2"
+    ],
+    "sonar": true
   }
 }