locale-ai 0.6.9 → 0.6.10

package/README.md

@@ -105,7 +105,7 @@ then declare it in `locale-ai.config.json`:
 }
 ```
 
-- `path` is a local folder (relative to the config file); `repo` is a Hugging Face repo with the converted files (uploaded output folder), downloaded and cached like built-in models.
+- `path` is a local folder (relative to the config file); `repo` is a Hugging Face repo with the converted files (uploaded output folder), downloaded and cached like built-in models — it must look like `namespace/name`, rejected otherwise (it's joined onto the cache directory with no further checks, so anything else could resolve outside it).
 - `prefix` is required for multi-target models (`convert` lists the model's `>>xx<<` tokens).
 - Project models take priority over built-ins for their language pairs and can be used for pivoting (e.g. `ja → en → tr`).
 

package/dist/catalog.js

@@ -90,10 +90,23 @@ export const CATALOG = [
     },
 ];
 const asList = (v) => (Array.isArray(v) ? v : [v]).map((x) => parseLocale(x).lang);
+/**
+ * A Hugging Face repo id is always exactly "namespace/name". `models.ts` joins it
+ * onto the cache root with no further checks, so a `repo` of "../../../etc" (or any
+ * segment that isn't a real name) would resolve outside the cache directory — and
+ * install() writes there, uninstall() recursively deletes there.
+ */
+function validRepo(repo) {
+    const parts = repo.split("/");
+    return parts.length === 2 && parts.every((p) => p !== "" && p !== "." && p !== ".." && !p.includes("\\"));
+}
 export function customEntries(models, configDir) {
     return (models ?? []).map((c, i) => {
         if (!c.repo === !c.path)
             throw new Error(`models[${i}]: set exactly one of "repo" or "path".`);
+        if (c.repo && !validRepo(c.repo)) {
+            throw new Error(`models[${i}]: "repo" must look like "namespace/name" (a Hugging Face repo id), got "${c.repo}".`);
+        }
         if (!c.source || !c.target)
             throw new Error(`models[${i}]: "source" and "target" are required.`);
         const sources = asList(c.source);

package/dist/models.js

@@ -25,8 +25,26 @@ export function cacheRoot() {
     return path.join(process.env.XDG_CACHE_HOME || path.join(os.homedir(), ".cache"), "locale-ai");
 }
 const modelsRoot = () => path.join(cacheRoot(), "models");
-/** Where a model's files live: its local folder, or its cache folder. */
-export const modelDir = (m) => m.path ?? path.join(modelsRoot(), ...m.repo.split("/"));
+/**
+ * Where a model's files live: its local folder, or its cache folder. `repo` is
+ * validated as a plain "namespace/name" Hugging Face id when it comes from a
+ * project config (see catalog.ts's customEntries) — this is a second,
+ * independent check that the computed cache folder actually stays inside the
+ * cache root, since install() writes there and uninstall() recursively deletes
+ * it: a `repo` that somehow smuggled a ".." segment past that first check must
+ * never be allowed to touch a path outside the cache.
+ */
+export function modelDir(m) {
+    if (m.path)
+        return m.path;
+    const root = modelsRoot();
+    const dir = path.join(root, ...m.repo.split("/"));
+    const rel = path.relative(root, dir);
+    if (rel.startsWith("..") || path.isAbsolute(rel)) {
+        throw new Error(`${m.id}: "repo" (${m.repo}) resolves outside the model cache.`);
+    }
+    return dir;
+}
 export function readManifest(m) {
     if (m.path)
         return undefined;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "locale-ai",
-  "version": "0.6.9",
+  "version": "0.6.10",
   "description": "Translate your i18n locale files locally on CPU. Free, offline, no API keys.",
   "author": "Taha KHABOUSS",
   "repository": {