local-mcp 3.0.80 → 3.0.82

package/download.js

@@ -156,13 +156,13 @@ async function ensureBinary() {
   } catch { /* no crítico */ }
 
   process.stderr.write(`  Listo en ${versionDir}\n`)
-  return { binPath, versionDir }
+  return { binPath, versionDir, version }
 }
 
 // Mantener compatibilidad con código que usa ensureRuntime
 async function ensureRuntime() {
-  const { binPath, versionDir } = await ensureBinary()
-  return { pythonBin: binPath, serverPath: binPath, runtimeDir: versionDir, binPath }
+  const { binPath, versionDir, version } = await ensureBinary()
+  return { pythonBin: binPath, serverPath: binPath, runtimeDir: versionDir, binPath, version }
 }
 
 /**

package/index.js

@@ -112,16 +112,30 @@ async function main() {
   const versionFile = path.join(CACHE_DIR, '.server-version')
   const pkg = require('./package.json')
 
-  // Fast path: if stable binary exists, version matches, exec directly.
+  // Semver comparison: returns true if version a >= b (e.g. "3.0.72" >= "3.0.70")
+  function semverGte(a, b) {
+    const av = (a || '').split('.').map(Number)
+    const bv = (b || '').split('.').map(Number)
+    for (let i = 0; i < 3; i++) {
+      const ai = av[i] || 0, bi = bv[i] || 0
+      if (ai > bi) return true
+      if (ai < bi) return false
+    }
+    return true
+  }
+
+  // Fast path: if stable binary exists AND its version is >= our npm package version, exec directly.
+  // Using >= (not ===) prevents Claude Desktop from downgrading a binary that the tray's
+  // UpdateManager has already upgraded. LMC-375: machine 5F8445AE downgraded 3.0.72→3.0.70
+  // because stale npx cache had old pkg.version and triggered the slow path unnecessarily.
   try {
     const stat = fs.lstatSync(stableBin)
     if (stat.isFile() && (stat.mode & 0o111)) {
-      // Check if cached binary matches current npm version
       const cachedVersion = fs.existsSync(versionFile)
         ? fs.readFileSync(versionFile, 'utf8').trim()
         : ''
-      if (cachedVersion === pkg.version) {
-        // Version matches — use fast path
+      if (cachedVersion && semverGte(cachedVersion, pkg.version)) {
+        // Cached binary is same or newer — use fast path, no download needed
         const { ensureTray, ensureTeamsProxy, ensureM365Proxy } = require('./download')
         ensureTray().catch(() => {})
         ensureTeamsProxy().catch(() => {})
@@ -131,7 +145,7 @@ async function main() {
         child.on('exit', (code) => process.exit(code ?? 0))
         return
       }
-      // Version mismatch — fall through to download new binary
+      // Cached binary is older than our npm package — download/update
       process.stderr.write(`Updating LMCP server (${cachedVersion || '?'} → ${pkg.version})...\n`)
       _pingFirstRun(true)
     } else {
@@ -160,7 +174,7 @@ async function main() {
     process.exit(1)
   }
 
-  const { binPath } = runtime
+  const { binPath, version: downloadedVersion } = runtime
 
   // Copy binary to stable path (survives version cleanup)
   try {
@@ -169,8 +183,12 @@ async function main() {
     fs.chmodSync(tmpPath, 0o755)
     try { execFileSync('codesign', ['--force', '--sign', '-', '--identifier', 'com.local-mcp.server', tmpPath], { stdio: 'pipe' }) } catch {}
     fs.renameSync(tmpPath, stableBin)
-    // Write version file so fast path knows when to update
-    fs.writeFileSync(versionFile, pkg.version)
+    // Write the ACTUAL downloaded binary version (not pkg.version) so the fast path
+    // knows what version is on disk. Using pkg.version here caused LMC-375: machines
+    // with old npm caches wrote an old version into .server-version even though
+    // ensureBinary() downloaded a newer binary, causing HeartbeatManager to report
+    // the stale version and triggering spurious downgrade events.
+    fs.writeFileSync(versionFile, downloadedVersion || pkg.version)
     // Also copy settings.html
     const settingsSrc = path.join(path.dirname(binPath), 'settings.html')
     const settingsDst = path.join(CACHE_DIR, 'settings.html')

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "local-mcp",
-  "version": "3.0.80",
+  "version": "3.0.82",
   "description": "LMCP — connect Claude Desktop, Cursor, Windsurf to Mail, Calendar, Contacts, Teams, OneDrive on macOS. Privacy-first: all data stays on your Mac.",
   "main": "index.js",
   "bin": {