local-kanban 1.9.0 → 1.10.0

package/CHANGELOG.md

@@ -3,6 +3,35 @@
 Notable changes, newest first. The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/)
 and the project uses [semantic versioning](https://semver.org/).
 
+## [1.10.0]
+
+### Fixed
+
+- **The deploy skill list only offers deploy skills.** On the project settings page it listed
+  everything in your skills folder — on a real board that is ten entries when one of them is an
+  actual deploy skill, and the board's own skill sits among them, offered as a way to deploy your
+  project. The wizard already filtered this; the project page did not, because the rule lived in
+  the wizard's file. Now both ask the same function. A skill your project already points at stays
+  in the list even if it falls outside the filter, so saving never quietly clears the field.
+
+- **A dropdown opens where there is room.** The custom select always opened downward with a fixed
+  height, so near the bottom of a dialog its list ran past the dialog and under the buttons. It now
+  measures the space first — against the dialog, not just the window — and flips up when it has to.
+  The rule already existed for the picker menus; there is one copy of it now instead of one and a
+  half.
+
+- **The Add project form is not cut off.** Its body was capped at 62% of the window height while
+  the dialog itself used far less, so on a 800px-tall window the last field lost 37 pixels and the
+  hint under it never showed at all. The cap now follows the space actually available.
+
+- **Picking the project folder starts with the folder, not with a list.** The step opened with
+  every unregistered folder in your projects directory — 31 entries on a real machine, eight of
+  them visible — and the path field and "Choose…" button were hidden behind an entry near the
+  bottom of that same list. The list now holds only the three modes (a folder, no folder, clone
+  from git), and the folder one — the default — shows the path field and the button straight away.
+  The system dialog no longer opens by itself just because you reached the step. Your project
+  folders are still one click away: the built-in browser opens on that very directory.
+
 ## [1.9.0]
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "local-kanban",
-  "version": "1.9.0",
+  "version": "1.10.0",
   "license": "MIT",
   "author": "Dannylamao",
   "repository": {

package/public/js/board.js

@@ -1,5 +1,5 @@
 
-import { $, ALL, ALL_STATUSES, DONE_LIMIT, LABEL_COLORS, LABEL_SELECTABLE, PRI_ICON, PRI_LEVELS, api, esc, ic, noteUnsaved, seg, state, tr } from './core.js';
+import { $, ALL, ALL_STATUSES, api, DONE_LIMIT, esc, ic, LABEL_COLORS, LABEL_SELECTABLE, noteUnsaved, popoverPlacement, PRI_ICON, PRI_LEVELS, seg, state, tr } from './core.js';
 import { markKbCursor, openCardMenu, openDrawer, openDrawerNew, setKbCursor, statusOptionList } from './drawer.js';
 import { getSetting, plural } from './settings.js';
 import { styledAlert, styledConfirm } from './sidebar.js';
@@ -676,6 +676,9 @@ export function buildSelect(host, opts) {
     if (host.classList.contains('open')) { close(); return; }
     document.querySelectorAll('.kbsel.open').forEach((el) => { if (el !== host) el.classList.remove('open'); });
     host.classList.add('open');
+    const place = popoverPlacement(host.querySelector('.kbsel-btn'));
+    list.classList.toggle('up', place.openUp);
+    list.style.maxHeight = `${place.maxHeight}px`;
     if (opts.search) { const si = host.querySelector('.kbsel-search-input'); si.value = ''; filterOpts(''); setTimeout(() => si.focus(), 0); }
     setTimeout(() => document.addEventListener('click', outside), 0);
   };

package/public/js/chaos.js

@@ -1,6 +1,6 @@
 
 import { buildSelect, selVal } from './board.js';
-import { $, LABEL_COLORS, LABEL_SELECTABLE, PRI_ICON, PRI_LEVELS, api, esc, ic, state, tr } from './core.js';
+import { $, api, esc, ic, LABEL_COLORS, LABEL_SELECTABLE, popoverPlacement, PRI_ICON, PRI_LEVELS, state, tr } from './core.js';
 import { openDrawer, openLightbox, uploadAttachment } from './drawer.js';
 import { loadProjects } from './sidebar.js';
 import { autoGrow, refresh, titleOr } from './sse.js';
@@ -159,11 +159,8 @@ function chaosPopover(anchor, items, onPick) {
   pop.innerHTML = items.map((o) => `<div class="chaos-pop-opt${o.active ? ' active' : ''}" data-v="${esc(String(o.v))}">${o.html}</div>`).join('');
   document.body.appendChild(pop);
   const r = anchor.getBoundingClientRect();
-  const margin = 10;
-  const below = innerHeight - r.bottom - margin;
-  const above = r.top - margin;
-  const openUp = below < 200 && above > below;
-  pop.style.maxHeight = `${Math.max(120, (openUp ? above : below) - 5)}px`;
+  const { openUp, maxHeight } = popoverPlacement(anchor);
+  pop.style.maxHeight = `${maxHeight}px`;
   let left = r.left;
   if (left + pop.offsetWidth > innerWidth - 8) left = innerWidth - pop.offsetWidth - 8;
   const top = openUp ? (r.top - pop.offsetHeight - 5) : (r.bottom + 5);

package/public/js/core.js

@@ -83,7 +83,7 @@ const I18N_RU = {
   'All projects': 'Все проекты',
   'all self-healed': 'всё починилось само',
   'All set!': 'Готово!',
-  'another folder on this computer…': 'другая папка на этом компьютере…',
+  'a folder on this computer': 'папка на этом компьютере',
   'Appearance': 'Оформление',
   'applies after page reload': 'применится после перезагрузки страницы',
   'Archive': 'Архивировать',
@@ -758,6 +758,15 @@ export const state = {
 
 export function $(id) { return document.getElementById(id); }
 
+export function popoverPlacement(anchor, { flipBelow = 200, floor = 120, gap = 10 } = {}) {
+  const r = anchor.getBoundingClientRect();
+  const box = anchor.closest?.('.modal')?.getBoundingClientRect();
+  const below = Math.min(window.innerHeight, box ? box.bottom : Infinity) - r.bottom - gap;
+  const above = r.top - Math.max(0, box ? box.top : 0) - gap;
+  const openUp = below < flipBelow && above > below;
+  return { openUp, maxHeight: Math.max(floor, (openUp ? above : below) - 5) };
+}
+
 export const SETUP_PROMPT = {
   ru: `Запусти скилл kanban.
 

package/public/js/project.js

@@ -124,6 +124,12 @@ export async function renderProjectSettings(force) {
   renderDocs(p);
 }
 
+export function deploySkills(info) {
+  const generic = info?.generic_deploy_skill || 'deploy';
+  const own = new Set(info?.own_skills || []);
+  return (info?.items || []).filter((s) => s.name === generic || s.used_by?.length || own.has(s.name));
+}
+
 export function skillOptions(cur, list) {
   const names = list ? list.map((s) => s.name) : (cur ? [cur] : []);
   if (cur && !names.includes(cur)) names.unshift(cur);
@@ -145,7 +151,7 @@ async function loadSkillOptions(p) {
   try { info = await api('GET', '/api/skills', null, { quiet: true }); }
   catch { return; }
   if (!$('ps-skill') || $('projset').dataset.slug !== p.slug) return;
-  buildSkillSelect(p, info.items || []);
+  buildSkillSelect(p, deploySkills(info));
 }
 
 async function renderDocs(p) {

package/public/js/sidebar.js

@@ -6,7 +6,7 @@ import { renderChaos } from './chaos.js';
 import { $, ALL, CALENDAR, CHAOS, DASH, HIDDEN_SECTIONS, HORIZON, LANG, SETTINGS, SIDEBAR_SECTIONS, api, esc, ic, seg, setupPrompt, state, tr } from './core.js';
 import { renderDashboard } from './dash.js';
 import { renderCalendar, renderHorizon } from './horizon.js';
-import { openProjectSettings, renderProjectSettings, skillOptions } from './project.js';
+import { openProjectSettings, renderProjectSettings, skillOptions, deploySkills } from './project.js';
 import { openSettingsModal, plural, setSetting, syncLangToServer } from './settings.js';
 import { copyText, refresh, showView } from './sse.js';
 
@@ -442,17 +442,17 @@ function openProjectWizard() {
     if (folderSel) {
       const options = [
         ...(type === 'local' ? [{ value: '', label: tr('no folder — just a task list') }] : []),
-        ...folders.map((f) => ({ value: f, label: `${tr('folder')} ${f} (${state.folders.root || '~'})` })),
-        { value: '__manual__', label: tr('another folder on this computer…') },
+        { value: '__manual__', label: tr('a folder on this computer') },
         ...(type === 'localserver' ? [{ value: '__clone__', label: tr('clone from a git URL…') }] : []),
       ];
       const onFolderChange = (v) => {
         $('wiz-path-row').classList.toggle('hidden', v !== '__manual__');
         $('wiz-browser').classList.add('hidden');
         $('wiz-git').classList.toggle('hidden', v !== '__clone__');
-        if (v === '__manual__') openFolderPicker();
       };
-      buildSelect(folderSel, { value: type === 'local' ? '' : (options[0]?.value ?? ''), options, onChange: onFolderChange });
+      const start = type === 'local' ? '' : '__manual__';
+      buildSelect(folderSel, { value: start, options, onChange: onFolderChange });
+      onFolderChange(start);
       $('wiz-browse').onclick = openFolderPicker;
     }
     const skillHost = $('wiz-skill');
@@ -462,8 +462,7 @@ function openProjectWizard() {
         .then((info) => {
           if (!$('wiz-skill')) return;
           const generic = info.generic_deploy_skill || GENERIC_DEPLOY;
-          const own = new Set(info.own_skills || []);
-          const deployish = (info.items || []).filter((s) => s.name === generic || s.used_by?.length || own.has(s.name));
+          const deployish = deploySkills(info);
           const has = deployish.some((s) => s.name === generic);
           buildSelect($('wiz-skill'), { value: has ? generic : '', options: skillOptions(generic, deployish) });
         })
@@ -498,8 +497,6 @@ function openProjectWizard() {
           btn.textContent = tr('cloning…');
           const r = await api('POST', '/api/projects/clone', { url, name: slug });
           body.path = r.path;
-        } else if (mode) {
-          body.path = `${state.folders.root}/${mode}`;
         }
         if (type === 'local') body.category = 'Local';
       }

package/public/style.css

@@ -614,7 +614,7 @@ body.dragging-board .col-add-ghost { display: none; }
 .modal-actions { display: flex; gap: 8px; }
 
 .modal.wiz { width: 400px; max-width: calc(100vw - 32px); }
-.wiz-body { display: flex; flex-direction: column; gap: 9px; max-height: 62vh; overflow-y: auto; }
+.wiz-body { display: flex; flex-direction: column; gap: 9px; max-height: calc(100vh - 190px); overflow-y: auto; }
 .wiz-type {
   display: flex; flex-direction: column; gap: 3px; text-align: left; padding: 10px 12px;
   border: 1px solid var(--border); border-radius: 9px; background: var(--panel); cursor: pointer; font: inherit; color: var(--text);
@@ -1037,6 +1037,7 @@ body.dragging-board .col-add-ghost { display: none; }
   box-shadow: 0 10px 28px var(--shadow); padding: 4px; max-height: 280px; overflow-y: auto;
 }
 .kbsel.open .kbsel-list { display: block; }
+.kbsel-list.up { top: auto; bottom: calc(100% + 4px); }
 .kbsel-search { position: sticky; top: -4px; background: var(--panel); padding: 2px 2px 5px; margin: -4px -4px 2px; z-index: 1; }
 .kbsel-search-input {
   width: 100%; box-sizing: border-box; padding: 6px 9px; font: inherit; font-size: 12.5px;