ln-service 57.7.1 → 57.8.1

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Versions
 
+## 57.8.1
+
+- `pay` and payment via request methods: disallow features 30/31 from payments
+
+## 57.8.0
+
+- `removeAdvertisedFeature`: Add method to remove a feature bit support ad
+
 ## 57.7.1
 
 - `getPendingChannels`: Add support for `close_transaction` to return raw tx

package/README.md

@@ -245,6 +245,7 @@ for `unlocker` methods.
 - [proposeChannel](#proposechannel) - Offer a channel proposal to a peer
 - [recoverFundsFromChannel](#recoverfundsfromchannel) - Restore a channel
 - [recoverFundsFromChannels](#recoverfundsfromchannels) - Restore all channels
+- [removeAdvertisedFeature](#removeadvertisedfeature) - Remove feature from ad
 - [removeExternalSocket](#removeexternalsocket) - Remove a p2p host:ip announce
 - [removePeer](#removepeer) - Disconnect from a connected peer
 - [requestChainFeeIncrease](#requestchainfeeincrease) - Request a CPFP spend on
@@ -4682,6 +4683,32 @@ const {backup} = await getBackups({lnd});
 await recoverFundsFromChannels({backup, lnd});
 ```
 
+### removeAdvertisedFeature
+
+Remove an advertised feature from the graph node announcement
+
+Note: this method is not supported in LND versions 0.14.5 and below
+
+Requires LND built with `peersrpc` build tag
+
+Requires `peers:write` permissions
+
+    {
+      feature: <BOLT 09 Feature Bit Number>
+      lnd: <Authenticated LND API Object>
+    }
+
+    @returns via cbk or Promise
+
+Example:
+
+```node
+const {removeAdvertisedFeature} = require('ln-service');
+
+// Remove a supported feature from the graph node announcement
+await removeAdvertisedFeature({lnd, feature: 12345});
+```
+
 ### removeExternalSocket
 
 Remove an existing advertised p2p socket address

package/index.js

@@ -100,6 +100,7 @@ const {probeForRoute} = require('lightning');
 const {proposeChannel} = require('lightning');
 const {recoverFundsFromChannel} = require('lightning');
 const {recoverFundsFromChannels} = require('lightning');
+const {removeAdvertisedFeature} = require('lightning');
 const {removeExternalSocket} = require('lightning');
 const {removePeer} = require('lightning');
 const {requestChainFeeIncrease} = require('lightning');
@@ -261,6 +262,7 @@ module.exports = {
   proposeChannel,
   recoverFundsFromChannel,
   recoverFundsFromChannels,
+  removeAdvertisedFeature,
   removeExternalSocket,
   removePeer,
   requestChainFeeIncrease,

package/package.json

@@ -9,12 +9,12 @@
   "dependencies": {
     "bolt07": "1.8.4",
     "invoices": "3.0.0",
-    "lightning": "10.7.1",
+    "lightning": "10.8.2",
     "macaroon": "3.0.4"
   },
   "description": "Interaction helper for your Lightning Network daemon",
   "devDependencies": {
-    "@alexbosworth/blockchain": "1.7.0",
+    "@alexbosworth/blockchain": "2.0.0",
     "@alexbosworth/node-fetch": "2.6.2",
     "async": "3.2.5",
     "asyncjs-util": "1.2.12",
@@ -69,5 +69,5 @@
     "integration-test-0.14.4": "DOCKER_LND_VERSION=v0.14.4-beta npm run test",
     "test": "echo $DOCKER_LND_VERSION && node test/runner"
   },
-  "version": "57.7.1"
+  "version": "57.8.1"
 }

package/test/integration/test_payment_errors.js

@@ -84,7 +84,11 @@ test('Payment errors', async () => {
     route.tokens = 1000;
 
     await pay({lnd, path: {id, routes: [route]}});
+
+    await kill({});
   } catch (err) {
+    await kill({});
+
     if (Array.isArray(err)) {
       const [, code, context] = err;
 
@@ -94,7 +98,5 @@ test('Payment errors', async () => {
     }
   }
 
-  await kill({});
-
   return;
 });

package/test/invoicesrpc-integration/test_cancel_invoice.js

@@ -67,11 +67,13 @@ test(`Cancel back a hodl invoice`, async () => {
 
     equal(code, 503, 'Canceled back HODL HTLC results in 404');
     equal(message, 'PaymentRejectedByDestination', 'Got back 404 error');
+
+    await kill({});
   } catch (err) {
+    await kill({});
+
     equal(err, null, 'Expected no error');
   }
 
-  await kill({});
-
   return;
 });

package/test/peersrpc-integration/test_remove_advertised_feature.js

@@ -0,0 +1,37 @@
+const {equal} = require('node:assert').strict;
+const test = require('node:test');
+
+const {spawnLightningCluster} = require('ln-docker-daemons');
+
+const {addAdvertisedFeature} = require('./../../');
+const {getWalletInfo} = require('./../../');
+const {removeAdvertisedFeature} = require('./../../');
+
+const feature = 12345;
+
+// Removing a feature should result in an updated advertised feature
+test(`Add external socket`, async () => {
+  const {kill, nodes} = await spawnLightningCluster({});
+
+  const [{id, lnd}] = nodes;
+
+  try {
+    await addAdvertisedFeature({feature, lnd});
+
+    await removeAdvertisedFeature({feature, lnd});
+
+    const {features} = await getWalletInfo({lnd});
+
+    const added = features.find(n => n.bit === feature);
+
+    equal(added, undefined, 'Feature was removed');
+
+    await kill({});
+  } catch (err) {
+    await kill({});
+
+    deepEqual(err, [400, 'ExpectedPeersRpcLndBuildTagToAddFeature']);
+  }
+
+  return;
+});

package/test/routerrpc-integration/test_delete_forwarding_reputations.js

@@ -89,11 +89,13 @@ test('Delete forwarding reputations', async () => {
 
       equal(nodes.length, [].length, 'Reputations should be wiped');
     }
+
+    await kill({});
   } catch (err) {
+    await kill({});
+
     equal(err, null, 'Expected no error');
   }
 
-  await kill({});
-
   return;
 });