ln-service 56.2.0 → 56.3.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Versions
 
+## 56.3.1
+
+- `subscribeToPastPayment`, `subscribeToPayViaDetails`,
+    `subscribeToPayViaRequest`, `subscribeToPayments`: Add `id` for `failed`
+    payment hash
+
 ## 56.2.0
 
 - `getChannels`: Add support for `type` to show channel type

package/README.md

@@ -5809,6 +5809,7 @@ Requires `offchain:read` permission
 
     @event 'failed'
     {
+      id: <Payment Hash Hex String>
       is_insufficient_balance: <Failed Due To Lack of Balance Bool>
       is_invalid_payment: <Failed Due to Payment Rejected At Destination Bool>
       is_pathfinding_timeout: <Failed Due to Pathfinding Timeout Bool>
@@ -5993,6 +5994,7 @@ Preferred `confidence` is not supported on LND 0.14.5 and below
 
     @event 'failed'
     {
+      id: <Payment Hash Hex String>
       is_insufficient_balance: <Failed Due To Lack of Balance Bool>
       is_invalid_payment: <Failed Due to Invalid Payment Bool>
       is_pathfinding_timeout: <Failed Due to Pathfinding Timeout Bool>
@@ -6147,6 +6149,7 @@ Preferred `confidence` is not supported on LND 0.14.5 and below
 
     @event 'failed'
     {
+      id: <Payment Hash Hex String>
       is_insufficient_balance: <Failed Due To Lack of Balance Bool>
       is_invalid_payment: <Failed Due to Invalid Payment Bool>
       is_pathfinding_timeout: <Failed Due to Pathfinding Timeout Bool>
@@ -6480,6 +6483,7 @@ Note: Method not supported on LND 0.15.5 and below
 
     @event 'failed'
     {
+      id: <Payment Hash Hex String>
       is_insufficient_balance: <Failed Due To Lack of Balance Bool>
       is_invalid_payment: <Failed Due to Payment Rejected At Destination Bool>
       is_pathfinding_timeout: <Failed Due to Pathfinding Timeout Bool>

package/package.json

@@ -11,7 +11,7 @@
     "cors": "2.8.5",
     "express": "4.18.2",
     "invoices": "2.2.3",
-    "lightning": "9.2.1",
+    "lightning": "9.3.1",
     "macaroon": "3.0.4",
     "morgan": "1.10.0",
     "ws": "8.13.0"
@@ -28,7 +28,7 @@
     "bn.js": "5.2.1",
     "bs58check": "3.0.1",
     "ecpair": "2.1.0",
-    "ln-docker-daemons": "5.0.2",
+    "ln-docker-daemons": "5.0.3",
     "p2tr": "1.3.3",
     "portfinder": "1.0.32",
     "psbt": "2.7.2",
@@ -67,5 +67,5 @@
     "integration-test-0.14.4": "DOCKER_LND_VERSION=v0.14.4-beta npm run test",
     "test": "echo $DOCKER_LND_VERSION && tap -j 2 --branches=1 --functions=1 --lines=1 --statements=1 -t 200 test/autopilotrpc-integration/*.js test/chainrpc-integration/*.js test/integration/*.js test/invoicesrpc-integration/*.js test/peersrpc-integration/*.js test/routerrpc-integration/*.js test/signerrpc-integration/*.js test/tower_clientrpc-integration/*.js test/tower_serverrpc-integration/*.js test/walletrpc-integration/*.js"
   },
-  "version": "56.2.0"
+  "version": "56.3.1"
 }

package/test/integration/test_delete_pending_channel.js

@@ -30,7 +30,7 @@ const interval = 100;
 const race = promises => Promise.race(promises);
 const size = 3;
 const timeout = 1000 * 20;
-const times = 1000;
+const times = 2000;
 
 // Forfeiting a pending channel should remove the pending channel
 test(`Forfeit pending channel`, async ({end, equal, strictSame}) => {

package/test/integration/test_get_failed_payments.js

@@ -112,6 +112,7 @@ test('Get failed payments', async ({end, equal, strictSame}) => {
         gotFailed,
         {
           failed: {
+            id: payment.id,
             is_insufficient_balance: false,
             is_invalid_payment: false,
             is_pathfinding_timeout: false,

package/test/walletrpc-integration/test_request_chain_fee_increase.js

@@ -12,7 +12,7 @@ const count = 100;
 const tokens = 1e8;
 
 // Test requesting a chain fee increase
-test(`Request chain fee increase`, async ({end, equal}) => {
+test(`Request chain fee increase`, async ({end, equal, fail, strictSame}) => {
   const [{generate, kill, lnd}] = (await spawnLightningCluster({})).nodes;
 
   try {
@@ -20,7 +20,10 @@ test(`Request chain fee increase`, async ({end, equal}) => {
 
     const {address} = await createChainAddress({lnd});
 
-    const {psbt} = await fundPsbt({lnd, outputs: [{address, tokens}]});
+    const {psbt} = await fundPsbt({lnd, outputs: [
+      {address, tokens},
+      {tokens, address: '2N8hwP1WmJrFF5QWABn38y63uYLhnJYJYTF'},
+    ]});
 
     const {transaction} = await signPsbt({lnd, psbt});
 
@@ -28,6 +31,17 @@ test(`Request chain fee increase`, async ({end, equal}) => {
 
     const bump = (await getUtxos({lnd})).utxos.find(n => n.tokens === tokens);
 
+    try {
+      await requestChainFeeIncrease({
+        lnd,
+        transaction_id: bump.transaction_id,
+        transaction_vout: bump.transaction_vout + 1,
+      });
+      fail('Expected chain fee increase rejected');
+    } catch (err) {
+      strictSame(err, [404, 'SpecifiedOutpointNotFoundInWalletUtxos'], '404');
+    }
+
     await requestChainFeeIncrease({
       lnd,
       transaction_id: bump.transaction_id,