ln-service 56.12.0 → 56.14.0

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Versions
 
+## 56.14.0
+
+- `openChannel`: Add `is_allowing_minimal_reserve` to allow no reserve on peer
+
+## 56.13.0
+
+- `openChannels`: Add `is_simplified_taproot` to make a simplified taproot chan
+
 ## 56.12.0
 
 - `openChannel`: Add `is_simplified_taproot` to make a simplified taproot chan

package/README.md

@@ -3758,6 +3758,8 @@ Requires `offchain:write`, `onchain:write`, `peers:write` permissions
 `base_fee_mtokens` is not supported on LND 0.15.5 and below
 `fee_rate` is not supported on LND 0.15.5 and below
 
+`is_allowing_minimal_reserve` is not supported on LND 0.15.0 and below
+
 `is_max_funding` is not supported on LND 0.16.4 and below
 
 `description` is not supported on LND 0.16.4 and below
@@ -3778,6 +3780,7 @@ Requires `offchain:write`, `onchain:write`, `peers:write` permissions
         transaction_id: <Fund With Unspent Transaction Id Hex String>
         transaction_vout: <Fund With Unspent Transaction Output Index Number>
       }]
+      [is_allowing_minimal_reserve]: <Allow Peer to Have Minimal Reserve Bool>
       [is_max_funding]: <Use Maximal Chain Funds For Local Funding Bool>
       [is_private]: <Channel is Private Bool> // Defaults to false
       [is_simplified_taproot]: <Channel is Simplified Taproot Type Bool>
@@ -3830,6 +3833,9 @@ as well as a channel open request listener to accept the trusted funding.
 
 `description` is not supported on LND 0.16.4 and below
 
+`is_simplified_taproot` is not supported on LND 0.16.4 and below and requires
+`--protocol.simple-taproot-chans` set on both sides.
+
     {
       channels: [{
         [base_fee_mtokens]: <Routing Base Fee Millitokens Charged String>
@@ -3839,6 +3845,7 @@ as well as a channel open request listener to accept the trusted funding.
         [fee_rate]: <Routing Fee Rate In Millitokens Per Million Number>
         [give_tokens]: <Tokens to Gift To Partner Number> // Defaults to zero
         [is_private]: <Channel is Private Bool> // Defaults to false
+        [is_simplified_taproot]: <Channel is Simplified Taproot Type Bool>
         [is_trusted_funding]: <Peer Should Avoid Waiting For Confirmation Bool>
         [min_htlc_mtokens]: <Minimum HTLC Millitokens String>
         [partner_csv_delay]: <Peer Output CSV Delay Number>

package/package.json

@@ -11,10 +11,10 @@
     "cors": "2.8.5",
     "express": "4.18.2",
     "invoices": "3.0.0",
-    "lightning": "9.12.0",
+    "lightning": "9.14.0",
     "macaroon": "3.0.4",
     "morgan": "1.10.0",
-    "ws": "8.13.0"
+    "ws": "8.14.2"
   },
   "description": "Interaction helper for your Lightning Network daemon",
   "devDependencies": {
@@ -24,7 +24,7 @@
     "asyncjs-util": "1.2.12",
     "bip32": "4.0.0",
     "bip66": "1.1.5",
-    "bitcoinjs-lib": "6.1.3",
+    "bitcoinjs-lib": "6.1.5",
     "bn.js": "5.2.1",
     "bs58check": "3.0.1",
     "ecpair": "2.1.0",
@@ -32,10 +32,10 @@
     "p2tr": "2.0.0",
     "portfinder": "1.0.32",
     "psbt": "3.0.0",
-    "rimraf": "5.0.1",
+    "rimraf": "5.0.5",
     "secp256k1": "5.0.0",
     "tiny-secp256k1": "2.2.3",
-    "uuid": "9.0.0",
+    "uuid": "9.0.1",
     "varuint-bitcoin": "1.1.2"
   },
   "engines": {
@@ -69,5 +69,5 @@
     "integration-test-0.14.4": "DOCKER_LND_VERSION=v0.14.4-beta npm run test",
     "test": "echo $DOCKER_LND_VERSION && node test/runner"
   },
-  "version": "56.12.0"
+  "version": "56.14.0"
 }

package/test/integration/test_open_low_reserve.js

@@ -0,0 +1,92 @@
+const {equal} = require('node:assert').strict;
+const test = require('node:test');
+
+const asyncRetry = require('async/retry');
+const {spawnLightningCluster} = require('ln-docker-daemons');
+
+const {addPeer} = require('./../../');
+const {getChannels} = require('./../../');
+const {getWalletInfo} = require('./../../');
+const {openChannel} = require('./../../');
+const {subscribeToOpenRequests} = require('./../../');
+
+const channelCapacityTokens = 1e6;
+const confirmationCount = 6;
+const count = 100;
+const dustLimit = 354;
+const interval = 10;
+const size = 2;
+const times = 2000;
+
+// Open a channel with a low channel reserve
+test(`Open channel but allow a minimal channel reserve`, async () => {
+  const {kill, nodes} = await spawnLightningCluster({size});
+
+  const [control, target] = nodes;
+
+  const {id, lnd} = control;
+
+  await target.generate({count});
+
+  await addPeer({lnd, public_key: target.id, socket: target.socket});
+
+  await asyncRetry({interval, times}, async () => {
+    const wallet = await getWalletInfo({lnd: target.lnd});
+
+    if (!wallet.is_synced_to_chain) {
+      throw new Error('ExpectedWalletSyncedToChain');
+    }
+  });
+
+  const acceptSub = subscribeToOpenRequests({lnd});
+
+  acceptSub.on('channel_request', request => {
+    request.accept({
+      min_confirmations: 1,
+      remote_csv: 999,
+      remote_reserve: 354,
+      remote_max_htlcs: 20,
+      remote_max_pending_mtokens: '200000',
+      remote_min_htlc_mtokens: '2000',
+    });
+
+    return;
+  });
+
+  try {
+    await asyncRetry({interval, times}, async () => {
+      return await openChannel({
+        lnd: target.lnd,
+        is_private: true,
+        is_allowing_minimal_reserve: true,
+        local_tokens: channelCapacityTokens,
+        partner_public_key: control.id,
+        socket: control.socket,
+      });
+    });
+  } catch (err) {
+    equal(err, null, 'Expected no error when a channel is accepted');
+  }
+
+  acceptSub.removeAllListeners();
+
+  await target.generate({count: confirmationCount});
+
+  const channel = await asyncRetry({interval, times}, async () => {
+    const [channel] = (await getChannels({lnd})).channels;
+
+    await control.generate({});
+
+    if (!channel) {
+      throw new Error('ExpectedChannelCreation');
+    }
+
+    return channel;
+  });
+
+  equal(channel.remote_reserve, dustLimit, 'Got minimal reserve value');
+
+  await kill({});
+
+  return;
+});

package/test/integration/test_open_simplified_taproot.js

@@ -5,8 +5,13 @@ const asyncRetry = require('async/retry');
 const {spawnLightningCluster} = require('ln-docker-daemons');
 
 const {addPeer} = require('./../../');
+const {broadcastChainTransaction} = require('./../../');
+const {fundPendingChannels} = require('./../../');
+const {fundPsbt} = require('./../../');
 const {getChannels} = require('./../../');
 const {openChannel} = require('./../../');
+const {openChannels} = require('./../../');
+const {signPsbt} = require('./../../');
 
 const channelCapacityTokens = 1e6;
 const count = 100;
@@ -107,5 +112,63 @@ test(`Open simplified taproot channel`, async () => {
     await kill({});
   }
 
+  // Try opening a simplified taproot channel via PSBT funding
+  {
+    const {kill, nodes} = await spawnLightningCluster({
+      size,
+      lnd_configuration: ['--protocol.simple-taproot-chans'],
+    });
+
+    const [{generate, id, lnd}, target] = nodes;
+
+    await generate({count});
+
+    await addPeer({lnd, public_key: target.id, socket: target.socket});
+
+    const channelOpen = await asyncRetry({interval, times}, async () => {
+      await addPeer({lnd, public_key: target.id, socket: target.socket});
+
+      return await openChannels({
+        lnd,
+        channels: [{
+          capacity: channelCapacityTokens,
+          is_private: true,
+          is_simplified_taproot: true,
+          partner_public_key: target.id,
+        }],
+      });
+    });
+
+    const funded = await fundPsbt({lnd, outputs: channelOpen.pending});
+
+    const signed = await signPsbt({lnd, psbt: funded.psbt});
+
+    await fundPendingChannels({
+      lnd,
+      channels: channelOpen.pending.map(n => n.id),
+      funding: signed.psbt,
+    });
+
+    await broadcastChainTransaction({lnd, transaction: signed.transaction});
+
+    const channel = await asyncRetry({interval, times}, async () => {
+      await generate({});
+
+      const {channels} = await getChannels({lnd});
+
+      const [channel] = channels;
+
+      if (!channel) {
+        throw new Error('ExpectedChannelOpened');
+      }
+
+      return channel;
+    });
+
+    equal(channel.type, 'simplified_taproot', 'Opened simplified taproot');
+
+    await kill({});
+  }
+
   return;
 });