ln-service 54.10.7 → 56.0.0

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Versions
 
+## 56.0.0
+
+### Breaking Changes
+
+- Minimum version of node.js is moved up from 14 to 16
+
+## 55.0.0
+
+- `openChannel`: Add `is_max_funding` to fund a channel maximally
+- `subscribeToRpcRequests`: Add support for returning `is_max_funding` in
+    `open_channel_request`
+
+### Breaking Changes
+
+- `subscribeToRpcRequests`: `open_channel_request`: `local_tokens` is now an
+    optional value
+
 ## 54.10.7
 
 - `signChainAddressMessage`: Add method to sign a message given a chain address

package/README.md

@@ -3697,12 +3697,15 @@ Requires `offchain:write`, `onchain:write`, `peers:write` permissions
 `base_fee_mtokens` is not supported on LND 0.15.5 and below
 `fee_rate` is not supported on LND 0.15.5 and below
 
+`is_max_funding` is not supported on LND 0.16.0 and below
+
     {
       [base_fee_mtokens]: <Routing Base Fee Millitokens Charged String>
       [chain_fee_tokens_per_vbyte]: <Chain Fee Tokens Per VByte Number>
       [cooperative_close_address]: <Restrict Cooperative Close To Address String>
       [fee_rate]: <Routing Fee Rate In Millitokens Per Million Number>
       [give_tokens]: <Tokens to Gift To Partner Number> // Defaults to zero
+      [is_max_funding]: <Use Maximal Chain Funds For Local Funding Bool>
       [is_private]: <Channel is Private Bool> // Defaults to false
       lnd: <Authenticated LND API Object>
       local_tokens: <Total Channel Capacity Tokens Number>
@@ -6826,7 +6829,9 @@ This method is not supported in LND 0.13.4 and below
         [fee_rate]: <Routing Fee Rate In Millitokens Per Million Number>
         [give_tokens]: <Tokens to Gift To Partner Number>
         [is_private]: <Channel is Private Bool>
-        local_tokens: <Local Tokens Number>
+        [is_max_funding]: <Use Maximal Chain Funds For Local Funding Bool>
+        [is_private]: <Channel is Private Bool>
+        [local_tokens]: <Local Tokens Number>
         [min_confirmations]: <Spend UTXOs With Minimum Confirmations Number>
         [min_htlc_mtokens]: <Minimum HTLC Millitokens String>
         [partner_csv_delay]: <Peer Output CSV Delay Number>

package/package.json

@@ -11,7 +11,7 @@
     "cors": "2.8.5",
     "express": "4.18.2",
     "invoices": "2.2.3",
-    "lightning": "7.1.9",
+    "lightning": "9.0.0",
     "macaroon": "3.0.4",
     "morgan": "1.10.0",
     "ws": "8.13.0"
@@ -28,18 +28,18 @@
     "bn.js": "5.2.1",
     "bs58check": "3.0.1",
     "ecpair": "2.1.0",
-    "ln-docker-daemons": "4.1.3",
+    "ln-docker-daemons": "5.0.0",
     "p2tr": "1.3.3",
     "portfinder": "1.0.32",
     "psbt": "2.7.2",
-    "rimraf": "4.4.1",
+    "rimraf": "5.0.0",
     "secp256k1": "5.0.0",
     "tiny-secp256k1": "2.2.1",
     "uuid": "9.0.0",
     "varuint-bitcoin": "1.1.2"
   },
   "engines": {
-    "node": ">=14"
+    "node": ">=16"
   },
   "keywords": [
     "bitcoin",
@@ -65,5 +65,5 @@
     "integration-test-0.14.4": "DOCKER_LND_VERSION=v0.14.4-beta npm run test",
     "test": "echo $DOCKER_LND_VERSION && tap -j 2 --branches=1 --functions=1 --lines=1 --statements=1 -t 200 test/autopilotrpc-integration/*.js test/chainrpc-integration/*.js test/integration/*.js test/invoicesrpc-integration/*.js test/peersrpc-integration/*.js test/routerrpc-integration/*.js test/signerrpc-integration/*.js test/tower_clientrpc-integration/*.js test/tower_serverrpc-integration/*.js test/walletrpc-integration/*.js"
   },
-  "version": "54.10.7"
+  "version": "56.0.0"
 }

package/test/integration/test_delete_pending_channel.js

@@ -30,7 +30,7 @@ const interval = 100;
 const race = promises => Promise.race(promises);
 const size = 3;
 const timeout = 1000 * 20;
-const times = 300;
+const times = 500;
 
 // Forfeiting a pending channel should remove the pending channel
 test(`Forfeit pending channel`, async ({end, equal, strictSame}) => {

package/test/integration/test_get_channel.js

@@ -25,7 +25,7 @@ test(`Get channel`, async ({end, equal}) => {
 
   details.policies.forEach(policy => {
     equal(policy.base_fee_mtokens, '1000', 'Base fee mtokens');
-    equal(policy.cltv_delta, 40, 'CLTV policy');
+    equal([40, 80].includes(policy.cltv_delta), true, 'CLTV policy');
     equal(policy.fee_rate, 1, 'Fee rate');
     equal(policy.is_disabled, false, 'Disabled flag');
     equal(policy.max_htlc_mtokens, `${ceil(details.capacity * 0.99)}000`);

package/test/integration/test_get_network_graph.js

@@ -51,7 +51,7 @@ test(`Get network graph`, async ({end, equal, strictSame}) => {
 
   channel.policies.forEach(policy => {
     equal(policy.base_fee_mtokens, '1000', 'Default channel base fee');
-    equal(policy.cltv_delta, 40, 'Default channel CLTV delta');
+    equal([40, 80].includes(policy.cltv_delta), true, 'Default CLTV delta');
     equal(policy.fee_rate, 1, 'Default channel fee rate');
     equal(policy.is_disabled, false, 'Channels are active');
     equal(policy.max_htlc_mtokens, `${ceil(channel.capacity * 0.99)}000`);

package/test/integration/test_pay.js

@@ -67,7 +67,12 @@ test(`Pay`, async ({end, equal, strictSame}) => {
   const height = (await getHeight({lnd})).current_block_height;
 
   paid.hops.forEach(n => {
-    equal(n.timeout === height + 40 || n.timeout === height + 43, true);
+    equal(
+      n.timeout === height + 40 ||
+      n.timeout === height + 43 ||
+      n.timeout === height + 80,
+      true
+    );
 
     delete n.timeout;
 

package/test/integration/test_pay_private_invoice.js

@@ -77,6 +77,7 @@ test(`Pay private invoice`, async ({end, equal, strictSame}) => {
     const route = await asyncRetry({interval: 10, times: 1000}, async () => {
       const {route} = await getRouteToDestination({
         lnd,
+        cltv_delta: decodedRequest.cltv_delta,
         destination: decodedRequest.destination,
         payment: invoice.payment,
         routes: decodedRequest.routes,

package/test/integration/test_subscribe_to_rpc_requests.js

@@ -117,7 +117,7 @@ test(`Subscribe to RPC requests`, async ({end, equal, fail, strictSame}) => {
       strictSame(err, [400, 'CannotOpenChannelToOwnNode'], 'RPC req accepted');
     }
 
-    await delay(2000);
+    await delay(2500);
 
     subscription.removeAllListeners();
   }

package/test/routerrpc-integration/test_pay_via_payment_details.js

@@ -36,7 +36,12 @@ test(`Pay`, async ({end, equal, rejects, strictSame}) => {
     await addPeer({lnd, public_key: remote.id, socket: remote.socket});
 
     const height = (await getHeight({lnd})).current_block_height;
-    const invoice = await createInvoice({tokens, lnd: remote.lnd});
+
+    const invoice = await createInvoice({
+      tokens,
+      cltv_delta: 40,
+      lnd: remote.lnd,
+    });
 
     const {features} = await decodePaymentRequest({
       lnd,
@@ -93,7 +98,7 @@ test(`Pay`, async ({end, equal, rejects, strictSame}) => {
     } catch (err) {
       strictSame(
         err,
-        [503, 'PaymentPathfindingFailedToFindPossibleRoute'],
+        [400, 'MaxTimeoutTooNearCurrentHeightToMakePayment'],
         'Fail'
       );
     }
@@ -104,7 +109,7 @@ test(`Pay`, async ({end, equal, rejects, strictSame}) => {
         lnd,
         destination: remote.id,
         id: invoice.id,
-        max_timeout_height: height + 90,
+        max_timeout_height: height + 200,
         messages: [{type: tlvType, value: tlvData}],
         payment: invoice.payment,
         tokens: invoice.tokens,
@@ -117,13 +122,7 @@ test(`Pay`, async ({end, equal, rejects, strictSame}) => {
       equal(paid.mtokens, '101000', 'Paid mtokens');
       equal(paid.secret, invoice.secret, 'Paid for invoice secret');
 
-      paid.hops.forEach(n => {
-        equal(n.timeout === height + 40 || n.timeout === height + 43, true);
-
-        delete n.timeout;
-
-        return;
-      });
+      paid.hops.forEach(n => delete n.timeout);
 
       strictSame(paid.hops, expectedHops, 'Hops are returned');
     } catch (err) {

package/test/routerrpc-integration/test_pay_via_routes.js

@@ -100,6 +100,7 @@ test(`Pay via routes`, async ({end, equal, strictSame}) => {
 
   const {route} = await getRouteToDestination({
     lnd,
+    cltv_delta: decodedRequest.cltv_delta,
     destination: decodedRequest.destination,
     payment: invoice.payment,
     routes: decodedRequest.routes,

package/test/routerrpc-integration/test_subscribe_to_forwards.js

@@ -133,7 +133,12 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
 
     // LND 0.13.0 and below do not support secret
     [controlForwards, targetForwards, remoteForwards].forEach(forwards => {
-      return forwards.forEach(n => delete n.at && delete n.secret);
+      return forwards.forEach(n =>
+        delete n.at &&
+        delete n.cltv_delta &&
+        delete n.secret &&
+        delete n.timeout
+      );
     });
 
     const height = (await getHeight({lnd})).current_block_height;
@@ -142,7 +147,6 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
     if (!isAnchors) {
       strictSame(controlForwards, [
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -156,11 +160,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: '101000',
           out_channel: controlChannel.id,
           out_payment: 0,
-          timeout: height + 40 + 43,
           tokens: 101,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -174,7 +176,6 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: undefined,
           out_channel: controlChannel.id,
           out_payment: 0,
-          timeout: undefined,
           tokens: undefined,
         },
         {
@@ -192,11 +193,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: '490851490',
           out_channel: controlChannel.id,
           out_payment: 1,
-          timeout: height + 40 + 43,
           tokens: 490851,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -210,11 +209,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: undefined,
           out_channel: controlChannel.id,
           out_payment: 1,
-          timeout: undefined,
           tokens: undefined,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -228,11 +225,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: '100000',
           out_channel: controlChannel.id,
           out_payment: 2,
-          timeout: height + 43,
           tokens: 100,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -246,7 +241,6 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: undefined,
           out_channel: controlChannel.id,
           out_payment: 2,
-          timeout: undefined,
           tokens: undefined,
         },
       ],
@@ -254,7 +248,6 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
 
       strictSame(targetForwards, [
         {
-          cltv_delta: 40,
           external_failure: undefined,
           fee: 1,
           fee_mtokens: '1000',
@@ -268,11 +261,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: '100000',
           out_channel: targetChannel.id,
           out_payment: 0,
-          timeout: 497,
           tokens: 100,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -286,11 +277,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: undefined,
           out_channel: targetChannel.id,
           out_payment: 0,
-          timeout: undefined,
           tokens: undefined,
         },
         {
-          cltv_delta: 40,
           external_failure: 'TEMPORARY_CHANNEL_FAILURE',
           fee: 1,
           fee_mtokens: '1490',
@@ -304,11 +293,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: '490850000',
           out_channel: targetChannel.id,
           out_payment: 0,
-          timeout: 497,
           tokens: 490850,
         },
         {
-          cltv_delta: undefined,
           external_failure: 'INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS',
           fee: undefined,
           fee_mtokens: undefined,
@@ -322,7 +309,6 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: undefined,
           out_channel: undefined,
           out_payment: undefined,
-          timeout: undefined,
           tokens: undefined,
         },
       ],
@@ -330,7 +316,6 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
 
       strictSame(remoteForwards, [
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -344,7 +329,6 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: undefined,
           out_channel: undefined,
           out_payment: undefined,
-          timeout: undefined,
           tokens: undefined,
         },
       ],
@@ -352,7 +336,6 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
     } else {
       strictSame(controlForwards, [
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -366,11 +349,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: '101000',
           out_channel: controlChannel.id,
           out_payment: 0,
-          timeout: height + 40 + 43,
           tokens: 101,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -384,11 +365,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: undefined,
           out_channel: controlChannel.id,
           out_payment: 0,
-          timeout: undefined,
           tokens: undefined,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -402,11 +381,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: '496431496',
           out_channel: controlChannel.id,
           out_payment: 1,
-          timeout: height + 40 + 43,
           tokens: 496431,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -420,11 +397,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: undefined,
           out_channel: controlChannel.id,
           out_payment: 1,
-          timeout: undefined,
           tokens: undefined,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -438,11 +413,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: '100000',
           out_channel: controlChannel.id,
           out_payment: 2,
-          timeout: height + 43,
           tokens: 100,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -456,7 +429,6 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: undefined,
           out_channel: controlChannel.id,
           out_payment: 2,
-          timeout: undefined,
           tokens: undefined,
         },
       ],
@@ -464,7 +436,6 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
 
       strictSame(targetForwards, [
         {
-          cltv_delta: 40,
           external_failure: undefined,
           fee: 1,
           fee_mtokens: '1000',
@@ -478,11 +449,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: '100000',
           out_channel: targetChannel.id,
           out_payment: 0,
-          timeout: height + 43,
           tokens: 100,
         },
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -496,11 +465,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: undefined,
           out_channel: targetChannel.id,
           out_payment: 0,
-          timeout: undefined,
           tokens: undefined,
         },
         {
-          cltv_delta: 40,
           external_failure: 'TEMPORARY_CHANNEL_FAILURE',
           fee: 1,
           fee_mtokens: '1496',
@@ -514,11 +481,9 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: '496430000',
           out_channel: targetChannel.id,
           out_payment: 0,
-          timeout: height + 43,
           tokens: 496430,
         },
         {
-          cltv_delta: undefined,
           external_failure: 'INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS',
           fee: undefined,
           fee_mtokens: undefined,
@@ -532,7 +497,6 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: undefined,
           out_channel: undefined,
           out_payment: undefined,
-          timeout: undefined,
           tokens: undefined,
         },
       ],
@@ -540,7 +504,6 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
 
       strictSame(remoteForwards, [
         {
-          cltv_delta: undefined,
           external_failure: undefined,
           fee: undefined,
           fee_mtokens: undefined,
@@ -554,7 +517,6 @@ test('Subscribe to forwards', async ({end, equal, rejects, strictSame}) => {
           mtokens: undefined,
           out_channel: undefined,
           out_payment: undefined,
-          timeout: undefined,
           tokens: undefined,
         },
       ],