ln-service 53.7.0 → 53.8.0

package/test/integration/test_remove_peer.js

@@ -14,21 +14,25 @@ test(`Remove a peer`, async ({end, equal}) => {
 
   const [{id, lnd}, target] = nodes;
 
-  await asyncRetry({interval: 10, times: 2000}, async () => {
-    await addPeer({lnd, public_key: target.id, socket: target.socket});
-  });
+  try {
+    await asyncRetry({interval: 10, times: 2000}, async () => {
+      await addPeer({lnd, public_key: target.id, socket: target.socket});
+    });
 
-  const {peers} = await getPeers({lnd});
+    const {peers} = await getPeers({lnd});
 
-  const [targetPeer] = peers;
+    const [targetPeer] = peers;
 
-  equal(targetPeer.public_key, target.id, 'Peer is added');
+    equal(targetPeer.public_key, target.id, 'Peer is added');
 
-  await removePeer({lnd, public_key: targetPeer.public_key});
+    await removePeer({lnd, public_key: targetPeer.public_key});
 
-  const postRemovalPeers = await getPeers({lnd});
+    const postRemovalPeers = await getPeers({lnd});
 
-  equal(postRemovalPeers.peers.length, [].length, 'Peer is removed');
+    equal(postRemovalPeers.peers.length, [].length, 'Peer is removed');
+  } catch (err) {
+    equal(err, null, 'Expected no error');
+  }
 
   await kill({});
 

package/test/integration/test_send_message_to_peer.js

@@ -8,7 +8,7 @@ const {subscribeToPeerMessages} = require('./../../');
 
 const interval = 10;
 const size = 2;
-const times = 1000;
+const times = 2000;
 
 // Sending a message to a peer should result in the message received
 test(`Send peer message`, async ({end, equal, strictSame}) => {
@@ -33,39 +33,50 @@ test(`Send peer message`, async ({end, equal, strictSame}) => {
     }
   }
 
-  await asyncRetry({interval, times}, async () => {
-    await addPeer({lnd, public_key: target.id, socket: target.socket});
-  });
+  try {
+    await asyncRetry({interval, times}, async () => {
+      await addPeer({
+        lnd,
+        public_key: target.id,
+        retry_count: 1,
+        retry_delay: 1,
+        socket: target.socket,
+        timeout: 1000,
+      });
+    });
 
-  const sub = subscribeToPeerMessages({lnd: target.lnd});
+    const sub = subscribeToPeerMessages({lnd: target.lnd});
 
-  const messages = [];
+    const messages = [];
 
-  sub.on('message_received', message => messages.push(message));
+    sub.on('message_received', message => messages.push(message));
 
-  await asyncRetry({interval, times}, async () => {
-    await sendMessageToPeer({
-      lnd,
-      message: Buffer.from('message').toString('hex'),
-      public_key: target.id,
-    });
+    await asyncRetry({interval, times}, async () => {
+      await sendMessageToPeer({
+        lnd,
+        message: Buffer.from('message').toString('hex'),
+        public_key: target.id,
+      });
 
-    if (!messages.length) {
-      throw new Error('ExpectedMessage');
-    }
-  });
-
-  const [message] = messages;
+      if (!messages.length) {
+        throw new Error('ExpectedMessage');
+      }
+    });
 
-  strictSame(
-    message,
-    {
-      message: Buffer.from('message').toString('hex'),
-      public_key: id,
-      type: 32768,
-    },
-    'Message successfully sent to peer'
-  );
+    const [message] = messages;
+
+    strictSame(
+      message,
+      {
+        message: Buffer.from('message').toString('hex'),
+        public_key: id,
+        type: 32768,
+      },
+      'Message successfully sent to peer'
+    );
+  } catch (err) {
+    equal(err, null, 'Expected no error');
+  }
 
   await kill({});
 

package/test/integration/test_send_to_chain_address.js

@@ -78,6 +78,10 @@ test(`Send to chain address`, async ({end, equal}) => {
           lnd: control.lnd,
         });
 
+        if (!!(await getChainBalance({lnd: control.lnd})).chain_balance) {
+          throw new Error('ExpectedChainBalanceOnControlEmptiedOut');
+        }
+
         return;
       });
 

package/test/integration/test_subscribe_to_channels.js

@@ -5,7 +5,6 @@ const {test} = require('@alexbosworth/tap');
 const {addPeer} = require('./../../');
 const {closeChannel} = require('./../../');
 const {getChainBalance} = require('./../../');
-const {getHeight} = require('./../../');
 const {getWalletInfo} = require('./../../');
 const {openChannel} = require('./../../');
 const {removePeer} = require('./../../');

package/test/integration/test_subscribe_to_invoices.js

@@ -4,13 +4,9 @@ const {routeFromHops} = require('bolt07');
 const {spawnLightningCluster} = require('ln-docker-daemons');
 const {test} = require('@alexbosworth/tap');
 
-const {cancelHodlInvoice} = require('./../../');
 const {createInvoice} = require('./../../');
 const {getChannel} = require('./../../');
-const {getChannels} = require('./../../');
-const {getHeight} = require('./../../');
 const {pay} = require('./../../');
-const {payViaRoutes} = require('./../../');
 const {setupChannel} = require('./../macros');
 const {subscribeToInvoices} = require('./../../');
 
@@ -37,107 +33,113 @@ test('Subscribe to invoices', async ({end, equal, fail}) => {
 
   const destination = control.id;
 
-  // Create a channel from the control to the target node
-  const controlToTargetChannel = await setupChannel({
-    generate,
-    lnd,
-    give: 1e5,
-    to: target,
-  });
+  try {
+    await generate({count: 100});
 
-  // Create a channel from the target back to the control
-  const targetToControlChannel = await setupChannel({
-    lnd: target.lnd,
-    generate: target.generate,
-    give: 1e5,
-    to: control,
-  });
-
-  // Created invoices are emitted
-  {
-    const sub = subscribeToInvoices({lnd, restart_delay_ms: 1});
+    // Create a channel from the control to the target node
+    const controlToTargetChannel = await setupChannel({
+      generate,
+      lnd,
+      give: 1e5,
+      to: target,
+    });
 
-    const updates = [];
+    // Create a channel from the target back to the control
+    const targetToControlChannel = await setupChannel({
+      lnd: target.lnd,
+      generate: target.generate,
+      give: 1e5,
+      to: control,
+    });
 
-    sub.on('invoice_updated', updated => updates.push(updated));
+    // Created invoices are emitted
+    {
+      const sub = subscribeToInvoices({lnd, restart_delay_ms: 1});
 
-    const update = await asyncRetry({interval, times}, async () => {
-      await createInvoice({lnd});
+      const updates = [];
 
-      const [update] = updates;
+      sub.on('invoice_updated', updated => updates.push(updated));
 
-      if (!update) {
-        throw new Error('ExpectedInvoiceUpdate');
-      }
+      const update = await asyncRetry({interval, times}, async () => {
+        await createInvoice({lnd});
 
-      return update;
-    });
+        const [update] = updates;
 
-    equal(update.tokens, 0, 'Invoiced zero');
+        if (!update) {
+          throw new Error('ExpectedInvoiceUpdate');
+        }
 
-    sub.removeAllListeners();
-  }
+        return update;
+      });
 
-  // Paid invoices are emitted
-  {
-    const sub = subscribeToInvoices({lnd, restart_delay_ms: 1});
+      equal(update.tokens, 0, 'Invoiced zero');
 
-    const updates = [];
+      sub.removeAllListeners();
+    }
 
-    sub.on('invoice_updated', updated => updates.push(updated));
+    // Paid invoices are emitted
+    {
+      const sub = subscribeToInvoices({lnd, restart_delay_ms: 1});
 
-    const update = await asyncRetry({interval, times}, async () => {
-      await pay({
-        lnd: target.lnd,
-        request: (await createInvoice({lnd, tokens})).request,
-      });
+      const updates = [];
 
-      const [update] = updates.filter(n => n.is_confirmed);
+      sub.on('invoice_updated', updated => updates.push(updated));
 
-      if (!update) {
-        throw new Error('ExpectedPaidInvoiceUpdate');
-      }
+      const update = await asyncRetry({interval, times}, async () => {
+        await pay({
+          lnd: target.lnd,
+          request: (await createInvoice({lnd, tokens})).request,
+        });
 
-      return update;
-    });
+        const [update] = updates.filter(n => n.is_confirmed);
 
-    equal(!!update.confirmed_at, true, 'Got receive date');
-    equal(!!update.confirmed_index, true, 'Got confirm index');
-    equal(update.payments.length, 1, 'Got received HTLC');
-    equal(update.received, tokens, 'Got received tokens');
-    equal(update.received_mtokens, '10000000', 'Got invoice mtokens');
+        if (!update) {
+          throw new Error('ExpectedPaidInvoiceUpdate');
+        }
 
-    sub.removeAllListeners();
-  }
+        return update;
+      });
 
-  // Old invoices are emitted
-  {
-    const sub = subscribeToInvoices({
-      lnd,
-      added_after: 1,
-      restart_delay_ms: 1,
-    });
+      equal(!!update.confirmed_at, true, 'Got receive date');
+      equal(!!update.confirmed_index, true, 'Got confirm index');
+      equal(update.payments.length, 1, 'Got received HTLC');
+      equal(update.received, tokens, 'Got received tokens');
+      equal(update.received_mtokens, '10000000', 'Got invoice mtokens');
+
+      sub.removeAllListeners();
+    }
+
+    // Old invoices are emitted
+    {
+      const sub = subscribeToInvoices({
+        lnd,
+        added_after: 1,
+        restart_delay_ms: 1,
+      });
 
-    const updates = [];
+      const updates = [];
 
-    sub.on('invoice_updated', updated => updates.push(updated));
+      sub.on('invoice_updated', updated => updates.push(updated));
 
-    const update = await asyncRetry({interval, times}, async () => {
-      const [update] = updates;
+      const update = await asyncRetry({interval, times}, async () => {
+        const [update] = updates;
 
-      if (!update) {
-        throw new Error('ExpectedPastInvoiceUpdate');
-      }
+        if (!update) {
+          throw new Error('ExpectedPastInvoiceUpdate');
+        }
 
-      return update;
-    });
+        return update;
+      });
 
-    equal(update.index, 2, 'Got past update');
+      equal(update.index, 2, 'Got past update');
 
-    sub.removeAllListeners();
+      sub.removeAllListeners();
+    }
+  } catch (err) {
+    equal(err, null, 'Expected no error');
+  } finally {
+    await kill({});
   }
 
-  await kill({});
-
   return end();
 });

package/test/integration/test_subscribe_to_peer_messages.js

@@ -17,10 +17,12 @@ test(`Subscribe to peer messages`, async ({end, equal, strictSame}) => {
   const [{lnd}, target, remote] = nodes;
 
   try {
-    await addPeer({
-      lnd,
-      public_key: target.id,
-      socket: target.socket,
+    await asyncRetry({interval, times}, async () => {
+      await addPeer({
+        lnd,
+        public_key: target.id,
+        socket: target.socket,
+      });
     });
 
     await addPeer({

package/test/integration/test_subscribe_to_peers.js

@@ -20,36 +20,40 @@ test(`Subscribe to peers`, async ({end, equal}) => {
 
   const [{generate, lnd}, target] = nodes;
 
-  const sub = subscribeToPeers({lnd});
+  try {
+    const sub = subscribeToPeers({lnd});
 
-  sub.on('error', () => {});
+    sub.on('error', () => {});
 
-  await asyncRetry({interval, times}, async () => {
-    await addPeer({lnd, public_key: target.id, socket: target.socket});
-  });
+    await asyncRetry({interval, times}, async () => {
+      await addPeer({lnd, public_key: target.id, socket: target.socket});
+    });
 
-  const disconnect = removePeer({lnd, public_key: target.id});
-  const receiveDisconnect = once(sub, 'disconnected');
+    const disconnect = removePeer({lnd, public_key: target.id});
+    const receiveDisconnect = once(sub, 'disconnected');
 
-  const [disconectMessage] = await all([receiveDisconnect, disconnect]);
+    const [disconectMessage] = await all([receiveDisconnect, disconnect]);
 
-  const [disconnected] = disconectMessage;
+    const [disconnected] = disconectMessage;
 
-  equal(disconnected.public_key, target.id, 'Got d/c event');
+    equal(disconnected.public_key, target.id, 'Got d/c event');
 
-  const connect = asyncRetry({interval, times}, async () => {
-    return addPeer({lnd, public_key: target.id, socket: target.socket});
-  });
+    const connect = asyncRetry({interval, times}, async () => {
+      return addPeer({lnd, public_key: target.id, socket: target.socket});
+    });
 
-  const receiveConnectMessage = once(sub, 'connected');
+    const receiveConnectMessage = once(sub, 'connected');
 
-  const [connectMessage] = await all([receiveConnectMessage, connect]);
+    const [connectMessage] = await all([receiveConnectMessage, connect]);
 
-  const [connected] = connectMessage;
+    const [connected] = connectMessage;
 
-  equal(connected.public_key, target.id, 'Got connected');
-
-  await kill({});
+    equal(connected.public_key, target.id, 'Got connected');
+  } catch (err) {
+    equal(err, null, 'Expected no error');
+  } finally {
+    await kill({});
+  }
 
   return end();
 });

package/test/invoicesrpc-integration/test_get_sweep_transactions.js

@@ -10,10 +10,8 @@ const {closeChannel} = require('./../../');
 const {createHodlInvoice} = require('./../../');
 const {delay} = require('./../macros');
 const {getChainTransactions} = require('./../../');
-const {getChannels} = require('./../../');
 const {getClosedChannels} = require('./../../');
 const {getInvoice} = require('./../../');
-const {getInvoices} = require('./../../');
 const {getPendingChannels} = require('./../../');
 const {getSweepTransactions} = require('./../../');
 const {getWalletInfo} = require('./../../');

package/test/invoicesrpc-integration/test_subscribe_cancel_invoice.js

@@ -8,7 +8,6 @@ const {cancelHodlInvoice} = require('./../../');
 const {createHodlInvoice} = require('./../../');
 const {delay} = require('./../macros');
 const {getInvoice} = require('./../../');
-const {getInvoices} = require('./../../');
 const {pay} = require('./../../');
 const {setupChannel} = require('./../macros');
 const {subscribeToInvoice} = require('./../../');

package/test/macros/wait_for_channel.js

@@ -6,7 +6,7 @@ const {getChannel} = require('./../../');
 const {getChannels} = require('./../../');
 
 const interval = 10;
-const times = 6000;
+const times = 10000;
 
 /** Wait for channel to be open
 

package/test/routerrpc-integration/test_delete_forwarding_reputations.js

@@ -1,3 +1,4 @@
+const asyncRetry = require('async/retry');
 const {spawnLightningCluster} = require('ln-docker-daemons');
 const {test} = require('@alexbosworth/tap');
 
@@ -5,12 +6,17 @@ const {addPeer} = require('./../../');
 const {createInvoice} = require('./../../');
 const {deleteForwardingReputations} = require('./../../');
 const {getForwardingReputations} = require('./../../');
+const {getNetworkGraph} = require('./../../');
 const {payViaPaymentRequest} = require('./../../');
 const {probeForRoute} = require('./../../');
 const {setupChannel} = require('./../macros');
 const {waitForRoute} = require('./../macros');
 
+const flatten = arr => [].concat(...arr);
+const interval = 10;
 const size = 3;
+const times = 1000;
+const tlvOnionBit = 14;
 const tokens = 1e6 / 2;
 
 // Deleting forwarding reputations should eliminate forwarding reputations
@@ -19,45 +25,73 @@ test('Delete forwarding reputations', async ({end, equal}) => {
 
   const [{generate, lnd}, target, remote] = nodes;
 
-  const controlToTargetChan = await setupChannel({generate, lnd, to: target});
+  try {
+    const controlToTargetChan = await setupChannel({
+      generate,
+      lnd,
+      to: target,
+    });
 
-  const targetToRemoteChan = await setupChannel({
-    generate: target.generate,
-    lnd: target.lnd,
-    to: remote,
-  });
+    const targetToRemoteChan = await setupChannel({
+      generate: target.generate,
+      lnd: target.lnd,
+      to: remote,
+    });
 
-  await addPeer({lnd, public_key: remote.id, socket: remote.socket});
+    await addPeer({lnd, public_key: remote.id, socket: remote.socket});
 
-  const {id, request} = await createInvoice({tokens, lnd: remote.lnd});
+    const {id, request} = await createInvoice({tokens, lnd: remote.lnd});
 
-  await waitForRoute({lnd, tokens, destination: remote.id});
+    await asyncRetry({interval, times}, async () => {
+      const {channels, nodes} = await getNetworkGraph({lnd});
 
-  try {
-    await payViaPaymentRequest({lnd, request});
-  } catch (err) {
-    equal(err, null, 'Expected no error paying payment request');
-  }
+      const limitedFeatures = nodes.find(node => {
+        return !node.features.find(n => n.bit === tlvOnionBit);
+      });
 
-  try {
-    await probeForRoute({lnd, tokens, destination: remote.id});
-  } catch (err) {}
+      const policies = flatten(channels.map(n => n.policies));
 
-  {
-    const {nodes} = await getForwardingReputations({lnd});
+      const cltvDeltas = policies.map(n => n.cltv_delta);
 
-    equal(nodes.length, 2, 'Reputations should exist');
-  }
+      if (!!cltvDeltas.filter(n => !n).length) {
+        throw new Error('ExpectedAllChannelPolicies');
+      }
 
-  await deleteForwardingReputations({lnd});
+      if (!!limitedFeatures) {
+        throw new Error('NetworkGraphSyncIncomplete');
+      }
+    });
 
-  {
-    const {nodes} = await getForwardingReputations({lnd});
+    await waitForRoute({lnd, tokens, destination: remote.id});
 
-    equal(nodes.length, [].length, 'Reputations should be wiped');
-  }
+    try {
+      await payViaPaymentRequest({lnd, request});
+    } catch (err) {
+      equal(err, null, 'Expected no error paying payment request');
+    }
 
-  await kill({});
+    try {
+      await probeForRoute({lnd, tokens, destination: remote.id});
+    } catch (err) {}
+
+    {
+      const {nodes} = await getForwardingReputations({lnd});
+
+      equal(nodes.length, 2, 'Reputations should exist');
+    }
+
+    await deleteForwardingReputations({lnd});
+
+    {
+      const {nodes} = await getForwardingReputations({lnd});
+
+      equal(nodes.length, [].length, 'Reputations should be wiped');
+    }
+  } catch (err) {
+    equal(err, null, 'Expected no error');
+  } finally {
+    await kill({});
+  }
 
   return end();
 });

package/test/routerrpc-integration/test_get_forwarding_reputations.js

@@ -5,7 +5,7 @@ const {test} = require('@alexbosworth/tap');
 const {addPeer} = require('./../../');
 const {getChannels} = require('./../../');
 const {getForwardingReputations} = require('./../../');
-const {payViaRoutes} = require('./../../');
+const {getNetworkGraph} = require('./../../');
 const {probeForRoute} = require('./../../');
 const {setupChannel} = require('./../macros');
 const {waitForRoute} = require('./../macros');
@@ -15,9 +15,12 @@ const channelCapacityTokens = 1e6;
 const confirmationCount = 20;
 const defaultFee = 1e3;
 const defaultOdds = 950000;
+const flatten = arr => [].concat(...arr);
 const interval = 10;
+const maturity = 100;
 const size = 3;
 const times = 2000;
+const tlvOnionBit = 14;
 const tokens = 1e6 / 2;
 
 // Getting forwarding reputations should return reputations
@@ -26,9 +29,9 @@ test('Get forwarding reputations', async ({end, equal}) => {
 
   const [{generate, id, lnd}, target, remote] = cluster.nodes;
 
-  await generate({count: 100});
-
   try {
+    await generate({count: maturity});
+
     // Create a channel from the control to the target node
     await setupChannel({
       generate,
@@ -45,22 +48,47 @@ test('Get forwarding reputations', async ({end, equal}) => {
     });
 
     await asyncRetry({interval, times}, async () => {
-      await addPeer({lnd, public_key: remote.id, socket: remote.socket});
+      const {channels, nodes} = await getNetworkGraph({lnd});
+
+      const limitedFeatures = nodes.find(node => {
+        return !node.features.find(n => n.bit === tlvOnionBit);
+      });
+
+      const policies = flatten(channels.map(n => n.policies));
+
+      const cltvDeltas = policies.map(n => n.cltv_delta);
+
+      if (!!cltvDeltas.filter(n => !n).length) {
+        throw new Error('ExpectedAllChannelPolicies');
+      }
+
+      if (!!limitedFeatures) {
+        throw new Error('NetworkGraphSyncIncomplete');
+      }
+    });
+
+    await asyncRetry({interval, times}, async () => {
+      await generate({});
+
+      await addPeer({
+        lnd,
+        public_key: remote.id,
+        socket: remote.socket,
+        retry_count: 1,
+        retry_delay: 1,
+        timeout: 1,
+      });
 
       const {channels} = await getChannels({lnd: remote.lnd});
 
       await waitForRoute({lnd, tokens, destination: remote.id});
 
-      try {
-        const res = await probeForRoute({
-          lnd,
-          tokens,
-          destination: remote.id,
-          is_ignoring_past_failures: true,
-        });
-      } catch (err) {
-        equal(err, null, 'Expected no error probing');
-      }
+      await probeForRoute({
+        lnd,
+        tokens,
+        destination: remote.id,
+        is_ignoring_past_failures: true,
+      });
 
       const {nodes} = await getForwardingReputations({lnd});