ln-service 53.6.0 → 53.7.3

package/test/routerrpc-integration/test_delete_forwarding_reputations.js

@@ -1,3 +1,4 @@
+const asyncRetry = require('async/retry');
 const {spawnLightningCluster} = require('ln-docker-daemons');
 const {test} = require('@alexbosworth/tap');
 
@@ -5,12 +6,17 @@ const {addPeer} = require('./../../');
 const {createInvoice} = require('./../../');
 const {deleteForwardingReputations} = require('./../../');
 const {getForwardingReputations} = require('./../../');
+const {getNetworkGraph} = require('./../../');
 const {payViaPaymentRequest} = require('./../../');
 const {probeForRoute} = require('./../../');
 const {setupChannel} = require('./../macros');
 const {waitForRoute} = require('./../macros');
 
+const flatten = arr => [].concat(...arr);
+const interval = 10;
 const size = 3;
+const times = 1000;
+const tlvOnionBit = 14;
 const tokens = 1e6 / 2;
 
 // Deleting forwarding reputations should eliminate forwarding reputations
@@ -19,45 +25,73 @@ test('Delete forwarding reputations', async ({end, equal}) => {
 
   const [{generate, lnd}, target, remote] = nodes;
 
-  const controlToTargetChan = await setupChannel({generate, lnd, to: target});
+  try {
+    const controlToTargetChan = await setupChannel({
+      generate,
+      lnd,
+      to: target,
+    });
 
-  const targetToRemoteChan = await setupChannel({
-    generate: target.generate,
-    lnd: target.lnd,
-    to: remote,
-  });
+    const targetToRemoteChan = await setupChannel({
+      generate: target.generate,
+      lnd: target.lnd,
+      to: remote,
+    });
 
-  await addPeer({lnd, public_key: remote.id, socket: remote.socket});
+    await addPeer({lnd, public_key: remote.id, socket: remote.socket});
 
-  const {id, request} = await createInvoice({tokens, lnd: remote.lnd});
+    const {id, request} = await createInvoice({tokens, lnd: remote.lnd});
 
-  await waitForRoute({lnd, tokens, destination: remote.id});
+    await asyncRetry({interval, times}, async () => {
+      const {channels, nodes} = await getNetworkGraph({lnd});
 
-  try {
-    await payViaPaymentRequest({lnd, request});
-  } catch (err) {
-    equal(err, null, 'Expected no error paying payment request');
-  }
+      const limitedFeatures = nodes.find(node => {
+        return !node.features.find(n => n.bit === tlvOnionBit);
+      });
 
-  try {
-    await probeForRoute({lnd, tokens, destination: remote.id});
-  } catch (err) {}
+      const policies = flatten(channels.map(n => n.policies));
 
-  {
-    const {nodes} = await getForwardingReputations({lnd});
+      const cltvDeltas = policies.map(n => n.cltv_delta);
 
-    equal(nodes.length, 2, 'Reputations should exist');
-  }
+      if (!!cltvDeltas.filter(n => !n).length) {
+        throw new Error('ExpectedAllChannelPolicies');
+      }
 
-  await deleteForwardingReputations({lnd});
+      if (!!limitedFeatures) {
+        throw new Error('NetworkGraphSyncIncomplete');
+      }
+    });
 
-  {
-    const {nodes} = await getForwardingReputations({lnd});
+    await waitForRoute({lnd, tokens, destination: remote.id});
 
-    equal(nodes.length, [].length, 'Reputations should be wiped');
-  }
+    try {
+      await payViaPaymentRequest({lnd, request});
+    } catch (err) {
+      equal(err, null, 'Expected no error paying payment request');
+    }
 
-  await kill({});
+    try {
+      await probeForRoute({lnd, tokens, destination: remote.id});
+    } catch (err) {}
+
+    {
+      const {nodes} = await getForwardingReputations({lnd});
+
+      equal(nodes.length, 2, 'Reputations should exist');
+    }
+
+    await deleteForwardingReputations({lnd});
+
+    {
+      const {nodes} = await getForwardingReputations({lnd});
+
+      equal(nodes.length, [].length, 'Reputations should be wiped');
+    }
+  } catch (err) {
+    equal(err, null, 'Expected no error');
+  } finally {
+    await kill({});
+  }
 
   return end();
 });

package/test/routerrpc-integration/test_get_forwarding_reputations.js

@@ -5,7 +5,7 @@ const {test} = require('@alexbosworth/tap');
 const {addPeer} = require('./../../');
 const {getChannels} = require('./../../');
 const {getForwardingReputations} = require('./../../');
-const {payViaRoutes} = require('./../../');
+const {getNetworkGraph} = require('./../../');
 const {probeForRoute} = require('./../../');
 const {setupChannel} = require('./../macros');
 const {waitForRoute} = require('./../macros');
@@ -15,9 +15,12 @@ const channelCapacityTokens = 1e6;
 const confirmationCount = 20;
 const defaultFee = 1e3;
 const defaultOdds = 950000;
+const flatten = arr => [].concat(...arr);
 const interval = 10;
+const maturity = 100;
 const size = 3;
 const times = 2000;
+const tlvOnionBit = 14;
 const tokens = 1e6 / 2;
 
 // Getting forwarding reputations should return reputations
@@ -26,66 +29,95 @@ test('Get forwarding reputations', async ({end, equal}) => {
 
   const [{generate, id, lnd}, target, remote] = cluster.nodes;
 
-  await generate({count: 400});
+  try {
+    await generate({count: maturity});
+
+    // Create a channel from the control to the target node
+    await setupChannel({
+      generate,
+      lnd,
+      capacity: channelCapacityTokens * 2,
+      to: target,
+    });
+
+    const targetToRemoteChan = await setupChannel({
+      generate: target.generate,
+      give: Math.round(channelCapacityTokens / 2),
+      lnd: target.lnd,
+      to: remote,
+    });
+
+    await asyncRetry({interval, times}, async () => {
+      const {channels, nodes} = await getNetworkGraph({lnd});
+
+      const limitedFeatures = nodes.find(node => {
+        return !node.features.find(n => n.bit === tlvOnionBit);
+      });
 
-  // Create a channel from the control to the target node
-  await setupChannel({
-    generate,
-    lnd,
-    capacity: channelCapacityTokens * 2,
-    to: target,
-  });
+      const policies = flatten(channels.map(n => n.policies));
 
-  const targetToRemoteChan = await setupChannel({
-    generate: target.generate,
-    give: Math.round(channelCapacityTokens / 2),
-    lnd: target.lnd,
-    to: remote,
-  });
+      const cltvDeltas = policies.map(n => n.cltv_delta);
 
-  await asyncRetry({interval, times}, async () => {
-    await addPeer({lnd, public_key: remote.id, socket: remote.socket});
+      if (!!cltvDeltas.filter(n => !n).length) {
+        throw new Error('ExpectedAllChannelPolicies');
+      }
 
-    const {channels} = await getChannels({lnd: remote.lnd});
+      if (!!limitedFeatures) {
+        throw new Error('NetworkGraphSyncIncomplete');
+      }
+    });
 
-    await waitForRoute({lnd, tokens, destination: remote.id});
+    await asyncRetry({interval, times}, async () => {
+      await generate({});
 
-    try {
-      const res = await probeForRoute({
+      await addPeer({
+        lnd,
+        public_key: remote.id,
+        socket: remote.socket,
+        retry_count: 1,
+        retry_delay: 1,
+        timeout: 1,
+      });
+
+      const {channels} = await getChannels({lnd: remote.lnd});
+
+      await waitForRoute({lnd, tokens, destination: remote.id});
+
+      await probeForRoute({
         lnd,
         tokens,
         destination: remote.id,
         is_ignoring_past_failures: true,
       });
-    } catch (err) {
-      equal(err, null, 'Expected no error probing');
-    }
-
-    const {nodes} = await getForwardingReputations({lnd});
 
-    const [node] = nodes;
+      const {nodes} = await getForwardingReputations({lnd});
 
-    if (!node) {
-      throw new Error('ExpectedForwardingNode');
-    }
+      const [node] = nodes;
 
-    equal(!!node.public_key, true, 'Temp fail node added');
+      if (!node) {
+        throw new Error('ExpectedForwardingNode');
+      }
 
-    const [peer] = node.peers;
+      equal(!!node.public_key, true, 'Temp fail node added');
 
-    if (!peer) {
-      throw new Error('ExpectedNodePeer');
-    }
+      const [peer] = node.peers;
 
-    if (!peer.last_failed_forward_at) {
-      throw new Error('ExpectedLastFailTimeReturned');
-    }
+      if (!peer) {
+        throw new Error('ExpectedNodePeer');
+      }
 
-    equal(!!peer.last_failed_forward_at, true, 'Last fail time returned');
-    equal(!!peer.to_public_key, true, 'Got peer pub key');
-  });
+      if (!peer.last_failed_forward_at) {
+        throw new Error('ExpectedLastFailTimeReturned');
+      }
 
-  await cluster.kill({});
+      equal(!!peer.last_failed_forward_at, true, 'Last fail time returned');
+      equal(!!peer.to_public_key, true, 'Got peer pub key');
+    });
+  } catch (err) {
+    equal(err, null, 'Expected no error');
+  } finally {
+    await cluster.kill({});
+  }
 
   return end();
 });

package/test/routerrpc-integration/test_get_route_confidence.js

@@ -17,41 +17,45 @@ test('Get route confidence', async ({end, equal}) => {
 
   const [{generate, lnd}, target, remote] = nodes;
 
-  // Create a channel from the control to the target node
-  await setupChannel({
-    generate,
-    lnd,
-    capacity: channelCapacityTokens * 2,
-    to: target,
-  });
-
-  // Create a too-small channel from target to remote
-  await setupChannel({
-    generate: target.generate,
-    give: Math.round(channelCapacityTokens / 2),
-    lnd: target.lnd,
-    to: remote,
-  });
-
-  await addPeer({lnd, public_key: remote.id, socket: remote.socket});
-
-  const destination = remote.id;
-
-  // Allow time for graph sync to complete
-  const {routes} = await waitForRoute({destination, lnd, tokens});
-
-  // Run into a failure to inform future pathfinding
   try {
-    await probeForRoute({destination, lnd, tokens});
-  } catch (err) {}
-
-  const [{hops}] = routes;
-
-  const {confidence} = await getRouteConfidence({lnd, hops});
-
-  equal((confidence / 1e6) < 0.1, true, 'Due to fail, odds of success = low');
-
-  await kill({});
+    // Create a channel from the control to the target node
+    await setupChannel({
+      generate,
+      lnd,
+      capacity: channelCapacityTokens * 2,
+      to: target,
+    });
+
+    // Create a too-small channel from target to remote
+    await setupChannel({
+      generate: target.generate,
+      give: Math.round(channelCapacityTokens / 2),
+      lnd: target.lnd,
+      to: remote,
+    });
+
+    await addPeer({lnd, public_key: remote.id, socket: remote.socket});
+
+    const destination = remote.id;
+
+    // Allow time for graph sync to complete
+    const {routes} = await waitForRoute({destination, lnd, tokens});
+
+    // Run into a failure to inform future pathfinding
+    try {
+      await probeForRoute({destination, lnd, tokens});
+    } catch (err) {}
+
+    const [{hops}] = routes;
+
+    const {confidence} = await getRouteConfidence({lnd, hops});
+
+    equal((confidence / 1e6) < 0.1, true, 'Due to fail, odds of success low');
+  } catch (err) {
+    equal(err, null, 'Expected no error');
+  } finally {
+    await kill({});
+  }
 
   return end();
 });

package/test/routerrpc-integration/test_get_route_through_hops.js

@@ -8,17 +8,22 @@ const {addPeer} = require('./../../');
 const {createInvoice} = require('./../../');
 const {decodePaymentRequest} = require('./../../');
 const {getInvoice} = require('./../../');
+const {getNetworkGraph} = require('./../../');
 const {getRouteThroughHops} = require('./../../');
 const {getRouteToDestination} = require('./../../');
 const {getWalletInfo} = require('./../../');
-const {getWalletVersion} = require('./../../');
 const {payViaRoutes} = require('./../../');
 const {setupChannel} = require('./../macros');
 const {waitForRoute} = require('./../macros');
 
 const confirmationCount = 6;
+const flatten = arr => [].concat(...arr);
+const interval = 10;
+const maturity = 100;
 const messages = [{type: '1000000', value: '01'}];
 const size = 3;
+const times = 1000;
+const tlvOnionBit = 14;
 const tokens = 100;
 
 // Getting a route through hops should result in a route through specified hops
@@ -27,8 +32,7 @@ test(`Get route through hops`, async ({end, equal, strictSame}) => {
 
   const [{generate, lnd}, target, remote] = nodes;
 
-  await target.generate({count: 100});
-  await remote.generate({count: 100});
+  await target.generate({count: maturity});
 
   const controlToTargetChan = await setupChannel({generate, lnd, to: target});
 
@@ -40,7 +44,7 @@ test(`Get route through hops`, async ({end, equal, strictSame}) => {
 
   await target.generate({count: confirmationCount});
 
-  await asyncRetry({interval: 10, times: 1000}, async () => {
+  await asyncRetry({interval, times}, async () => {
     const wallet = await getWalletInfo({lnd: remote.lnd});
 
     await addPeer({lnd, public_key: remote.id, socket: remote.socket});
@@ -50,6 +54,26 @@ test(`Get route through hops`, async ({end, equal, strictSame}) => {
     }
   });
 
+  await asyncRetry({interval, times}, async () => {
+    const {channels, nodes} = await getNetworkGraph({lnd});
+
+    const limitedFeatures = nodes.find(node => {
+      return !node.features.find(n => n.bit === tlvOnionBit);
+    });
+
+    const policies = flatten(channels.map(n => n.policies));
+
+    const cltvDeltas = policies.map(n => n.cltv_delta);
+
+    if (!!cltvDeltas.filter(n => !n).length) {
+      throw new Error('ExpectedAllChannelPolicies');
+    }
+
+    if (!!limitedFeatures) {
+      throw new Error('NetworkGraphSyncIncomplete');
+    }
+  });
+
   const invoice = await createInvoice({tokens, lnd: remote.lnd});
 
   const {id} = invoice;
@@ -59,21 +83,25 @@ test(`Get route through hops`, async ({end, equal, strictSame}) => {
 
   await waitForRoute({lnd, destination: remote.id, tokens: invoice.tokens});
 
-  const {route} = await getRouteToDestination({
-    lnd,
-    cltv_delta: decodedRequest.cltv_delta,
-    destination: decodedRequest.destination,
-    tokens: invoice.tokens,
+  const {route} = await asyncRetry({interval, times}, async () => {
+    return await getRouteToDestination({
+      lnd,
+      cltv_delta: decodedRequest.cltv_delta,
+      destination: decodedRequest.destination,
+      tokens: invoice.tokens,
+    });
   });
 
-  const res = await getRouteThroughHops({
-    lnd,
-    messages,
-    cltv_delta: decodedRequest.cltv_delta + 6,
-    mtokens: (BigInt(invoice.tokens) * BigInt(1e3)).toString(),
-    payment: decodedRequest.payment,
-    public_keys: route.hops.map(n => n.public_key),
-    total_mtokens: invoice.mtokens,
+  const res = await asyncRetry({interval, times}, async () => {
+    return await getRouteThroughHops({
+      lnd,
+      messages,
+      cltv_delta: decodedRequest.cltv_delta + 6,
+      mtokens: (BigInt(invoice.tokens) * BigInt(1e3)).toString(),
+      payment: decodedRequest.payment,
+      public_keys: route.hops.map(n => n.public_key),
+      total_mtokens: invoice.mtokens,
+    });
   });
 
   await payViaRoutes({lnd, id: invoice.id, routes: [res.route]});

package/test/routerrpc-integration/test_multipath_payment.js

@@ -4,7 +4,6 @@ const {test} = require('@alexbosworth/tap');
 const {createInvoice} = require('./../../');
 const {getInvoice} = require('./../../');
 const {getRouteToDestination} = require('./../../');
-const {getWalletVersion} = require('./../../');
 const {parsePaymentRequest} = require('./../../');
 const {payViaPaymentRequest} = require('./../../');
 const {payViaRoutes} = require('./../../');