ln-service 53.5.1 → 53.7.1

package/test/integration/test_get_pending_force.js

@@ -177,7 +177,14 @@ test(`Get pending channels`, async ({end, equal}) => {
   equal(forceClose.partner_public_key, target.id, 'pk');
   equal(forceClose.received, 0, 'No receive amount');
   equal(forceClose.recovered_tokens, undefined, 'No recovered amount');
-  equal(forceClose.remote_balance, 0, 'No remote balance');
+
+  // LND 0.14.2 and below do not support remote balance info
+  if (!!forceClose.remote_balance) {
+    equal(forceClose.remote_balance, giftTokens, 'Got gift remote balance');
+  } else {
+    equal(forceClose.remote_balance, 0, 'No remote balance');
+  }
+
   equal(forceClose.sent, 0, 'No sent amount');
   equal(!!forceClose.timelock_blocks, true, 'Timelock blocks set');
   equal(forceClose.timelock_expiration, startHeight + 265, 'Funds timelock');

package/test/integration/test_get_wallet_info.js

@@ -1,11 +1,14 @@
+const asyncRetry = require('async/retry');
 const {spawnLightningCluster} = require('ln-docker-daemons');
 const {test} = require('@alexbosworth/tap');
 
 const {getWalletInfo} = require('./../../');
 
 const initHeight = 1;
+const interval = 10;
 const pubKeyHexLength = Buffer.alloc(33).toString('hex').length;
 const regtestChainId = '06226e46111a0b59caaf126043eb5bbf28c34f3a5e332a1fc7b2b73cf188910f';
+const times = 1000;
 const walletInfoType = 'wallet';
 
 // Getting the wallet info should return info about the wallet
@@ -16,6 +19,14 @@ test(`Get wallet info`, async ({end, equal, strictSame}) => {
 
   const result = await getWalletInfo({lnd});
 
+  await asyncRetry({interval, times}, async () => {
+    if (result.current_block_height === initHeight) {
+      return;
+    }
+
+    throw new Error('ExpectedBlockHeightAtInitHeight');
+  });
+
   equal(result.active_channels_count, 0, 'Expected channels count');
   equal(!!result.alias, true, 'Expected alias');
   strictSame(result.chains, [regtestChainId], 'Got chains');

package/test/integration/test_subscribe_to_channels.js

@@ -16,7 +16,7 @@ const defaultFee = 1e3;
 const giveTokens = 1e5;
 const interval = 100;
 const size = 2;
-const times = 20;
+const times = 200;
 
 // Subscribing to channels should trigger channel events
 test('Subscribe to channels', async ({end, equal, fail}) => {

package/test/integration/test_subscribe_to_peer_messages.js

@@ -16,98 +16,104 @@ test(`Subscribe to peer messages`, async ({end, equal, strictSame}) => {
 
   const [{lnd}, target, remote] = nodes;
 
-  await addPeer({
-    lnd,
-    public_key: target.id,
-    socket: target.socket,
-  });
-
-  await addPeer({
-    lnd: target.lnd,
-    public_key: remote.id,
-    socket: remote.socket,
-  });
-
   try {
-    await sendMessageToPeer({
+    await addPeer({
       lnd,
-      message: Buffer.from('message').toString('hex'),
       public_key: target.id,
+      socket: target.socket,
+    });
+
+    await addPeer({
+      lnd: target.lnd,
+      public_key: remote.id,
+      socket: remote.socket,
     });
-  } catch (err) {
-    const [code] = err;
 
-    // Send message to peer is not supported on LND 0.13.4 or lower
-    if (code === 501) {
-      await kill({});
+    try {
+      await sendMessageToPeer({
+        lnd,
+        message: Buffer.from('message').toString('hex'),
+        public_key: target.id,
+      });
+    } catch (err) {
+      const [code] = err;
 
-      return end();
+      // Send message to peer is not supported on LND 0.13.4 or lower
+      if (code === 501) {
+        await kill({});
+
+        return end();
+      }
     }
-  }
 
-  const messages = [];
-  const targetSub = subscribeToPeerMessages({lnd: target.lnd});
-  const remoteSub = subscribeToPeerMessages({lnd: remote.lnd});
-  const targetMessages = [];
+    const messages = [];
+    const targetSub = subscribeToPeerMessages({lnd: target.lnd});
+    const remoteSub = subscribeToPeerMessages({lnd: remote.lnd});
+    const targetMessages = [];
 
-  remoteSub.on('message_received', message => messages.push(message));
+    remoteSub.on('message_received', message => messages.push(message));
 
-  targetSub.on('message_received', async ({message, type}) => {
-    targetMessages.push(message);
+    targetSub.on('message_received', async ({message, type}) => {
+      targetMessages.push(message);
 
-    if (type !== 40805) {
-      return;
-    }
+      if (type !== 40805) {
+        return;
+      }
+
+      // Wait for message to appear
+      return await asyncRetry({interval, times}, async () => {
+      // Relay message from control to remote
+        await sendMessageToPeer({
+          message,
+          type,
+          lnd: target.lnd,
+          public_key: remote.id,
+        });
+
+        if (!messages.length) {
+          throw new Error('ExpectedMessage');
+        }
+      });
+    });
 
     // Wait for message to appear
-    return await asyncRetry({interval, times}, async () => {
-    // Relay message from control to remote
+    await asyncRetry({interval, times}, async () => {
+      // Control send a message to target peer
       await sendMessageToPeer({
-        message,
-        type,
-        lnd: target.lnd,
-        public_key: remote.id,
+        lnd,
+        message: Buffer.from('message to remote').toString('hex'),
+        public_key: target.id,
+        type: 40805,
       });
 
-      if (!messages.length) {
-        throw new Error('ExpectedMessage');
+      if (!targetMessages.length) {
+        throw new Error('ExpectedTargetMessageReceived');
       }
     });
-  });
 
-  // Wait for message to appear
-  await asyncRetry({interval, times}, async () => {
-    // Control send a message to target peer
-    await sendMessageToPeer({
-      lnd,
-      message: Buffer.from('message to remote').toString('hex'),
-      public_key: target.id,
-      type: 40805,
+    // Wait for message to appear
+    await asyncRetry({interval, times}, async () => {
+      if (!messages.length) {
+        throw new Error('ExpectedMessage');
+      }
     });
 
-    if (!targetMessages.length) {
-      throw new Error('ExpectedTargetMessageReceived');
-    }
-  });
-
-  // Wait for message to appear
-  await asyncRetry({interval, times}, async () => {
-    if (!messages.length) {
-      throw new Error('ExpectedMessage');
-    }
-  });
-
-  strictSame(
-    messages,
-    [{
-      message: Buffer.from('message to remote').toString('hex'),
-      public_key: target.id,
-      type: 40805,
-    }],
-    'Message successfully relayed through target'
-  );
-
-  await kill({});
+    const [message] = messages;
+
+    strictSame(
+      message,
+      {
+        message: Buffer.from('message to remote').toString('hex'),
+        public_key: target.id,
+        type: 40805,
+      },
+      'Message successfully relayed through target'
+    );
+  } catch (err) {
+    equal(err, null, 'Expected no error');
+  } finally {
+    await kill({});
+  }
 
   return end();
 });

package/test/routerrpc-integration/test_get_forwarding_reputations.js

@@ -26,66 +26,70 @@ test('Get forwarding reputations', async ({end, equal}) => {
 
   const [{generate, id, lnd}, target, remote] = cluster.nodes;
 
-  await generate({count: 400});
-
-  // Create a channel from the control to the target node
-  await setupChannel({
-    generate,
-    lnd,
-    capacity: channelCapacityTokens * 2,
-    to: target,
-  });
-
-  const targetToRemoteChan = await setupChannel({
-    generate: target.generate,
-    give: Math.round(channelCapacityTokens / 2),
-    lnd: target.lnd,
-    to: remote,
-  });
-
-  await asyncRetry({interval, times}, async () => {
-    await addPeer({lnd, public_key: remote.id, socket: remote.socket});
-
-    const {channels} = await getChannels({lnd: remote.lnd});
-
-    await waitForRoute({lnd, tokens, destination: remote.id});
-
-    try {
-      const res = await probeForRoute({
-        lnd,
-        tokens,
-        destination: remote.id,
-        is_ignoring_past_failures: true,
-      });
-    } catch (err) {
-      equal(err, null, 'Expected no error probing');
-    }
-
-    const {nodes} = await getForwardingReputations({lnd});
-
-    const [node] = nodes;
-
-    if (!node) {
-      throw new Error('ExpectedForwardingNode');
-    }
-
-    equal(!!node.public_key, true, 'Temp fail node added');
-
-    const [peer] = node.peers;
-
-    if (!peer) {
-      throw new Error('ExpectedNodePeer');
-    }
-
-    if (!peer.last_failed_forward_at) {
-      throw new Error('ExpectedLastFailTimeReturned');
-    }
-
-    equal(!!peer.last_failed_forward_at, true, 'Last fail time returned');
-    equal(!!peer.to_public_key, true, 'Got peer pub key');
-  });
-
-  await cluster.kill({});
+  await generate({count: 100});
+
+  try {
+    // Create a channel from the control to the target node
+    await setupChannel({
+      generate,
+      lnd,
+      capacity: channelCapacityTokens * 2,
+      to: target,
+    });
+
+    const targetToRemoteChan = await setupChannel({
+      generate: target.generate,
+      give: Math.round(channelCapacityTokens / 2),
+      lnd: target.lnd,
+      to: remote,
+    });
+
+    await asyncRetry({interval, times}, async () => {
+      await addPeer({lnd, public_key: remote.id, socket: remote.socket});
+
+      const {channels} = await getChannels({lnd: remote.lnd});
+
+      await waitForRoute({lnd, tokens, destination: remote.id});
+
+      try {
+        const res = await probeForRoute({
+          lnd,
+          tokens,
+          destination: remote.id,
+          is_ignoring_past_failures: true,
+        });
+      } catch (err) {
+        equal(err, null, 'Expected no error probing');
+      }
+
+      const {nodes} = await getForwardingReputations({lnd});
+
+      const [node] = nodes;
+
+      if (!node) {
+        throw new Error('ExpectedForwardingNode');
+      }
+
+      equal(!!node.public_key, true, 'Temp fail node added');
+
+      const [peer] = node.peers;
+
+      if (!peer) {
+        throw new Error('ExpectedNodePeer');
+      }
+
+      if (!peer.last_failed_forward_at) {
+        throw new Error('ExpectedLastFailTimeReturned');
+      }
+
+      equal(!!peer.last_failed_forward_at, true, 'Last fail time returned');
+      equal(!!peer.to_public_key, true, 'Got peer pub key');
+    });
+  } catch (err) {
+    equal(err, null, 'Expected no error');
+  } finally {
+    await cluster.kill({});
+  }
 
   return end();
 });

package/test/routerrpc-integration/test_get_route_confidence.js

@@ -17,41 +17,45 @@ test('Get route confidence', async ({end, equal}) => {
 
   const [{generate, lnd}, target, remote] = nodes;
 
-  // Create a channel from the control to the target node
-  await setupChannel({
-    generate,
-    lnd,
-    capacity: channelCapacityTokens * 2,
-    to: target,
-  });
-
-  // Create a too-small channel from target to remote
-  await setupChannel({
-    generate: target.generate,
-    give: Math.round(channelCapacityTokens / 2),
-    lnd: target.lnd,
-    to: remote,
-  });
-
-  await addPeer({lnd, public_key: remote.id, socket: remote.socket});
-
-  const destination = remote.id;
-
-  // Allow time for graph sync to complete
-  const {routes} = await waitForRoute({destination, lnd, tokens});
-
-  // Run into a failure to inform future pathfinding
   try {
-    await probeForRoute({destination, lnd, tokens});
-  } catch (err) {}
-
-  const [{hops}] = routes;
-
-  const {confidence} = await getRouteConfidence({lnd, hops});
-
-  equal((confidence / 1e6) < 0.1, true, 'Due to fail, odds of success = low');
-
-  await kill({});
+    // Create a channel from the control to the target node
+    await setupChannel({
+      generate,
+      lnd,
+      capacity: channelCapacityTokens * 2,
+      to: target,
+    });
+
+    // Create a too-small channel from target to remote
+    await setupChannel({
+      generate: target.generate,
+      give: Math.round(channelCapacityTokens / 2),
+      lnd: target.lnd,
+      to: remote,
+    });
+
+    await addPeer({lnd, public_key: remote.id, socket: remote.socket});
+
+    const destination = remote.id;
+
+    // Allow time for graph sync to complete
+    const {routes} = await waitForRoute({destination, lnd, tokens});
+
+    // Run into a failure to inform future pathfinding
+    try {
+      await probeForRoute({destination, lnd, tokens});
+    } catch (err) {}
+
+    const [{hops}] = routes;
+
+    const {confidence} = await getRouteConfidence({lnd, hops});
+
+    equal((confidence / 1e6) < 0.1, true, 'Due to fail, odds of success low');
+  } catch (err) {
+    equal(err, null, 'Expected no error');
+  } finally {
+    await kill({});
+  }
 
   return end();
 });

package/test/routerrpc-integration/test_get_route_through_hops.js

@@ -8,6 +8,7 @@ const {addPeer} = require('./../../');
 const {createInvoice} = require('./../../');
 const {decodePaymentRequest} = require('./../../');
 const {getInvoice} = require('./../../');
+const {getNetworkGraph} = require('./../../');
 const {getRouteThroughHops} = require('./../../');
 const {getRouteToDestination} = require('./../../');
 const {getWalletInfo} = require('./../../');
@@ -17,8 +18,10 @@ const {setupChannel} = require('./../macros');
 const {waitForRoute} = require('./../macros');
 
 const confirmationCount = 6;
+const interval = 10;
 const messages = [{type: '1000000', value: '01'}];
 const size = 3;
+const times = 1000;
 const tokens = 100;
 
 // Getting a route through hops should result in a route through specified hops
@@ -40,7 +43,7 @@ test(`Get route through hops`, async ({end, equal, strictSame}) => {
 
   await target.generate({count: confirmationCount});
 
-  await asyncRetry({interval: 10, times: 1000}, async () => {
+  await asyncRetry({interval, times}, async () => {
     const wallet = await getWalletInfo({lnd: remote.lnd});
 
     await addPeer({lnd, public_key: remote.id, socket: remote.socket});
@@ -59,11 +62,25 @@ test(`Get route through hops`, async ({end, equal, strictSame}) => {
 
   await waitForRoute({lnd, destination: remote.id, tokens: invoice.tokens});
 
-  const {route} = await getRouteToDestination({
-    lnd,
-    cltv_delta: decodedRequest.cltv_delta,
-    destination: decodedRequest.destination,
-    tokens: invoice.tokens,
+  const {route} = await asyncRetry({interval, times}, async () => {
+    return await getRouteToDestination({
+      lnd,
+      cltv_delta: decodedRequest.cltv_delta,
+      destination: decodedRequest.destination,
+      tokens: invoice.tokens,
+    });
+  });
+
+  await asyncRetry({interval, times}, async () => {
+    const {nodes} = await getNetworkGraph({lnd});
+
+    const limitedFeatures = nodes.find(node => {
+      return !node.features.find(n => n.bit === 14);
+    });
+
+    if (!!limitedFeatures) {
+      throw new Error('NetworkGraphSyncIncomplete');
+    }
   });
 
   const res = await getRouteThroughHops({

package/test/routerrpc-integration/test_pay_via_routes.js

@@ -18,6 +18,7 @@ const {openChannel} = require('./../../');
 const {payViaRoutes} = require('./../../');
 const {routeFromChannels} = require('./../../');
 const {setupChannel} = require('./../macros');
+const {subscribeToForwardRequests} = require('./../../');
 const {waitForChannel} = require('./../macros');
 const {waitForPendingChannel} = require('./../macros');
 const {waitForRoute} = require('./../macros');
@@ -27,6 +28,7 @@ const confirmationCount = 6;
 const defaultFee = 1e3;
 const defaultVout = 0;
 const interval = 10;
+const intermediateRecord = {type: '65536', value: '5678'};
 const mtokPadding = '000';
 const regtestChain = '0f9188f13cb7b2c71f2a335e3a4fc328bf5beb436012afca590b1a11466e2206';
 const reserveRatio = 0.99;
@@ -39,7 +41,7 @@ const tokens = 100;
 const txIdHexLength = 32 * 2;
 
 // Paying via routes should successfully pay via routes
-test(`Pay via routes`, async ({end, equal}) => {
+test(`Pay via routes`, async ({end, equal, strictSame}) => {
   const {kill, nodes} = await spawnLightningCluster({size});
 
   const [{generate, lnd}, target, remote] = nodes;
@@ -170,10 +172,26 @@ test(`Pay via routes`, async ({end, equal}) => {
     equal(lowFeeErrMessage, 'FeeInsufficient', 'Low fee returns low fee msg');
   }
 
+  const [hopToTarget] = route.hops;
+
+  hopToTarget.messages = [intermediateRecord];
+
   route.messages = [{type: tlvType, value: tlvValue}];
 
+  const sub = subscribeToForwardRequests({lnd: target.lnd});
+
+  const forwardMessages = [];
+
+  sub.on('forward_request', request => {
+    request.messages.forEach(message => forwardMessages.push(message));
+
+    return request.accept();
+  });
+
   const payment = await payViaRoutes({id, lnd, routes: [route]});
 
+  strictSame(forwardMessages, [intermediateRecord], 'Got intermediate record');
+
   equal(payment.confirmed_at > start, true, 'Paid has confirm date');
 
   const paidInvoice = await getInvoice({id, lnd: remote.lnd});

package/test/routerrpc-integration/test_subscribe_to_forward_requests.js

@@ -20,8 +20,8 @@ const {waitForRoute} = require('./../macros');
 const size = 3;
 const tokens = 100;
 
-// Paying an invoice should settle the invoice
-test(`Pay via payment request`, async ({end, equal, rejects, strictSame}) => {
+// Subscribing to forward requests should intercept forwards
+test(`Subscribe to requests`, async ({end, equal, rejects, strictSame}) => {
   const {kill, nodes} = await spawnLightningCluster({size});
 
   const [{generate, lnd}, target, remote] = nodes;