llm-switcher 1.2.5 → 1.2.6

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog — LLM Switcher
 
+## Release 1.2.6
+
+- **Deactivate in the dashboard:** The Deactivate button did not change the configuration, but the dashboard showed "deactivated". The dashboard sends `deactivate: true` and the profile key in `profile`. The gateway read `deactivate` as the profile key, so no target matched. Now `POST /api/switch` accepts both forms: `{"profile": "x", "deactivate": true}` and `{"deactivate": "x"}`.
+- **No silent success:** If the profile is not active, `POST /api/switch` now answers `404` with the error `Profile "x" is not active`. If `deactivate` is `true` and no profile is named, it answers `400`. Before, both requests answered `200` with `success: true`.
+
 ## Release 1.2.5
 
 - **Dashboard controls:** The dashboard controls use MIT elements from Uiverse.io galaxy as a base. The CSS gives the name of each author.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "llm-switcher",
-  "version": "1.2.5",
+  "version": "1.2.6",
   "description": "Zero-dependency multi-protocol edge gateway & provider switcher for Claude Code, Codex, OpenAI and Gemini clients",
   "keywords": [
     "llm",

package/proxy.mjs

@@ -1367,7 +1367,12 @@ async function routeConfigApi(res, method, pathname, body) {
   if (pathname === '/api/switch') {
     let err = null;
     if (body.deactivate) {
-      deactivateProfile(cfg, body.deactivate);
+      // The dashboard sends `deactivate: true` with the key in `profile`; the CLI sends the key itself.
+      const key = body.deactivate === true ? body.profile : body.deactivate;
+      if (typeof key !== 'string' || !key) return sendJson(res, 400, { error: 'deactivate needs a profile key' });
+      // A no-op must not answer success: the dashboard trusts `success` alone.
+      if (!isProfileActive(cfg, key)) return sendJson(res, 404, { error: `Profile "${key}" is not active` });
+      deactivateProfile(cfg, key);
     } else if (body.target) {
       err = setTargetProfile(cfg, body.target, body.profile || null);
     } else if (body.profile) {

package/switch.cmd

@@ -1,2 +1,2 @@
-@echo off
-node "%~dp0switch.mjs" %*
+@echo off
+node "%~dp0switch.mjs" %*

package/tests/gateway.e2e.test.mjs

@@ -1208,3 +1208,30 @@ test('Admin test-upstream reports latency and a sample from the upstream', async
   assert.match(json.sample, /Final answer/);
   assert.equal(typeof json.latency, 'number');
 });
+
+// Runs last: turning `codex` off and on stops and restarts the shared interceptor, which the
+// Codex WebSocket tests above depend on.
+test('/api/switch deactivate: the dashboard payload works, the CLI payload works, a no-op is an error', async () => {
+  try {
+    // What the dashboard sends: the profile in `profile`, a boolean in `deactivate`.
+    const dash = await post('/api/switch', { profile: 'chat', deactivate: true });
+    assert.equal(dash.status, 200);
+    assert.deepEqual((await dash.json()).activeProfiles, { claude: null, codex: null });
+
+    // The same profile is now inactive, so asking again must not report success.
+    const again = await post('/api/switch', { profile: 'chat', deactivate: true });
+    assert.equal(again.status, 404);
+    assert.match((await again.json()).error, /not active/);
+
+    // What the CLI sends: the profile key in `deactivate`.
+    assert.equal((await post('/api/switch', { profile: 'chat' })).status, 200);
+    const cli = await post('/api/switch', { deactivate: 'chat' });
+    assert.equal(cli.status, 200);
+    assert.deepEqual((await cli.json()).activeProfiles, { claude: null, codex: null });
+
+    // `deactivate: true` with no profile names nothing.
+    assert.equal((await post('/api/switch', { deactivate: true })).status, 400);
+  } finally {
+    await post('/api/switch', { profile: 'chat' });
+  }
+});