llm-mock-server 1.0.6 → 1.0.7

package/.desloppify/subagents/runs/20260315_185613/holistic_findings_merged.json

@@ -1,741 +0,0 @@
-{
-  "assessments": {
-    "abstraction_fitness": {
-      "score": 79.3,
-      "components": [
-        "Abstraction Leverage",
-        "Indirection Cost",
-        "Interface Honesty"
-      ],
-      "component_scores": {
-        "Abstraction Leverage": 82.0,
-        "Indirection Cost": 85.7,
-        "Interface Honesty": 86.0
-      }
-    },
-    "ai_generated_debt": 86.5,
-    "api_surface_coherence": 67.3,
-    "authorization_consistency": 92.8,
-    "convention_outlier": 78.8,
-    "cross_module_architecture": 73.2,
-    "design_coherence": 72.8,
-    "error_consistency": 67.8,
-    "high_level_elegance": 66.7,
-    "incomplete_migration": 95.7,
-    "low_level_elegance": 78.3,
-    "mid_level_elegance": 82.3,
-    "package_organization": 61.6
-  },
-  "dimension_notes": {
-    "cross_module_architecture": {
-      "evidence": [
-        "src/types.ts is a barrel that re-exports request/reply/rule types, and internal modules like src/rule-engine.ts and src/formats/request-helpers.ts import from \"./types.js\"/\"../types.js\" instead of their domain-specific type files.",
-        "The root types barrel becomes a dependency hub for unrelated modules, increasing blast radius for type changes across domains."
-      ],
-      "impact_scope": "subsystem",
-      "fix_scope": "multi_file_refactor",
-      "confidence": "high",
-      "issues_preventing_higher_score": ""
-    },
-    "high_level_elegance": {
-      "evidence": [
-        "src/formats/types.ts (format contracts) imports RequestMeta from src/formats/request-helpers.ts, coupling a contract type to a helper/logic module.",
-        "src/formats/request-helpers.ts mixes RequestMeta with buildMockRequest and parsing helpers, blurring ownership of the format boundary types."
-      ],
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor",
-      "confidence": "high",
-      "issues_preventing_higher_score": ""
-    },
-    "convention_outlier": {
-      "evidence": [
-        "Log level naming diverges: `LEVEL_PRIORITY` exposes `warning` while the logger API uses `warn`, and CLI validation only accepts `warning` (src/logger.ts, src/cli-validators.ts, src/cli.ts).",
-        "Validator API mixes sync and async parsing in the same module: `parseHost` is async while other `parse*` helpers are sync, making call sites and tests use different interaction patterns (src/cli-validators.ts, test/cli-validators.test.ts)."
-      ],
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor",
-      "confidence": "medium",
-      "issues_preventing_higher_score": "Conventions around log-level naming and validator async/sync shape are inconsistent within the CLI surface."
-    },
-    "error_consistency": {
-      "evidence": [
-        "Resolver exceptions in `src/route-handler.ts` are caught and converted into a normal fallback reply, returning HTTP 200 without an error payload.",
-        "In `src/formats/responses/parse.ts`, malformed tool entries are silently dropped via `safeParse`, while `src/formats/openai/parse.ts` and `src/formats/anthropic/parse.ts` hard-fail on schema validation."
-      ],
-      "impact_scope": "subsystem",
-      "fix_scope": "multi_file_refactor",
-      "confidence": "high",
-      "issues_preventing_higher_score": ""
-    },
-    "mid_level_elegance": {
-      "evidence": [
-        "src/mock-server.ts registers routes from the formats array (openaiFormat/anthropicFormat/responsesFormat) and relies on each format\u2019s route.",
-        "src/cli.ts prints a hard-coded endpoints string instead of deriving from the same formats registry."
-      ],
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor",
-      "confidence": "medium",
-      "issues_preventing_higher_score": "Endpoint listing is a manual seam between CLI output and runtime route registration, which can drift when adding/removing formats."
-    },
-    "abstraction_fitness": {
-      "evidence": [
-        "src/mock-server.ts builds sequence rules inline in when().replySequence(), including mapping entries and calling createSequenceResolver, then sets rule.remaining.",
-        "src/loader.ts repeats near-identical sequence rule wiring in addSequenceRule(), including entry mapping, createSequenceResolver, and rule.remaining."
-      ],
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor",
-      "confidence": "high",
-      "issues_preventing_higher_score": "Sequence-rule construction is duplicated in two modules, making future option/behavior changes easy to miss in one path.",
-      "sub_axes": {
-        "abstraction_leverage": 79.0,
-        "indirection_cost": 84.0,
-        "interface_honesty": 83.0
-      }
-    },
-    "low_level_elegance": {
-      "evidence": [
-        "src/formats/responses/serialize.ts serialize() mixes header creation, block construction, chunk flattening, and response finalization in one dense function.",
-        "src/formats/openai/serialize.ts serialize() builds text/tool chunks, finish/usage chunks, and envelopes inline without local extraction."
-      ],
-      "impact_scope": "local",
-      "fix_scope": "single_edit",
-      "confidence": "medium",
-      "issues_preventing_higher_score": "Serialization functions are readable but locally dense; small extractions would make the control flow more intention-revealing."
-    },
-    "api_surface_coherence": {
-      "evidence": [
-        "parsePort/parseChunkSize/parseLatency use parseInt without strict digit validation, so values like \"10abc\" or \"1.5\" are accepted as 10 or 1.",
-        "parseLogLevel uses `value in LEVEL_PRIORITY`, which is true for prototype keys like \"toString\" and can accept non-log-level strings.",
-        "parseHost is async (DNS lookup) while other validators are sync, creating mixed sync/async API shape in the same validator module."
-      ],
-      "impact_scope": "module",
-      "fix_scope": "single_edit",
-      "confidence": "high",
-      "issues_preventing_higher_score": ""
-    },
-    "authorization_consistency": {
-      "evidence": [
-        "MockServer wires all format routes via `this.app.post(format.route, createRouteHandler(format, deps))` with no auth/token checks in this file.",
-        "`host` option allows `\"0.0.0.0\"` exposure but there is no access-control or warning path in MockServer."
-      ],
-      "impact_scope": "module",
-      "fix_scope": "single_edit",
-      "confidence": "medium",
-      "issues_preventing_higher_score": "No optional auth hook or explicit guard/warning when binding to public interfaces; the server is always unauthenticated regardless of host exposure."
-    },
-    "ai_generated_debt": {
-      "evidence": [
-        "src/types/request.ts uses multiple explanatory comments on self-describing fields (e.g., lastMessage/systemMessage/toolNames) that mostly restate the property name.",
-        "src/types/rule.ts has a long comment block on Match that largely repeats the union\u2019s behavior (string/RegExp/object/function)."
-      ],
-      "impact_scope": "local",
-      "fix_scope": "single_edit",
-      "confidence": "medium",
-      "issues_preventing_higher_score": "Several comments restate obvious field semantics and could be reduced to higher-signal notes only."
-    },
-    "incomplete_migration": {
-      "evidence": [
-        "No @deprecated markers, migration TODOs, or legacy/new dual-path APIs appear in src/types/request.ts.",
-        "No @deprecated markers, migration TODOs, or legacy/new dual-path APIs appear in src/types/rule.ts."
-      ],
-      "impact_scope": "local",
-      "fix_scope": "single_edit",
-      "confidence": "low",
-      "issues_preventing_higher_score": "Small surface area limits certainty; no migration residue observed in the reviewed files."
-    },
-    "package_organization": {
-      "evidence": [
-        "holistic_context.structure.directory_profiles shows `src/` has `file_count: 11` with mixed concerns (cli, server/runtime, history, loader, logger, rule-engine).",
-        "holistic_context.structure.coupling_matrix shows bidirectional edges `src/ \u2192 src/formats/` (3) and `src/formats/ \u2192 src/` (3), indicating a blurred boundary between core runtime and format-specific code."
-      ],
-      "impact_scope": "subsystem",
-      "fix_scope": "multi_file_refactor",
-      "confidence": "high",
-      "issues_preventing_higher_score": ""
-    },
-    "design_coherence": {
-      "evidence": [
-        "Sequence rule construction is implemented in two places with similar step-mapping and resolver wiring (`MockServer.when().replySequence()` in src/mock-server.ts and `addSequenceRule()` in src/loader.ts).",
-        "The `MockServer` class mixes HTTP server lifecycle (Fastify setup/start/stop), rule authoring APIs, fallback management, and request history/logging state in one surface (src/mock-server.ts)."
-      ],
-      "impact_scope": "subsystem",
-      "fix_scope": "multi_file_refactor",
-      "confidence": "medium",
-      "issues_preventing_higher_score": ""
-    }
-  },
-  "findings": [
-    {
-      "dimension": "cross_module_architecture",
-      "identifier": "types_barrel_hub",
-      "summary": "Root types barrel creates a dependency hub and obscures domain boundaries.",
-      "related_files": [
-        "src/types.ts",
-        "src/rule-engine.ts",
-        "src/formats/request-helpers.ts"
-      ],
-      "evidence": [
-        "src/types.ts only re-exports from ./types/request.js, ./types/reply.js, ./types/rule.js.",
-        "src/rule-engine.ts and src/formats/request-helpers.ts import shared types from \"./types.js\"/\"../types.js\" rather than domain-specific type files."
-      ],
-      "suggestion": "Prefer direct imports from domain type files (e.g., src/types/request.ts) for internal modules, or split into domain-specific entry points and reserve src/types.ts for external/public API use.",
-      "confidence": "high",
-      "impact_scope": "subsystem",
-      "fix_scope": "multi_file_refactor",
-      "root_cause_cluster": "type_barrel_hub"
-    },
-    {
-      "dimension": "high_level_elegance",
-      "identifier": "request_meta_in_helper",
-      "summary": "Format contract depends on helper module, blurring ownership of request boundary types.",
-      "related_files": [
-        "src/formats/types.ts",
-        "src/formats/request-helpers.ts"
-      ],
-      "evidence": [
-        "src/formats/types.ts imports RequestMeta from ./request-helpers.js.",
-        "src/formats/request-helpers.ts combines RequestMeta with buildMockRequest and isStreaming logic."
-      ],
-      "suggestion": "Move RequestMeta into a dedicated types module (e.g., src/formats/request-types.ts) or into src/formats/types.ts, and have request-helpers import it instead of defining it.",
-      "confidence": "high",
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor",
-      "root_cause_cluster": "types_helpers_boundary_blur"
-    },
-    {
-      "dimension": "convention_outlier",
-      "identifier": "log_level_naming_mismatch",
-      "summary": "Log level naming is inconsistent (`warning` vs `warn`) across CLI and Logger APIs.",
-      "related_files": [
-        "src/logger.ts",
-        "src/cli-validators.ts",
-        "src/cli.ts"
-      ],
-      "evidence": [
-        "`LEVEL_PRIORITY` defines `warning`, CLI validation only accepts `warning`, but Logger exposes `warn` and labels logs as `WARN` (src/logger.ts, src/cli-validators.ts).",
-        "CLI flag `--log-level` is the public surface; a user seeing `WARN` may reasonably try `warn`, which is rejected (src/cli.ts, src/cli-validators.ts)."
-      ],
-      "suggestion": "Align on one string (`warn` or `warning`) and accept both in the validator to preserve compatibility; update logger constants and CLI help text accordingly.",
-      "confidence": "medium",
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor"
-    },
-    {
-      "dimension": "convention_outlier",
-      "identifier": "mixed_sync_async_parsers",
-      "summary": "CLI validators mix async and sync parsing styles, creating an API shape outlier.",
-      "related_files": [
-        "src/cli-validators.ts",
-        "test/cli-validators.test.ts"
-      ],
-      "evidence": [
-        "`parseHost` is async (DNS lookup) while `parsePort`, `parseLogLevel`, `parseChunkSize`, and `parseLatency` are sync, so consumers must treat the module inconsistently (src/cli-validators.ts).",
-        "Tests reflect the split by mixing `await expect(parseHost(...))` with sync expectations for other parsers (test/cli-validators.test.ts)."
-      ],
-      "suggestion": "Normalize the validator interface: either make all parsers async (returning Promises) or provide a sync `parseHostSync` and move the async lookup to the CLI entrypoint.",
-      "confidence": "low",
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor"
-    },
-    {
-      "dimension": "error_consistency",
-      "identifier": "reload_rules_clears_on_error",
-      "summary": "Rules reload clears existing rules before load, and on failure only logs, leaving a running server with no rules.",
-      "related_files": [
-        "src/cli.ts",
-        "src/logger.ts"
-      ],
-      "evidence": [
-        "Watch reload path does `server.reset(); await server.load(rulesPath);` inside a try/catch and only logs on error (src/cli.ts).",
-        "If `server.load` throws, prior rules are already cleared and the server continues running with an empty rule set, with no rollback (src/cli.ts)."
-      ],
-      "suggestion": "Load into a temporary ruleset or only call `reset()` after a successful load; on failure, preserve the previous rules and log the error with context.",
-      "confidence": "medium",
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor"
-    },
-    {
-      "dimension": "abstraction_fitness",
-      "identifier": "sequence_rule_duplication",
-      "summary": "Sequence rule construction is duplicated across MockServer and loader, risking drift.",
-      "related_files": [
-        "src/mock-server.ts",
-        "src/loader.ts",
-        "src/rule-engine.ts"
-      ],
-      "evidence": [
-        "src/mock-server.ts when().replySequence() maps entries, calls createSequenceResolver, mutates rule.resolve and rule.remaining.",
-        "src/loader.ts addSequenceRule() performs the same mapping/resolve/remaining steps with a slightly different entry shape."
-      ],
-      "suggestion": "Extract a shared helper (e.g., in src/rule-engine.ts) that accepts normalized sequence steps and applies createSequenceResolver + remaining, then reuse it from both MockServer and loader.",
-      "confidence": "high",
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor",
-      "root_cause_cluster": "sequence_rule_duplication"
-    },
-    {
-      "dimension": "mid_level_elegance",
-      "identifier": "format_registry_split",
-      "summary": "CLI hard-codes endpoints while MockServer derives routes from format modules.",
-      "related_files": [
-        "src/mock-server.ts",
-        "src/cli.ts"
-      ],
-      "evidence": [
-        "src/mock-server.ts registers routes by iterating formats[] with per-format route values.",
-        "src/cli.ts prints a static endpoints list string that must be updated manually."
-      ],
-      "suggestion": "Expose a single formats registry (or route list) and have the CLI render endpoints from it, avoiding cross-module drift.",
-      "confidence": "medium",
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor"
-    },
-    {
-      "dimension": "api_surface_coherence",
-      "identifier": "lax_numeric_parsing",
-      "summary": "Numeric validators accept non-numeric suffixes due to parseInt behavior",
-      "related_files": [
-        "src/cli-validators.ts"
-      ],
-      "evidence": [
-        "parsePort/parseChunkSize/parseLatency use parseInt and only check isNaN and range, so inputs like \"10abc\" or \"1.5\" pass as 10 or 1."
-      ],
-      "suggestion": "Validate with a strict digit regex (e.g., `/^\\d+$/`) and use `Number(value)` + `Number.isInteger` before range checks.",
-      "confidence": "high",
-      "impact_scope": "module",
-      "fix_scope": "single_edit"
-    },
-    {
-      "dimension": "api_surface_coherence",
-      "identifier": "log_level_guard_proto_keys",
-      "summary": "Log-level guard accepts prototype keys because it uses `in`",
-      "related_files": [
-        "src/cli-validators.ts"
-      ],
-      "evidence": [
-        "`isLogLevel` uses `value in LEVEL_PRIORITY`, which returns true for inherited keys like \"toString\"."
-      ],
-      "suggestion": "Use `Object.hasOwn(LEVEL_PRIORITY, value)` or `VALID_LOG_LEVELS.includes(value as LogLevel)` to restrict to real log levels.",
-      "confidence": "high",
-      "impact_scope": "local",
-      "fix_scope": "single_edit"
-    },
-    {
-      "dimension": "api_surface_coherence",
-      "identifier": "mixed_sync_async_validators",
-      "summary": "Validator API mixes sync and async functions within the same surface",
-      "related_files": [
-        "src/cli-validators.ts"
-      ],
-      "evidence": [
-        "parseHost is async (DNS lookup) while parsePort/parseLogLevel/parseChunkSize/parseLatency are synchronous."
-      ],
-      "suggestion": "Either make all validators async (returning Promise) or split DNS resolution into a separate async phase so the core validator API is uniform.",
-      "confidence": "medium",
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor"
-    },
-    {
-      "dimension": "ai_generated_debt",
-      "identifier": "restating_comments_on_types",
-      "summary": "Comments restate obvious type semantics, adding low-signal noise",
-      "related_files": [
-        "src/types/request.ts",
-        "src/types/rule.ts"
-      ],
-      "evidence": [
-        "src/types/request.ts comments explain fields like lastMessage/systemMessage/toolNames in a way that mirrors the field name.",
-        "src/types/rule.ts Match comment block describes each union variant in a way that repeats the type definition."
-      ],
-      "suggestion": "Trim comments to only convey non-obvious constraints or behavioral nuances; remove restatements of field names or type unions.",
-      "confidence": "medium",
-      "impact_scope": "local",
-      "fix_scope": "single_edit"
-    },
-    {
-      "dimension": "low_level_elegance",
-      "identifier": "redundant_optional_undefined",
-      "summary": "Optional fields redundantly include `| undefined`, creating inconsistency and noise",
-      "related_files": [
-        "src/types/request.ts",
-        "src/types/rule.ts"
-      ],
-      "evidence": [
-        "src/types/request.ts declares `tools?: readonly ToolDef[] | undefined` and `toolCallId?: string | undefined`, which are already implied by `?`.",
-        "src/types/rule.ts uses `?:` without explicit `| undefined`, so the style is inconsistent across related type modules."
-      ],
-      "suggestion": "Remove explicit `| undefined` from optional properties in src/types/request.ts to align with TypeScript conventions and the style used in src/types/rule.ts.",
-      "confidence": "high",
-      "impact_scope": "local",
-      "fix_scope": "single_edit"
-    },
-    {
-      "dimension": "package_organization",
-      "identifier": "flat_src_root_mixed_concerns",
-      "summary": "`src/` is a flat folder with mixed CLI/runtime/history concerns, obscuring ownership boundaries.",
-      "related_files": [
-        "src/cli.ts",
-        "src/history.ts",
-        "src/cli-validators.ts"
-      ],
-      "evidence": [
-        "`holistic_context.structure.directory_profiles` lists 11 files in `src/` spanning CLI (`cli.ts`), history/state (`history.ts`), and core runtime (`mock-server.ts`, `rule-engine.ts`).",
-        "`holistic_context.structure.coupling_matrix` shows `src/ \u2194 src/formats/` bidirectional imports, which is a typical signal of missing subpackage boundaries."
-      ],
-      "suggestion": "Staged reorg plan: 1) Create `src/cli/` and `src/server/` folders. 2) Move CLI files first: `src/cli.ts` \u2192 `src/cli/index.ts`, `src/cli-validators.ts` \u2192 `src/cli/validators.ts`. 3) Move runtime/state next: `src/history.ts` \u2192 `src/server/history.ts` (and later other runtime files like `mock-server.ts`, `rule-engine.ts` if desired). 4) Update import paths using `rg \"./cli-validators|./history\" src test` and edit imports to new locations. 5) Validate with `npm test` (vitest) and, if available, `npm run build` to ensure path resolution is correct.",
-      "confidence": "high",
-      "impact_scope": "subsystem",
-      "fix_scope": "multi_file_refactor",
-      "root_cause_cluster": "flat_src_root"
-    },
-    {
-      "dimension": "package_organization",
-      "identifier": "cli_validators_not_colocated",
-      "summary": "CLI-only validators live at `src/` root despite being used only by the CLI entrypoint.",
-      "related_files": [
-        "src/cli.ts",
-        "src/cli-validators.ts",
-        "test/cli-validators.test.ts"
-      ],
-      "evidence": [
-        "`src/cli-validators.ts` is imported only by `src/cli.ts` and its dedicated test (`test/cli-validators.test.ts`).",
-        "No other modules consume `cli-validators.ts`, indicating it belongs inside a CLI-focused subpackage rather than the root."
-      ],
-      "suggestion": "Staged reorg plan: 1) Create `src/cli/`. 2) Move `src/cli-validators.ts` \u2192 `src/cli/validators.ts`. 3) Update `src/cli.ts` to import from `./cli/validators.js` (or `./cli/validators.js` after moving `cli.ts` as part of a broader CLI folder move). 4) Update `test/cli-validators.test.ts` to import from `../src/cli/validators.js`. 5) Validate with `npm test` to ensure CLI parsing tests still pass.",
-      "confidence": "high",
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor",
-      "root_cause_cluster": "flat_src_root"
-    },
-    {
-      "dimension": "high_level_elegance",
-      "identifier": "ownership_boundaries_blurred_by_root_layout",
-      "summary": "Top-level decomposition mixes CLI and runtime concerns, weakening domain-aligned ownership.",
-      "related_files": [
-        "src/cli.ts",
-        "src/history.ts"
-      ],
-      "evidence": [
-        "CLI entry (`src/cli.ts`) and runtime/state (`src/history.ts`) sit side-by-side at the root, making the top-level package map less expressive than the format-specific subfolders under `src/formats/*`.",
-        "The flat root layout requires readers to scan files to infer domains instead of discovering boundaries through folder structure."
-      ],
-      "suggestion": "Staged reorg plan: 1) Introduce explicit domain folders such as `src/cli/` and `src/runtime/` (or `src/server/`). 2) Move `src/cli.ts` (and `src/cli-validators.ts`) into `src/cli/` first, then move `src/history.ts` into `src/runtime/` alongside related runtime modules. 3) Update imports via `rg \"\\./cli|\\./history\" src test` and edit to new paths. 4) Validate with `npm test` and, if applicable, `npm run build` to confirm the public entrypoints still resolve correctly.",
-      "confidence": "medium",
-      "impact_scope": "subsystem",
-      "fix_scope": "multi_file_refactor",
-      "root_cause_cluster": "flat_src_root"
-    },
-    {
-      "dimension": "cross_module_architecture",
-      "identifier": "types_barrel_coupling_hub",
-      "summary": "Root types barrel concentrates multiple domains and amplifies cross-module coupling.",
-      "related_files": [
-        "src/types.ts",
-        "src/formats/types.ts",
-        "src/formats/request-helpers.ts"
-      ],
-      "evidence": [
-        "src/types.ts re-exports request/reply/rule types into one root barrel, and format modules import from ../types.js rather than their specific domain files.",
-        "This pattern makes any change to request/reply/rule type boundaries ripple through a single high-fan-in module."
-      ],
-      "suggestion": "Split the barrel into domain entry points (for example: `src/types/request.ts`, `src/types/reply.ts`, `src/types/rule.ts`) and update format imports to target the specific domain paths; keep `src/types.ts` only for external package exports if needed, and avoid internal imports from it.",
-      "confidence": "medium",
-      "impact_scope": "subsystem",
-      "fix_scope": "multi_file_refactor"
-    },
-    {
-      "dimension": "high_level_elegance",
-      "identifier": "format_layer_owns_request_construction",
-      "summary": "Format layer builds the core MockRequest, blurring ownership of request lifecycle.",
-      "related_files": [
-        "src/formats/request-helpers.ts",
-        "src/formats/types.ts",
-        "src/types.ts"
-      ],
-      "evidence": [
-        "buildMockRequest in src/formats/request-helpers.ts derives lastMessage/systemMessage/toolNames and sets headers/path defaults, which are core request concerns.",
-        "Format interface in src/formats/types.ts consumes this helper indirectly, keeping request shape tied to the formats package."
-      ],
-      "suggestion": "Move MockRequest construction into a core module (for example `src/request/build-mock-request.ts` or `src/core/mock-request.ts`) and have format parsers return a minimal parsed shape; use the core builder to add shared defaults and derived fields.",
-      "confidence": "medium",
-      "impact_scope": "subsystem",
-      "fix_scope": "multi_file_refactor"
-    },
-    {
-      "dimension": "package_organization",
-      "identifier": "flat_src_mixed_concerns",
-      "summary": "The root src/ directory is a mixed-concern flat folder that hides ownership boundaries.",
-      "related_files": [
-        "src/logger.ts",
-        "src/rule-engine.ts",
-        "src/types.ts",
-        "src/cli.ts",
-        "src/mock-server.ts",
-        "src/route-handler.ts",
-        "src/loader.ts"
-      ],
-      "evidence": [
-        "holistic_context.structure shows src/ contains 11 production files spanning CLI/server/logging/rules/types, indicating mixed responsibilities in a single directory.",
-        "Core building blocks (logger, rule engine, types) live beside entrypoints, making navigation and change ownership less predictable.",
-        "`src/` contains 11 files across CLI, HTTP server, rule engine, logging, and utilities (directory profile shows `file_count: 11`).",
-        "Coupling shows bidirectional edges between `src/` and `src/formats/`, indicating blurred boundaries at the top level."
-      ],
-      "suggestion": "Staged reorg plan: 1) Create target folders `src/core/`, `src/logging/`, and `src/entrypoints/`. 2) Move core building blocks: `git mv src/rule-engine.ts src/core/rule-engine.ts`, `git mv src/types.ts src/core/types.ts`. 3) Move logging: `git mv src/logger.ts src/logging/logger.ts`. 4) Update imports by searching: `rg -n \"from \\\"\\.\\/rule-engine\\\"|from \\\"\\.\\/types\\\"|from \\\"\\.\\/logger\\\"\" src test` and adjust to new paths. 5) Validate with `npm test` and `npm run build`.",
-      "confidence": "high",
-      "impact_scope": "codebase",
-      "fix_scope": "multi_file_refactor",
-      "merged_from": [
-        "flat_src_mixed_concerns"
-      ]
-    },
-    {
-      "dimension": "design_coherence",
-      "identifier": "sequence_rule_duplication",
-      "summary": "Sequence rule normalization is duplicated in server API and loader paths",
-      "related_files": [
-        "src/mock-server.ts",
-        "src/loader.ts",
-        "src/rule-engine.ts"
-      ],
-      "evidence": [
-        "`MockServer.when().replySequence()` maps `SequenceEntry` values into steps, creates a sequence resolver, assigns `rule.resolve`, and sets `rule.remaining`.",
-        "`addSequenceRule()` in `src/loader.ts` performs the same step normalization, `createSequenceResolver()` call, and `rule.remaining` setup for JSON5 rules."
-      ],
-      "suggestion": "Extract a shared helper in `src/rule-engine.ts` (or a new `sequence` utility) that accepts normalized entries and returns a configured rule; use it from both `replySequence()` and `addSequenceRule()` to centralize sequence behavior.",
-      "confidence": "medium",
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor"
-    },
-    {
-      "dimension": "design_coherence",
-      "identifier": "mockserver_multi_role",
-      "summary": "`MockServer` combines server lifecycle, rule authoring, and state tracking responsibilities",
-      "related_files": [
-        "src/mock-server.ts",
-        "src/rule-engine.ts",
-        "src/history.ts"
-      ],
-      "evidence": [
-        "`MockServer` constructs the Fastify server and registers format routes in the constructor, exposes rule authoring methods (`when`, `whenTool`, `nextError`), manages fallback state, and owns `RequestHistory` and logging.",
-        "This blends HTTP runtime concerns with rule registry and history concerns that already exist as separate modules (`RuleEngine`, `RequestHistory`)."
-      ],
-      "suggestion": "Split `MockServer` into a runtime/server wrapper and a rule/history registry (e.g., extract a `RuleRegistry` or `MockServerCore` that exposes `when*`, `history`, `rules`, and fallback), and keep Fastify lifecycle and route wiring in a thinner server class.",
-      "confidence": "medium",
-      "impact_scope": "subsystem",
-      "fix_scope": "architectural_change"
-    },
-    {
-      "dimension": "error_consistency",
-      "identifier": "resolver_errors_swallowed",
-      "summary": "Resolver exceptions are swallowed and returned as normal fallback replies",
-      "related_files": [
-        "src/route-handler.ts",
-        "src/types/reply.ts",
-        "src/mock-server.ts"
-      ],
-      "evidence": [
-        "`resolveReply` catches resolver errors and returns `normalizeReply(fallback)` with no error signal.",
-        "Downstream in the handler, the fallback reply is serialized as a normal 200 response if it doesn\u2019t set `error`."
-      ],
-      "suggestion": "Surface resolver failures explicitly: either rethrow and let Fastify return 500, or translate to `ReplyObject.error` with a 5xx status. Update `resolveReply` and `createRouteHandler` to propagate an error reply, and document the error contract in `src/types/reply.ts`.",
-      "confidence": "high",
-      "impact_scope": "subsystem",
-      "fix_scope": "multi_file_refactor",
-      "root_cause_cluster": "error_handling_policy"
-    },
-    {
-      "dimension": "error_consistency",
-      "identifier": "responses_tools_silent_drop",
-      "summary": "Responses tool parsing silently drops invalid tools unlike other formats",
-      "related_files": [
-        "src/formats/responses/parse.ts",
-        "src/formats/openai/parse.ts",
-        "src/formats/anthropic/parse.ts"
-      ],
-      "evidence": [
-        "`parseTools` in responses uses `FunctionToolSchema.safeParse` and filters out failed parses, so malformed tool entries are ignored.",
-        "OpenAI and Anthropic requests rely on schema parsing that fails the whole request on invalid structures."
-      ],
-      "suggestion": "Align tool-validation behavior across formats: either treat invalid tools as a request error for responses, or document and apply a consistent \u201cbest-effort\u201d policy across all formats. Prefer failing the request for invalid tools to keep error handling predictable.",
-      "confidence": "medium",
-      "impact_scope": "module",
-      "fix_scope": "multi_file_refactor",
-      "root_cause_cluster": "error_handling_policy"
-    },
-    {
-      "dimension": "low_level_elegance",
-      "identifier": "non_unique_ids",
-      "summary": "ID generation relies on Date.now(), risking collisions under concurrency",
-      "related_files": [
-        "src/formats/serialize-helpers.ts",
-        "src/formats/openai/serialize.ts",
-        "src/formats/responses/serialize.ts"
-      ],
-      "evidence": [
-        "`genId` and `toolId` use `Date.now().toString(36)` which can repeat in the same millisecond.",
-        "Streaming serializers call these helpers multiple times per request, and concurrent requests can produce duplicate IDs."
-      ],
-      "suggestion": "Switch to a collision-resistant ID source (e.g., `crypto.randomUUID()` or a process-wide monotonic counter with a random prefix). Update `genId`/`toolId` and regenerate IDs in the serializers to avoid duplicate response IDs.",
-      "confidence": "high",
-      "impact_scope": "subsystem",
-      "fix_scope": "single_edit"
-    }
-  ],
-  "review_quality": {
-    "batch_count": 10,
-    "dimension_coverage": 0.262,
-    "evidence_density": 2.5,
-    "high_score_missing_issue_note": 0,
-    "finding_pressure": 43.94,
-    "dimensions_with_findings": 11
-  },
-  "review_scope": {
-    "reviewed_files_count": 41,
-    "successful_batch_count": 10,
-    "full_sweep_included": true,
-    "total_files": 41,
-    "imported_dimensions": [
-      "abstraction_fitness",
-      "ai_generated_debt",
-      "api_surface_coherence",
-      "authorization_consistency",
-      "convention_outlier",
-      "cross_module_architecture",
-      "design_coherence",
-      "error_consistency",
-      "high_level_elegance",
-      "incomplete_migration",
-      "low_level_elegance",
-      "mid_level_elegance",
-      "package_organization"
-    ]
-  },
-  "reviewed_files": [
-    "src/types.ts",
-    "src/formats/types.ts",
-    "src/formats/request-helpers.ts",
-    "src/logger.ts",
-    "src/rule-engine.ts",
-    "src/history.ts",
-    "test/history.test.ts",
-    "src/cli.ts",
-    "src/formats/anthropic/schema.ts",
-    "src/formats/openai/schema.ts",
-    "src/formats/responses/schema.ts",
-    "src/types/request.ts",
-    "test/helpers/make-req.ts",
-    "test/cli-validators.test.ts",
-    "test/mock-server.test.ts",
-    "test/rule-engine.test.ts",
-    "src/cli-validators.ts",
-    "src/mock-server.ts",
-    "test/formats/anthropic.test.ts",
-    "src/formats/responses/serialize.ts",
-    "test/formats/responses.test.ts",
-    "src/loader.ts",
-    "test/formats/openai.test.ts",
-    "test/loader.test.ts",
-    "test/logger.test.ts",
-    "src/formats/openai/serialize.ts",
-    "src/types/rule.ts",
-    "vitest.config.ts",
-    "src/formats/anthropic/index.ts",
-    "src/formats/anthropic/parse.ts",
-    "src/formats/serialize-helpers.ts",
-    "src/formats/openai/index.ts",
-    "src/formats/openai/parse.ts",
-    "src/formats/responses/index.ts",
-    "src/formats/responses/parse.ts",
-    "README.md",
-    "src/formats/anthropic/serialize.ts",
-    "src/index.ts",
-    "src/route-handler.ts",
-    "src/sse-writer.ts",
-    "src/types/reply.ts"
-  ],
-  "provenance": {
-    "kind": "blind_review_batch_import",
-    "blind": true,
-    "runner": "codex",
-    "run_stamp": "20260315_185613",
-    "created_at": "2026-03-15T19:12:25+00:00",
-    "batch_count": 10,
-    "batch_indexes": [
-      1,
-      2,
-      3,
-      4,
-      5,
-      6,
-      7,
-      8,
-      9,
-      10
-    ],
-    "packet_path": "/Users/suyash.x.srijan/Documents/Personal_Projects/llm-mock-server/.desloppify/review_packet_blind.json",
-    "packet_sha256": "e663ded15d2a9ecb9c0d30321375d99c9508846539c46be15e8d706c8053de8c"
-  },
-  "assessment_coverage": {
-    "scored_dimensions": [
-      "naming_quality",
-      "logic_clarity",
-      "type_safety",
-      "contract_coherence",
-      "error_consistency",
-      "abstraction_fitness",
-      "ai_generated_debt",
-      "high_level_elegance",
-      "mid_level_elegance",
-      "low_level_elegance",
-      "cross_module_architecture",
-      "initialization_coupling",
-      "convention_outlier",
-      "dependency_health",
-      "test_strategy",
-      "api_surface_coherence",
-      "authorization_consistency",
-      "incomplete_migration",
-      "package_organization",
-      "design_coherence"
-    ],
-    "selected_dimensions": [
-      "cross_module_architecture",
-      "convention_outlier",
-      "error_consistency",
-      "abstraction_fitness",
-      "api_surface_coherence",
-      "authorization_consistency",
-      "ai_generated_debt",
-      "incomplete_migration",
-      "package_organization",
-      "high_level_elegance",
-      "mid_level_elegance",
-      "low_level_elegance",
-      "design_coherence"
-    ],
-    "imported_dimensions": [
-      "abstraction_fitness",
-      "ai_generated_debt",
-      "api_surface_coherence",
-      "authorization_consistency",
-      "convention_outlier",
-      "cross_module_architecture",
-      "design_coherence",
-      "error_consistency",
-      "high_level_elegance",
-      "incomplete_migration",
-      "low_level_elegance",
-      "mid_level_elegance",
-      "package_organization"
-    ],
-    "missing_dimensions": [
-      "naming_quality",
-      "logic_clarity",
-      "type_safety",
-      "contract_coherence",
-      "initialization_coupling",
-      "dependency_health",
-      "test_strategy"
-    ]
-  }
-}