livepilot 1.9.11 → 1.9.13

package/remote_script/LivePilot/devices.py

@@ -3,6 +3,7 @@ LivePilot - Device domain handlers (11 commands).
 """
 
 import Live
+from collections import deque
 
 from .router import register
 from .utils import get_track, get_device
@@ -178,6 +179,8 @@ def toggle_device(song, params):
             break
     if on_param is None:
         # Fallback to parameter 0 for devices that don't use "Device On"
+        if not list(device.parameters):
+            raise ValueError("Device '%s' has no parameters to toggle" % device.name)
         on_param = device.parameters[0]
 
     on_param.value = 1.0 if active else 0.0
@@ -399,10 +402,10 @@ def find_and_load_device(song, params):
         This ensures raw 'Operator' is found before 'Hello Operator.adg' buried
         in a user_library subfolder."""
         nonlocal iterations
-        # Queue of (item, depth) tuples
-        queue = [(category, 0)]
+        # Queue of (item, depth) tuples — deque for O(1) popleft
+        queue = deque([(category, 0)])
         while queue:
-            item, depth = queue.pop(0)
+            item, depth = queue.popleft()
             if depth > 8:
                 continue
             try:

package/remote_script/LivePilot/server.py

@@ -95,7 +95,8 @@ class LivePilotServer(object):
         self._thread = threading.Thread(target=self._server_loop)
         self._thread.daemon = True
         self._thread.start()
-        self._log("Server started on %s:%d" % (self._host, self._port))
+        # Note: "Listening on ..." is logged from _server_loop after bind
+        # succeeds. Don't log "Server started" here — bind may still fail.
 
     def stop(self):
         """Shutdown the server gracefully."""
@@ -187,12 +188,12 @@ class LivePilotServer(object):
         except OSError as exc:
             self._log("Client error: %s" % exc)
         finally:
-            with self._client_lock:
-                self._client_connected = False
             try:
                 client.close()
             except OSError:
                 pass
+            with self._client_lock:
+                self._client_connected = False
             self._log("Client disconnected")
 
     def _handle_client(self, client):
@@ -205,6 +206,9 @@ class LivePilotServer(object):
                 if not data:
                     break
                 buf += data.decode("utf-8", errors="replace")
+                if len(buf) > 4 * 1024 * 1024:  # 4 MB
+                    self._log("Client buffer overflow — disconnecting")
+                    break
                 while "\n" in buf:
                     line, buf = buf.split("\n", 1)
                     line = line.strip()
@@ -249,8 +253,14 @@ class LivePilotServer(object):
         try:
             self._cs.schedule_message(0, self._process_next_command)
         except AssertionError:
-            # Already on main thread — process directly
-            self._process_next_command()
+            # ControlSurface is disconnecting — return error instead of
+            # running LOM calls on the TCP thread (which would be unsafe)
+            response_queue.put({
+                "id": request_id,
+                "ok": False,
+                "error": {"code": "STATE_ERROR", "message": "Script is disconnecting"},
+            })
+            return
 
         # Wait for response from main thread
         try:
@@ -296,7 +306,8 @@ class LivePilotServer(object):
             try:
                 self._cs.schedule_message(1, send_response)  # ~100ms
             except AssertionError:
-                send_response()
+                # ControlSurface disconnecting — send result immediately
+                response_queue.put(result)
         else:
             response_queue.put(result)
             # Drain any remaining queued commands
@@ -308,7 +319,9 @@ class LivePilotServer(object):
             try:
                 self._cs.schedule_message(0, self._process_next_command)
             except AssertionError:
-                self._process_next_command()
+                # ControlSurface disconnecting — drop remaining commands
+                # rather than running LOM calls on the wrong thread
+                pass
 
     # ── Socket I/O ───────────────────────────────────────────────────────
 

package/remote_script/LivePilot/tracks.py

@@ -175,9 +175,14 @@ def duplicate_track(song, params):
             "Track index %d out of range (0..%d)"
             % (track_index, len(tracks) - 1)
         )
+    count_before = len(tracks)
     song.duplicate_track(track_index)
-    new_index = track_index + 1
-    return {"index": new_index, "name": list(song.tracks)[new_index].name}
+    all_tracks = list(song.tracks)
+    # For group tracks, Ableton duplicates the group + all children.
+    # The duplicate block starts right after the original group's last child.
+    added = len(all_tracks) - count_before
+    new_index = track_index + added
+    return {"index": new_index, "name": all_tracks[new_index].name}
 
 
 @register("set_track_name")

package/remote_script/LivePilot/transport.py

@@ -53,9 +53,9 @@ def get_session_info(song, params):
         "metronome": song.metronome,
         "record_mode": song.record_mode,
         "session_record": song.session_record,
-        "track_count": len(list(song.tracks)),
-        "return_track_count": len(list(song.return_tracks)),
-        "scene_count": len(list(song.scenes)),
+        "track_count": len(tracks_info),
+        "return_track_count": len(return_tracks_info),
+        "scene_count": len(scenes_info),
         "tracks": tracks_info,
         "return_tracks": return_tracks_info,
         "scenes": scenes_info,

package/requirements.txt

@@ -3,9 +3,14 @@ numpy>=1.24.0
 fastmcp>=3.0.0,<4.0.0
 midiutil>=1.2.1
 pretty_midi>=0.2.10
-opycleid>=0.5.1
 # v1.8 Perception Layer (offline analysis)
 pyloudnorm>=0.1.0
 soundfile>=0.12.0
 scipy>=1.11.0
 mutagen>=1.47.0
+
+# Development / testing (not required for runtime)
+# pip install pytest pytest-asyncio
+
+# Optional: neo-Riemannian group theory (not required — harmony engine is pure Python)
+# pip install opycleid>=0.5.1